Commit Graph

193 Commits

Author SHA1 Message Date
daniele vettorel
3f077097bd Include GPU breadcrumb data in Editor crash report payloads.
This change serializes the GPU breadcrumb data into the shared context so that it can then be retrieved by the crash report client and included in the final payload.

#jira UE-214270
#tests tested locally
#rb mihnea.balta

[CL 34237925 by daniele vettorel in ue5-main branch]
2024-06-10 11:23:15 -04:00
martin sevigny
66e9b60cce WORKAROUND CL33938220.
The module name is ok but the CrashReportClientEditor target is causing a warning that can be safely ignored.

#jira UE-215245
#rb Sebastian.Thomeczek, Patrick.Laflamme

[CL 33941604 by martin sevigny in ue5-main branch]
2024-05-28 10:57:37 -04:00
danny couture
274939047f Fix deprecation warning
[CL 33138204 by danny couture in ue5-main branch]
2024-04-22 10:31:37 -04:00
nicolas mercier
fe3544ae4a Added a IsStuck field in the crash context. This flag gets set when a thread exceeds the Stuck threshold (usually one second, normally much lower than the Hang threshold). The flag is cleared when the thread resumes.
IsStuck can be used to categorize abnormal terminations. This can catch reports where the player terminates the program before the hang detection kicks in (normally quite high, 45 to 60 seconds).

#rb daniele.vettorel
#tests multiple crash reports using debug commands
#rnx

[CL 32428340 by nicolas mercier in ue5-main branch]
2024-03-22 04:43:00 -04:00
nicolas mercier
f08d4a7041 Publish AnticheatProvider in the abnormal termination context.
Change PlatformName to be stored as TCHAR array like all other properties.

#rb daniele.vettorel, elizabeth.bunner, zach.harris
#tests locally in FrontEnd

[CL 31938694 by nicolas mercier in ue5-main branch]
2024-03-01 04:10:42 -05:00
johan berg
ef7eb025ac Several changes to crash reporting and crash telemetry.
* Renamed some configuration settings in CrashReporterClient(Editor) targets and added comments to clarify their use.
* Merged the different telemetry keys to one.
* Allow telemetry to be set using environment variables.

#rb Wes.Hunt
#jira UE-205533

[CL 31417647 by johan berg in ue5-main branch]
2024-02-13 04:59:18 -05:00
nicolas mercier
d331651c8a Add missing fields in CrashReportClient. CrashReporter would fail to sort those crashes properly and it would make these very hard to find.
#rb
#tests CrashReporter in shipping with a deployed build as well as with a local build

[CL 31354401 by nicolas mercier in ue5-main branch]
2024-02-09 15:54:08 -05:00
johan berg
6279b8e5bd Add optional display of company name and endpoint in CRC dialog.
* Disable send buttons if both crash receiver and data router configuration values are unset.
* Optionally display end point in crash report client.
* "Agree to be contacted" text is now configurable with to be able to set company name.

#rb ionut.matasaru

[CL 30921491 by johan berg in ue5-main branch]
2024-01-26 08:56:33 -05:00
johan berg
39ce8ab525 Fix unattended debug message
#rb johan.berg

[CL 30879996 by johan berg in ue5-main branch]
2024-01-25 04:06:04 -05:00
johan berg
9b4cf84d30 Add support for project overrides in crash report client
Introduces a few changes that enables CrashReportClient to read project it's settings from project configuration.
* Add compile time fallback of data router to CrashReportClientEditor.
* Refactored how some global defines are set in CrashReportClient/CrashReportClientEditor target to allow different settings for development time vs retail time.
* Added code that allows project configuration files to override any CRC setting. Previously it would only apply to some properties.
* Refactored CrashReportCoreConfig.
* Added compile time defines for company name. UX changes in other CL.
* Limit core usage for CRC to 5 cores. Significantly reduces memory usage for machines with many cores.

#rb Patrick.Laflamme
#jira UE-114670

[CL 30879797 by johan berg in ue5-main branch]
2024-01-25 03:54:34 -05:00
steve robb
104c0f2416 Fixed up more bool-taking calls to take EAllowShrinking instead.
[CL 30806200 by steve robb in ue5-main branch]
2024-01-23 11:07:28 -05:00
saim80
4cc46194f1 Safer NSApp terminate: call.
#jira UE-203315
#rb Josh.Adams
#11271

[CL 30623430 by saim80 in ue5-main branch]
2024-01-15 15:06:30 -05:00
nicolas mercier
7cd58f8030 Fixed some crash reporter issues:
- use BaseDir() instead of ProjectDir(), as ProjectDir could return a relative path (unsuitable for drive information)
- Added missing fields in the crash reporter context that is sent on abnormal termination. Some fields were added recently but were never synced/sent by the crash reporter client.
- Fix an issue that prevented listing of partitions. The Wbem Next() method can return a value that is not 0 but also not a failure.

#rb daniele.vettorel, zach.harris
#rnx

[CL 30330133 by nicolas mercier in ue5-main branch]
2023-12-14 15:34:26 -05:00
robert millar
0f8491565b Add an API for adding many portable thread callstacks at once to avoid re-reading process module list.
Cuts time to record a crash context by as much as 30s in the presence of some security software.

#rb johan.berg

[CL 27322947 by robert millar in ue5-main branch]
2023-08-23 17:40:25 -04:00
robert millar
043df76171 Add configurable button to copy crash report files to clipboard.
#rb johan.berg

[CL 27282237 by robert millar in ue5-main branch]
2023-08-22 15:17:30 -04:00
andriy tylychko
9e8b314eb1 made ApplicationWillTerminateDelegate thread-safe: deprecated FCoreDelegates::ApplicationWillTerminateDelegate (because thread-safe delegates can't be statically initialised) and added FCoreDelegates::GetApplicationWillTerminateDelegate() accessor for a thread-safe delegate
#rb francis.hurteau

[CL 25926515 by andriy tylychko in ue5-main branch]
2023-06-12 07:58:54 -04:00
michael atchison
6e3e668f8b Update analytics user id and crash reporting user id when the epic account id for the running process changes.
[REVIEW] [at]patrick.laflamme, [at]wes.hunt, [at]eric.day
#preflight 63f065463c1eb56f0516c03e

[CL 24355926 by michael atchison in ue5-main branch]
2023-02-22 00:22:48 -05:00
christopher waters
6a4206d490 Removing bad Launch include paths from programs.
[CL 24328631 by christopher waters in ue5-main branch]
2023-02-20 17:39:13 -05:00
yohann dossantos
59b5769eca -Text font size changes in Text Box (Multy-Line) widget applies only after moving the text widget
It was the initial bug, but while looking at it, I noticed that the MultilineEditableTextBox was containing both a Font via FEditableTextBoxStyle, and another one via FTextBlockStyle, thus being error prone / inconsistent.
In order to fix the underlying issue (in addition to fix the initial bug), I removed the Font from FEditableTextBoxStyle, and moved the FTextBlockStyle from MultilineEditableTextBox to FEditableTextBoxStyle.
It solves the duplication issue and so make it clear where the Font should be set/read from.
However, as the text block style is now embedded in the editable text box style, it cannot be initialized the exact same way, and I had to do some changes to ensure there was no regression, by configuring various FEditableTextBoxStyle in some style files. I also change the default value for TextBlockStyle to better match our default theme.

-Default font is not set for text widgets.
EditableWidget: ensure to have a default font, and to set the style when calling SynchronizeProperties to ensure it reacts directly without having to force a refresh (by moving the widget for instance)

Bonus:
-Move to cpp some private methods that where 'forced' inline (and we were using function pointer on them). It will avoid some noise in public interface and speed up iteration / compile time when playing with them.

#jira UE-96464
#jira UE-137126

[RN] MultilineEditableTextBox was containing both a Font via FEditableTextBoxStyle, and another one via FTextBlockStyle, thus being error prone / inconsistent.The Font from FEditableTextBoxStyle has been removed, and the FTextBlockStyle moved from MultilineEditableTextBox to FEditableTextBoxStyle. It solves the duplication issue and so make it clear where the Font should be set/read from.
However, as the FTextBlockStyle is now embedded in the FEditableTextBoxStyle, it cannot be initialized the exact same way, and you can now configure the FTextBlockStyle of FEditableTextBoxStyle when creating one from scratch, by calling SetTextStyle on it.


Test
- created a Widget blueprint with different editable types combination: multiline or single line, box or no box.
    -Validated that everything was reacting live as expected now.
    -Created a blue print to set the text style and validated it was working.
    -Create data with old version, then open it with updated version to validate that the visual was still the same and deprecation of style working as expected.
-checked different places in the editor using variation of editable text to ensure they were behaving as before (detail view, console command entry, comment on blueprint node).
#preflight 63344b9f110bb3721ef8aa77

[CL 22232366 by yohann dossantos in ue5-main branch]
2022-09-28 17:59:29 -04:00
Devin Doucette
76234e85ae Set EngineIncludeOrderVersion.Latest for several additional targets
#preflight 6318ddca2b7fe03eb66fbb46
#rb none
#rnx

[CL 21858206 by Devin Doucette in ue5-main branch]
2022-09-07 14:45:10 -04:00
UnrealBot
73409369c0 Branch snapshot for CL 21319338
[CL 21319338 in ue5-main branch]
2022-08-10 16:03:37 +00:00
patrick laflamme
6f5ba2331d Added a command line option to CrashReportClient to disable the 'Submit and Restart' button in case the application doesn't want to be automaticaly restarted.
#rb Chris.Gagnon, Johan.Berg
#preflight 629f7017617cbe81d32add99

#ushell-cherrypick of 20541559 by Patrick.Laflamme
#preflight 629fbb4b521254896f6c2c43

#ROBOMERGE-AUTHOR: patrick.laflamme
#ROBOMERGE-SOURCE: CL 20546605 via CL 20546619 via CL 20546630 via CL 20546644 via CL 20546648
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v954-20466795)

[CL 20552343 by patrick laflamme in ue5-main branch]
2022-06-08 02:02:29 -04:00
lauren barnes
53488dc718 Updating CrashReportClient style to only use images from certain folders, and moving developer tool style setup to individual style classes.
#jira UE-152623
#rb Josh.Adams, Patrick.Boutot, Patrick.Laflamme, Louise.Rasmussen
#preflight 628d6c5faf7a2e956b8de990

#ROBOMERGE-OWNER: lauren.barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20366551 via CL 20368551 via CL 20369147 via CL 20369164
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20370889 by lauren barnes in ue5-main branch]
2022-05-25 16:27:45 -04:00
Devin Doucette
3045e3c75f Logging: Changed CanBeUsedOnPanicThread() to return false by default
The previous default of CanBeUsedOnAnyThread() proved unsafe since some output devices can safely be used on any thread but cannot safely be used during a crash. CanBeUsedOnAnyThread() was used pre-5.1 to control serialization to an output device during a crash, but optimizations in 5.1 have uncovered that some of these were never safe.

#preflight 62856506614041edb7a6de4b
#rb Zousar.Shaker
#rnx

[CL 20280354 by Devin Doucette in ue5-main branch]
2022-05-19 10:39:18 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00