[FYI] George.Rolfe
Original CL Desc
-----------------------------------------------------------------
[ToolWidgets] Dependencies reference correct base widget
#rnx
[CL 35075563 by george rolfe in ue5-main branch]
- Fix UDataValidationChangelist warnings not propagating to the window properly and only being emitted into the Message Log
- Fix asset validation warnings not appearing in the Confirm changelist submit window if the validator says the asset is valid
- Fix tokenized messages appearing blank
#rb Sebastien.Lussier
#jira none
#ushell-cherrypick of 34860898 by gabriel.wreczycki
[CL 34879202 by ben hoffman in ue5-main branch]
Put guardrails against using URC with multiple projects because it's not supported
#rb wouter.burgers
[CL 34127677 by dave belanger in ue5-main branch]
* Fix initial refresh UI not being call for all changelist type (esp. the Uncontrolled Cl)
#rb JeanFrancois.Dube, Patrick.Enfedaque
#jira UE-211803
[CL 33578294 by vincent beauchemin in ue5-main branch]
This case can occur when a submit is done external to the editor ( e.g. from P4V ) and has also been reported to happen after submits from within the editor. Now, when it is detected we request a changelists refresh in the next tick by setting bShouldRefresh to true.
This changelist also fixes another issue where files in the list view would get cleared when the selected changelist changed and then never get re-added to the list view.
#jira UE-211943
#rb brooke.hubert, zach.rammell
[CL 33213432 by ross smith2 in ue5-main branch]
- allows viewing descriptions which traverse multiple lines
- only affects the single line view (tooltip, etc still display as before)
#rnx
#rb zach.rammell
[CL 30279052 by matt peters in ue5-main branch]
Previously, the SYNC was done prior to showing the SUBMIT FILES dialog. If another user submitted anything while the user was typing their changelist description, the CHECK IN would fail (for Skein) because the user is no longer checking in as latest. By moving the SYNC to after the changelist description is completed, this is avoided. In addition, this allows the user once again to click the CHECK IN CHANGES without syncing to head if he just wants to see what local changes he has that need checking in - a workflow which I imagine is not uncommon.
Additionally, the check-in should be aborted if the SYNC results in the user entering conflict resolution.
#rb manuel.lang, marco.anastasi
#rnx
[CL 29484477 by wouter burgers in ue5-main branch]
Results with a 40K actors changelist editor startup time:
- Before: FPerforce::AddShelvedFilesToChangelist took 2:35 min
- After: FPerforce::AddShelvedFilesToChangelist took 160.08 ms
#rb sebastien.lussier
[FYI] jeansebastien.guay
[CL 29047110 by jeanfrancois dube in ue5-main branch]
General
Add support for returning tokenized messages from validation.
Unify validation reporting for different validation entry points - in particular, source control window context menu.
Move EDataValidationUsecase to CoreUObject for use by UObject::IsDataValid.
UEditorValidatorSubsystem
Add support for validating changelists. Use of this interface allows building lists of unmodified assets to re-validate based on the changes that were made.
Allow subclassing, with functions GatherAssetsToValidateFromChangelist and ShouldValidateAsset to modify behavior of validation.
Add optional to load assets for validation to validation parameters.
Capture logs during asset loads to report as errors (optional in validation parameters).
Allow limit to number of assets to validate in validation parameters, report limit reached.
Add message log page to validation parameters.
Add validation parameter to validate referencers of deleted assets in changelists for validation
UEditorValidatorBase
Centralize dispatch to BP/Native validation in non-virtual ValidateLoadedAsset function.
Add native interface functions to UEditorValidatorBase that take FDataValidationContext.
Rename BP interface functions to have K2 prefix and different signature to native functions.
FDataValidationContext
Add validation usecase.
Add 'associated assets' to allow associating external actors with maps for validators.
UDataValidationChangelist
Support changelists based on changelist objects, file states, and simple lists of files.
Group modifications into packages/non-assets and modified/deleted ahead of time for validators to inspect.
#rb dominic.couture
[CL 28824042 by robert millar in ue5-main branch]