Commit Graph

198 Commits

Author SHA1 Message Date
jamie dale
bb2eb686ca Fixed a crash when pasting into an array on class sparse data
This would try and get the value of the outer array property (for the inner array value) using FObjectBaseAddress::ObjectOrStruct as the start address, however for class sparse data FObjectBaseAddress::ObjectOrStruct was set to the CDO of the class that owns the sparse data, rather than the start of the sparse data itself. This resulted in a crash as it would try and read garbage from the CDO.

This change removes FObjectBaseAddress::ObjectOrStruct and FObjectBaseAddress::bIsStruct, in favor of storing FObjectBaseAddress::Object (if not editing a struct) and FObjectBaseAddress::StructAddress. FObjectBaseAddress::StructAddress always points to the thing that actually contains FObjectBaseAddress::BaseAddress, which allows the ImportText code to get the correct offset for the array property within the sparse data instance.

#jira
#rb Sebastian.Nordgren
#preflight 61a59b104f5d65edc3a8564b
#rnx

#ROBOMERGE-AUTHOR: jamie.dale
#ROBOMERGE-SOURCE: CL 18326295 via CL 18328452 via CL 18328534 via CL 18328607 via CL 18330452 via CL 18330516
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18330630 by jamie dale in ue5-release-engine-test branch]
2021-11-30 15:35:13 -05:00
Marc Audy
0c3be2b6ad Merge Release-Engine-Staging to Test @ CL# 18240298
[CL 18241953 by Marc Audy in ue5-release-engine-test branch]
2021-11-18 14:37:34 -05:00
daren cheng
b9610d8eca Add FPropertyHandleColor to support copy / paste between different color types.
#jira UETOOL-4586
#rb sebastian.nordgren
#preflight 619521439f7a6462e05b64e9

#ROBOMERGE-AUTHOR: daren.cheng
#ROBOMERGE-SOURCE: CL 18229602 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v895-18170469)
#ROBOMERGE[bot1]: Main

[CL 18229649 by daren cheng in ue5-release-engine-test branch]
2021-11-17 17:04:14 -05:00
andrew davidson
de67c7d575 LWC: Temporary support added to PropertyHandleVector for vectors of either float or double type.
#jira UE-119797
#preflight 6112a195f19b37000193c274

#ROBOMERGE-SOURCE: CL 17124305 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v855-17104924)

[CL 17124322 by andrew davidson in ue5-release-engine-test branch]
2021-08-10 16:59:18 -04:00
Andrew Davidson
3ddc3a4da3 Merge up from //UE5/Dev-LargeWorldCoordinates
#rb none

[CL 16211417 by Andrew Davidson in ue5-main branch]
2021-05-05 15:07:25 -04:00
aurel cordonnier
50944fd712 Merge UE5/RES @ 16162155 to UE5/Main
This represents UE4/Main @ 16130047 and Dev-PerfTest @ 16126156

[CL 16163576 by aurel cordonnier in ue5-main branch]
2021-04-29 19:32:06 -04:00
Martin Sevigny
fc222e63e0 Allow FNames to be initialized with a string that starts with an underscores from the editor.
https://p4-swarm.epicgames.net/reviews/15934265

#rb MattK
#jira none

#ushell-cherrypick of 15934265 by swarm

#ushell-cherrypick of 16060267 by Martin.Sevigny

[CL 16063439 by Martin Sevigny in ue5-main branch]
2021-04-20 13:33:00 -04:00
Marc Audy
01b7c9f4f5 Merge UE5/RES @ 15958325 to UE5/Main
This represents UE4/Main @ 15913390 and Dev-PerfTest @ 15913304

[CL 15958515 by Marc Audy in ue5-main branch]
2021-04-08 14:32:07 -04:00
sebastian nordgren
0aace23acf FPropertyEditorHelpers::GetMetadataOptionsKey now returns an FName. Internally, FProperty::GetMetaData deals with FName keys, so it makes sense to introduce them as early as possible.
#fyi luke.thatcher

[CL 15872334 by sebastian nordgren in ue5-main branch]
2021-03-31 04:11:32 -04:00
patrick enfedaque
34b9b71b4b Fix invalid failure message (regression of CL 13954062)
#jira UE-97312
[FYI]
#rb jeanfrancois.dube
#preflight 6062630325b98e0001466458

#ROBOMERGE-SOURCE: CL 15859526 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v786-15839533)

[CL 15859813 by patrick enfedaque in ue5-main branch]
2021-03-30 07:51:20 -04:00
Luke Thatcher
199fe78b79 Add "GetKeyOptions" and "GetValueOptions" uproperty metadata to allow combobox dropdowns on TMap FString/FName key/value pairs.
This makes it possible to declare a UPROPERTY like so:

    UPROPERTY(EditAnywhere, meta = (GetKeyOptions="GetValidItemKeys"))
    TMap<FString, FString> MapOfItems;

and have the dropdown appear only on the key field.

#rb Lauren.Barnes
#fyi Vincent.Gauthier,Sebastian.Nordgren
#preflight 606229ea57aca40001ff1441

[CL 15855122 by Luke Thatcher in ue5-main branch]
2021-03-29 16:34:46 -04:00
Marc Audy
0cbbc781ca Merge UE5/Release-Engine-Staging @ 15740152 to UE5/Main
This represents UE4/Main @ 15709114

[CL 15740605 by Marc Audy in ue5-main branch]
2021-03-18 15:20:03 -04:00
sebastian nordgren
0c2630e044 Resetting Light Units to default in point lights now functions correctly.
The issue is that FPropertyHandleBase does not have a very long lifetime, so this instance was getting ref counted and deleted when trying to be used the next frame.

#robomerge Release-5.0-EarlyAccess
#jira UE-110463
#rb paul.chipchase

[CL 15711948 by sebastian nordgren in ue5-main branch]
2021-03-16 11:49:37 -04:00
sebastian nordgren
50b8bd81f1 Fixed potential nullptr access to this in FPropertyHandleImpl::ExecuteCustomResetToDefault.
Fixed PreviewSceneCustomization causing reset to default to be deferred.

#jira UE-109160
#rb lauren.barnes

[CL 15623076 by sebastian nordgren in ue5-main branch]
2021-03-05 06:47:53 -04:00
sebastian nordgren
6f1682e790 GetOptions now works correctly with multi-selection.
Added test actor to PropertyEditorTestObject.h to allow for testing actor things, like this GetOptions multiselection bug.

Fixed whitespace errors caused by mismerge.

#jira UE-109745
#rb paul.chipchase

[CL 15604138 by sebastian nordgren in ue5-main branch]
2021-03-04 09:02:09 -04:00
daren cheng
60cd75894a Add support for displaying floats greater than e18 & remove cast losing double precision.
#jira UE-105026
#rb Matt.Kuhlenschmidt, Jamie.Dale
#robomerge Release-5.0-EarlyAccess

[CL 15516611 by daren cheng in ue5-main branch]
2021-02-24 13:43:42 -04:00
Marc Audy
9753392e2b Merge UE5/RES CL# 15462083 to UE5/Main
This represents UE4/Main @ 15414221

[CL 15463811 by Marc Audy in ue5-main branch]
2021-02-18 18:13:28 -04:00
Marc Audy
cac1fe0019 Merge UE5/Release-Engine-Staging @ CL# 15299266 to UE5/Main
This represents UE4/Main @ CL# 15277572

[CL 15299962 by Marc Audy in ue5-main branch]
2021-02-03 14:57:28 -04:00
David Hibbitts
fda414ff2c Added a EditorScriptExecutionGuard to FPropertyHandleBase::GeneratePossibleValues so GetOptions property functions no longer require CallInEditor specifiers when used with Actors
#rb Michael.Noland

[CL 15277583 by David Hibbitts in ue5-main branch]
2021-02-01 21:32:35 -04:00
mikko mononen
eff06ce060 Remove reset to default from SDefaultPropertyButtonWidgets
#jira none
#review-15244890

[CL 15269817 by mikko mononen in ue5-main branch]
2021-02-01 07:09:58 -04:00
Marc Audy
bc88b73a29 Merge Release-Engine-Staging to Main @ CL# 15151250
Represents UE4/Main @ 15133763

[CL 15158774 by Marc Audy in ue5-main branch]
2021-01-21 16:22:06 -04:00
sebastian nordgren
52b28be473 Added GetOuterBaseClass() to IPropertyHandle, which fetches the common base class of all the outer objects of an IPropertyHandle.
#rb lauren.barnes

[CL 15065544 by sebastian nordgren in ue5-main branch]
2021-01-13 04:33:28 -04:00
Yoan StAmant
223dd1c6d4 [Instanced properties] ResetToDefault on a property value will also update instanced properties to use deep copy (same as SDetailSingleItemRow::OnPasteProperty)
#rb sebastian.nordgren

[CL 15051840 by Yoan StAmant in ue5-main branch]
2021-01-12 13:23:51 -04:00
Marc Audy
bf80889353 UE5/Release-Engine-Staging to UE5/Main
This represents UE4/Main up to CL# 14958402

[CL 15028197 by Marc Audy in ue5-main branch]
2021-01-08 19:56:07 -04:00
sebastian nordgren
aedd43a9d1 Detail property rows that had a custom widget defined for them now correctly call the OverrideResetToDefault delegate given to the custom widget row.
FPropertyHandleImpl also no longer causes an infinite loop of deferred actions when a custom reset to default is set on a property row.

#rb lauren.barnes
#fyi kiaran.ritchie

[CL 14842839 by sebastian nordgren in ue5-main branch]
2020-12-03 06:13:13 -04:00