Commit Graph

25 Commits

Author SHA1 Message Date
ryan schmidt
17cefb1dd1 ModelingTools:
Reduce surface area of MeshDescriptionProvider/Committer, replace with UE::ToolTarget:: calls where possible.

Add new UE::ToolTarget::CommitMeshDescriptionUpdateViaDynamicMesh() function. This is being used for now to avoid potential regressions as UE::ToolTarget::CommitDynamicMeshUpdate will preferentially use DynamicMeshCommitter, and I am not certain it is functionally equivalent in all cases.
Add new UE::ToolTarget::CommitDynamicMeshNormalsUpdate(), similar to existing UV version
Add new Move-variant of UE::ToolTarget::CommitMeshDescriptionUpdate(), uses new Move-variant of IMeshDescriptionCommitter::CommitMeshDescription.
Make existing IMeshDescriptionCommitter::CommitMeshDescription callback interface protected, to prevent usage of this function at public API level (will be removed in future).

Tool updates should not change, just using cleaner APIs.
EditNormalsTool now uses CommitDynamicMeshNormalsUpdate(), which does go via DynamicMeshCommitter preferentially, where it previously went via MeshDescriptionCommitter. In light testing the results appear equivalent.
AttributeEditorTool now operates on MeshDescription copies in various update functions. These are not performance-critical.

#rb rinat.abdrashitov
#rnx
#preflight 61ae45998358693a22c28d1b

#ROBOMERGE-AUTHOR: ryan.schmidt
#ROBOMERGE-SOURCE: CL 18384350 in //UE5/Release-5.0/... via CL 18384361
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v896-18170469)

[CL 18384373 by ryan schmidt in ue5-release-engine-test branch]
2021-12-06 12:42:19 -05:00
lonnie li
f21c53eb0f ModelingTools: Reorder bake input mesh and output settings UI.
Remove TransientToolProperty from Resolution and Bit Depth properties.
Minor refactoring of BakeMeshAttributeMapsToolBase.

#rb none
#rnx
#jira none
#preflight 61a69467800738dbfb94ecbe

#ROBOMERGE-AUTHOR: lonnie.li
#ROBOMERGE-SOURCE: CL 18332363 in //UE5/Release-5.0/... via CL 18332412
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18332443 by lonnie li in ue5-release-engine-test branch]
2021-11-30 16:34:23 -05:00
lonnie li
1a8e4ef56f ModelingTools: Add details customization of EBakeMapType properties for bake tools.
#rb rinat.abdrashitov
#rnx
#jira none
#preflight 61a10c47c3287aab2748fcea

#ROBOMERGE-AUTHOR: lonnie.li
#ROBOMERGE-SOURCE: CL 18302621 in //UE5/Release-5.0/... via CL 18302626
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18302631 by lonnie li in ue5-release-engine-test branch]
2021-11-26 19:27:18 -05:00
lonnie li
33877a12c5 ModelingTools: Update the Texture/MultiTexture UV parameters to use GetOptions UI in BakeTexture/BakeVertex.
Fixed MultiTexture UV channel parameter not propagating to evaluator in BakeTexture.
Fixed crash when using invalid source UV channel for BakeAll.

#rb michael.balzer
#rnx
#jira none
#preflight 619eea61801b361978d47905

#ROBOMERGE-AUTHOR: lonnie.li
#ROBOMERGE-SOURCE: CL 18300009 in //UE5/Release-5.0/... via CL 18300013
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18300019 by lonnie li in ue5-release-engine-test branch]
2021-11-26 09:39:26 -05:00
lonnie li
18bf5bd184 ModelingTools: Minor Bake tools rename pass.
#rb trivial
#rnx
#jira none
#preflight 619ed10b801b361978d28665

#ROBOMERGE-AUTHOR: lonnie.li
#ROBOMERGE-SOURCE: CL 18290923 in //UE5/Release-5.0/... via CL 18290931
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18290938 by lonnie li in ue5-release-engine-test branch]
2021-11-24 19:19:10 -05:00
lonnie li
6ae7690823 ModelingTools: Minor refactor and renaming of bake tool members.
Fixed Texture2D bake not respecting selected UV layer.
Fixed MultiTexture2D bake overriding Texture2D bake UV layer.

#rb none
#rnx
#preflight 619e6917801b361978c8b74d

#ROBOMERGE-AUTHOR: lonnie.li
#ROBOMERGE-SOURCE: CL 18285637 in //UE5/Release-5.0/... via CL 18285668
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18285681 by lonnie li in ue5-release-engine-test branch]
2021-11-24 12:49:18 -05:00
lonnie li
14e49dec6f ModelingTools: Only show source mesh target in Bake tools if it is not baking to self.
Removed broken EditCondition from BakeAll property set.

#rb trivial
#rnx

#ROBOMERGE-AUTHOR: lonnie.li
#ROBOMERGE-SOURCE: CL 18270982 in //UE5/Release-5.0/... via CL 18270987
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18271011 by lonnie li in ue5-release-engine-test branch]
2021-11-23 11:33:05 -05:00
lonnie li
6584198283 InteractiveToolsFramework: Remove unnecessary target interface functions from MultiSelectionTool.
ModelingTools: Add UMultiSelectionMeshEditingTool to hold common interface requirements and functions that pertain to modeling mode MultiSelectionTools.

#rb semion.piskarev
#rnx
#jira none
#preflight 619c66d5c3287aab27e12c73

#ROBOMERGE-AUTHOR: lonnie.li
#ROBOMERGE-SOURCE: CL 18269697 in //UE5/Release-5.0/... via CL 18269713
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18269717 by lonnie li in ue5-release-engine-test branch]
2021-11-23 09:42:40 -05:00
Marc Audy
0c3be2b6ad Merge Release-Engine-Staging to Test @ CL# 18240298
[CL 18241953 by Marc Audy in ue5-release-engine-test branch]
2021-11-18 14:37:34 -05:00
michael balzer
b8a1c9b6cf GeometryCore: Remove ExplicitUseGeometryMathTypes.h
#ROBOMERGE-AUTHOR: michael.balzer
#ROBOMERGE-SOURCE: CL 18227685 in //UE5/Release-5.0/... via CL 18229350
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)
#ROBOMERGE[STARSHIP]: UE5-Main

[CL 18231457 by michael balzer in ue5-release-engine-test branch]
2021-11-17 19:02:44 -05:00
lonnie li
db670aaffc ModelingTools: Add additional trace events to the Bake tools.
#rb trivial
#rnx
#jira none
#preflight 6189db370779df5c6a59f3e9

#ROBOMERGE-AUTHOR: lonnie.li
#ROBOMERGE-SOURCE: CL 18099121 in //UE5/Release-5.0/... via CL 18099168
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v889-18060218)
#ROBOMERGE[STARSHIP]: UE5-Main

[CL 18099175 by lonnie li in ue5-release-engine-test branch]
2021-11-08 21:54:53 -05:00
lonnie li
d227863f71 ModelingTools: Fix broken preview material in BakeVertex.
#rb trivial
#rnx
#jira none

#ROBOMERGE-AUTHOR: lonnie.li
#ROBOMERGE-SOURCE: CL 18095436 in //UE5/Release-5.0/... via CL 18095466
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v889-18060218)
#ROBOMERGE[STARSHIP]: UE5-Main

[CL 18095476 by lonnie li in ue5-release-engine-test branch]
2021-11-08 18:13:30 -05:00
lonnie li
7cd76d1079 ModelingTools: Fix BakeVertex MultiTexture not prepopulating the source maps.
Fix BakeVertex MultiTexture not updating when changing source maps.

#rb none
#rnx
#jira UE-133708
#preflight 61845c2c0172ec000140926e

#ROBOMERGE-AUTHOR: lonnie.li
#ROBOMERGE-SOURCE: CL 18091863 in //UE5/Release-5.0/... via CL 18091886
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v889-18060218)
#ROBOMERGE[STARSHIP]: UE5-Main

[CL 18091907 by lonnie li in ue5-release-engine-test branch]
2021-11-08 15:04:40 -05:00
lonnie li
dcfda7663a ModelingTools: Fix Bake analytics event prefix.
#rb trivial
#rnx

#ROBOMERGE-AUTHOR: lonnie.li
#ROBOMERGE-SOURCE: CL 18045281 in //UE5/Release-5.0/... via CL 18045289
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v885-17909292)
#ROBOMERGE[STARSHIP]: UE5-Main

[CL 18045295 by lonnie li in ue5-release-engine-test branch]
2021-11-03 22:05:08 -04:00
lonnie li
9898c1feeb ModelingTools: Unify control flow in the bake tools to use BakeOpState. This will address the perceived hangs in BakeVertex.
#rb michael.balzer
#rnx
#jira UE-133693
#preflight 61830e1a56cd410001125dbe

#ROBOMERGE-AUTHOR: lonnie.li
#ROBOMERGE-SOURCE: CL 18045073 in //UE5/Release-5.0/... via CL 18045092
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v885-17909292)
#ROBOMERGE[STARSHIP]: UE5-Main

[CL 18045094 by lonnie li in ue5-release-engine-test branch]
2021-11-03 21:48:49 -04:00
lonnie li
5abfa622a6 ModelingTools: Add analytics to BakeVtx.
#rb matija.kecman
#rnx
#jira none
#preflight 6181660efc786a0001494c4a

#ROBOMERGE-AUTHOR: lonnie.li
#ROBOMERGE-SOURCE: CL 18022190 in //UE5/Release-5.0/... via CL 18022300
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v885-17909292)
#ROBOMERGE[STARSHIP]: UE5-Main

[CL 18022393 by lonnie li in ue5-release-engine-test branch]
2021-11-02 13:59:11 -04:00
lonnie li
503b63f9d1 ModelingTools: Cleanup BakeVertex type enum names.
#rb trivial
#rnx
#jira none

#ROBOMERGE-AUTHOR: lonnie.li
#ROBOMERGE-SOURCE: CL 17891875 in //UE5/Release-5.0/... via CL 17891889
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v883-17842818)
#ROBOMERGE[STARSHIP]: UE5-Main

[CL 17891897 by lonnie li in ue5-release-engine-test branch]
2021-10-21 18:36:32 -04:00
lonnie li
82115ee5c6 ModelingTools: Removed Occlusion Distribution and Bent Normal Space properties.
#rb trivial
#rnx
#jira none
#preflight 616e0e96e0de460001f0c86a

#ROBOMERGE-AUTHOR: lonnie.li
#ROBOMERGE-SOURCE: CL 17854840 in //UE5/Release-5.0/... via CL 17854854
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v883-17842818)
#ROBOMERGE[STARSHIP]: UE5-Main

[CL 17854858 by lonnie li in ue5-release-engine-test branch]
2021-10-18 21:51:09 -04:00
ryan schmidt
12f074e656 ModelingTools: optional path tracing support inside Modeling Tools
- Add new UModelingComponentsSettings which has settings for in-tool preview mesh rendering and emitted new mesh objects
- Add ToolSetupUtil::ApplyRenderingConfigurationToPreview() utility functions, most Tools now call this function to configure UPreviewMesh/DynamicMeshComponents they create for mesh editing preview rendering (uses Settings to make setup decisions like RT on/off)
- add PreviewMesh::NotifyWorldPathTracedOutputInvalidated(), forces invalidation of current path tracing result, call from various PreviewMesh internal functions
- UCreateMeshObjectTypeProperties::ConfigureCreateMeshObjectParams() now configures new-mesh-object parameters with RT and Collision from UModelingComponentsSettings
- DynamicMeshComponent now defaults to raytracing-enabled, usage in Editor is controlled by above settings

#rb rinat.abdrashitov
#rnx
#jira none
#preflight 615f376bf0ee840001cab0fc

#ROBOMERGE-AUTHOR: ryan.schmidt
#ROBOMERGE-SOURCE: CL 17753416 in //UE5/Release-5.0/... via CL 17758212
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v879-17706426)
#ROBOMERGE[STARSHIP]: UE5-Main

[CL 17758266 by ryan schmidt in ue5-release-engine-test branch]
2021-10-07 22:25:54 -04:00
lonnie li
4e24f71ad8 ModelingTools: Remove obsolete GaussianBlur properties.
Improve BakeMapType display names and tool tips.

#rb trivial
#rnx
#jira none
#preflight 615cc21c8ebc260001aaf8e4

#ROBOMERGE-AUTHOR: lonnie.li
#ROBOMERGE-SOURCE: CL 17729622 in //UE5/Release-5.0/... via CL 17729646
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v879-17706426)
#ROBOMERGE[STARSHIP]: UE5-Main

[CL 17729655 by lonnie li in ue5-release-engine-test branch]
2021-10-05 19:01:17 -04:00
lonnie li
7b553a5966 ModelingTools: Fix color texture output color space to correct asset previews.
#rb michael.balzer
#rnx
#jira UE-119423
#preflight 615c7a298c8edf000121305f

#ROBOMERGE-AUTHOR: lonnie.li
#ROBOMERGE-SOURCE: CL 17724573 in //UE5/Release-5.0/... via CL 17724580
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v879-17706426)
#ROBOMERGE[STARSHIP]: UE5-Main

[CL 17724592 by lonnie li in ue5-release-engine-test branch]
2021-10-05 13:56:51 -04:00
lonnie li
b9e683b2a7 ModelingTools: Fix crash in BakeVertex tool.
- Fix curvature settings in BakeVertex in per-channel mode.
- Fix erroneous ensure when in Identity correspondence mode.
- Remove remnants of previous Detail mesh system.
- Minor FMeshMapBaker interface updates.

#rb trivial
#rnx
#jira none
#preflight 6142689b3c7c670001add3ce

#ROBOMERGE-AUTHOR: lonnie.li
#ROBOMERGE-SOURCE: CL 17530703 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v870-17433530)

[CL 17530722 by lonnie li in ue5-release-engine-test branch]
2021-09-15 20:13:36 -04:00
lonnie li
7b0c2454ee ModelingTools: Bake tool detail mesh sampling abstraction
- Refactored direct detail mesh sampling queries into an abstract base interface for repurposing to alternative detail mesh constucts other than DynamicMesh3 (including N-to-1).
- Move IsTriangle tests out of evaluators and into the core bake loop.

#rb jimmy.andrews
#rnx
#jira UETOOL-3395
#preflight 6137d813d9c85a000150d95a

#ROBOMERGE-AUTHOR: lonnie.li
#ROBOMERGE-SOURCE: CL 17451759 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v870-17433530)

[CL 17451812 by lonnie li in ue5-release-engine-test branch]
2021-09-07 19:06:34 -04:00
lonnie li
a1819897ba ModelingTools: Pre-transform vertex colors SRGB to Linear in BakeVertex.
#rb jimmy.andrews michael.balzer semion.piskarev
#rnx
#jira UETOOL-3748
#preflight 61140b876c6eb000016e7e5a

#ROBOMERGE-SOURCE: CL 17144701 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v855-17104924)

[CL 17144719 by lonnie li in ue5-release-engine-test branch]
2021-08-11 20:29:24 -04:00
michael balzer
82ab317af0 MeshModelingToolset: Split plugin into non-experimental and experimental
#jira UETOOL-3823
#rb ryan.schmidt
#preflight 6101fb4b2b002800014f7007

#ROBOMERGE-SOURCE: CL 17003092 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v838-16927207)

[CL 17003151 by michael balzer in ue5-release-engine-test branch]
2021-07-29 20:08:48 -04:00