Commit Graph

430 Commits

Author SHA1 Message Date
sara schvartzman
4c5f837e61 Control Rig: fix crash on function's local variable deletion undo
#jira UE-136770
#rb jack.cai
#preflight 61b2344f764790bee6c132bb

#ROBOMERGE-AUTHOR: sara.schvartzman
#ROBOMERGE-SOURCE: CL 18431904 in //UE5/Release-5.0/... via CL 18435365
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v897-18405271)
#ROBOMERGE[STARSHIP]: UE5-Main

[CL 18435863 by sara schvartzman in ue5-release-engine-test branch]
2021-12-10 18:04:28 -05:00
mike zyracki
d1b2ee23c0 Sequencer: Control Rig: Support Re-Baking over a track with a Control Rig and crash with Pose Library open on exit due to edit mode being de-activated but not calling Exit which does it cleanup to well later.
#jira UE-136846
#jira UE-136857
#rb max.chen

#ROBOMERGE-AUTHOR: mike.zyracki
#ROBOMERGE-SOURCE: CL 18408003 in //UE5/Release-5.0/... via CL 18408015
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v897-18405271)

[CL 18408022 by mike zyracki in ue5-release-engine-test branch]
2021-12-08 12:55:37 -05:00
sara schvartzman
b721627ccb Control Rig: Allow copy/paste of control shape properties
#jira UE-112646
#rb jack.cai
#preflight 61af8f031649962b665d377d

#ROBOMERGE-AUTHOR: sara.schvartzman
#ROBOMERGE-SOURCE: CL 18404327 in //UE5/Release-5.0/... via CL 18404332
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v896-18170469)
#ROBOMERGE[STARSHIP]: UE5-Main

[CL 18404335 by sara schvartzman in ue5-release-engine-test branch]
2021-12-08 05:50:48 -05:00
jack cai
f1b352d482 Control Rig: Disable default value validation on load, which was causing array pins to lose their subpins. sometimes a serialized default value can become invalid when the pin's struct type's cpp declaration was changed. However we don't want to completely reject the default value since it still holds valid values for pins that did not change
#jira UE-136669
#rb trivial

#ROBOMERGE-AUTHOR: jack.cai
#ROBOMERGE-SOURCE: CL 18401767 in //UE5/Release-5.0/... via CL 18401790
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v896-18170469)

[CL 18401808 by jack cai in ue5-release-engine-test branch]
2021-12-07 19:03:08 -05:00
mike zyracki
f34d634919 CIS Fix
https://horde.devtools.epicgames.com/job/61afd845ee6e47a827ef2be3?step=4aff

#ROBOMERGE-AUTHOR: mike.zyracki
#ROBOMERGE-SOURCE: CL 18400755 in //UE5/Release-5.0/... via CL 18400757
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v896-18170469)

[CL 18400759 by mike zyracki in ue5-release-engine-test branch]
2021-12-07 17:10:38 -05:00
mike zyracki
8b7b2b4f16 Sequencer: Control Rig Anim Layer Improvements, pt1.
Fixes issue with selections when a control rig's section has channels masked out, it could select the wrong control, added CategoryIndex to fix that. Also improved selection/deselction speed by avoiding reselecting Controls when they are selected. That was done to make sure Python selections worked on the first time, but what the only that that was needed there was enabling the Control Rig Edit Mode, so we just do that.
#jira na
#preflight 61ae99682b3384289ad7208d
#rb max.chen

#ROBOMERGE-OWNER: mike.zyracki
#ROBOMERGE-AUTHOR: mike.zyracki
#ROBOMERGE-SOURCE: CL 18400449 in //UE5/Release-5.0/... via CL 18400525
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v896-18170469)
#ROBOMERGE-CONFLICT from-shelf

[CL 18400572 by mike zyracki in ue5-release-engine-test branch]
2021-12-07 16:54:34 -05:00
halfdan ingvarsson
df06cdb77d Control Rig: Fix redirector lookups when loading pins whose type has changed.
#jira UE-136812
#rb jack.cai

#ROBOMERGE-AUTHOR: halfdan.ingvarsson
#ROBOMERGE-SOURCE: CL 18396706 in //UE5/Release-5.0/... via CL 18396721
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v896-18170469)

[CL 18396723 by halfdan ingvarsson in ue5-release-engine-test branch]
2021-12-07 13:16:38 -05:00
keith yerex
1546a8a356 Add object existence interval tracking to Gameplay insights.
Remove most of the ObjectEvents being tracked, which will prevent allocating an event timeline for every object and wasting memory.
[REVIEW] Thomas.Sarkanen
#preflight 61af8d6bb841b84301b98874

#ROBOMERGE-AUTHOR: keith.yerex
#ROBOMERGE-SOURCE: CL 18396148 in //UE5/Release-5.0/... via CL 18396154
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v896-18170469)

[CL 18396161 by keith yerex in ue5-release-engine-test branch]
2021-12-07 12:29:09 -05:00
helge mathee
89cf3dffa9 Control Rig: Fix regression with input widgets showing on structs
#rb sara.schvartzman
#jira UE-136614

#ROBOMERGE-AUTHOR: helge.mathee
#ROBOMERGE-SOURCE: CL 18394134 in //UE5/Release-5.0/... via CL 18394159
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v896-18170469)
#ROBOMERGE[STARSHIP]: UE5-Main

[CL 18394162 by helge mathee in ue5-release-engine-test branch]
2021-12-07 08:25:34 -05:00
helge mathee
5430c3a415 Control Rig: Adjust icons for Tab Summoner, Rig Tree
#rb sara.schvartzman
#jira UE-136600 UE-136606
#preflight https://horde.devtools.epicgames.com/job/61af3af4c6650f98a97b37b7

#ROBOMERGE-AUTHOR: helge.mathee
#ROBOMERGE-SOURCE: CL 18393793 in //UE5/Release-5.0/... via CL 18393795
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v896-18170469)
#ROBOMERGE[STARSHIP]: UE5-Main

[CL 18393796 by helge mathee in ue5-release-engine-test branch]
2021-12-07 07:04:46 -05:00
mike zyracki
f5a63ce9d5 Sequencer:Control Rig: Don't move parented custom attribute type controls with pivot tool, and make sure to not key if not needed.
#jira UE-135531
#rb na
#trivial

#ROBOMERGE-AUTHOR: mike.zyracki
#ROBOMERGE-SOURCE: CL 18389925 in //UE5/Release-5.0/... via CL 18389935
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v896-18170469)

[CL 18389945 by mike zyracki in ue5-release-engine-test branch]
2021-12-06 18:27:28 -05:00
jeanfrancois dube
2f8faa977e ControlRig:
- Fix missing call to super in UControlRigComponent::InitializeComponent.
- Don't call UControlRigComponent::Initialize from UControlRigComponent::InitializeComponent.

Saves multiple frames over 200ms due to calling UControlRigComponent::Initialize from ULevel::RouteActorInitialize in cooked builds.

#rb halfdan.ingvarsson, andrew.firth
#lockdown jeff.farris
#preflight 616dc2ebbd4df400015f7a5d

#ROBOMERGE-AUTHOR: jeanfrancois.dube
#ROBOMERGE-SOURCE: CL 17850268 via CL 18003905 via CL 18369616 via CL 18369715
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18369793 by jeanfrancois dube in ue5-release-engine-test branch]
2021-12-03 13:05:01 -05:00
luke thatcher
30a06e01eb Fix nullptr dereference in FControlRigComponentMappedElement::GetAnimProxyOnGameThread()
- UObject Cast can fail, returning nullptr, if the object is not the correct type. This led to calling GetControlRigProxyOnGameThread() on the nullptr.

#rb Helge.Mathee
#lockdown Andrew.Firth
#preflight skip

#ROBOMERGE-AUTHOR: luke.thatcher
#ROBOMERGE-SOURCE: CL 17650546 via CL 17965285 via CL 18365538 via CL 18365620
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18365734 by luke thatcher in ue5-release-engine-test branch]
2021-12-03 01:05:50 -05:00
jon nabozny
cdc65f654f Reland: Fixes motion blur lengths when using time dilation
#rb josie.yang
#lockdown michal.valient
#preflight 614a44526c96990001c47143

#ROBOMERGE-OWNER: jon.nabozny
#ROBOMERGE-AUTHOR: guillaume.abadie
#ROBOMERGE-SOURCE: CL 17606608 via CL 17962735 via CL 18364937 via CL 18364960
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18365023 by jon nabozny in ue5-release-engine-test branch]
2021-12-02 23:53:56 -05:00
jon nabozny
9693ad4915 Undo //UE5/Private-Frosty/Engine/... changelist 17586431
#lockdown michal.valient
#preflight revert for build breakage

#ROBOMERGE-OWNER: jon.nabozny
#ROBOMERGE-AUTHOR: guillaume.abadie
#ROBOMERGE-SOURCE: CL 17587410 via CL 17948832 via CL 18364580 via CL 18364616
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18364712 by jon nabozny in ue5-release-engine-test branch]
2021-12-02 23:34:52 -05:00
jon nabozny
c418c40de0 Fixes motion blur lengths when using time dilation
#rb josie.yang
#lockdown michal.valient
#preflight 614a1e3259380f0001888d92

#ROBOMERGE-OWNER: jon.nabozny
#ROBOMERGE-AUTHOR: guillaume.abadie
#ROBOMERGE-SOURCE: CL 17586431 via CL 17948712 via CL 18364381 via CL 18364522
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18364604 by jon nabozny in ue5-release-engine-test branch]
2021-12-02 23:30:35 -05:00
mike zyracki
fe0903144b Control Rig: Don't exit prematurely when selecting with the controller otherwise elements may not be selected/deselected correctly. This comes up for example with Sequencer since it will auto-select child nodes, and often does a ClearSelection based upon a selection change, both of which can cause issues with this function.
#rb sara.schvartzman, helge.mathee
#jira na

#ROBOMERGE-AUTHOR: mike.zyracki
#ROBOMERGE-SOURCE: CL 18353625 in //UE5/Release-5.0/... via CL 18353662
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18353689 by mike zyracki in ue5-release-engine-test branch]
2021-12-02 12:09:00 -05:00
sara schvartzman
c2e8517589 Control Rig: Fix cannot add execute context to a function once it is removed
#jira UE-135600
#rb helge.mathee
#preflight 61a8c1afe8314ee7b594cb36

#ROBOMERGE-AUTHOR: sara.schvartzman
#ROBOMERGE-SOURCE: CL 18353073 in //UE5/Release-5.0/... via CL 18353095
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)
#ROBOMERGE[STARSHIP]: UE5-Main

[CL 18353121 by sara schvartzman in ue5-release-engine-test branch]
2021-12-02 11:44:22 -05:00
mark lintott
2e931a7335 More Non-Unity fixes..
#rb none
#jira none
#preflight 61a796441d2787d839607373

#ROBOMERGE-AUTHOR: mark.lintott
#ROBOMERGE-SOURCE: CL 18339559 in //UE5/Release-5.0/... via CL 18339565
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18339570 by mark lintott in ue5-release-engine-test branch]
2021-12-01 10:50:36 -05:00
mark lintott
a915daf999 Non-Unity fixes
#rb none
#jira none

#ROBOMERGE-AUTHOR: mark.lintott
#ROBOMERGE-SOURCE: CL 18339491 in //UE5/Release-5.0/... via CL 18339510
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18339542 by mark lintott in ue5-release-engine-test branch]
2021-12-01 10:47:42 -05:00
sara schvartzman
f48467a63e Control Rig: Fix errors on nodes don't disappear after undoing
#jira UE-135986
#rb helge.mathee
#preflight 61a60d0947752856c918153d

#ROBOMERGE-AUTHOR: sara.schvartzman
#ROBOMERGE-SOURCE: CL 18338597 in //UE5/Release-5.0/... via CL 18338636
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)
#ROBOMERGE[STARSHIP]: UE5-Main

[CL 18338677 by sara schvartzman in ue5-release-engine-test branch]
2021-12-01 09:36:35 -05:00
jack cai
4a980ee248 ControlRig: make sure duplicated temp assets used for editor validation cannot dirty the original assets
#jira UE-135745
#rb helge.mathee

#ROBOMERGE-AUTHOR: jack.cai
#ROBOMERGE-SOURCE: CL 18337534 in //UE5/Release-5.0/... via CL 18337541
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18337549 by jack cai in ue5-release-engine-test branch]
2021-12-01 06:29:29 -05:00
mike zyracki
077e58ff27 Sequencer: Control Rig: Create CR outliner and details panel for Controls while animating.
Created base widget for these new dockable tabs. Moved logic to these new widgets.
However since we want some feedback we left a #define to keep the old code that we can bring back if needed, will be removed once vetted by design.
Note space picker has it's own tab also but isn't working, need to revist that with Engine UX, think they have a bug.

#rb max.chen
#jira UE-136368
#preflight 61a6a1a68015016c7e11eb88
Note AG/Lyra failed do to other changes not related to this CL.

#ROBOMERGE-AUTHOR: mike.zyracki
#ROBOMERGE-SOURCE: CL 18335252 in //UE5/Release-5.0/... via CL 18335268
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18335271 by mike zyracki in ue5-release-engine-test branch]
2021-11-30 20:39:20 -05:00
mike zyracki
1b89b8bb61 Sequencer: Control Rig: When selecting controls we refresh the tree on next tick. Also when get key area's we don't get them if from track or object since that messes with control rig selection.
#jira UE-135944

#ROBOMERGE-AUTHOR: mike.zyracki
#ROBOMERGE-SOURCE: CL 18334898 in //UE5/Release-5.0/... via CL 18334904
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18334907 by mike zyracki in ue5-release-engine-test branch]
2021-11-30 19:43:26 -05:00
mike zyracki
be15a52015 Control Rig: Change TreeView so that it won't deselect items that are filtered out or collapsed.
#jira na
#rb na
[FYI] helge.mathee, jeremiah.grant

#ROBOMERGE-AUTHOR: mike.zyracki
#ROBOMERGE-SOURCE: CL 18333059 in //UE5/Release-5.0/... via CL 18333128
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18333140 by mike zyracki in ue5-release-engine-test branch]
2021-11-30 17:12:19 -05:00