Commit Graph

282 Commits

Author SHA1 Message Date
Francis Hurteau
9dfe27ab41 Truncation warning fixes for multiple core modules:
CookOnTheFly, CookOnTheFlyNetServer, PakFileUtilities, PakFile

#jira UE-166274
#rb PJ.Kack
#preflight 63c041f01a06fc61057115b7

[CL 23666183 by Francis Hurteau in ue5-main branch]
2023-01-12 13:17:30 -05:00
thomas ross
292d449b84 Fixing crash when unmounting a pak that is not yet in the paklist.
#rb swarm
#tests Android Dev Client

[CL 23369768 by thomas ross in ue5-main branch]
2022-12-01 23:36:02 -05:00
pj kack
d5aea7d4ef Fix IPlatformFilePak deadlock when mounting and unmounting simultaneously from different threads.
Refactor Mount and Unmount to only acquire one lock at a time.
Mount was calling into FPakPlatformFile::GetPakSignatureFile() and acquiring PakSignatureFileCacheLock before calling CreateFileReader() which ends up acquiring PakListCritical in FPakPlatformFile::GetMountedPaks().
Unmount was acquiring PakListCritical first and then calling into FPakPlatformFile::RemoveCachedPakSignaturesFile() and acquiring PakSignatureFileCacheLock.


#rb carlmagnus.nordin
#rnx
#preflight 638713b84004f73f6219fda9

[CL 23325188 by pj kack in ue5-main branch]
2022-11-30 06:20:18 -05:00
carlmagnus nordin
3d76ce80b5 IoDispatcher: Fixed shutdown crash
#preflight 63774398f514e1ded9982c1b
#rb pj.kack

[CL 23192024 by carlmagnus nordin in ue5-main branch]
2022-11-18 05:46:42 -05:00
carlmagnus nordin
f815a8a92f IoDispatcher: Fixed crash when requesting reads of 0 bytes
#preflight 6375edf0953c19d43557cb97
#rb per.larsson

[CL 23174498 by carlmagnus nordin in ue5-main branch]
2022-11-17 07:44:38 -05:00
rex hill
cc31e97fe2 Fix Static Analysis Win64 (MSVC): UE_FORCE_USE_IOSTORE
#preflight skip
#rnx

[CL 22823848 by rex hill in ue5-main branch]
2022-10-28 01:03:21 -04:00
rex hill
c217a35bcf Add UE_FORCE_USE_PAKS and UE_FORCE_USE_IOSTORE preprocessors so a target can set them for devs to stop needing to manually pass those arguments.
#preflight 6359cb6f9b2e9c76c7d90410
#rb dave.belanger

[CL 22810699 by rex hill in ue5-main branch]
2022-10-27 11:20:38 -04:00
pj kack
dd3487108b Fix for SignedArchiveReader requesting one chunk too many when doing reads that ends on a 64K chunk boundary
#jira UE-168199
#rb carlmagnus.nordin
#rnx
#preflight 635a32180d3a231123b25aeb, 635a325c316cf8bef62c3701

[CL 22806755 by pj kack in ue5-main branch]
2022-10-27 05:36:44 -04:00
carlmagnus nordin
8e924b5791 IoDispatcher: Fixed various issues related to unmounting a container when there are still requests in flight for that container
#rb pj.kack
#preflight 634e776e820aa0c193325b66

[CL 22596860 by carlmagnus nordin in ue5-main branch]
2022-10-18 07:55:38 -04:00
pj kack
d3724b5712 AsyncLoading2: Optimize loading related memory by releasing big allocations in dynamic data structures after big bursts of loading.
Saves ~3 MB after going from a peak of preloading ~17 000 async packages to in game streaming with a peak of ~700 async packages:
~2.2 MB in AsyncLoading (AsyncLoading2.cpp, StreamableManager.cpp)
~340 KB in FileSystem (IoDispatcherFileBackend.cpp)
~430 KB in Untagged (UObjectBase.cpp)

#rb carlmagnus.nordin
#rnx
#preflight 63496eeda8717e9453c69f2e, 63496f5aad0f7e2f203bbe35

[CL 22595150 by pj kack in ue5-main branch]
2022-10-18 04:03:28 -04:00
dmytro vovk
a02c1fc739 Fixed IMappedFileHandle::MapRegion to map files\regions smaller than a page size
#jira none
#rb Brandon.Schaefer
#preflight 6320c80447741a7dbd233398

[CL 22092571 by dmytro vovk in ue5-main branch]
2022-09-20 10:34:38 -04:00
Andriy Tylychko
6b7a075ba7 FCoreDelegates cleanup: removed delegate macros
#preflight 632072f947741a7dbd03e2c1
#rb steve.robb

[CL 21981540 by Andriy Tylychko in ue5-main branch]
2022-09-13 09:08:26 -04:00
Andriy Tylychko
158d311d73 FCoreDelegates: deprecations cleanup #2
#preflight 631878c0980179553e6f32d7
#rb matt.peters

[CL 21847431 by Andriy Tylychko in ue5-main branch]
2022-09-07 07:27:19 -04:00
Andriy Tylychko
ab033b8854 FCoreDelegates: deprecations cleanup #1
#preflight 63187771a20b67673b2f4c22
#rb paul.chipchase

[CL 21847272 by Andriy Tylychko in ue5-main branch]
2022-09-07 07:14:57 -04:00
carlmagnus nordin
20d5411f73 FilePackageStore (editor): Don't update mounted iostore containers if we've only added or removed paths for uncooked packages
#preflight 6310bc97840bf1e5c376171e
#rb pj.kack

[CL 21759776 by carlmagnus nordin in ue5-main branch]
2022-09-02 11:15:53 -04:00
Per Larsson
5792400769 PAK - use FileExists instead of OpenRead when mounting PAK files
#rb PJ.Kack
#jira UE-130681
#8465
#rnx
#preflight 6310b423ea685939704c04e9

[CL 21740752 by Per Larsson in ue5-main branch]
2022-09-01 10:38:45 -04:00
mark lintott
18e87ce3ed Removed unacceptable words from IPlatformPak
#rb pj.kack
#jira UE-158666
#preflight 62fe625f3f75602b2f064b53

[CL 21455048 by mark lintott in ue5-main branch]
2022-08-19 05:44:45 -04:00
carlmagnus nordin
133f4c3218 FilePackageStore: Fixed reversed ordering of mounted containers
#rb francis.hurteau
#preflight 629a475e090519c4ec214c18

#ROBOMERGE-OWNER: carlmagnus.nordin
#ROBOMERGE-AUTHOR: carlmagnus.nordin
#ROBOMERGE-SOURCE: CL 20490763 via CL 20490796 via CL 20490814 via CL 20491957 via CL 20491960
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v954-20466795)

[CL 20495583 by carlmagnus nordin in ue5-main branch]
2022-06-03 19:15:05 -04:00
CarlMagnus Nordin
3d5a2052dc AsyncLoading2: Add support for having multiple PackageStore backends
#preflight 6296fc872a1851b4ccae7e39
#rb pj.kack

[CL 20447121 by CarlMagnus Nordin in ue5-main branch]
2022-06-01 02:12:33 -04:00
David Harvey
a4fb95c2b8 Allow for platform specializations of the 'is pak file installed' logic when enumerating pak files.
#jira UE-152852
#preflight 628b8b90f1421422ea695cf7
#rb Justin.Marcus

[CL 20361380 by David Harvey in ue5-main branch]
2022-05-25 04:30:23 -04:00
CarlMagnus Nordin
0e301802b1 PR #9165: Prevent fileOpenLog command-line to bypass signature check (Contributed by rveilleux)
#rb none
#preflight 627e40145d0fe3ffef3a8d3e

[CL 20180214 by CarlMagnus Nordin in ue5-main branch]
2022-05-13 08:58:06 -04:00
guillaume abadie
b4db51bf8a Fixes -cvarsini when bAllowNonUFSIniWhenCooked=false
#rb trivial
#preflight 627d4ea9dd54e9fde6929bc5

#ROBOMERGE-AUTHOR: guillaume.abadie
#ROBOMERGE-SOURCE: CL 20169322 via CL 20169364 via CL 20169393
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20170742 by guillaume abadie in ue5-main branch]
2022-05-12 16:38:20 -04:00
dave belanger
b1529d572c Update FFilePackageStore::UncookedPackagesMap when unmounting content
#rb CarlMagnus.Nordin
#preflight 627ac0edc42338be6529f15b

#ROBOMERGE-AUTHOR: dave.belanger
#ROBOMERGE-SOURCE: CL 20138464 via CL 20139528 via CL 20139778 via CL 20140092
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20143828 by dave belanger in ue5-main branch]
2022-05-11 13:16:30 -04:00
CarlMagnus Nordin
63b8cbc9dd AsyncLoading2: Implemented loading of optional package segments
#rnx
#preflight 62627548ac29fcf6a213fe33
#rb francis.hurteau

[CL 19900368 by CarlMagnus Nordin in ue5-main branch]
2022-04-25 07:37:07 -04:00
Johan Torp
ef8e0c4660 Optimize WITH_CASE_PRESERVING_NAME FName loading
LoadDisplayNames() 1.06s -> 0.24s when async loading the name batch in CachedAssetRegistry.bin during editor startup of an internal project

* Introduce FDisplayNameEntryId to avoid cache misses in FName::GetComparisonIdFromDisplayId() lookups
* Force name batch serialization to use display entry ids to help enforce cooking determinism
* Fix determinism problem when loading then saving via FPackageStoreNameMapBuilder
* Inline FNameEntryId::FromUnstableInt()
* Remove slow IsNumbered() check in CreateFromDisplayId when not using 4B FName
* Remove expensive heap sort by sorting up front instead

#rb rob.millar,matt.peters,pj.kack
#preflight 62664bd06968f18d5137d419

[CL 19899104 by Johan Torp in ue5-main branch]
2022-04-25 03:48:33 -04:00