Commit Graph

58 Commits

Author SHA1 Message Date
nick verigakis
d2ed7b31a3 New batch APIs to optimize UEFN project close times by deferring and batching:
- Calls to OnPluginUnload (one GC call for all plugins)
- Calls to FCollectionManager::HandleObjectDeleted (one UpdateCaches call at the end)

#rb Dave.Belanger, Francis.Hurteau
[FYI] Rex.Hill
#rnx

[CL 36757086 by nick verigakis in 5.5 branch]
2024-10-01 19:26:41 -04:00
logan buchy
56d324f623 Collections should respect auto-commit on submit setting when referencing deleted redirectors
* Redirector deletion is not auto-submitted, this allows users to submit both collection change and redirector deletion change as part of the same CL

#jira UE-224040
#rb ross.smith

[CL 36234848 by logan buchy in 5.5 branch]
2024-09-12 13:16:46 -04:00
robert millar
f699103d4a Making collection manager thread safe to allow future work to run content browser search in parallel.
Deprecate GetLastError and replace with FText* output parameters on fallible methods.
Use hierarchy of guard types to document access requirements for internal methods.
Separate cache updates from cache access. Cache updates must be performed explicitly so that read->write lock update and possible preemption is clear.

#rb logan.buchy

[CL 33120048 by robert millar in ue5-main branch]
2024-04-19 18:17:59 -04:00
bob tellez
b0bbbcd9bf [Backout] - CL33005160
[FYI] robert.millar
Original CL Desc
-----------------------------------------------------------------
Making collection manager thread safe to allow future work to run content browser search in parallel.
Deprecate GetLastError and replace with FText* output parameters on fallible methods.
Use hierarchy of guard types to document access requirements for internal methods.
Separate cache updates from cache access. Cache updates must be performed explicitly so that read->write lock update and possible preemption is clear.

#rb logan.buchy

[CL 33030091 by bob tellez in ue5-main branch]
2024-04-17 02:10:31 -04:00
robert millar
15f262a297 Fix unnecessary dereference of OutError exposed by PVS studio
[CL 33017824 by robert millar in ue5-main branch]
2024-04-16 18:35:01 -04:00
robert millar
e2103115d0 Attempt to fix PVS-studio error by passing pointer explicitly rather than reference to uninitialized member.
[CL 33013648 by robert millar in ue5-main branch]
2024-04-16 16:38:50 -04:00
robert millar
0e88efe9d0 Fix missing early out on non-existent collection.
[CL 33012739 by robert millar in ue5-main branch]
2024-04-16 16:14:09 -04:00
robert millar
820b6c0952 Making collection manager thread safe to allow future work to run content browser search in parallel.
Deprecate GetLastError and replace with FText* output parameters on fallible methods.
Use hierarchy of guard types to document access requirements for internal methods.
Separate cache updates from cache access. Cache updates must be performed explicitly so that read->write lock update and possible preemption is clear.

#rb logan.buchy

[CL 33005243 by robert millar in ue5-main branch]
2024-04-16 12:54:49 -04:00
logan buchy
21022f1121 Update workflows for when not using Collection Setting AutoCommitOnSave
* Only AddToCollection, RemoveFromCollection, SetColor and Reparent will not commit to perforce server if setting is off
* Creating collections notably must commit otherwise it will not be added to a source control working set
* Tunnelled the behaviour of submitting to SCC through the Internal helper function as it does not have the context to decide what workflow is running.

#rb brooke.hubert, robert.millar

[CL 31892830 by logan buchy in ue5-main branch]
2024-02-28 18:50:54 -05:00
rex hill
31ddb7b1c4 Optimize collection manager by allowing batch remove
#rb logan.buchy

[CL 30926597 by rex hill in ue5-main branch]
2024-01-26 11:33:21 -05:00
ben zeigler
bd1e5f1d9b Update and optimize the collection manager callback that happens after the asset registry scan, this version is twice as fast
Add a direct accessor to Collection's asset set for fast iteration
#rb matt.peters

[CL 26591928 by ben zeigler in ue5-main branch]
2023-07-25 18:24:55 -04:00
logan buchy
8cb8cff1ba Feedback changes to Collections telemetry
* Moved workflow tracking of collection manipulations up one level to target user interaction only
* Added create/destroy collection workflows
* Remove hand-holding utilities aimed to ease verbosity of telemetry event generation

#rb wes.hunt
#jira UE-155132
#preflight 6463b34f063e77985c259c71

[CL 25492328 by logan buchy in ue5-main branch]
2023-05-16 13:02:13 -04:00
logan buchy
63b05e7fc4 Collection Manager Telemetry Events
* Uses method of exposing a delegate for telemetry events to be registered by a StudioAnalytic provider implementation to avoid embedding schema in the engine
* Generic templates for RAII scoped timed telemetry events added to aid in generating timed events

#jira UE-155132
#rb Brooke.Hubert Wes.Hunt Ronald.Koppers
#preflight 645022cdee56ca4c247ef92a

[CL 25291458 by logan buchy in ue5-main branch]
2023-05-01 17:00:52 -04:00
patrick laflamme
878d1ae127 Instrumented source control upcate callbacks with with cpu scopes for monitoring performances.
Optimized Collection code invoked at each source control update to avoid comparing large set to detect if the in-memory collection is different from the collection on disk.

#rb Julien.StJean
#preflight 6346e2cf663dafe4162e8c9e

[CL 22505265 by patrick laflamme in ue5-main branch]
2022-10-13 11:24:42 -04:00
robert millar
e6857190f2 Updating collection manager interface to use FSoftObjectPath for the paths of assets and objects rather than FName.
#jira UE-161932
#rb julien.stjean
#preflight https://horde.devtools.epicgames.com/job/6324e773f258fccf98de78cf

[CL 22064625 by robert millar in ue5-main branch]
2022-09-16 20:57:34 -04:00
charles bloom
38b1d2e51f Mark up more ParallelFor scopes for Insights
#rb none
#preflight 6216cd82647bb7debf703367

[CL 19105606 by charles bloom in ue5-main branch]
2022-02-23 19:25:03 -05:00
michael noland
feafa92f44 Editor: Added a project setting to allow specifying additional changelist tags for use when the editor auto-commits edits to collections
#jira UE-142041
#rb marc.audy
#preflight 62044d39a65a8a28462ff528
#lockdown julien.marchand

#ROBOMERGE-AUTHOR: michael.noland
#ROBOMERGE-SOURCE: CL 18935369 in //UE5/Release-5.0/... via CL 18935468 via CL 18935638
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18935681 by michael noland in ue5-main branch]
2022-02-10 10:05:44 -05:00
Matt Peters
f76045bb7e LowLevelMemTracker - add scopes for some large allocations during cooking.
#rb Devin.Doucette
#rnx
#preflight 62047a600a1c4eb68f555ba5

[CL 18930861 by Matt Peters in ue5-main branch]
2022-02-09 21:53:31 -05:00
bob tellez
3c018f315a #UE Add commandline option to avoid following redirectors in collections during startup. You sometimes want to make collections of redirectors when audting content
#ROBOMERGE-AUTHOR: bob.tellez
#ROBOMERGE-SOURCE: CL 18327503 via CL 18327514 via CL 18327529 via CL 18328464 via CL 18328574
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18328663 by bob tellez in ue5-release-engine-test branch]
2021-11-30 14:20:47 -05:00
andriy tylychko
6bf3101dcd deprecated FTicker and family and replaced by thread-safe FTSTicker
#jira UE-120090
#rb francis.hurteau


#ROBOMERGE-SOURCE: CL 17176325 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v855-17104924)

[CL 17176374 by andriy tylychko in ue5-release-engine-test branch]
2021-08-16 11:09:22 -04:00
Marc Audy
01b7c9f4f5 Merge UE5/RES @ 15958325 to UE5/Main
This represents UE4/Main @ 15913390 and Dev-PerfTest @ 15913304

[CL 15958515 by Marc Audy in ue5-main branch]
2021-04-08 14:32:07 -04:00
danny couture
36cd2ee1da Optimize collection files reading
- Parallelize collection loading in FCollectionManager::LoadCollections
  - Parallelize FName registration to cut on hashing cost in Collection::Load
  - Leverage FStringView where possible in Collection::Load

  - 987ms -> 238ms for collection loading during editor startup
  - 987ms -> 696ms with -onethread

#rnx
#tests generated md5 of all loaded collections content before and after the change
#rb Bob.Tellez

#ROBOMERGE-SOURCE: CL 13054205 via CL 13054206 via CL 13054211
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v686-13045012)

[CL 13054213 by danny couture in Main branch]
2020-04-28 06:20:33 -04:00
JeanMichel Dignard
70d074639f Merging //UE4/Dev-Main @ 10886849 to Dev-Tools-Staging (//UE4/Dev-Tools-Staging)
#rb none
#rnx

[CL 10906274 by JeanMichel Dignard in Dev-Tools-Staging branch]
2020-01-08 13:26:18 -05:00
ryan durand
471d972e62 Updating copyright for Engine Developer.
#rnx
#rb none


#ROBOMERGE-SOURCE: CL 10869240 via CL 10869516 via CL 10869902
#ROBOMERGE-BOT: (v613-10869866)

[CL 10870584 by ryan durand in Main branch]
2019-12-26 15:32:37 -05:00
Gines Hidalgo
7e5c105006 #jira none
Some displayed error messages about paths being too long are more informatives and include full path and current/maximum length allowed.

#rb none

[CL 10119068 by Gines Hidalgo in Dev-Editor branch]
2019-11-12 18:03:37 -05:00