Commit Graph

117 Commits

Author SHA1 Message Date
gerard martin
e30ca04a02 [Mutable] Minor CustomizableObjectSystem code improvements.
- Added consts.
- Changed function copies to references.
- Moved checks at the beggining of functions.
- Removed parameters passed outside the FMutableOperationData.
- Default initialization of members.
- Removed unused code.
- Moved implementations to source file.
- Fixed typos.

[REVIEW] [at]alexei.lebedev, [at]pere.rifa
#rnx

[CL 27666874 by gerard martin in ue5-main branch]
2023-09-07 04:23:11 -04:00
jordi rovira
dcd487a510 [mutable] Add option to use Unreal's texture compressor at compile and debug time. Enable it by default for cook. Add option to override the internal pixel format function.
Change the method to find out the platform texture format, so that we have less ad-hoc code and more support for Unreal's project settings affecting it.
Cleanup image conversion code related to instance baking, removing duplicated hacky code.
[REVIEW] [at]gerard.martin, [at]pere.rifa
#rnx

[CL 27666341 by jordi rovira in ue5-main branch]
2023-09-07 03:45:44 -04:00
alexei lebedev
6b42c3c36a [FYI] [at]jacob.buck
#rnx

[CL 27632697 by alexei lebedev in ue5-main branch]
2023-09-06 09:49:00 -04:00
pere rifa
18ff806675 [Mutable] Fix crashes when accessing the ComponentData in platforms where, due to LOD Setting, the FirstLODToGenerate is greater than 0.
#rnx

#localization none
#tests PIE

[CL 27533723 by pere rifa in ue5-main branch]
2023-08-31 15:22:46 -04:00
alexei lebedev
bc0236db35 #rnx
[CL 27533690 by alexei lebedev in ue5-main branch]
2023-08-31 15:22:03 -04:00
pere rifa
224abcad3e [Mutable] Fix crash in FSkeletalMeshSceneProxy::GetDynamicMeshElements caused by GCed materials used in the render thread.
Added CVar mutable.TicksUntilMaterialRelease to change the number of ticks to keep swapped materials alive.

#rnx

#localization none
#tests Frontend and Locker

[CL 27528163 by pere rifa in ue5-main branch]
2023-08-31 13:21:05 -04:00
pere rifa
89fdda5ba7 [Mutable] Fix generation of wrongly sized textures when a size limitation is applied on top of the image and streaming is disabled.
#rnx
#rb [at]genis.sole, [at]alexei.lebedev

[CL 27371394 by pere rifa in ue5-main branch]
2023-08-25 05:16:17 -04:00
alexei lebedev
bd1de3692a #rnx
[CL 27303722 by alexei lebedev in ue5-main branch]
2023-08-23 09:23:59 -04:00
pere rifa
0a26d398c7 [Mutable] Initialize the generated meshes with the LOD quality settings specified in the CO.
#rnx
#rb alexei.lebedev

[CL 27268182 by pere rifa in ue5-main branch]
2023-08-22 08:38:33 -04:00
pere rifa
1a3c729025 [Mutable] Fix crash caused by the CustomizableObjectSystem triggering garbage collection when a World is in the middle of its tick.
#rnx
#rb alexei.lebedev

[CL 27172651 by pere rifa in ue5-main branch]
2023-08-17 10:26:18 -04:00
alexei lebedev
88ed4b15e8 #rnx
[CL 27169407 by alexei lebedev in ue5-main branch]
2023-08-17 07:38:09 -04:00
pere rifa
01a2660bd8 [Mutable] Allow forcing the generation of the mipmaps tail of textures marked as low-priority textures in the customizable object.
#rnx

[CL 27071617 by pere rifa in ue5-main branch]
2023-08-14 11:32:30 -04:00
alexei lebedev
086fada508 [mutable] Fixed projections permanently appearing as default textures when quickly changing between two options.
The problem was that an update was cancelled because it was a subset of the current descriptor of the instance, but didn't take into consideration that the current running operation was modifiying the descriptor of the instance.

[REVIEW] [at]jordi.rovira, [at]pere.rifa
#rnx

#localization none
#tests PIE Frontend

[CL 27070410 by alexei lebedev in ue5-main branch]
2023-08-14 10:47:31 -04:00
pere rifa
fc053a2c8a [Mutable] Fix missing texture parameters and skipped updates.
Texture parameters of the ongoing update were being uncached by incoming petitions if they had different parameters.
Asking for an update of the current instance being updated would sometimes skip it and mark it as successful.

#rnx

[CL 27000866 by pere rifa in ue5-main branch]
2023-08-10 14:14:20 -04:00
jordi rovira
163275047e [mutable] More compact packing of binary blobs for parameter values in generated resources keys.
Changed external image IDs to use FNames.
Single cache for all models.
[REVIEW] [at]gerard.martin
#rnx

[CL 26700249 by jordi rovira in ue5-main branch]
2023-07-31 03:24:06 -04:00
pere rifa
4309007ae5 [Mutable] Fix TextureParameters being removed from the ImageProvider's cache while still in use.
#rnx
#rb gerard.martin

[CL 26668136 by pere rifa in ue5-main branch]
2023-07-28 06:06:02 -04:00
max garcia
19f7e7aa24 [mutable] Changed table material functionality. Now a table material works as a real material swtch instead of creating a swtch for each modified parameter.
+ Now, if a node is linked to a texture parameter, the image pin mode would not be able to be modified.

#rnx
#rb alexei.lebedev, gerard.martin

[CL 26665521 by max garcia in ue5-main branch]
2023-07-28 02:20:23 -04:00
gerard martin
cc399ad32b [Mutable] Reduce MutableRuntime memory peak.
Forbidden to do an UpdateImage before releasing the resources from a generation update.

[REVIEW] [at]alexei.lebedev, [at]genis.sole
#rnx

[CL 26602495 by gerard martin in ue5-main branch]
2023-07-26 06:46:59 -04:00
gerard martin
df154c49a5 [Mutable] Fix "Failed to cache external image" warning.
- Some update paths where not adding reference the external images. Added an additional check to detect this kind of errors.
- Task_Game_Lock_Cache was removing old references before adding the new ones.
- Fix LOD updates completely skipping DoUpdateSkeletalMesh.

[REVIEW] [at]alexei.lebedev, [at]pere.rifa
#rnx

[CL 26505990 by gerard martin in ue5-main branch]
2023-07-21 03:28:52 -04:00
pere rifa
2850573a87 [Mutable] Disable editor compilations and the CO system tick when the cook commandlet is running.
#rnx
#rb alexei.lebedev

[CL 26482178 by pere rifa in ue5-main branch]
2023-07-20 07:38:13 -04:00
keaton stewart
36aede7dca [Backout] - CL26456500 Main CIS AutoTest Cook Error
[FYI] gerard.martin
Original CL Desc
-----------------------------------------------------------------
[Mutable] Fix "Failed to cache external image" warning.

- Some update paths where not adding reference the external images. Added an additional check to detect this kind of errors.
- Task_Game_Lock_Cache was removing old references before adding the new ones.
- Fix LOD updates completely skipping DoUpdateSkeletalMesh.

[REVIEW] [at]alexei.lebedev, [at]pere.rifa
#rnx

[CL 26468715 by keaton stewart in ue5-main branch]
2023-07-19 15:41:16 -04:00
keaton stewart
a03f5af231 [Backout] - CL26458820 Main CIS AutoTest Cook Error
[FYI] pere.rifa
Original CL Desc
-----------------------------------------------------------------
[Mutable] Fix missing material parameters when reusing surfaces between LODs.

#rnx
[REVIEW] gerard.martin

[CL 26468693 by keaton stewart in ue5-main branch]
2023-07-19 15:40:37 -04:00
pere rifa
eb57ea4a86 [Mutable] Fix missing material parameters when reusing surfaces between LODs.
#rnx
[REVIEW] gerard.martin

[CL 26458974 by pere rifa in ue5-main branch]
2023-07-19 09:25:52 -04:00
gerard martin
7323dfc2fc [Mutable] Fix "Failed to cache external image" warning.
- Some update paths where not adding reference the external images. Added an additional check to detect this kind of errors.
- Task_Game_Lock_Cache was removing old references before adding the new ones.
- Fix LOD updates completely skipping DoUpdateSkeletalMesh.

[REVIEW] [at]alexei.lebedev, [at]pere.rifa
#rnx

[CL 26457560 by gerard martin in ue5-main branch]
2023-07-19 08:22:35 -04:00
pere rifa
32254df5af [Mutable] Fix incorrect implicit type conversion which resulted in released textures being kept in the generated textures cache.
#rnx
#rb alexei.lebedev

[CL 26432522 by pere rifa in ue5-main branch]
2023-07-18 09:36:44 -04:00