Commit Graph

290 Commits

Author SHA1 Message Date
jack cai
70bc5b69f4 RigVMRegistry: Added support for user defined type addition and removal
Important notes:
1. We should now use TypeUtils::GetUniqueStructName  instead of struct->getstructcppname for type names used by the registry since user defined struct need to have unique names generated for them

2. We should be aware that we can have invalid permutations in templates when types are deleted, so make sure you check for typeindex != INDEX_NONE when looping over permutations

#jira UE-152930
#rb Sara.schvartzman, Benoit.gadreau, Halfdan.Ingvarsson
#preflight https://horde.devtools.epicgames.com/job/6310c6992a5406d810d5a0e8

[CL 21754534 by jack cai in ue5-main branch]
2022-09-01 23:33:24 -04:00
sara schvartzman
458060c7a4 Control Rig: Fix aggregate nodes inside functions can not be pasted
#jira UE-162141
#rb benoit.gadreau
#preflight 630f6b5f660db81edbb7f558

[CL 21723965 by sara schvartzman in ue5-main branch]
2022-08-31 13:28:04 -04:00
jack cai
8c33e07aaa ControlRig: use break link to removing injected nodes so that link deletion does not fail and leave a invalid link in the graph.
#jira UE-160795
#rb Sara.schvartzman, Benoit.gadreau
#preflight skip

[CL 21709652 by jack cai in ue5-main branch]
2022-08-30 17:08:45 -04:00
benoit gadreau
71b23cb2e9 ensure exec context uniqueness except for aggregate nodes
#jira UE-161892
#rb sara.schvartzman
#preflight 630e135398103d4521a69da3

[CL 21701814 by benoit gadreau in ue5-main branch]
2022-08-30 11:26:08 -04:00
sara schvartzman
0123155f9d Control Rig: Fix crash when collapsing to function
#jira UE-161884
#rb jack.cai, benoit.gadreau
#preflight 6307907aec6059cd2a088e27

[CL 21587220 by sara schvartzman in ue5-main branch]
2022-08-26 05:30:22 -04:00
sara schvartzman
ab56a6f52c Control Rig: Fix unresolved deprecated nodes are not reporting an error if not involved in compilation
#rb jack.cai
#preflight 6304fce8ae13a5a098e86fbc

[CL 21524982 by sara schvartzman in ue5-main branch]
2022-08-23 19:22:27 -04:00
sara schvartzman
20e553d53f Control Rig: Fix crash on compile when node is not able to resolve
#jira UE-161503
#rb jack.cai
#preflight 6304926f516bef57ff9ac6e7

[CL 21512188 by sara schvartzman in ue5-main branch]
2022-08-23 13:08:13 -04:00
sara schvartzman
f3c1631d68 Control Rig: Fix GetFilteredTypes returning wildcard type
#jira na
#rb trivial
#preflight 6304b0600061f895d013d248

[CL 21504976 by sara schvartzman in ue5-main branch]
2022-08-23 07:15:04 -04:00
sara schvartzman
ced4c6c94f RigVM: Auto-resolval for template nodes
#author helge.mathee
#rb sara.schvartzman
#jira UE-160956
#preflight https://horde.devtools.epicgames.com/job/62fe191d086f90bbc4b17c26

[CL 21504849 by sara schvartzman in ue5-main branch]
2022-08-23 07:06:22 -04:00
jack cai
f72bcf15df ControlRig: Rename exposed pin should also rename the display name in addition to the name of the pin object
#jira UE-160796
#rb sara.schvartzman, benoit.gadreau, helge.mathee
#preflight skip

[CL 21467698 by jack cai in ue5-main branch]
2022-08-19 19:19:45 -04:00
Helge Mathee
36e8d6d357 RigVM: Nullptr fix for GetRegisteredUnitStructs
#rb sara.schvartzman
#preflight skip
#jira UE-158949
#robomerge FNMain

[CL 21402493 by Helge Mathee in ue5-main branch]
2022-08-16 05:18:31 -04:00
helge mathee
317046bf91 RigVM: Generalize all execute pins to use the RigVMExecuteContext
#rb sara.schvartzman
#jira UE-159391
#preflight https://horde.devtools.epicgames.com/job/62f39397086f90bbc4d92510

#ROBOMERGE-OWNER: helge.mathee
#ROBOMERGE-AUTHOR: helge.mathee
#ROBOMERGE-SOURCE: CL 21333330 via CL 21333332 via CL 21333623
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21334003 by helge mathee in ue5-main branch]
2022-08-11 06:58:29 -04:00
sara schvartzman
f5caea7afc Control Rig: Fix new name of the Function does not display on Function's node in the Rig Graph after renaming
#jira UE-160273
#rb helge.mathee
#preflight 62f4d3e5185b21882a28d8e5

[CL 21333761 by sara schvartzman in ue5-main branch]
2022-08-11 06:17:57 -04:00
sara schvartzman
897cf294b1 Control Rig: Fix crash when undoing collapse function references
#jira UE-159919
#rb helge.mathee
#preflight 62f139b7d834fe6ee78ff81d

[CL 21282179 by sara schvartzman in ue5-main branch]
2022-08-09 05:01:30 -04:00
sara schvartzman
5d52a11107 Control Rig: Fix crash when copy pasting template node
#jira UE-159896
#rb helge.mathee
#preflight 62f127ec185da2495f7b3e81

[CL 21282129 by sara schvartzman in ue5-main branch]
2022-08-09 04:58:19 -04:00
helge mathee
05433d025b Control Rig: Support watches within functions
#rb sara.schvartzman
#jira UE-144667
#preflight https://horde.devtools.epicgames.com/job/62d56f76af68cd745b024095

#ROBOMERGE-AUTHOR: helge.mathee
#ROBOMERGE-SOURCE: CL 21161137 via CL 21165954 via CL 21169879
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21182735 by helge mathee in ue5-main branch]
2022-07-20 12:20:55 -04:00
sara schvartzman
f0c793ff54 Control Rig: Fix crash when undo/redoing paste of library node with bounded variables
#jira UE-159285
#rb helge.mathee
#preflight 62d5a98aaf68cd745b23556b
#robomerge FNMain

[CL 21161253 by sara schvartzman in ue5-main branch]
2022-07-19 09:14:23 -04:00
sara schvartzman
759ade463a Control Rig: Adding aggregates for template nodes
#jira UE-147512
#rb helge.mathee
#preflight 62d459d499514be7eb2920a4

[CL 21143858 by sara schvartzman in ue5-main branch]
2022-07-18 04:44:55 -04:00
sara schvartzman
339fb58e04 Control Rig: Fix compile issue
#jira na
#rb trivial

#ROBOMERGE-AUTHOR: sara.schvartzman
#ROBOMERGE-SOURCE: CL 21096155 in //UE5/Release-Engine-Staging/...
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21099282 by sara schvartzman in ue5-main branch]
2022-07-14 17:07:44 -04:00
sara schvartzman
8a614978b8 Control Rig: Fix ensure hit when openning rigs with FRigPose pins
#jira UE-159392
#rb helge.mathee
#preflight 62cfe0f6a4645cf7b0099ae7


#ROBOMERGE-OWNER: sara.schvartzman
#ROBOMERGE-AUTHOR: sara.schvartzman
#ROBOMERGE-SOURCE: CL 21091246 via CL 21091293 via CL 21091498 via CL 21095119
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21099193 by sara schvartzman in ue5-main branch]
2022-07-14 17:05:41 -04:00
sara schvartzman
44e04d8fe0 Control Rig: Fix ensure hit when openning rigs with FRigPose pins
#jira UE-159392
#rb helge.mathee
#preflight 62cfe0f6a4645cf7b0099ae7
#robomerge FNMain

[CL 21091246 by sara schvartzman in ue5-main branch]
2022-07-14 11:15:57 -04:00
sara schvartzman
eec59437e9 Control Rig: Collapse nodes with templates
#jira UE-146929
#rb helge.mathee
#preflight 62ced5dbd00f3c208e47c183

[CL 21089290 by sara schvartzman in ue5-main branch]
2022-07-14 06:53:37 -04:00
ronald koppers
12979e53c2 FMessageLog::CriticalError has been deprecated.
FMessageLog::CriticalError has a delay before throwing an assert to allow compositing of the message. As a result the assert isn't thrown at the location of the problem, but somewhere in the surrounding area, which makes the problem harder to debug and generates misleading log entries. Due to these problems FMessageLog::CriticalError and EMessageSeverity::CriticalError have been deprecated. It's recommended to use checkf instead.

When FMessageLog goes out of scope or is destroyed explicitly it will flush its messages to the log, which in turn means the log may immediately use the messages. In a few places a reference to the message was kept that outlived the lifetime of the owning FMessageLog in order to add arguments later on. The found cases have been updated to make sure FMessageLog doesn't outlive the addition of the arguments so the arguments are correctly passed to the log.

#jira: UE-155605
#rb brooke.hubert francis.hurteau jerome.delattre
#preflight 62cc4fca9922f7e5129e4e0a

[CL 21042765 by ronald koppers in ue5-main branch]
2022-07-11 12:58:26 -04:00
Helge Mathee
8671edf67f RigVM: Support upgrading from struct to dispatch
#rb na
#jira na
#preflight https://horde.devtools.epicgames.com/job/62c802d1e060ecd065af7a49

[CL 21004729 by Helge Mathee in ue5-main branch]
2022-07-08 06:19:10 -04:00
Helge Mathee
8b0318e6bc RigVM: Dispatch Factory Support
* Moved TypeIndex from int32 to typedef for easier debugging
* Implemented Dispatch Factory
* Factories stored under registry
* FindFunction to invoke dispatch
* Runtime Type checking on the memory handle
* Implemented dispatch rigvm node
* Unit testing for numeric add test both for low level + controller layer

#rb sara.schvartzman
#jira UE-157794
#preflight https://horde.devtools.epicgames.com/job/62c4541b2f31b87c6c89360a

[CL 20942948 by Helge Mathee in ue5-main branch]
2022-07-05 11:39:15 -04:00