Commit Graph

29 Commits

Author SHA1 Message Date
rob gay
2660985605 [MetaSounds] Automated test & fix-up for getting class, node, access type, and ctor state of node inputs/outputs
#rb helen.yang
#rnx
#jira UE-194159

[CL 27772157 by rob gay in ue5-main branch]
2023-09-11 17:33:43 -04:00
helen yang
939f35db64 Various minor MetaSound Builder BP function fixups
- Default MajorVersion to 1 for AddNodeByClassName w/ better log
- Set some lesser used pins to AdvancedDisplay
- Clarify Node Handle display name

#rb maxwell.hayes
#jira UE-192617
#jira UE-192628

[CL 27559967 by helen yang in ue5-main branch]
2023-09-01 13:19:23 -04:00
Rob Gay
947c8ae10a Fix comment with unacceptable word
#rb trivial
#jira
#rnx

[CL 26974838 by Rob Gay in ue5-main branch]
2023-08-09 17:40:47 -04:00
rob gay
61cb3544cf - Fix for auditioning the same sound multiple times not respecting live updates on additional calls
- Upgrade Live Node Update automation tests to LiveUpdateMultipleMetaSoundSources for more comprehensive coverage
#rb helen.yang
#jira UE-192099
#rnx
#lockdown julien.marchand

[CL 26971688 by rob gay in ue5-main branch]
2023-08-09 16:45:21 -04:00
rob gay
3568cc0034 - Remove --> RemoveSwap delegates to allow for handlers to not duplicate forwarded messages where applicable
- Refactor remove node handler for transactor to not do swap piecemeal, which was resulting in dropped connections
- Add test for adding/removing nodes while auditioning (excercises add/remove edges by extension)
#rb phil.popp
#rnx
#jira UE-191865

[CL 26890183 by rob gay in ue5-main branch]
2023-08-07 13:38:36 -04:00
rob gay
48e0c4350d - Make Connect... MetaSoundBuilderSubsystem API calls replace edges as needed to parallel editor behavior more
- Update MetaSoundFrontendDocumentBuilder AddEdge... API calls to support both replacement and ignoring invalid requests where applicable
#rb phil.popp
#jira UE-190989

[CL 26661505 by rob gay in ue5-main branch]
2023-07-27 19:43:47 -04:00
rob gay
6f37b5d549 Conform test component initialization in MetaSound Engine Tests & fix false negative error in case where component is built with invalid initial state of built sound.
#rb trivial
#jira UE-190758
#rnx

[CL 26578447 by rob gay in ue5-main branch]
2023-07-25 12:40:57 -04:00
Rob Gay
267e801aa9 Fix for nametable/MetaSound Search Engine entry leaks due to new class name being generated on every builder build/audition call associated with a given target object
#rb todo
#jira UE-190590
#rnx

[CL 26471782 by Rob Gay in ue5-main branch]
2023-07-19 17:25:21 -04:00
Rob Gay
3b5f9c1e39 Add missing forward of early return value causing false negative when attempting to add MetaSound Interface via Builder API
#rb trivial
#jira UE-190478
#fyi sondra.moyls

[CL 26443241 by Rob Gay in ue5-main branch]
2023-07-18 15:24:34 -04:00
rob gay
4858ab4ec4 Fix ConnectNode<In/Out>sToMatchingGraphInterface<In/Out>puts
- Add tests for connecting & disconnecting nodes that match graph interfaces
- Rename test accordingly
#rnx
#jira UE-186188
#rb helen.yang

[CL 26242483 by rob gay in ue5-main branch]
2023-06-26 15:42:30 -04:00
rob gay
586618a007 - Added test for binding interfaces & fixed following fallout
Major:
- Added missing input MetaSound audio interfaces
- Fixed interface bindings not working with referenced transient, non-asset MetaSounds

Minor:
- Fix builder name not being propagated to transient builders
- Fix not defaulting to success enum when creating patch builder
- Generalized pool of named/registered builders on Builder Subsystem instead of having them per type (to support future types without having to update the subystem for each additional future type.)
#rb helen.yang

[CL 26189673 by rob gay in ue5-main branch]
2023-06-22 14:51:42 -04:00
rob gay
19c88744d9 - Fix-up MetaSound dynamic builder engine tests
- Add missing move of transactor to generator init params

#rb Phil.Popp
#jira UE-181889
#rnx

[CL 26128742 by rob gay in ue5-main branch]
2023-06-20 14:03:55 -04:00
Rob Gay
df490de7a8 Initial work to pipe builder updates to dynamic graph
- Add delegates to respond to builder changes to document
- Add delegate handlers to source builder to forward requests to audition sound if live update enabled
- Misc piping for live updating
#jira UE-186952
#ok forgithub public
#rb phil.popp

[CL 26072389 by Rob Gay in ue5-main branch]
2023-06-16 17:48:20 -04:00
rob gay
aeb25bb49d - Add Runtime MetaSound Builder support
- Add MetaSound Patch Interface support
- Add MetaSound Interface Bindings
#rb phil.popp
#preflight 640783bd5515f4f57b4b1268
[FYI] Sondra.Moyls
[FYI] Dan.Reynolds

[CL 24548617 by rob gay in ue5-main branch]
2023-03-07 17:01:52 -05:00
christopher waters
e671a70412 Adding includes for upcoming dependency cleanup.
#preflight 63e6a580aa024864c3ec1c15

[CL 24137082 by christopher waters in ue5-main branch]
2023-02-11 12:39:56 -05:00
Rob Gay
25826b9069 Summer Cleaning
- Rename MetasoundArchetype Source file to MetasoundFrontendInterface
- Move MetaSound interface files to subdirectory.
- Break out document versioning transforms to own impl/header
#rb todo
#rnx
#jira none
#preflight 62fed263200ff87e07d77340

[CL 21458865 by Rob Gay in ue5-main branch]
2022-08-19 12:14:31 -04:00
phil popp
1dede94cf0 Fix for metasound engine test failing
#rb trivial
#jira UE-150418
#rnx
#preflight 6269c8094114e1869ccbe063

[CL 19949438 by phil popp in ue5-main branch]
2022-04-27 19:04:31 -04:00
phil popp
b0380ec246 Metasound Frontend Search Engine Memory Improvements
- Split out search engine into Core functionality and EditorOnly functionality
- Removed some ISearchEngine integration in the INodeController
- Fixed up callsites that were relying on EditorOnly ISearchEngine functionality on non-editor builds.
#jira UE-147632
#rb Aaron.McLeran
#preflight 626709dc0231ca6c0d8d892e

[CL 19908865 by phil popp in ue5-main branch]
2022-04-25 16:59:41 -04:00
UnrealBot
c47e81b2cb Branch snapshot for CL 18531810
[CL 18531810 in ue5-main branch]
2022-01-06 16:44:09 +00:00
UnrealBot
2987349d36 Branch snapshot for CL 18514113
[CL 18514113 in ue5-main branch]
2022-01-05 20:41:17 +00:00
phil popp
df45b5c0f0 Fix for ensure in metasound source engine test
#jira UE-136573
#rb Rob.Gay
#preflight 61d5e3356511bc498e4827b5

#ROBOMERGE-AUTHOR: phil.popp
#ROBOMERGE-SOURCE: CL 18522327 in //UE5/Release-5.0/... via CL 18522409
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18522460 by phil popp in ue5-release-engine-test branch]
2022-01-05 14:05:25 -05:00
aaron mcleran
0ffa11ba73 Adding new interface for one-shots, upgrading old metasounds to use new interface if they hooked up the on-finished trigger.
Great test-case for interfaces and our upgrade code paths.

#rb Rob.Gay
#jira UE-137708
#preflight 61ba7d64753a9d8c87c2a038

#ROBOMERGE-AUTHOR: aaron.mcleran
#ROBOMERGE-SOURCE: CL 18472322 in //UE5/Release-5.0/... via CL 18473370
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18473402 by aaron mcleran in ue5-release-engine-test branch]
2021-12-15 23:11:10 -05:00
rob gay
ac7944ab27 Backout backed out changelist 18369259
-----------------------------------------------------------------
EngineTest fix-ups for interface changes
#rb phil.popp
#rnx
#p4v-cherrypick 18344375

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18413265 via CL 18413387 via CL 18413403 via CL 18434961 via CL 18437305
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v897-18405271)

[CL 18437362 by rob gay in ue5-release-engine-test branch]
2021-12-10 20:37:43 -05:00
aurel cordonnier
12005ebd1e [Backout] - CL18345241
[FYI] rob.gay
Original CL Desc
-----------------------------------------------------------------
EngineTest fix-ups for interface changes
#rb phil.popp
#rnx
#p4v-cherrypick 18344375

#ROBOMERGE-AUTHOR: aurel.cordonnier
#ROBOMERGE-SOURCE: CL 18369259 via CL 18369281 via CL 18369294 via CL 18434232 via CL 18435615
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v897-18405271)

[CL 18436534 by aurel cordonnier in ue5-release-engine-test branch]
2021-12-10 19:13:38 -05:00
rob gay
436896aff2 EngineTest fix-ups for interface changes
#rb phil.popp
#rnx
#jira none

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18344375 in //UE5/Release-5.0/... via CL 18344463
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18344565 by rob gay in ue5-release-engine-test branch]
2021-12-01 16:03:15 -05:00