Commit Graph

171 Commits

Author SHA1 Message Date
cedric caillaud
e103e963e0 Dataflow / Geometry collection : fix crash when geometry collection are empty
- this also allow terminal node to actually properly process empty collection

#jira UE-223273
#rb brice.criswell, michael.forot, gustav.melich

[CL 36289407 by cedric caillaud in 5.5 branch]
2024-09-13 21:28:49 -04:00
cedric caillaud
e03dad4378 Fix assert about CachedDensityFromPhysicsMaterialInGCm3 when saving an empty geometry collection
- make sure the cache data is computed before saving of the asset happens

#rb Jimmy.Andrews
#jira UE-194284

[CL 35718317 by cedric caillaud in ue5-main branch]
2024-08-21 16:22:11 -04:00
shaun kime
3096a5104b Fixed Geometry collection memory reporting for GetResourceSizeEx if editor data is filtered and the cooking data options are removed.
#rb cedric.caillaud

[CL 34955918 by shaun kime in ue5-main branch]
2024-07-20 13:48:34 -04:00
Michael Forot
0a75528473 Save of the dataflow scene description
#rb Brice.Criswell
#jira none

[CL 34495970 by Michael Forot in ue5-main branch]
2024-06-19 08:11:11 -04:00
cedric caillaud
6c7af5818d [Backout] - CL33950711
[FYI] cedric.caillaud
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL33931377
[FYI] cedric.caillaud
Original CL Desc
-----------------------------------------------------------------
Geometry collection asset - move cooking of render data  out of the serialize method
- This is required to support async loading and avoid the resource initialization from calling GameThread  checked methods
- Move cooking to both PreSave and PostLoad
THis simplifies the code as PostLoad and PreSave are not called during transactions

#rb Jeremy.Moore
#jira UE-215088

[CL 33978689 by cedric caillaud in ue5-main branch]
2024-05-29 13:10:12 -04:00
cedric caillaud
fd85c92ee6 [Backout] - CL33931377
[FYI] cedric.caillaud
Original CL Desc
-----------------------------------------------------------------
Geometry collection asset - move cooking of render data  out of the serialize method
- This is required to support async loading and avoid the resource initialization from calling GameThread  checked methods
- Move cooking to both PreSave and PostLoad
THis simplifies the code as PostLoad and PreSave are not called during transactions

#rb Jeremy.Moore
#jira UE-215088

[CL 33951250 by cedric caillaud in ue5-main branch]
2024-05-28 16:12:37 -04:00
cedric caillaud
40afb51b2a Geometry collection asset - move cooking of render data out of the serialize method
- This is required to support async loading and avoid the resource initialization from calling GameThread  checked methods
- Move cooking to both PreSave and PostLoad
THis simplifies the code as PostLoad and PreSave are not called during transactions

#rb Jeremy.Moore
#jira UE-215088

[CL 33931385 by cedric caillaud in ue5-main branch]
2024-05-27 17:17:50 -04:00
cedric caillaud
bd29cafbab Geometry collection - memory optimization
* packed and re-ordered data in structures to minimize padding as much as possible
* reduce simulation parameters data by 80 bytes ( 112 if stripping the deprecated members )
* remove dead code

#rb titouan.deslandes

[CL 33871845 by cedric caillaud in ue5-main branch]
2024-05-23 15:40:38 -04:00
jimmy andrews
636bfbf3fc Remove bone selected material reference from UGeometryCollection, and clean up some references / accesses to it and legacy methods referring to its (now nonexistent) material ID
#rb cedric.caillaud

[CL 33836478 by jimmy andrews in ue5-main branch]
2024-05-22 13:38:07 -04:00
cedric caillaud
9a834f685f Remove unused NaniteIndex attribute when creating minimal collection for nanite
#rb Jimmy.Andrews

[CL 33834558 by cedric caillaud in ue5-main branch]
2024-05-22 12:48:57 -04:00
cedric caillaud
b1294014fd Geometry collection / Dataflow : properly support material instances
[CL 33821138 by cedric caillaud in ue5-main branch]
2024-05-22 00:24:38 -04:00
cedric caillaud
a411fe17b2 Move the creation of default size spceific data in the constructor of the geometry collection object
#rb Brice.Criswell

[CL 33816031 by cedric caillaud in ue5-main branch]
2024-05-21 19:52:06 -04:00
Michael Forot
7afe95f574 3- Multiple dataflow terminal nodes
#rb Brice.Criswell
#jira none

[CL 33762293 by Michael Forot in ue5-main branch]
2024-05-20 04:19:46 -04:00
cedric caillaud
95f4ca7bb6 Fix crash when loading some geometry collection asset missing mass/inertia attributes
- When attributes are missing we regenerate them   ( editor time only , so assets will be fixed next cook )
- in the future we should revise the way we cook those assets

#rb Jimmy.Andrews

[CL 33649235 by cedric caillaud in ue5-main branch]
2024-05-14 22:36:52 -04:00
cedric caillaud
c6f2fc4c7b Geometry Collection : Fix Nanite Index attribute being created with the wrong type (FBox) but being used as an int32
Note : this attribute does not seem to be used anywhere , will likely remove it in future changes

#rb Jimmy.Andrews
#jira UE-214890

[CL 33640820 by cedric caillaud in ue5-main branch]
2024-05-14 19:54:20 -04:00
sarah noonan
a586204e3f Update GeometryCollection memory count to be more accurate in obj lists.
#rb cedric.caillaud

[CL 33604206 by sarah noonan in ue5-main branch]
2024-05-13 10:37:06 -04:00
cedric caillaud
604109c3a3 Geometry collection : when loading geometry collection with older version of the implicits / sharedimplicits attributes, make sure to account for the fact that the collection may contains multiple of those
#rb vincent.robert
#jira UE-213338

[CL 33283210 by cedric caillaud in ue5-main branch]
2024-04-26 19:09:00 -04:00
jimmy andrews
9124ea5c41 Fix failed check on undo of geometry collection changes in fracture mode
#rb cedric.caillaud

[CL 32859852 by jimmy andrews in ue5-main branch]
2024-04-10 12:22:12 -04:00
michael forot
b6168a808d Boolean on the geometry collection to enable the convex optimization
#rb cedric.caillaud

[CL 32445886 by michael forot in ue5-main branch]
2024-03-22 15:20:59 -04:00
cedric caillaud
9c986f33b9 Geometry Collection : Fix potential crash in FillAutoInstanceMeshesInstancesIfNeeded if the index attribute is not fopund but the asset has auto instance meshes assigned
#jira UE-207298

[CL 31788798 by cedric caillaud in ue5-main branch]
2024-02-23 22:27:38 -05:00
shaun kime
a39e29500d Filtering out geometry collection editor data from memory calculations
#rb cedric.caillaud, benn.gallagher

[CL 31696127 by shaun kime in ue5-main branch]
2024-02-21 15:57:23 -05:00
cedric caillaud
81ed0d764e Fix crash in FillAutoInstanceMeshesInstancesIfNeeded if the AutoInstanceMeshIndex is missing while there's auto instanced mnesh assign to the asset
#jira UE-207298

[CL 31604478 by cedric caillaud in ue5-main branch]
2024-02-17 21:38:07 -05:00
arciel rekman
b34e7d240b Rename StripData methods to better reflect their semantics.
- Done in anticipation of adding new StripData flags.

[REVIEW] [at]Josh.Adams
#rb Josh.Adams

[CL 30384206 by arciel rekman in ue5-main branch]
2023-12-18 17:47:34 -05:00
Brice Criswell
76564a4230 Dataflow : GeometryCollection
- Crash when TransformStarts or InstanceCounts are empty.
#rb cedric.caillaud
#jira none

[CL 30363726 by Brice Criswell in ue5-main branch]
2023-12-15 17:46:59 -05:00
matt peters
d96bd0db63 GeometryCollection Indeterminism: Fix crash due to not calling ValidateSizeSpecificDataDefaults when it is saved; the validation done during serialize is needed in some cases.
Crash repro instructions: create a new worldpartition level, add cube, create a level instance from that cube.
#rnx
#rb matt.peters
#rbself Fixing build break

[CL 30293351 by matt peters in ue5-main branch]
2023-12-13 10:30:16 -05:00