Commit Graph

13591 Commits

Author SHA1 Message Date
jordan cristiano
eb7fe6058c Compiled out namedevents csv metadata changes when UE_SERVER=1 for now.
Server csvs are being filtered out by PRS due to auto trace/framepro captures during the match.

#rb richard.smith
[FYI] ben.woodhouse

[CL 31589223 by jordan cristiano in ue5-main branch]
2024-02-16 19:14:02 -05:00
dan thompson
15fd28a21e Reference Chunk Database:
* Optionally output a CSV of changed/new packages.
* Add an additional directory input if containers get separated off during a build process
* Catch optional segment containers and patch up the container id per the id fix in a separate CL.
bunch of different preflights due to CIS issues.
#rb fabian.giesen
#jira UE-172130

[CL 31576665 by dan thompson in ue5-main branch]
2024-02-16 15:10:30 -05:00
eric knapik
b12f5164b8 Add support for + and - when defining config variables on the commandline for array type variables.
[REVIEW] [at]Gary.Yuan [at]Josh.Adams [at]Joshua.Shlemmer

[CL 31572905 by eric knapik in ue5-main branch]
2024-02-16 13:41:40 -05:00
daniele vettorel
7cb6a22e06 Enable some driver denylist tests for Windows only.
[CL 31571963 by daniele vettorel in ue5-main branch]
2024-02-16 13:18:51 -05:00
daniele vettorel
b1f2d7f0be Refactor driver denylist parsing and checking code:
* All existing functionality is preserved.
* Additional functionality: allow to set denylists using a regex on the GPU name in addition of per-RHI.
* Additional functionality: these constraints (RHI name, GPU name) can now also be applied to the SuggestedDriverVersion entries.
* Further constraints can easily be added in the FDriverConfigEntryConstraints class if needed in the future.
* Now suggest the recommended driver OR latest drivers in the pop-up message (unless latest driver is denylisted).
* Remove unused code and modernize legacy code.
* Add bespoke unit tests.

#rb elizabeth.bunner, nicolas.mercier
#tests tested by QA on a variety of multi-vendor scenarios

[CL 31568290 by daniele vettorel in ue5-main branch]
2024-02-16 11:48:30 -05:00
matt peters
65511c6a9b Fix crash when running game with legacy pakfiles (-skipiostore). FPakReadRequestBase and all subclasses of IAsyncReadRequest need a default implementation for the new EnsureCompletion function rather than a fatal error if called.
#rnx
#rb danny.couture

[CL 31567969 by matt peters in ue5-main branch]
2024-02-16 11:40:30 -05:00
halfdan ingvarsson
168fcbee1a Skeletal Mesh: Change storage of morph target normals to be on vertex instances rather than vertices, to match how the base normals are stored. Add a backward compatibility path for skeletal meshes imported from Alembic files that have manually constructed UMorphTargets to support non-standard normals on the morph targets.
#jira UE-204464
#rb benoit.gadreau
#rnx

[CL 31566631 by halfdan ingvarsson in ue5-main branch]
2024-02-16 11:06:04 -05:00
matt peters
f93e5d9568 SavePackage Name Sorting: Sort names case-sensitively to prevent indeterminism.
#rnx
#rb Johan.Torp

[CL 31562582 by matt peters in ue5-main branch]
2024-02-16 08:58:43 -05:00
steve robb
44fee28dea Added optimized single element TArray Remove* overloads which don't take a count.
#rb devin.doucette

[CL 31559360 by steve robb in ue5-main branch]
2024-02-16 05:58:47 -05:00
carl lloyd
b7052a7976 Fixed compile errors on iOS due to missing ir_converter.h which wont be supported until later
#rb trivial
#jira UE-204112

[CL 31557348 by carl lloyd in ue5-main branch]
2024-02-16 03:50:33 -05:00
dan thompson
ef9ccefa8f Updating optional segment iostore containers to have a unique container id instead of reusing their base container's id. This time to verify I removed the FIoContainerId struct _entirely_ from the codebase to make sure I caught all use cases, and kicked the relevant build that failed.
#rb Per.Larsson

[CL 31541486 by dan thompson in ue5-main branch]
2024-02-15 18:04:47 -05:00
andrew ladenberger
454220bf1f Set DetailMode:Epic(3) as the new default. This means that DetailMode:High(2) is now unassigned by the engine, but it can be used by project settings.
Also fixed up some minor things missed from the new detail mode (comments, etc).

#rb jordan.cristiano
[FYI] bryce.lumpkin, Andrew.Davidson, mihnea.balta

[CL 31535952 by andrew ladenberger in ue5-main branch]
2024-02-15 16:27:13 -05:00
carl lloyd
ba27035a00 Added support for Metal Shader Converter with Bindless in MetalRHI
- Available on SM6
 - Disabled with config
 - Includes support for heap allocations on Metal, enabled by default, can be disabled with -nometalheap

#rb Luke.Thatcher, Chris.Waters, Laura.Hermanns
#jira UE-204112

[CL 31531113 by carl lloyd in ue5-main branch]
2024-02-15 14:58:02 -05:00
josh adams
2525c7e723 - Changed ArrayAddUnique to ArrayAdd for file loads that don't use commands
- Fixed an issue with config override filenames on the commandline
#rb Matt.Peters

#changelist validated
#virtualized

[CL 31528217 by josh adams in ue5-main branch]
2024-02-15 14:09:56 -05:00
matt peters
db403a9c0d ConfigAccessTracking: Fix various assignments of ConfigAccessTracking data in the new FConfigBranch architecture.
#rnx
#rb Josh.Adams

[CL 31523083 by matt peters in ue5-main branch]
2024-02-15 11:57:56 -05:00
steve robb
84c811bcfd Added a workaround for a compiler bug in MSVC 17.9:
https://developercommunity.visualstudio.com/t/VS-2022-1790-Preview-10-__builtin_arr/10519788

/predefined C++ types (compiler internal)(420): error C2248: 'FHazardPointerCollection::FHazardRecord::FHazardRecord': cannot access private member declared in class 'FHazardPointerCollection::FHazardRecord'

#rb robert.manuszewski

[CL 31517744 by steve robb in ue5-main branch]
2024-02-15 09:00:32 -05:00
johan berg
02d6443f86 Check for read only channels when enabling channels
Some channels are marked read-only (e.g. memory tracing channels) and cannot be toggled while the application is running. However there was no feedback when users tried to enable those channels using console commands for example or using the public API. With this change a logging channel argument is added to several internal methods in order to output information correctly, to console feedback when needed.

#rb ionut.matasaru
#jira UE-149917

[CL 31515121 by johan berg in ue5-main branch]
2024-02-15 06:12:08 -05:00
pj kack
690f244d58 Restore the Windows dll directory cache optimization that was added in cl 23269675 but has been broken since cl 23574121.
#rb devin.doucette

[CL 31514091 by pj kack in ue5-main branch]
2024-02-15 04:44:36 -05:00
neil henning
af6f770b16 Make weak semantics of shared pointers work in AutoRTFM (and add tests).
[CL 31513038 by neil henning in ue5-main branch]
2024-02-15 03:32:34 -05:00
jamie dale
723cba4a0d Initialize FInternationalization atomically via TLazySingleton static initialization
This required fixing a cycle where FInternationalization::Get() was being called during FInternationalization::Initialize

[FYI] Leon.Huang, Will.Brown
#rnx

[CL 31509710 by jamie dale in ue5-main branch]
2024-02-14 22:17:59 -05:00
jordan cristiano
0b5d4dc060 Fixed csv metadata for NamedEvents not being set if namedevents was enabled after the csv capture starts.
#rb evgenii.babinets
[FYI] ben.woodhouse
#tests Win64 test client csv start/stop with stat namedevents/stop with stat namedevents

[CL 31494710 by jordan cristiano in ue5-main branch]
2024-02-14 16:43:22 -05:00
josh adams
2d6bb3c4f4 - Fixed a config bug where loading into an existing FConfigFile was always returning false
- Changed some post-load fixup to work with existing single files, instead of only Branch files
#jira UE-206843
#rb Matt.Peters

[CL 31487914 by josh adams in ue5-main branch]
2024-02-14 14:39:23 -05:00
matt peters
14a3793919 ConfigBranch: Fix Error: Error deleting file '../../../Engine/Config/ConsoleVariables.ini', which occurred on files added through FConfigCacheIni::Find. Mark them as NoSave.
#rnx
#rb Josh.Adams

[CL 31476998 by matt peters in ue5-main branch]
2024-02-14 11:36:58 -05:00
mark lintott
31341e90c3 Studio Telemetry Update
Enable hitch detection in Studio Telemetry only when the application is in the foreground.
Increased the Hitch detection frequency as this was not the cause of the Telemetry dashboard inefficiency.
Added explicit TaskName Insights Region
[FYI] robert.millar, matt.breindel

[CL 31473622 by mark lintott in ue5-main branch]
2024-02-14 10:28:08 -05:00
josh adams
08e95db7d2 Fixed the warning that caused the original backout
[Backout] - CL31459949
[FYI] bob.tellez
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL31443953
[FYI] Josh.Adams
Original CL Desc
-----------------------------------------------------------------
Phase 1 of the FConfigBranch changes:
Introduced FConfigBranch which maintains logic and data for each individual branch of GConfig (Engine, Game, Input, DeviceProfiles, etc), with static and dynamic layers
Introduced FConfigCommandStream which is how each layer is loaded, and Apply'd to an FConfigFile
Added a new way of making a "diff" of in-memory vs what's loaded, which creates an FConfigCommandStream that can be re-applied (more useful in Phase 2, see below)
Expectation is no visible differences from before this change, as it's mostly internal data structure changes
Phase 2 is where the functional changes will happen, with the dynamic layers being able to be removed at runtime, and the state of GConfig is maintained as expdected
The editor does maintain full state of where config values come from, so the "getini" command in the editor will show a lot more information now
Runtime will not keep any state, so unloading dynamic layers is not supported by default (running with -ConfigReplayMethod=1 or 2 will allow for it, but will use more memory)

#rb david.harvey
#jira UE-201472

[CL 31470013 by josh adams in ue5-main branch]
2024-02-14 08:59:25 -05:00