I've left the Sync code path as seperate to the Sync Time Sliced one, as its atleast 10% faster (but much spikier). Its also good way of easily verifying if the Time Sliced Code is correct.
I've let medium level functions have access to the timeslicer as they are often expensive enough to warrent it and many times we are time slicing within loops of these functions.
Some fucntions don't need timeslicing within them selves and can be timesliced from the outside and used on both code paths. Currently no functions are called from the non time slicing code that return a FTimeSliceWorkResultData type.
I've increaced the time slice regen times a bit to account for the fact we'll be going over the time slice limit less often now.
[at]Maxime.Mercier, [at]Mikko.Mononen, [at]Yoan.StAmant, [at]Aris.Theophanidis
#ROBOMERGE-SOURCE: CL 10303494 via CL 10303495
#ROBOMERGE-BOT: (v593-10286020)
[CL 10303496 by stephen holmes in Main branch]
With Editor multiple NavigationSystems may exist at the same time (i.e. Editor, Client Game, Server Game worlds) so we want to make sure that any given NavigationSystem instance performs a single flush of the global pending queue to register the links associated to their outer World.
[at]guillaume.guay [at]mieszko.zielinski [at]aris.theophanidis
#ROBOMERGE-SOURCE: CL 10057481 via CL 10057734
#ROBOMERGE-BOT: (v566-10053404)
[CL 10057800 by yoan stamant in Main branch]
#ROBOMERGE-OWNER: matt.kuhlenschmidt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
#ROBOMERGE-SOURCE: CL 9870262 via CL 9870265
#ROBOMERGE-BOT: (v548-9842178)
#rb chris.gagnon
[CL 9872761 by Matt Kuhlenschmidt in Main branch]
Changed UNavigationSystemV1::OnBeginTearingDown to call UNavigationSystemV1::CleanUp so that CrowdManager doesn't do unnecessary work when we unregister nav data on EndPlay.
#jira UE-81818
[at]Yoan.StAmant, [at]Mikko.Mononen, [at]Aris.Theophanidis
#rb Yoan.StAmant
#ROBOMERGE-SOURCE: CL 9676135 in //UE4/Release-4.24/...
#ROBOMERGE-BOT: RELEASE (Release-4.24 -> Main) (v536-9675740)
[CL 9676136 by mieszko zielinski in Main branch]
Replicated from CL# 7924370.
#rb none
#ROBOMERGE-OWNER: steve.robb
#ROBOMERGE-AUTHOR: steve.robb
#ROBOMERGE-SOURCE: CL 9279060 via CL 9279063
#ROBOMERGE-BOT: (v443-9013191)
[CL 9279836 by steve robb in Main branch]
[FYI] Ben.Woodhouse
#ROBOMERGE-SOURCE: CL 9045167 via CL 9046686 via CL 9046799
#ROBOMERGE-BOT: (v443-9013191)
[CL 9049646 by stephen holmes in Main branch]
#rb none
[at]Yoan.StAmant, [at]Stephen.Holmes, [at]Mikko.Mononen
#ROBOMERGE-SOURCE: CL 9038081 via CL 9043888 via CL 9044090
#ROBOMERGE-BOT: (v443-9013191)
[CL 9047383 by mieszko zielinski in Main branch]
While modifying NavigationSystemV1 I've extended IsNavigationBuildingLocked with a parameter allowing more precise queries.
#rb Yoan.StAmant, Mikko.Mononen
[at]Yoan.StAmant, [at]Stephen.Holmes, [at]Mikko.Mononen
#ROBOMERGE-SOURCE: CL 8886708 via CL 8886728 via CL 8889423
#ROBOMERGE-BOT: (v427-8887818)
[CL 8889507 by mieszko zielinski in Main branch]
[FYI] Paul.Johnston
#ROBOMERGE-SOURCE: CL 8786492 via CL 8786506 via CL 8792525
#ROBOMERGE-BOT: (v422-8689730)
[CL 8792537 by james brinkerhoff in Main branch]
This approach allowed for easy NavigationSystem's config update with NavSystemConfigOverride's properties. NavSystemConfigOverride can now specify if it wants to fully override the pre-existing nav sys instance or if it just wants to append new information (like supported agents) to the existing navigation system instance. There's also an option to do nothing if there's already a navigation system present.
This CL rolls-back a bunch of temp fixes done in past couple of days.
#rb Yoan.StAmant
Yoan.StAmant
#ROBOMERGE-OWNER: mieszko.zielinski
#ROBOMERGE-AUTHOR: mieszko.zielinski
#ROBOMERGE-SOURCE: CL 8187661 via CL 8193395 via CL 8207613
#ROBOMERGE-BOT: (v401-8057353)
[CL 8207758 by mieszko zielinski in Main branch]
#jira UE-78811
[at]guillaume.guay [at]mieszko.zielinski
#ROBOMERGE-SOURCE: CL 8119051 via CL 8122721
#ROBOMERGE-BOT: (v401-8057353)
[CL 8124722 by yoan stamant in Main branch]
- Added navigation system config 'bGenerateNavDataWhenNoCompatibleNavBound". When set to TRUE (default) it will still generate navigation data if any NavBoundVolume is compatible with its NavDataConfig, if false it gets rid of that navigation data;
- Make sure that when "bSpawnNavDataInNavBoundsLevel" is TRUE, it builds the navigation data in the first level containing a NavBoundVolume that actually supports this navigation data config (not any first one);
- Added virtual method on NavigateSystem "OnNavSystemOverriden" to give a chance to inspect previous NavigationSystem when getting overriden by a nav config override;
- Added some missing NavigationSystem clean up logic.
#tests client/server standalone Creative AI, Phoebe and regular + editor
#cr maxime.mercier
[FYI] mieszko.zielinski, stephen.holmes, yoan.stamant
#ROBOMERGE-OWNER: guillaume.guay
#ROBOMERGE-AUTHOR: guillaume.guay
#ROBOMERGE-SOURCE: CL 7679442 via CL 7679443 via CL 7688466
#ROBOMERGE-BOT: (v383-7686620)
[CL 7688470 by guillaume guay in Main branch]
#rnx
[at]maxime.mercier
#rb guillaume.guay
#ROBOMERGE-SOURCE: CL 7289773 via CL 7306493
#ROBOMERGE-BOT: (v370-7290619)
[CL 7306546 by yoan stamant in Main branch]
Notable changes:
- Added FNavigationOctreeController that wraps up what used to be NavigationSystemV1's navoctree-related logic
- Added FNavigationDirtyAreasController that wraps up what used to be NavigationSystemV1's DirtyAreas-related logic
- Added FNavigationDataHandler that is a helper struct that wraps up what used to be NavigationSystemV1's logic related to operation involving both navoctree and dirty areas
- Deprecated both FNavDataConfig.NavigationDataClass and FNavDataConfig.NavigationDataClassName and replaced them with a single NavDataClass property
- FNavigationOctree is not responsible for hashing element objects and storing their ElementId
- NavOctree elements how know about the octree they belong to (via a member property).
[at]Yoan.StAmant, [at]Maxime.Mercier, [at]Guillaume.Guay
#rb Yoan.StAmant
#ROBOMERGE-OWNER: mieszko.zielinski
#ROBOMERGE-AUTHOR: mieszko.zielinski
#ROBOMERGE-SOURCE: CL 7249089 via CL 7262555
#ROBOMERGE-BOT: (v369-7254125)
[CL 7262559 by mieszko zielinski in Main branch]
FRecastTileGenerator & FRecastNavMeshGenerator
* Better support for transformation of per instance Convex shapes in MarkDynamicArea (replacing PartialTransformConvexHull)
* Added Per Instance modifier support in GrabDebugSnapshot for VisualLogger (both Geomerty export & AreaNavModifier)
* Added Per Instance modifier support in ExportNavigationData (both Geomerty export & AreaNavModifier)
FCompositeNavModifier
* Deprecated PerInstanceTransformDelegate code since it is unused and duplicated functionality handled by FNavigationRelevantData
* Added flag to mark as a PerInstance modifier
Fixed NavigationDataDump when default FBox is used (since GetVolume will be computed from uninitialized values)
#jira UE-71481
#review-6893930 @mieszko.zielinski
#rb mieszko.zielinski
[CL 6912667 by Yoan StAmant in Dev-Framework branch]
