Commit Graph

15210 Commits

Author SHA1 Message Date
zousar shaker
670ff52d9d Build fixes (compile shipping, and cook if zenserver not running) for last submission.
[CL 35465110 by zousar shaker in ue5-main branch]
2024-08-12 16:11:37 -04:00
tyler staples
207723849f [Insights] Fix non-unity compile error due to EColumnSortMode not being defined.
Changed the TableCommands to take the internal sort mode instead so we didn't need to add a slate dependency.

#rnx
#rb jordan.cristiano
[FYI] ionut.matasaru

[CL 35463984 by tyler staples in ue5-main branch]
2024-08-12 15:37:12 -04:00
fabian giesen
fa5782080e Account for RGBA32F Source Data size in texture build memory estimates
When resizing, we don't just end up with the _target_ image in RGBA32F, but also (at least temporarily) the source.

#rb Dan.Thompson

[CL 35463157 by fabian giesen in ue5-main branch]
2024-08-12 15:22:11 -04:00
zousar shaker
5cabc11d45 Introduce an interface (ICookArtifactReader) for reading data back from a package store used at cook time, with implementations to either read artifacts from zen (if not present on the filesystem), or read artifacts from the filesystem alone. Also ensured that the reader is used in the places that currently expect to read data for incremental cook. Specifically:
- CookSettings.txt
- DevelopmentAssetRegistry.bin
- Shader code libraries

#rb Matt.Peters

[CL 35461438 by zousar shaker in ue5-main branch]
2024-08-12 14:45:14 -04:00
tyler staples
32f1f340ee UnrealInsights - Add 'Copy Name To Clipboard' context menu option.
#rb ionut.matasaru

[CL 35461287 by tyler staples in ue5-main branch]
2024-08-12 14:41:41 -04:00
tyler staples
9b7f445004 [Insights] Fix ExportTimingEvents not always finding the timer when providing a specific timer to -timers.
There can be multiple of the same timer with different Ids. Use a mutli-map when building them up and include them all in filter.

#rb ionut.matasaru

[CL 35461185 by tyler staples in ue5-main branch]
2024-08-12 14:39:11 -04:00
zach bethel
c451548ce3 Clean-up of Slate RHI renderer and conversion to RDG.
- Removed legacy render pass management.
 - Merged individual window render passes into single RDG builder.
 - Cleaned up lots of dead code around HDR processing.
 - Moved render batch merging to run asynchronously on the CPU.
 - Ported UMG post buffer system and custom draw element paths to RDG.
 - Replaced expensive scene view creation with much simpler view uniform buffer path.

#rb daren.cheng
#jira UE-211739

[CL 35454938 by zach bethel in ue5-main branch]
2024-08-12 12:00:42 -04:00
carl lloyd
056d57f3e7 Metal RHI Context Refactor
- Removed MetalContext and MetalRenderPass.
- Removed all code to restart renderpasses
- Added support in the RHI for a new UploadContext which allows uploads to execute before the submission of contexts using them.
- Most functionality is now within MetalRHIContext and removed dependancies so that multiple MetalRHIContext's can execute in parallel.
- MetalDeviceContext has been removed and replaced with MetalDevice.
- Removed the previous FrameAllocator and replaced with a temporary heap based allocator.
- Metal no longer uses SubmitCommandsHint and now builds/submits command buffers through RHIFinalizeContext/RHISubmitCommandLists
- Added initial support for MetalRHI parallel encoding, can be tested with -rhiparallel.
- Removed addition temporary allocations when uploading to buffers

#rb Luke.Thatcher
#jira UE-212349

[CL 35450226 by carl lloyd in ue5-main branch]
2024-08-12 08:41:13 -04:00
ross smith
0d3bed091c ISettingsModule : Add OnContainerAdded() delegate
Previously, there was no way to observe the addition of new containers to a settings module.  The current implementation never removes containers ( although they can be empty ) so there is no need for an OnContainerRemoved delegate at this time.

#rb ronald.koppers

[CL 35429449 by ross smith in ue5-main branch]
2024-08-09 13:47:38 -04:00
brad monahan
f7551efc4a [Sequencer] Fix sequencer sidebar focus issue when double clicking color keys
#rb Max.Chen, yohann.dossantos

[CL 35427296 by brad monahan in ue5-main branch]
2024-08-09 12:42:54 -04:00
yoan stamant
68c74deece Fix CIS Issue 540807
#rb yoan.stamant

[CL 35418948 by yoan stamant in ue5-main branch]
2024-08-09 07:38:25 -04:00
andrew phillips
a05a432db0 Gathering dependencies now includes ExternalObjects.
Correction for External(Objects|Actors) path destination path generation.

#rb Francis.Hurteau, kevin.macaulayvacher, Richard.Malo

[CL 35418159 by andrew phillips in ue5-main branch]
2024-08-09 06:02:57 -04:00
yoan stamant
151d10f03b Fix CIS Issue 540807
#rb yoan.stamant

[CL 35408254 by yoan stamant in ue5-main branch]
2024-08-08 17:13:54 -04:00
yoan stamant
def6877068 [Mass] Fix for observers getting notified before the fragments values are set on entities created through 'CreateEntity' and 'BuildEntity'
#rb Maxime.Mercier

[CL 35406205 by yoan stamant in ue5-main branch]
2024-08-08 15:53:23 -04:00
catalin dragoiu
2e8edb2f74 Add trace status information to the Trace Control Window.
Fix trace stats bandwidth calculations by using runtime timestamps.
Get Engine presets from the runtime via Message Bus in Trace Control Window.
Fix crash when UE_TRACE_ENABLED is off.

#rb ionut.matasaru
#jira UE-215072

[CL 35401088 by catalin dragoiu in ue5-main branch]
2024-08-08 13:29:31 -04:00
ionut matasaru
a965841452 [Insights]
- CpuProfilerTraceAnalysis: Improved analysis performance for traces with huge number of timers.
  - CpuProfilerTraceAnalysis: Added "[CpuProfiler] Analysis completed" log message (with analysis stats) when the analysis is completed.
  - CpuProfilerTraceAnalysis: Added warnings when analysis detects timers defined multiple times and for possible incorrect use of FCpuProfilerTrace::OutputEventType().
  - CpuProfilerTraceAnalysis: Clean-up memory when analysis completes.

#rb Catalin.Dragoiu

[CL 35392281 by ionut matasaru in ue5-main branch]
2024-08-08 06:41:50 -04:00
ionut matasaru
bff487ef4d [Insights] TraceServices: Fixed session's main string store to not duplicate strings with same hash. This fixes issue with some of the duplicated CPU timers (CpuProfilerTraceAnalysis).
#rb Catalin.Dragoiu

[CL 35392274 by ionut matasaru in ue5-main branch]
2024-08-08 06:41:45 -04:00
Skylonxe
8ce537cd92 PR #11096: Cooking: Rename bIterativeCookingForFileCookContent DisplayName to match UE5 UI layout
#rb Paul.Chipchase
#jira UE-200491
#rnx

[CL 35392226 by Skylonxe in ue5-main branch]
2024-08-08 06:40:54 -04:00
JayLu2000
e04a0ccdd5 PR #12150: [MetaXR]: Integrate Adreno Offline Shader Compiler into UE
#jira UE-220969
#rnx
#rb Dmitriy.Dyomin, Florin.Pascu

[CL 35369646 by JayLu2000 in ue5-main branch]
2024-08-07 11:07:33 -04:00
jonathan bard
08898836fe Fixed LiveCoding not detecting changes when working from vanilla editor
#rb Tim.Smith

[CL 35366022 by jonathan bard in ue5-main branch]
2024-08-07 08:44:03 -04:00
huw bowles
c81d47b8e9 [ShaderPreprocessor] Parse line directives. Apply line number and filename to parser state so that subsequent errors will have line numbers with offsets applied from line directives.
[ComputeFramework] Treat preprocessor issues as warnings if compile succeeded, otherwise errors, which is the standard rule.
[PCG] Adapt error summary to whatever line information is available in the error (if any).

#rb dan.elksnitis, Jeremy.Moore, Laura.Hermanns, wyatt.marvil
#rnx

[CL 35362997 by huw bowles in ue5-main branch]
2024-08-07 04:05:17 -04:00
dan elksnitis
857e446f3b [shaders] fix preprocessor infinite loop caused by '[at]' being considered part of the identifier character class, but not being handled properly by copy_and_filter_macro (it appears the RADC compiler from which this code originated allowed [at] in identifiers, but our UE SIMD optimizations missed this quirk. since it's not a valid identifier character in HLSL I opted to just remove it from the character class.
#rb Jason.Nadro, Laura.Hermanns
#jira UE-219735

[CL 35353119 by dan elksnitis in ue5-main branch]
2024-08-06 17:12:57 -04:00
jason hoerner
fc1f7e0bf1 Shader Preprocessor: Fix bug where the pointer to the preprocessed text buffer isn't updated when reallocated while appending string printing code. This hadn't been hit before, because we reserve a large (1.25 MB) buffer to begin with, so encountering the bug requires a shader that uses string printing (itself rare), and of an extremely precise length (within a few KB of the reserve size, so there isn't slack to absorb the appended code).
#rnx
#rb dan.elksnitis

[CL 35346815 by jason hoerner in ue5-main branch]
2024-08-06 13:59:01 -04:00
yohann dossantos
67fcf57378 Slate: Display glyph info (Font, size, outline size, glyphindex, fontskew, ...) when hovering a glyph in the Font Atlas Visualizer.
[RN] Slate Font Atlas Visualizer: when hovering a glyph, display info about it (Font, size,...).
#tests Opened the Font atlas viewer and Texture atlas viewer, hovered glyphs and textures, was able to display expected info for all but one (issue in the FontCache system with SDF to investigate). No regression on texture tooltip display. Flushed the cache while actively hovering glyph without stability issue.
#jira UE-220365
#rb daren.cheng

[CL 35345942 by yohann dossantos in ue5-main branch]
2024-08-06 13:27:06 -04:00
laura hermanns
b40bd9d092 [Shaders] Remove unused platform specific identifiers from GLES shader backend.
#rnx
#rb brian.white, Florin.Pascu

[CL 35343031 by laura hermanns in ue5-main branch]
2024-08-06 11:52:26 -04:00