Commit Graph

212 Commits

Author SHA1 Message Date
aditya ravichandran
31830290ab Asset Editors: Deprecate OnClose and RequestClose in favor of similar functions that take in a close reason
Fix a crash in some asset editors when you force deleted an asset with pending changes and hit "cancel" on the save dialog

#jira UE-107248
#preflight 64517c880e33f2d51d6e3adb

[CL 25321878 by aditya ravichandran in ue5-main branch]
2023-05-03 14:45:26 -04:00
Brian Chrisman
f9536c9ab6 Add support for copying wave file metadata chunks to USoundWave payload when converting bit depth of source file.
#rb aaron.mcleran
#jira UE-176226
#preflight 6449dc7cb208f61af8cb5471

[CL 25210613 by Brian Chrisman in ue5-main branch]
2023-04-26 22:43:07 -04:00
Aaron McLeran
70e7c3734f Removing many vestigates of old audio engine code.
#rb Ryan.Mangin
#jira UE-144348
#preflight 6446e9d30206a6e20f49f2e7

[CL 25172786 by Aaron McLeran in ue5-main branch]
2023-04-24 18:22:37 -04:00
Aaron McLeran
b437ef3903 Adding support for AIFF files with the .aiff extension on import
#jira UE-173356
#rb trivial
#preflight none

[CL 25154625 by Aaron McLeran in ue5-main branch]
2023-04-21 17:46:56 -04:00
maxwell hayes
6a8f45d70f Cvar-able soundwave duration import limit
#rb aaron.mcleran
#pf 63ffd8f4c00784bee26493b0

[CL 24508786 by maxwell hayes in ue5-main branch]
2023-03-03 17:35:49 -05:00
jake burga
e6c4d60cc8 Read smpl data when importing USoundWave.
- Audio.h/.cpp Add functionality to read the `smpl` chunk in a `.wav` asset and adds SampleLoop data to `FWaveModInfo`
- SoundWaveFactor.cpp, parse `WaveSampleLoops` from `FWaveModInfo` and add them to the`CuePoints` array instead of creating a new array
- add `bIsLoopRegion` to `FSoundWaveCuePoint` to identify if a cue point is being used as a "Sample Loop"
- add methods to `USoundWave` to get filtered "CuePoints" and "LoopRegions" from cuepoints array
- When converting `USoundWave` to proxy data, split cue points into "Loop Regions" and "Cue Points" array (less of a memory issue to add new arrays to these classes)
- Fail import if the sample loop start and end points are invalid

#rb aaron.mcleran
[REVIEW] [at]buzz.burrowes [at]charlie.huguenard [at]aaron.mcleran
#preflight 63fe579bef1b24bf9421bb9c

[CL 24465016 by jake burga in ue5-main branch]
2023-03-01 12:33:43 -05:00
maxwell hayes
46ec4afc44 Have audio Factories query whether SoundWave and Ambient Sound import is allowed.
#rb Aaron.McLeran
#preflight 63f3e48a977ceed9156a59a8

[CL 24331754 by maxwell hayes in ue5-main branch]
2023-02-20 20:22:34 -05:00
dan parkes
04bee78a35 [UEFN] Hide disallowed sound nodes
#rb charlie.huguenard rob.gay
#preflight 63eb620db91ae11c1c21a8cd

[CL 24322950 by dan parkes in ue5-main branch]
2023-02-20 15:38:40 -05:00
stan hormell
41739477ae [Backout] - CL24227355 - CIS Errors
[FYI] Dan.Parkes
Original CL Desc
-----------------------------------------------------------------
[UEFN] Hide disallowed sound nodes

#rb charlie.huguenard rob.gay
#preflight 63eb620db91ae11c1c21a8cd

[CL 24251450 by stan hormell in ue5-main branch]
2023-02-16 01:44:36 -05:00
dan parkes
3c75059c0c [UEFN] Hide disallowed sound nodes
#rb charlie.huguenard rob.gay
#preflight 63eb620db91ae11c1c21a8cd

[CL 24249296 by dan parkes in ue5-main branch]
2023-02-15 21:02:09 -05:00
nick darnell
7c56e6c4d1 AssetDefinition - Upgrading several skeletal and animation assets to be asset definitions. Had to upgrade a few utilities that were causing the assets to still load.
#jira UE-165574

[CL 23781708 by nick darnell in ue5-main branch]
2023-01-19 17:09:58 -05:00
nick darnell
b81efdcf63 AssetDefinition - Upgrading several sound asset actions.
AssetDefinition - Fixing a regression where we needed to load assets on right click to check a 'can we create a blueprint from this asset' option.
AssetDefinition - Making the dynamic entries for GetAssetActions nameless so that they don't stomp eachother on accident.
AssetDefinition -

#jira UE-165574

[CL 23632575 by nick darnell in ue5-main branch]
2023-01-10 15:49:07 -05:00
jimmy smith
64b5873f56 Deprecate CreateCompressedInfo path and GetRuntimeFormat in favour of IAudioInfoFactoryRegistry
#rb phill.popp
#jira none
#preflight 63bca93f0b7fcef8b093d9b7

[CL 23622468 by jimmy smith in ue5-main branch]
2023-01-09 19:09:51 -05:00
nick darnell
752a16721c AssetDefinition - Upgrading several sound asset actions.
#jira UE-165574

[CL 23602458 by nick darnell in ue5-main branch]
2023-01-06 15:37:15 -05:00
nick darnell
fe9a530ecf AssetDefinition - LevelSequence has been upgraded and no longer loads on right click.
AssetDefinition - Upgraded ReverbEffect.

#jira UE-165574

[CL 23599473 by nick darnell in ue5-main branch]
2023-01-06 12:22:46 -05:00
henrik karlsson
4a5e13525d Fixed non-unity non-pch compile errors
#preflight skipped
#rb none

[CL 22788359 by henrik karlsson in ue5-main branch]
2022-10-26 16:22:34 -04:00
henrik karlsson
b5b86c796c This change is a strategical submit for a coming change that removes lots of includes in headers that are included by many files. This change contains adding of includes in files that previously got those includes transitively from other inclkudes
#preflight 6355d4940313c24974b2107b
#rb none

[CL 22783162 by henrik karlsson in ue5-main branch]
2022-10-26 12:57:32 -04:00
nick darnell
954d29b9f5 Editor - Beginning the process to no longer make loading all assets you right click in the content browser. The first step, is setting up the code to have a deprecation flag DEPRECATE_ASSET_TYPE_ACTIONS_NEEDING_LOADED_OBJECTS, this will make it illegal to implement GetActions on all AssetTypeAction implementations. Checked in disabled, enable it locally to begin trying to implement the recommended method detailed in the IAssetTypeActions header. WIP. One of the things this change does is outlaw (regardless of deprecation) the HasActions() function, this function is no longer used at all, and so we may as well remove its implementation, it also works well as a canary in finding other samples and things that need to be upgraded.
#jira UE-165574
[REVIEW] [at]Rex.Hill, [at]Lauren.Barnes
#preflight 63483c43ad0f7e2f20e44910

[CL 22534452 by nick darnell in ue5-main branch]
2022-10-14 16:59:41 -04:00
alfaroh corneyiii
ad525b20a0 Fix Audio Modulation Parameter Mismatch UI Bug
#jira UE-126644
#preflight 6340aee2437603cb0e4f14d8
#rb rob.gay
#lockdown aurel.cordonnier

[CL 22414481 by alfaroh corneyiii in ue5-main branch]
2022-10-07 21:33:37 -04:00
rob gay
c23e7530ae Swap set property functional iterator to GetElement to for API conformity
#rb ryan.mangin
#rnx
#jira none
#preflight 631fad09f7369c49efdf9fae

[CL 21985205 by rob gay in ue5-main branch]
2022-09-13 12:30:33 -04:00
bryan sefcik
b93a6cf7ed Pass 1 on editor include fixes:
Removed redundant private include paths from build.cs files.
Fixed include paths to be relative to the private or public folders.
Hid or removed includes that reached into other private module folders.
Updated PublicInclude paths when necessary.

#jira
#preflight 631e283bec5b0c765fc0ffdb

[CL 21960084 by bryan sefcik in ue5-main branch]
2022-09-11 18:33:06 -04:00
rob gay
3f94473cc9 ModulationDestinations Upgrade
- Support sets of input modulators
- Support union of modulation heirarchy
#rb alfaroh.corney
#jira UE-163157
#preflight 63191cc3ec45fbf3d708437c

[CL 21892756 by rob gay in ue5-main branch]
2022-09-08 09:18:28 -04:00
bryan sefcik
925161d3e2 Another IWYU pass on Engine/Source/Editor/...
#jira

[CL 21716486 by bryan sefcik in ue5-main branch]
2022-08-30 23:04:40 -04:00
bryan sefcik
0837230669 Ran IWYU again on half of the Engine/Source/Editor/... source files.
#jira

[CL 21716414 by bryan sefcik in ue5-main branch]
2022-08-30 23:03:03 -04:00
bryan sefcik
8cc129f2b6 IWYU Pass 1 - Engine/Source/Editor/...
#jira
#preflight 6306736ac85b7fef22be7751

[CL 21558583 by bryan sefcik in ue5-main branch]
2022-08-24 22:45:13 -04:00