Showing the asset discovery dialog and preventing the plugin creation until the asset discovery is complete.
#rb Rex.Hill
#preflight 645008286538e45f75c38ccb
[CL 25292941 by will brown in ue5-main branch]
[CrashFix] Removed invalid check()
- when I made assets diffable against null I must've missed this. Easy fix.
#jira none
#preflight trivial
#rb dan.oconnor
#lockout julien.marchand
[CL 24186475 by jordan hoffmann in ue5-main branch]
In addition, I refactored AssetViewUtils::SyncPathsFromSourceControl somewhat.
- Added alternative (preferred) way to get affected files/packages using the FSyncPreview operation as opposed to querying the AssetRegistry.
- Added support for hot reloading the world if one of its external packages (actor/object) got synced so those changes are reflected in the viewport.
- Added support for passing in either content paths or absolute paths to sync.
- Deprecated the 'bIsSyncLatestOperation' parameter from SyncPackagesFromSourceControl.
Note that SyncPackagesFromSourceControl now has a single internal caller (FAssetSourceControlContextMenuState::ExecuteSCCSync).
Note that SyncPathsFromSourceControl now has a single internal caller (FSourceControlWindows::SyncLatest).
[REVIEW]
#preflight 63e3a014244dc45a201c918d
[CL 24074948 by wouter burgers in ue5-main branch]
Updated AssetTypeActivationOpenedMethod.h to include the generated.h.
#preflight 63d2beb85354589b5c70adb5
[CL 23871556 by bryan sefcik in ue5-main branch]
AssetDefintiion - Converted more blueprint / Animation blueprint stuff over to be an asset definition.
#jira UE-165574
[CL 23804692 by nick darnell in ue5-main branch]
* Sync Latest no longer listing and reloading all packages when the source control provider provides a sync preview functionality. When a Sync Preview is available, Sync Latest unloads only the files that are going to be overwritten by the sync operation, and then reloads them and the world
* Refactored Revert All operation to improve performance
* Revert All no longer lists and reloads all packages when the source control provider provides a sync preview functionality. Instead it unloads only the files that may be overwritten by the revert operation (i.e. submittable files), and then reloads them and the world
* Replaced RevertAndReloadAllPackages with RevertAndReloadWorld, no longer listing and reloading all packages (see https://p4-swarm.epicgames.net/reviews/23244245/)
This review is a combination of the two archived reviews https://p4-swarm.epicgames.net/reviews/23736137 and https://p4-swarm.epicgames.net/reviews/23736282
#rb wouter.burgers, stuart.hill, brooke.hubert, francis.hurteau
#preflight 63c9c7786a00f3cc8ead6779
[CL 23796067 by marco anastasi in ue5-main branch]
AssetDefinition - Working on the asset definitions for blueprints/class types, iterating on the Merge API. Bringing over more of the blueprint features into its asset definition, unregistered the Blueprint AssetType Actions.
Asset Filters - We now support categories per filter, this enables a single asset definition to correctly specify multiple filters. For example, blueprints actually supply 4 filters, one for blueprints, but also blueprint interfaces, macros and function libraries.
[CL 23791489 by nick darnell in ue5-main branch]
* Adds a new delegate for when AdvancedCopy is complete (since Advanced Copy is async and can't return the results directly)
* Adds a new blueprint callable overload for AdvancedCopy in the AssetTools interface that optionally takes this callback
[REVIEW] [at]matt.peters [at]brooke.hubert
[CL 23781823 by dj schilens in ue5-main branch]
AssetDefinition - Changing how getting the SourceFiles works a bit, wanted it to be easier to just get the real data and not have to wrap it myself, and also to not need to needlessly put it into a container if it's not needed.
#jira UE-165574
[CL 23686064 by nick darnell in ue5-main branch]
The migration also now report in its callback the dependencies that where not exported because of the new filtering of the assets that can be migrated.
Fixed some other issues like a crash and a bad event broadcast.
#preflight 63bc235c763c6c10641898bb
#rb JeanLuc.Corenthin
[CL 23617167 by julien stjean in ue5-main branch]
AssetActionUtility Blueprints - You can now add a further refinement step in addition to a class filter you can specify Content Browser style filter strings and an error message so that people can see the scripted action, but will know why it's not available to them. Like maybe you have a thing that only can run on non virtual texture streaming assets, you could filter on that tag inaddition to the texture class.
#jira UE-165574
[CL 23580250 by nick darnell in ue5-main branch]
Editor - Upgrading the Texture AssetTypeActions to be AssetDefinitions.
#jira UE-169989
#jira UE-165574
[CL 23121796 by nick darnell in ue5-main branch]
Several amounts of effort went into the newer design of UAssetDefinition to make it easier to change over time, more things are structs now for input and output so additional parameters can be added.
AssetDefinition module is an editor module instead of being a developer module.
AssetDefinition does not include a myraid of things it shouldn't such as the blueprint module and UnrealEd.
#jira UE-165574
#preflight 636c0ec4d0174259cca85e37
[CL 23083536 by nick darnell in ue5-main branch]
[FYI] Nick.Darnell
Original CL Desc
-----------------------------------------------------------------
AssetDefinition - This is the seed of a long term replacement of IAssetTypeActions. IAssetTypeActions is woefully inadiquit now. It puts a lot of functionality in one place, which wouldn't be a terrible thing, except for the GetActions, and some of the menu stuff being built into this class. We need to make an effort to not have to load every single asset just to open the context menu you have selected, to-wit, a previous CL made it so that summoning the menu no longer *Had* to load the assets, however several remaining issues remained with the Blueprint Utility Actions, and the fact that we don't "KNOW" if we need to call GetActions for an asset. We could introduce a replacement in the class, but that would just get inherited, causing other issues. So instead the parallel UObject based AssetDefinition now exists. In large part it will probably be very similar to the other one, but several things in it probably need to chnage. For now there is a bridging concept in the form of the AssetDefinitionAssetTypeProxy.
Several amounts of effort went into the newer design of UAssetDefinition to make it easier to change over time, more things are structs now for input and output so additional parameters can be added.
AssetDefinition module is an editor module instead of being a developer module.
AssetDefinition does not include a myraid of things it shouldn't such as the blueprint module and UnrealEd.
#jira UE-165574
#preflight 636c0ec4d0174259cca85e37
[CL 23072024 by bob tellez in ue5-main branch]
Several amounts of effort went into the newer design of UAssetDefinition to make it easier to change over time, more things are structs now for input and output so additional parameters can be added.
AssetDefinition module is an editor module instead of being a developer module.
AssetDefinition does not include a myraid of things it shouldn't such as the blueprint module and UnrealEd.
#jira UE-165574
#preflight 636c0ec4d0174259cca85e37
[REVIEW]
[CL 23072002 by nick darnell in ue5-main branch]
