Commit Graph

298 Commits

Author SHA1 Message Date
charlie huguenard
3ba6439ab6 [Metasound] Check whether analyzer exists before attempting to add it to a generator.
Also, remove ensure when trying to find an analyzer factory, since we can fail gracefully.

#jira UE-185335
#rnx
#rb phil.popp
#preflight 645a6477a73096fab7787284

[CL 25402611 by charlie huguenard in ue5-main branch]
2023-05-10 08:29:22 -04:00
rob gay
dc986cb6b8 - Minor bug w/setting vertex ID instead of node ID when member modify context is updated
- Misc clean-up
#rb trivial
#rnx
#preflight 645943abfd4b8f4e0dc97fbb

[CL 25380538 by rob gay in ue5-main branch]
2023-05-08 19:08:22 -04:00
rob gay
531ba75ad7 - Fix to avoid not adding graph vertices to graph on creation
- Fix to MetaSound doc builder ClassIdToNodeIndices not initializing properly
#rb trivial
#rnx
#preflight 6459346c2d27fa25b3a2bff9

[CL 25375972 by rob gay in ue5-main branch]
2023-05-08 15:47:42 -04:00
phil popp
ca0f1dc0c5 Allow metasound C++ nodes to swap pointers on vertex data binding.
#jira UE-184049
#rb Max.Hayes
#preflight 64552207d77a82d6a77796c8

[CL 25363328 by phil popp in ue5-main branch]
2023-05-05 21:35:49 -04:00
rob gay
5f1dc4979e Refactor interface modification placement algorithm to position newly added nodes using sort order of adjacent graph members
- Clean-up & remove dead code in FModifyRootGraphInterfaces transform
#rb helen.yang
#jira UE-120184
#rnx
#preflight 6453fbf34574b81df482a79a

[CL 25343968 by rob gay in ue5-main branch]
2023-05-04 18:12:21 -04:00
charlie huguenard
a564e71d89 [Metasound] Fix crash when attempting to connect vertices with mismatched access types
#rnx
#preflight 64511f860e33f2d51d50f797

[CL 25321272 by charlie huguenard in ue5-main branch]
2023-05-03 14:17:48 -04:00
charlie huguenard
7b12ccaeae [Metasound] Get history of output changes instead of last value
#preflight 64513fbb4d593c0b42b03cc8
#rb phil.popp

[CL 25320519 by charlie huguenard in ue5-main branch]
2023-05-03 13:43:51 -04:00
helen yang
98d0bb918d Clear object literals when connecting MetaSound nodes to prevent hidden asset references
#jira UE-182177
#rb rob.gay
#preflight 645170876538e45f7565824a

[CL 25308044 by helen yang in ue5-main branch]
2023-05-02 17:00:45 -04:00
phil popp
9dfb3b30ba Adding diagnostcis for metasounds which load before interfaces are registered.
#jira UE-184499
#preflight 644be5919c50ddcc0bb0167f

[CL 25240412 by phil popp in ue5-main branch]
2023-04-28 16:43:19 -04:00
phil popp
a6d73b141a Fix metasound literal node loctext clash
#rb trivial
#preflight skip
#rnx

[CL 24995092 by phil popp in ue5-main branch]
2023-04-11 14:27:17 -04:00
phil popp
b3cb07f19a Reduce template use in metasound input and literal nodes.
#jira UE-179252
#rb Rob.Gay
#preflight 64345b614c3ccbbdf181e885

[CL 24984410 by phil popp in ue5-main branch]
2023-04-10 17:33:53 -04:00
phil popp
28544b44bd Fix data channel management on MetaSounds
#rnx
[FYI] Miles.Flanagan
#preflight 642f1db1b306e98c6328cecc
#rb Rob.Gay

[CL 24959616 by phil popp in ue5-main branch]
2023-04-06 18:47:28 -04:00
Rob Gay
49c739169c Fix class references misguided towards transient MetaSound class instead of MetaSound Builder class causing failures to add/remove interfaces in certain contexts
#rb phil.popp
#jira UE-181360
#preflight 642f15426d46f6b1bfac1f59
#rnx

[CL 24955760 by Rob Gay in ue5-main branch]
2023-04-06 16:32:00 -04:00
Rob Gay
401365d4c3 Fix for OneShot MetaSound interface not being modifiable in editor due to copy pasta of UClass options
#rb trivial
#jira UE-182508
#rnx
#preflight 642e0aa5f376ab43d2022e06

[CL 24939623 by Rob Gay in ue5-main branch]
2023-04-05 20:15:22 -04:00
phil popp
274f01210e Remove transmittable input nodes and move updating parameters to the metasound generator
#jira UE-179992
#rb Rob.Gay
#preflight 642d9f944847065878db1c64

[CL 24937473 by phil popp in ue5-main branch]
2023-04-05 17:38:47 -04:00
rob gay
1de499ef8e More MetaSound Interface registry clean-up
- Move bIsDefault/bCanEdit(renamed bIsModifiable) from InterfaceRegistryEntry to Interface data definition
- Add checks in builder to disallow mutation of interfaces that shouldn't be via editor or document builder (ex. SourceInterface which is default and then never changed)
- Optimize SearchEngine query for finding default interfaces
- Tweak MetaSoundUObjectRegistry to support non MetasoundAssetBase classes and add UMetaSoundBuilderDocument. Update iterator w/optional param to only return asset types (true by default for back compat)
- Move FName class name comparitors to use new TopLevelAssetPath
#rb phil.popp
#jira UE-181360
#rnx
#p4v-preflight-copy 24658328
#preflight 642b10834d26bcd1eb0e566c

[CL 24920763 by rob gay in ue5-main branch]
2023-04-04 19:14:26 -04:00
phil popp
b231f62c22 Fix default values not being retained when sound is virtualized.
#jira UE-181571
#rnx
#rb Rob.Gay
#preflight 642afc938f078cc7032ce840
#lockdown aaron.mcleran

[CL 24899626 by phil popp in ue5-main branch]
2023-04-03 16:20:21 -04:00
rob gay
6e2c09045d - Fix for builder subsystem not able to reuse audition sound properly due to the sound not being unregistered from the MetaSound Frontend Class Registry before mutation and attempt to play/re-register. Default to register when building and don't expose option to BP (referencing unregistered assets can lead to silent failures when attempting playback later)
- Fix for const correctness causing BP functions to not provide execution path even though they're set to BlueprintCallable :(
#rb helen.yang
[FYI] seth.weedin
[FYI] kevin.cavanaugh
#preflight 641c767fa86ae7cbccd64bb9

[CL 24765400 by rob gay in ue5-main branch]
2023-03-23 14:04:36 -04:00
charlie huguenard
4fdfbdf806 [Metasound] Watch outputs on a FMetasoundGenerator
#rb rob.gay, phil.popp
#preflight 6414cabd345ab08524fc9542

[CL 24723801 by charlie huguenard in ue5-main branch]
2023-03-20 17:13:25 -04:00
Steve Robb
c341d7fc22 Added [[nodiscard]] to relevant TUniquePtr functions.
Fixed up misuses.

#rb devin.doucette
#jira none
#preflight 6413707f345ab08524938eec

[CL 24686373 by Steve Robb in ue5-main branch]
2023-03-17 07:06:23 -04:00
rob gay
cff304e9da Interface Registry Tidying
1.) Move Bindings to own registry
2.) Nuke source files & left over cruft relating to archetypes
3.) Move deprecated interface registration next to respective interfaces for clarity
4.) Rename "FMetasoundFrontendInterfaceBindingConnections" to "FMetasoundFrontendInterfaceVertexBindings"
#rb phil.popp
#preflight 640f6852d778f889752a5bd1

[CL 24622079 by rob gay in ue5-main branch]
2023-03-13 17:23:05 -04:00
rob gay
0214d1c465 - Fix crash w/PostInitProperties initialization of MetaSoundDocumentBuilder
- Fix bugs with interfaces not registering with the correct UClass types
- Add missing RemoveByInterfaceBinding MS Builder function
- Builder cache fix for ContainsEdge
#rb trivial
#rnx
#preflight 640a34153c2db40029343bab

[CL 24584406 by rob gay in ue5-main branch]
2023-03-09 17:56:53 -05:00
rob gay
6e5db2b989 Quick fix for automated test build failures by removing object creation from MS Builders on default ctor/copy ctor/copy assignment operators. Have a longer term fix in the works that's a bit safer, but in general builders are transient and should never be copied.
#rb trivial
#jira UE-179513
#rnx
#preflight 640958338832f48a4de03600

[CL 24572248 by rob gay in ue5-main branch]
2023-03-09 01:21:59 -05:00
helen yang
281a6f7fb3 Fix ensure when creating variables on a MetaSound graph that has been converted from preset
#jira UE-179044
#rb rob.gay
#preflight 6406736d3206d45d2039b8ab

[CL 24564460 by helen yang in ue5-main branch]
2023-03-08 14:25:19 -05:00
phil popp
5040a81bee Fix crash in metasound output node
#rnx
#preflight skip
#rb Jimmy.Smith

[CL 24552014 by phil popp in ue5-main branch]
2023-03-07 19:12:11 -05:00