Commit Graph

292 Commits

Author SHA1 Message Date
charlie huguenard
3ba6439ab6 [Metasound] Check whether analyzer exists before attempting to add it to a generator.
Also, remove ensure when trying to find an analyzer factory, since we can fail gracefully.

#jira UE-185335
#rnx
#rb phil.popp
#preflight 645a6477a73096fab7787284

[CL 25402611 by charlie huguenard in ue5-main branch]
2023-05-10 08:29:22 -04:00
maxwell hayes
568aa49a91 [Metasounds] re-adding Reset() function from audio bus writer node.
#jira UE-184800
#rb Phil.Popp
[FYI] Phil.Popp
#preflight 645975e54c3ec54e6e2d0a0a

[CL 25396155 by maxwell hayes in ue5-main branch]
2023-05-09 17:27:12 -04:00
rob gay
e576e8b8d9 Fix for shadowing of function when registering interface introduced in refactor
#rb trivial
#rnx
#preflight 6453fd5e4c3ec54e6eff425f

[CL 25343957 by rob gay in ue5-main branch]
2023-05-04 18:12:02 -04:00
rob gay
b17ee42ed3 Fix for ensure in the MS BP builder subsystem when attempting to add a MetaSound Node Class using a literal BP node value
#jira UE-180954
#rnx
#rb helen.yang
#preflight 64529cf1743c256cd6a98b13

[CL 25327697 by rob gay in ue5-main branch]
2023-05-03 18:06:20 -04:00
charlie huguenard
7b12ccaeae [Metasound] Get history of output changes instead of last value
#preflight 64513fbb4d593c0b42b03cc8
#rb phil.popp

[CL 25320519 by charlie huguenard in ue5-main branch]
2023-05-03 13:43:51 -04:00
charlie huguenard
5239c236a2 [Metasound] Fix mismatch in param transmitter ids
#preflight 645024ea6538e45f75d16b7e
#rb miles.flanagan, phil.popp

[CL 25300567 by charlie huguenard in ue5-main branch]
2023-05-02 09:27:16 -04:00
charlie huguenard
16e205ba71 [Metasound] Pass audio component id to OnGeneratorInstanceCreated instead of the individual voice id
#jira UE-184555, UE-184554
#preflight 644befb1f50260822919bc80

[CL 25234241 by charlie huguenard in ue5-main branch]
2023-04-28 12:28:48 -04:00
phil popp
e8be08d06e [Metasounds] removing Reset() function from0 audio bus writer node to see if it is the cause of automated test crashes.
#jira UE-184201
#rb Phil.Popp
#preflight 6449aa4a6b589f8b369fa4a2
[FYI] Maxwell.Hayes

[CL 25225488 by phil popp in ue5-main branch]
2023-04-27 18:49:33 -04:00
maxwell hayes
b2246c57ee [Metasounds] Adding Reset() function to audio bus reader/writer nodes.
#jira UE-179001
#rb Phil.Popp
#preflight 644317e90171aae0b1de17df

[CL 25156686 by maxwell hayes in ue5-main branch]
2023-04-21 20:49:41 -04:00
maxwell hayes
e5d027e80c [Backout] - CL25139335
[FYI] Dan.Nottingham
Original CL Desc
-----------------------------------------------------------------
[Metasounds] Adding Reset() function to audio bus reader/writer nodes.
#jira UE-179001
#rb Phil.Popp
#preflight 6441b293c023bb1f73cbddb1

[CL 25150905 by maxwell hayes in ue5-main branch]
2023-04-21 14:55:25 -04:00
maxwell hayes
3164bd34d0 [Metasounds] Adding Reset() function to audio bus reader/writer nodes.
#jira UE-179001
#rb Phil.Popp
#preflight 6441b293c023bb1f73cbddb1

[CL 25140541 by maxwell hayes in ue5-main branch]
2023-04-20 19:49:03 -04:00
kirill zorin
a469aafd78 Update callsites to prepare for upcoming TArray/TArrayView<TObjectPtr<...>> restrictions
#rb zousar.shaker
#rb devin.doucette
#rb steve.robb
#rb robert.manuszewski
#rb saam.barati
#preflight 643f4c09a35280ed4f53ccb3

[CL 25100071 by kirill zorin in ue5-main branch]
2023-04-18 22:39:29 -04:00
charlie huguenard
5f5e340d51 [Metasound] Re-register output analyzers if sound is stopped and re-started
#jira UE-183409
#rnx
#rb phil.popp
#preflight 643dc576bf1053846626eb75

[CL 25084655 by charlie huguenard in ue5-main branch]
2023-04-18 08:44:35 -04:00
phil popp
290e0736c6 Add absolute time output to metasound waveplayer node
#preflight 643da68a8901e5ef98f78b28
#9953
#rb Phil.popp
#jira UE-173179

[CL 25076976 by phil popp in ue5-main branch]
2023-04-17 17:40:44 -04:00
Rob Gay
366cf65d70 Speculative fix for parameter list construction issue on certain platforms
#rb trivial
#jira none
#rnx
#preflight 64347e2241783dc3d0894f21

[CL 24984638 by Rob Gay in ue5-main branch]
2023-04-10 17:45:18 -04:00
phil popp
28544b44bd Fix data channel management on MetaSounds
#rnx
[FYI] Miles.Flanagan
#preflight 642f1db1b306e98c6328cecc
#rb Rob.Gay

[CL 24959616 by phil popp in ue5-main branch]
2023-04-06 18:47:28 -04:00
Rob Gay
3c562cf540 Jumped the gun on submit after preflight on last CL, missing fix.
#rb trivial
#jira UE-181360
#rnx
#preflight skip

[CL 24956461 by Rob Gay in ue5-main branch]
2023-04-06 16:51:46 -04:00
Rob Gay
49c739169c Fix class references misguided towards transient MetaSound class instead of MetaSound Builder class causing failures to add/remove interfaces in certain contexts
#rb phil.popp
#jira UE-181360
#preflight 642f15426d46f6b1bfac1f59
#rnx

[CL 24955760 by Rob Gay in ue5-main branch]
2023-04-06 16:32:00 -04:00
charlie huguenard
fb1959d641 [Metasound] Fix races in UMetasoundOutputSubsystem
The generator created/destroyed events get called on the audio thread, so avoid manipulating containers used on the game thread in the event.

#rnx
#rb phil.popp, aaron.mcleran
#preflight 642db4d71d19c0312a39ab12

[CL 24937556 by charlie huguenard in ue5-main branch]
2023-04-05 17:42:36 -04:00
phil popp
274f01210e Remove transmittable input nodes and move updating parameters to the metasound generator
#jira UE-179992
#rb Rob.Gay
#preflight 642d9f944847065878db1c64

[CL 24937473 by phil popp in ue5-main branch]
2023-04-05 17:38:47 -04:00
kevin cavanaugh
45a42b6042 Workaround in the metasound builder for source interfaces not being added automatically
#preflight skip
#rb charlie.huguenard
[FYI] rob.gay

[CL 24936606 by kevin cavanaugh in ue5-main branch]
2023-04-05 17:01:55 -04:00
rob gay
1de499ef8e More MetaSound Interface registry clean-up
- Move bIsDefault/bCanEdit(renamed bIsModifiable) from InterfaceRegistryEntry to Interface data definition
- Add checks in builder to disallow mutation of interfaces that shouldn't be via editor or document builder (ex. SourceInterface which is default and then never changed)
- Optimize SearchEngine query for finding default interfaces
- Tweak MetaSoundUObjectRegistry to support non MetasoundAssetBase classes and add UMetaSoundBuilderDocument. Update iterator w/optional param to only return asset types (true by default for back compat)
- Move FName class name comparitors to use new TopLevelAssetPath
#rb phil.popp
#jira UE-181360
#rnx
#p4v-preflight-copy 24658328
#preflight 642b10834d26bcd1eb0e566c

[CL 24920763 by rob gay in ue5-main branch]
2023-04-04 19:14:26 -04:00
buzz burrowes
e7af0e2bde Add TRACE macros for profiling
[REVIEW] [at]phil.popp
#preflight 642c2cea4d26bcd1eb7aaac3

[CL 24912849 by buzz burrowes in ue5-main branch]
2023-04-04 12:40:45 -04:00
marc audy
e330959f2a Fix bad merge
#rnx

[CL 24906562 by marc audy in ue5-main branch]
2023-04-03 23:32:48 -04:00
buzz burrowes
93831837d9 Namespace the names of the multicast delegate definitions (move them into the class definition) to avoid polluting the global namespace.
[REVIEW] [at]phil.popp [at]charlie.huguenard
#preflight 642b2a92ce01db47acc4bf9b

[CL 24906544 by buzz burrowes in ue5-main branch]
2023-04-03 23:31:26 -04:00