SDL_LoadBMP was returning a RGB888 surface with a width of 975 and a pitch of 2928. Code was assuming pitch == w * bpp.
Fix is to memcpy rows in FLinuxSplashState::RenderStrings() instead of entire bitmap.
#jira FORT-145774
#rb Brandon.Schaefer
[CL 6653700 by Michael Sartain in Dev-Editor branch]
Daimler was asking about time to display splash loading screen.
This should help them.
Limitations:
Only loads .bmp files
Doesn't support any dynamic text (SetSplashText method NYI right now)
Uses straight SDL2 (Not GL, Freetype, or ImageWrapper)
#jira none
#codereview Brandon.Schaefer, Arciel.Rekman
#review-6653686 @Brandon.Schaefer, @Arciel.Rekman
#rb Brandon.Schaefer, Arciel.Rekman
[CL 6653684 by Michael Sartain in Dev-Editor branch]
The bZeroSize fix was causing notification windows to hide forever while in a Slate Throttle mode causing GameViewportClient draw issue
#jira UE-73182
#rb none
#fyi Arciel.Rekman
[CL 6599047 by Brandon Schaefer in Dev-Editor branch]
When we got a FOCUS OUT event we would start spamming upwards of ~2000 USER EVENTS checking if we need to deactivate the application. This was taking upwards of 150ms
Now per event pump we check if we have been focused out for to then we deactivate.
#jira UE-72278
#rb Arciel.Rekman
[CODEREVIEW] Arciel.Rekman, Michael.Sartain
#lockdown cristina.riveron
#ROBOMERGE-SOURCE: CL 5745113 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)
[CL 5745123 by brandon schaefer in Main branch]
When we got a FOCUS OUT event we would start spamming upwards of ~2000 USER EVENTS checking if we need to deactivate the application. This was taking upwards of 150ms
Now per event pump we check if we have been focused out for to then we deactivate.
#jira UE-72278
#rb Arciel.Rekman
#review-5711052 @Arciel.Rekman, @Michael.Sartain
#codereview Arciel.Rekman, Michael.Sartain
[CL 5713364 by Brandon Schaefer in Dev-Editor branch]
- Also provided a way to hint a particular device with -egldevice=X
#jira UE-70131
#rb Brandon.Schaefer
[FYI] Brandon.Schaefer
#ROBOMERGE-SOURCE: CL 5295498 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)
[CL 5308936 by arciel rekman in Main branch]
- Zero-sized display resulted in zero-sized viewport, which caused UWorld::UpdateLevelStreaming() to not be called (see logic in FViewport::Draw()).
#rb Brandon.Schaefer
#jira UE-70496
#ROBOMERGE-SOURCE: CL 5149800 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)
[CL 5207500 by arciel rekman in Main branch]
Revert adding popup windows who are not set to be focused to the revert stack
#jira UE-69661
#rb Rex.Hill
#ROBOMERGE-SOURCE: CL 4938275 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)
[CL 4938279 by brandon schaefer in Main branch]
Make sure if we are a popup, even if we dont take focus we will be taking activation away from the main editor. Put our selfs in the revert list to revert that activation
#jira UE-69175
#rb none
[FYI] Arciel.Rekman
#ROBOMERGE-SOURCE: CL 4883721 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)
[CL 4883722 by brandon schaefer in Main branch]
This change was suppose to be part of CL 4770158
#jira none
#rb none
#lockdown matt.kuhlenschmidt
[CL 4771518 by Brandon Schaefer in Dev-Editor branch]
Also avoid Setting keyboard grabs on windows that are no longer override redirect
#jira UE-64985, UE-64821
#codereview Arciel.Rekman
#review-4765595 @Arciel.Rekman
#rb Arciel.Rekman
#lockdown matt.kuhlenschmidt
[CL 4770158 by Brandon Schaefer in Dev-Editor branch]