Commit Graph

72 Commits

Author SHA1 Message Date
Maxwell Hayes
5afd6b944c Making clear distinction between GetAbsoluteAverageAmplitude and GetAverageAmplitude in buffer vector ops.
#jira nojira
#rb Phil.Popp

[CL 15187887 by Maxwell Hayes in ue5-main branch]
2021-01-25 17:26:35 -04:00
Rob Gay
077044f885 Add missing AUDIOMODULATION_API decorator
#fyi Dan.Reynolds
#jira none
#rb trivial

[CL 15065111 by Rob Gay in ue5-main branch]
2021-01-13 00:48:28 -04:00
Marc Audy
ada7c144fa Merge //UE5/Release-Engine-Staging @14903491 to //UE5/Main
[CL 14906022 by Marc Audy in ue5-main branch]
2020-12-11 14:21:20 -04:00
Marc Audy
4c1bb11c29 Merge UE5/Release-Engine-Staging to UE5/Main @ 14548662
This represents UE4/Main @ 14525125 + cherrypicked fixes
#skipundocheck

[CL 14551026 by Marc Audy in ue5-main branch]
2020-10-22 19:19:16 -04:00
Josh Adams
c98c3dfde8 - Some compile error fixes that in UE5 target that didn't happen in others
[CL 14474317 by Josh Adams in ue5-main branch]
2020-10-12 15:45:47 -04:00
Marc Audy
50a3d7d368 Merge Release-Engine-Staging to Main @ CL# 14467590
This represents UE4/Main @ 14432125 + some cherrypick fixes

[CL 14468207 by Marc Audy in ue5-main branch]
2020-10-09 22:42:26 -04:00
Rob Gay
a2142d8a98 Fix pedantic spelling issue
#fyi aaron.mcleran
#rb trivial
#jira none

[CL 14466503 by Rob Gay in ue5-main branch]
2020-10-09 18:33:16 -04:00
Rob Gay
ce5217877f Edigrate from 4 to 5:
- Clean-up Generator property UX
- Add invert flag to EnvelopeFollower to allow AudioBus to gate source
#rb phil.popp
#jira none

[CL 14460466 by Rob Gay in ue5-main branch]
2020-10-09 11:38:30 -04:00
Rob Gay
ec47dbc7ba Edigrate following from 4 to 5:
Hide Modulation properly when disabled from SoundBase
    - Move canonical modulation destinations on SoundBase to struct and making a simple customized display that looks up whether modulation is enabled
    - Remove dead code/bModulationEnabled property from SoundBase from earlier attempt to use UObject reflection to hide modulation parameters on sound assets
#rb phil.popp
#jira UEAU-598

Fix Modulation Debugger to use new au. commands properly
- Fix bugs around general display of generator debug data
#jira UE-100492
#rb phil.popp

Fix missing array entry manipulators on Modulation Mix Stage property
#rb lauren.barnes

- Clean-up Generator property UX
- Add invert flag to EnvelopeFollower to allow AudioBus to gate source
#rb phil.popp

- Fix missing AudioDeviceId assignment in AudioModulationSystem (bad merge?)
#rb phil.popp

[CL 14447765 by Rob Gay in ue5-main branch]
2020-10-08 12:59:24 -04:00
Rob Gay
c966d3efd8 Edigrate fixes from 4.26: SoundCueTemplate update & Modulation Mix crash fix
#rb none
#jira none

[CL 14372610 by Rob Gay in ue5-main branch]
2020-09-22 23:55:45 -04:00
Rob Gay
942890a5b1 Edigrate from 4.26: Fix missing macro for DebugName in shipped builds
#rb aaron.mcleran
#jira none

[CL 14370899 by Rob Gay in ue5-main branch]
2020-09-22 18:16:56 -04:00
Rob Gay
9ac4b9129b Missing WITH_EDITORONLY_DATA macro
#rb trivial
#jira none

[CL 14367928 by Rob Gay in ue5-main branch]
2020-09-22 14:07:32 -04:00
Rob Gay
ab70d9bacb Rename 'linear' space to 'normalized' now that parameters are actually normalizing and not just clamping (per docs discussion)
#rb aaron.mcleran
#jira none

[CL 14366795 by Rob Gay in ue5-main branch]
2020-09-22 12:56:52 -04:00
Rob Gay
99fae007bf Modulation Envelope Follower Generator: AudioBus implementation MVP
#rb max.hayes
#jira none UEAU-556

[CL 14360294 by Rob Gay in ue5-main branch]
2020-09-21 18:23:17 -04:00
Rob Gay
7e6b685033 Generalize LFO implementation so Modulation supports any type of control-rate generator
#rb max.hayes
#jira UEAU-556

[CL 14356591 by Rob Gay in ue5-main branch]
2020-09-21 11:30:56 -04:00
Rob Gay
cc7d7990e8 Fix modulation parameter assets not being loaded in non-editor builds
#rb ryan.mangin
#jira none

[CL 14329546 by Rob Gay in ue5-main branch]
2020-09-16 14:30:53 -04:00
geoff evans
68300df094 Jira: Opening the Project Settings for Fortnite causes a noticeable hitch in the editor
Remove CreateIfNotFound parameter to FConfigCacheIni::Find.

This was creating thousands of fstat calls peeking for the existence of Saved/Config/WindowsEditor/GameplayTagsEditorState.ini when opening the Project Settings dialog. This we make frequent calls (in a recursive manner) into the config system, but no file or config is created (where false is passed), and we keep statting it thousands of times

Callers that pass false for this fail to land on any config properties because they don't exist to begin with.

Callers that pass true for this still basically get what they want. Since we did not stub the file out upon Find(), there is no disk state difference between Find() and config system shutdown (where dirty config files are saved to disk). So saving is still manual, and there is no implication from
CreateIfNotFound communicated to the FConfigFile about whether it is meant to be saved or not. So by and large this semantic is meaningless except with the existence of the new config file of the config file map (which creates the optimization of skipping the subsequent stats).

SSettingsEditor::ReloadCategories before: 2290ms
SSettingsEditor::ReloadCategories after: 1669ms

Tested with a BuildCookRun of ShooterGame, and running with it in Editor for a few days.

#jira UE-95853

[CL 14258235 by geoff evans in ue5-main branch]
2020-09-03 19:07:58 -04:00
Marc Audy
7379fa99c5 Merging //UE5/Release-Engine-Staging to Main (//UE5/Main) @ 14229157
[CL 14233282 by Marc Audy in ue5-main branch]
2020-09-01 14:07:48 -04:00
Marc Audy
a7c9001a94 Merging //UE5/Release-Engine-Staging to Main (//UE5/Main) @ 14075166
#rb
#rnx

[CL 14075271 by Marc Audy in ue5-main branch]
2020-08-11 01:36:57 -04:00
Marc Audy
11f5b21210 Merging //UE5/Release-Engine-Staging @ 13752110 to Main (//UE5/Main)
#rnx

[CL 13753156 by Marc Audy in ue5-main branch]
2020-06-23 18:40:00 -04:00
Matt Kuhlenschmidt
603a4119c5 Fix HAL/PlatformFileManager.h non-portable casing CIS issues
#rb none

[CL 13214257 by Matt Kuhlenschmidt in ue5-main branch]
2020-05-06 17:58:18 -04:00
rob gay
dc73acfc83 Swap Emplace_GetRef... no ref needed
#rb none
#rnx

#ROBOMERGE-SOURCE: CL 13075320 via CL 13075326 via CL 13075328
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v686-13045012)

[CL 13075331 by rob gay in Main branch]
2020-04-29 18:11:07 -04:00
rob gay
e67e71d024 Fix circular dependency
#jira UE-91899 UE-91896
#rb none
#rnx

#ROBOMERGE-SOURCE: CL 12758606 via CL 12758850 via CL 12758997
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v678-12743200)

[CL 12759070 by rob gay in Main branch]
2020-04-13 13:35:02 -04:00
rob gay
20fe08b42d Generic Parameter Modulation Refactor
- Add classes to allow modulation of effect parameters
- Remove cruft from first attempt at adding generic modulators

Minor-ish:
- Clean-up headers
- Rename AudioModulationImpl --> AudioModulationSystem
- Remove dead generic code

#rb jimmy.smith

#ROBOMERGE-SOURCE: CL 12732445 via CL 12732449 via CL 12732451
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v676-12543919)

[CL 12732457 by rob gay in Main branch]
2020-04-10 16:18:29 -04:00
rob gay
6d19247939 Edigrate CL 11942501:
Fixing FModulatorBusMixChannelProxy not being marked as friend of FAudioModulationImpl in shipped builds
#jira UE-90145
#rnx
#rb none

#ROBOMERGE-SOURCE: CL 11942822 in //UE4/Release-4.25/... via CL 11942916
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v656-11643781)

[CL 11943011 by rob gay in Main branch]
2020-03-05 13:21:58 -05:00