Commit Graph

4630 Commits

Author SHA1 Message Date
josh adams
db22896a03 - Attempt 3 at getting dylib frameworks working with EC splitting up build and stage on different machines
#rb none

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: josh.adams
#ROBOMERGE-SOURCE: CL 5337575 via CL 5338784 via CL 5338785
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5401306 by josh adams in Dev-Networking branch]
2019-03-14 16:59:22 -04:00
ben marsh
37468fe6fb Better handling of window focus when compiling for live code.
* Console window is made visible and brought to the front when a compile is triggered.
* Patched application window is brought to the front once patching is complete.

#rb none
#jira UE-71128

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5337696 in //UE4/Release-4.22/... via CL 5338036
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5401218 by ben marsh in Dev-Networking branch]
2019-03-14 16:57:01 -04:00
ben marsh
efdd999759 LiveCoding: Fix "Show Console" button not making the window visible if the window has been closed.
#rb none
#jira UE-71076

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5337403 in //UE4/Release-4.22/... via CL 5338030
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5401212 by ben marsh in Dev-Networking branch]
2019-03-14 16:56:51 -04:00
ben marsh
d2c920f9f5 UBT: Use compact FileItem objects in source file metadata cache. Improves serialization performance by another 50-60ms.
#rb none
#jira UE-71116

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5337196 in //UE4/Release-4.22/... via CL 5337949
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5400511 by ben marsh in Dev-Networking branch]
2019-03-14 16:37:13 -04:00
ben marsh
8ef7678978 UBT: Serialize compact FileItem objects. Improves serialization performance and significantly reduces size of cpp dependency cache.
#rb none
#jira UE-71116

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5337193 in //UE4/Release-4.22/... via CL 5337948
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5400510 by ben marsh in Dev-Networking branch]
2019-03-14 16:37:11 -04:00
ben marsh
57afc9244c UBT: Store hashes in the action history rather than full command lines. Improves serialization performance by ~50ms.
#rb none
#jira UE-71116

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5337191 in //UE4/Release-4.22/... via CL 5337944
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5400509 by ben marsh in Dev-Networking branch]
2019-03-14 16:37:10 -04:00
ben marsh
1134dc7c87 Improve accuracy of timer for running UBT. Now includes startup time as well as time spent in the build mode.
#rb none
#jira UE-71116

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5319676 in //UE4/Release-4.22/... via CL 5337053
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5376523 by ben marsh in Dev-Networking branch]
2019-03-12 21:24:06 -04:00
ben marsh
8266dc1f19 UBT: Use the cached filesystem attributes to figure out which files are part of the adaptive non-unity working set. Much faster than querying directly because (a) they're cached, and (b) they're enumerated via a directory scan, which fetches the metadata up front.
#rb none
#jira UE-71116
#rnx

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5318685 in //UE4/Release-4.22/... via CL 5336842
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5376473 by ben marsh in Dev-Networking branch]
2019-03-12 21:23:41 -04:00
ben marsh
934c3249bf UBT: Figure out outdated actions in parallel. Saves 0.5s on iterative compile.
#rb none
#jira
#rnx

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5315074 in //UE4/Release-4.22/... via CL 5317566
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5331945 by ben marsh in Dev-Networking branch]
2019-03-06 18:47:23 -05:00
ben marsh
a65006ccfc UBT: Add additional timing info into logs.
#rb none
#rnx
#jira

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5312405 in //UE4/Release-4.22/... via CL 5316167
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5331237 by ben marsh in Dev-Networking branch]
2019-03-06 18:43:05 -05:00
david harvey
f4c06619dc alllow incredibuild to restart processes on local machine.
#rb anthony.bills, ben.marsh
[FYI] luke.thatcher

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: david.harvey
#ROBOMERGE-SOURCE: CL 5313215 via CL 5315973 via CL 5316037
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5331183 by david harvey in Dev-Networking branch]
2019-03-06 18:42:47 -05:00
ben marsh
05e632d6e6 Fix shadow variable warnings in WebRTCProxy.
#rb none
#jira

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5312014 in //UE4/Release-4.22/... via CL 5314696
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5329660 by ben marsh in Dev-Networking branch]
2019-03-06 18:35:15 -05:00
yujiang wang
66dea2be0a Fix mismatched zlib versions between UE4Editor and UnrealLightmass, which might be the reason of decompression failure in FLightmassProcessor::ImportLightMapData2DData().
#jira UE-62797
#rb none

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: yujiang.wang
#ROBOMERGE-SOURCE: CL 5307280 in //UE4/Release-4.22/... via CL 5314640
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5329469 by yujiang wang in Dev-Networking branch]
2019-03-06 18:34:19 -05:00
ben marsh
7c46cc6b4c Integrating live coding feature (aka Live++) into UE4.
Allows fast iteration of C++ changes without restarting the application. To use, select the "Live Coding (Experimental)" mode from the drop down menu next to the editor's compile button, or type "LiveCoding" into the console for a monolithic build. Press Ctrl+Alt+F11 to find changes and compile.

Changes vs standalone Live++ version:

* UBT is used to execute builds. This allows standard UE4 adaptive unity mode, allows us to reuse object files when we do regular builds, supports using any build executor allowed by UBT (XGE, SNDBS, etc..).
* Adding new source files is supported.
* Custom visualizer for FNames is supported via a weakly linked symbol in a static library (Engine/Extras/NatvisHelpers).
* Settings are exposed in the editor's project settings dialog.
* Standalone application has been rewritten as a Slate app ("LiveCodingConsole"). There is an additional option to start the program as hidden, where it will not be visible until Ctrl+Alt+F11 is hit. Similarly, closing the window will hide it instead of closing the application.
* Does not require a standalone licensed version of Live++.

Known issues:

* Does not currently support class layout changes / object reinstancing

#rb none
[FYI] Marc.Audy, Stefan.Boberg, Nick.Penwarden
#jira

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5304722 in //UE4/Release-4.22/... via CL 5309051
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5326306 by ben marsh in Dev-Networking branch]
2019-03-06 18:19:24 -05:00
ben marsh
1f47bb216c Fix settings for enabling shadow variable and undefined identifier warnings not being treated as requiring a unique PCH. Also fix shared PCHs not enabling each by default. The compiler (at least on Windows) does not produce a warning/error on this mismatch, but does not respect the different settings passed via the command line.
#rb none
#jira

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5295902 in //UE4/Release-4.22/... via CL 5308945
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5325986 by ben marsh in Dev-Networking branch]
2019-03-06 18:18:34 -05:00
ben marsh
c07d2ad3f1 Remove overrides forcing undefined identifier and shadow variable warnings off. Separating out from change to force these settings to create a new PCH to prevent the warning setting being ignored.
#rb none
#jira

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5295892 in //UE4/Release-4.22/... via CL 5308944
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5325973 by ben marsh in Dev-Networking branch]
2019-03-06 18:18:31 -05:00
cosmin sulea
aee1fc2885 UE-69786 - Installed Build fails to Build Tools CS - error: Command 'StopDeploymentServer.bat
#jira UE-69786
#rb Jack.Porter

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: cosmin.sulea
#ROBOMERGE-SOURCE: CL 5294388 in //UE4/Release-4.22/... via CL 5308932
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5325772 by cosmin sulea in Dev-Networking branch]
2019-03-06 18:17:28 -05:00
ben marsh
bc9248d76c Fix exception when trying to get path for main module for hot reload.
#rb none
#rnx
#jira

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5290983 in //UE4/Release-4.22/... via CL 5308917
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5325731 by ben marsh in Dev-Networking branch]
2019-03-06 18:17:19 -05:00
clayton langford
6a1e19b577 Added dynamic resolution to HealthSnapshots. Also, fixed a whitespace issue with RHI Thread and added FrameTime to UnrealSnapshotSummary.ToString()
#rnx
[CODEREVIEW] Andrew.Grant

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: clayton.langford
#ROBOMERGE-SOURCE: CL 5304237 via CL 5304280 via CL 5308246 via CL 5308325
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5325436 by clayton langford in Dev-Networking branch]
2019-03-06 18:16:13 -05:00
justin marcus
acd21e74bc Merging //Fortnite/Dev-Kairos to Main (//Fortnite/Main)
CL 5287635

Fix memory mapped bulk data files all being put in chunk0 because they have a wierd compound extension.

review-5287636 [at]Daniel.Lamb

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: justin.marcus
#ROBOMERGE-SOURCE: CL 5296981 via CL 5307598 via CL 5307724
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5324274 by justin marcus in Dev-Networking branch]
2019-03-06 18:11:02 -05:00
marc audy
dce7993ff5 Dynamic Multicast delegates can now specify that their storage be stored in a sparse allocation for delegates that are expected to be bound rarely. The memory usage of an unbound sparse delegate is 1 byte instead of 16 bytes (for the empty array), however, a bound sparse delegate will have access overhead to retrieve the invocation list from the sparse object annotation.
The definition of the delegate type must specify the class and property name of the delegate that will use it and the type cannot be used outside of that context or just on the stack.
UMulticastDelegateProperty is now abstract and has 2 subclasses (UMulticastDelegateInlineProperty and UMulticastDelegateSparseProperty). The SparseProperty SignatureFunction will be a USparseDelegateFunction.
The sparse delegates do not work correctly with the python bindings at this point, but this will be visited soon.
#rb Michael.Noland
#jira

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 5295832 via CL 5306530 via CL 5306657
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5322730 by marc audy in Dev-Networking branch]
2019-03-06 18:04:30 -05:00
josh adams
cd4e36c68b - Changed how framework signing for dylibs works. Remove the framework searching from Xcode into UBT (likely a placeholder spot until we overhaul some things)
- This keeps Mac from failing with SG_Com because now it only signs what has been staged via UBT/UAT
#rb michael.trepka (well, the concept, i had to get this in today, and he is OOO, but he will look at this tomorrow)
[FYI] michael.trepka

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: josh.adams
#ROBOMERGE-SOURCE: CL 5290031 via CL 5294615 via CL 5294617
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5303328 by josh adams in Dev-Networking branch]
2019-03-05 15:37:28 -05:00
sorin gradinaru
9a20cfe804 UE-68313 Advertising Identified (IDFA) code for iOS should be optional in the Engine
#jira UE-68313
#iOS
#4.22
#rb Jack.Porter

Adding Enable Advertising Identified (IDFA) in Settings >> iOS >> Build. Enabled by default
Fom CL5287566[at]Revision-4.22

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: sorin.gradinaru
#ROBOMERGE-SOURCE: CL 5287756 in //UE4/Main/...
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5289584 by sorin gradinaru in Dev-Networking branch]
2019-03-04 16:59:54 -05:00
alistair white
9fdea3be2c Change Show FPS to button since we don't have the current shown state and so can't update the UI appropriately to it's current state.
#jira UE-70807
#rb: Stuart.Hill

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: alistair.white
#ROBOMERGE-SOURCE: CL 5286302 in //UE4/Release-4.22/... via CL 5286303
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5289573 by alistair white in Dev-Networking branch]
2019-03-04 16:59:44 -05:00
ben marsh
74f4ff9cab Workaround for corrupt minidumps on Windows 10 v1709. Bundle a working version of dbghelp.dll with the application, and attempt load it at startup before loading the system version. Disabled for any targets using CrashDebugHelper, which depends on a matching version of dbgeng.dll (which we can't distribute).
#rb none
#jira UE-70207

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5284948 in //UE4/Release-4.22/... via CL 5284959
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5286816 by ben marsh in Dev-Networking branch]
2019-03-04 13:03:15 -05:00