[FYI] Tim.Smith
Original CL Desc
-----------------------------------------------------------------
Fixed verse build phase to happen after new UObjects have been registered in the engine. Wrong delegate was being used causing the build to happen prior to UObject definitions in some instances.
#rb Markus.Breyer
[CL 31992544 by tim smith in ue5-main branch]
[FYI] Tim.Smith
Original CL Desc
-----------------------------------------------------------------
Improve the support for notification that UObjects have been registered. This includes the callback always being registered regardless of the target options.
#rb ben.zeigler
[CL 31917272 by tim smith in ue5-main branch]
#rb Matt.Peters
#jira UE-208080
#rnx
- The bulkdata registry can spawn async jobs that need to load bulkdata payloads from disk (so that we can calculate the hashes) and this loading can be done via IPackageResourceManager. So if these jobs are running after IPackageResourceManager has been shutdown we can run into problems.
- It should be safe to move the call to shutdown the bulkdata registry system before the call to shutdown the package resource manager. The bulkdata registry shutdown code will wait until all pending jobs have been cleaned up, after which it should then be safe for us to shutdown the package resource manager.
[CL 31908903 by paul chipchase in ue5-main branch]
- Only in places where it is trivially proven the call is only made on the render thread, due to an existing check(IsInRenderingThread()) assert somewhere in the function.
- FRHICommandListImmediate::Get() itself contains a check(IsInRenderingThread()), so this enforces correct threading, and removes the need for extra checks at the call sites.
- Remaining uses of FRHICommandListExecutor::GetImmediateCommandList() need investigation. Some may be bugs.
- Also some changes to make use of the passed-in RHICmdList where possible (e.g. render commands that are given the immediate command list, but call the global getter rather than using the argument they were given).
#rb zach.bethel
[CL 31699633 by luke thatcher in ue5-main branch]
- Sort host address by loopback addresses (IPV6 and IPV4) and local host subnet in order to improve the chances of having a successfull connection at the first attempt and avoid possible timeouts
#jira UE-207222
#rb Josie.Yang, Zousar.Shaker
[CL 31652038 by daniele pieroni in ue5-main branch]
Major fix is to ensure use of a consistent GFrameCounter value in animation and rendering with the rest of the frame, by moving increment of this value until after the OnEndFrame delegate, where MRQ rendering occurs. CSV stat generation end frame call is moved after the GFrameCounter increment, to preserve a side effect when the code calls PlatformMemoryHelpers::GetFrameMemoryStats, which caches platform memory by frame, so that continues to happen at a consistent time (will always be the first call for a given GFrameCounter value, which was the case before). Removed support for OverrideFrameCounter value in FSceneViewFamily previously used as a workaround (the value is still in the structure, but no longer set or used).
A further minor fix is necessary, which involves moving logic that sets "PreviousBoneTransformRevisionNumber" to "CurrentBoneTransformRevisionNumber" so it happens in UpdateBoneTransformRevisionNumber instead of CreateRenderState_Concurrent and SendRenderDynamicData_Concurrent. This makes it so additional calls to CreateRenderState_Concurrent in a frame (due to material changes) see the same value for "PreviousBoneTransformRevisionNumber". Animation updates can be called more than once during Tick, so a frame number is added to track when bone transforms were updated, so the previous revision number is only updated once. We also send that frame number to the render state instead of the current GFrameCounter. With these changes, render state exactly mirrors the component state, producing consistent results following re-creation.
#jira UE-206217
#rnx
#rb Josie.Yang
[CL 31545289 by jason hoerner in ue5-main branch]
#jira UE-133736
[RN] Minor, Foundation
#rb Josh.Adams, Zousar.Shaker
#changelist validated
#virtualized
[CL 31224638 by matt peters in ue5-main branch]
* Visualize texture system starts out in an inactive state until a command is issued, avoiding overhead of tracking views and scene textures, saving 1.4% on the render thread.
* Visualization overhead eliminated for views besides the one currently being visualized.
* Support for visualization of textures from scene captures, via "view=N" option (specifying the unique ID of the view), with "view=?" displaying a list of views for reference.
* Improved visualization for cube maps. PIP uses 2:1 aspect for the longitudinal render to match resource viewer display, and pixel perfect option shows tiled flat cube map faces (actual pixels) rather than running a projection.
* Padding for scene or screen pass textures is removed in the visualization -- the padding otherwise shows up as garbage or blank space.
To remove scene texture padding, it's necessary to add a field to RDG textures to provide an option to track the viewport sizes that were rendered for a given texture. If not set, the assumption is the whole texture was rendered. The field is set for FSceneTextures and FScreenPassTexture, covering the vast majority of cases, plus the denoiser was spot fixed -- worst case if any other cases are missed, you still see the padding. You can tell padding was present when visualizing by contrasting the texture size with the viewport size.
Padding was always a potential issue for the visualizer, but is exacerbated by scene captures, as the padded scene textures are set to a size that's a union of the main view and any scene captures. Padding is also exacerbated by dynamic resolution scaling, as the buffers will be padded to the maximum resolution. For example, a cube map rendering at 512x512 will have 93% of the pixel area as padding if the front buffer is at 1440p, or the default dynamic resolution setup will have 70% of the pixels as padding at minimum res.
#rb Jason.Nadro
[CL 31160232 by jason hoerner in ue5-main branch]
This was a regression from 23567776, as previously the platform specific feedback context (eg, FWindowsNativeFeedbackContext) would modify the verbosity that was passed to the underlying GLog/GLogConsole.
This change restores the old behavior at the new code location (FFeedbackContext).
#rb Devin.Doucette
[CL 31106926 by jamie dale in ue5-main branch]
Significant refactor of RHI command list management and submission, and RHI breadcrumbs / RenderGraph (RDG) scopes, to allow for parallel translation of most RHI command lists.
See individual changelists in //UE5/Dev-ParallelRendering for details. A summary of the changes is as follows:
This work's primary goal was to allow as many RHI command lists as possible to be parallel translated, to make more efficient use of many-core systems. To achieve this:
- The submission code paths for the immediate and parallel RHI command lists have been merged into a single function: FRHICommandListExecutor::Submit().
- A "dispatch thread" (which is simply a series of chained task graph tasks) is used to decide which command lists are batched together in a single parallel translate job.
- Individual command lists can disable parallel translate, which forces them to be executed on the RHI thread. This happens automatically if an RHI command list performs an operation that is not thread safe (e.g. buffer lock, or low-level resource transition).
One of the primary blockers for parallel translation was the RHI breadcrumb system, and the way RDG builds scopes. This was also refactored to remove these limitations:
- RDG could only push/pop events on the immediate command list, which resulted in parallel and immediate work being interleaved, breaking any opportunity for parallelism.
- Platform RHI implementations of breadcrumbs (e.g. in D3D12 RHI) was not correct across multiple RHI contexts. Push/pop operations aren't necessarily balanced within any one RHI context given that RDG builds "parallel pass sets" containing arbitrary ranges of renderer passes.
A summary of the new RHI breadcrumb system is as follows:
- A tree of breadcrumb nodes is built by the render thread and RDG. Each node contains the node name, and pointers to the parent and next nodes. When fully built, the nodes form a depth-first linked list which is used for traversing the tree for GPU crash debugging.
- The memory for breadcrumb nodes is provided by ref-counted allocator objects. These allocators are pipelined through the RHI, allowing the platform RHI implementation to extend their lifetime for GPU crash debugging purposes.
- RHIPushEvent / RHIPopEvent have been removed, replaced with RHIBeginBreadcrumbGPU / RHIEndBreadcrumbGPU. Platform RHIs implement these functions to perform GPU immediate writes using the unique ID of each node, for tracking GPU progress.
- Format string arguments are captured by-value to remove the cost of string formatting while building the breadcrumb tree. String formatting only occurs when the actual formatted string is required (e.g. during GPU crash breadcrumb stack traversal, or when calling platform GPU profiling APIs).
RenderGraph scopes have been simplified:
- The separate scope trees / arrays of ops have been combined. There is now a single tree of RDG scopes containing all types.
- Each RDG pass holds a pointer to the scope it was created under.
- BeginCPU / EndCPU is called on each RDG scope as the various RDG threads enter / exit them. This allows us to mark-up each worker thread with the relevant Unreal Insights scopes.
Other changes include:
- Fixes for bugs uncovered when parallel translate was enabled.
- Adjusted platform affinities necessary due to the new layout of thread tasks in the renderer.
- Refactored RHI draw call stats to better fit the new pipeline design.
#rb jeannoe.morissette, zach.bethel
#jira UE-139543
[CL 30973133 by Luke Thatcher in ue5-main branch]
When using bForceUniqueLogNames, we record offsets to an initial Engine TimeStamp which gives us similar functionality to just using WorldTimeStamp in the Log Visualizer (i.e. multiple runs will line-up at time 0).
When not using bForceUniqueLogNames, we only record the offset when the data is cleared in the Log Visualizer. That will allow multiple runs to record properly on a single timeline (rather than having new data overwrite old data).
bForceUniqueLogNames is now the default setting.
#jira UE-203873
#rb ben.hoffman, Mieszko.Zielinski, Yoan.StAmant
#lockdown marc.audy
[CL 30639009 by jodon karlik in ue5-main branch]
SlackReport debug command for TArray slack tracking.
* Requires ENABLE_ARRAY_SLACK_TRACKING define to be enabled at compile time (enabling the tracking all the time would be too significant a performance hit, as it requires a function call per array count change).
* Generates TSV (tab separated value) reports in Shared/Logs/SlackReport, which can be loaded into a spreadsheet program. A filename can be specified to the command, or a default one with an incrementing index will be used.
* Switch -Stack=N controls the number of stack frames used for sorting. Setting a value less than the maximum (9 levels) can coalesce instances of the same allocation from slightly different call stacks. Switch -Verbose=0 enables a more condensed report that only shows the largest unique Num / Max bucket per call stack.
#rb Steve.Robb
[CL 30346075 by jason hoerner in ue5-main branch]
[FYI] jason.hoerner
Original CL Desc
-----------------------------------------------------------------
SlackReport debug command for TArray slack tracking.
* Requires ENABLE_ARRAY_SLACK_TRACKING define to be enabled at compile time (enabling the tracking all the time would be too significant a performance hit, as it requires a function call per array count change).
* Generates TSV (tab separated value) reports in Shared/Logs/SlackReport, which can be loaded into a spreadsheet program. A filename can be specified to the command, or a default one with an incrementing index will be used.
* Switch -Stack=N controls the number of stack frames used for sorting. Setting a value less than the maximum (9 levels) can coalesce instances of the same allocation from slightly different call stacks. Switch -Verbose=0 enables a more condensed report that only shows the largest unique Num / Max bucket per call stack.
#rb Steve.Robb
[CL 30336635 by justin peterson in ue5-main branch]
* Requires ENABLE_ARRAY_SLACK_TRACKING define to be enabled at compile time (enabling the tracking all the time would be too significant a performance hit, as it requires a function call per array count change).
* Generates TSV (tab separated value) reports in Shared/Logs/SlackReport, which can be loaded into a spreadsheet program. A filename can be specified to the command, or a default one with an incrementing index will be used.
* Switch -Stack=N controls the number of stack frames used for sorting. Setting a value less than the maximum (9 levels) can coalesce instances of the same allocation from slightly different call stacks. Switch -Verbose=0 enables a more condensed report that only shows the largest unique Num / Max bucket per call stack.
#rb Steve.Robb
[CL 30332344 by jason hoerner in ue5-main branch]
- Moving IAssetCompilingManager to its own header
- Changing FAsyncCompilationNotification members to TUniquePtr<FAsyncCompilationNotification> to remove dependencies on AsyncCompilationHelpers.h
- Removing includes of AsyncCompilationHelpers.h and AssetCompilingManager.h removes 3s of compile time per file on a 3990x
#rb henrik.karlsson
[CL 30094069 by christopher waters in ue5-main branch]
[FYI] christopher.waters
Original CL Desc
-----------------------------------------------------------------
Dependency Cleanup
- Moving IAssetCompilingManager to its own header
- Changing FAsyncCompilationNotification members to TUniquePtr<FAsyncCompilationNotification> to remove dependencies on AsyncCompilationHelpers.h
- Removing includes of AsyncCompilationHelpers.h and AssetCompilingManager.h removes 3s of compile time per file on a 3990x
#rb henrik.karlsson
[CL 30054260 by alex kahn in ue5-main branch]
- Moving IAssetCompilingManager to its own header
- Changing FAsyncCompilationNotification members to TUniquePtr<FAsyncCompilationNotification> to remove dependencies on AsyncCompilationHelpers.h
- Removing includes of AsyncCompilationHelpers.h and AssetCompilingManager.h removes 3s of compile time per file on a 3990x
#rb henrik.karlsson
[CL 30051281 by christopher waters in ue5-main branch]
