Commit Graph

13685 Commits

Author SHA1 Message Date
sebastien lussier
bc0a39c97d FBoxSphereBounds::Builder - Make sure to retain a tight SphereRadius rather than performing a BoxSphereBounds -> Box -> BoxSphereBounds conversion which is causing the SphereRadius to be computed from the box corners
#rb JeanFrancois.Dube

[CL 32140365 by sebastien lussier in ue5-main branch]
2024-03-08 21:26:17 -05:00
devin doucette
fffc34d127 Updated FCompressedBufferReader to support a RawHash of zero
This situation arises with the Zen project store. This is a temporary fix to avoid unintentional reuse of decompressed data between from different compressed buffers.

#jira UE-207220
#rb daniele.pieroni
#rnx

[CL 32131510 by devin doucette in ue5-main branch]
2024-03-08 16:22:50 -05:00
zousar shaker
13e36926f3 Make Apple file descriptors unconditionally non-inheritable as they are on Unix. This avoids issues with file descriptors accumulating as we respawn the editor when creating or switching projects.
#rb brandon.schaefer
#rb zack.neyland
#jira UE-209046

[CL 32127829 by zousar shaker in ue5-main branch]
2024-03-08 14:26:16 -05:00
marc audy
d3dfbaa963 Fix unreachable code warnings
[CL 32107600 by marc audy in ue5-main branch]
2024-03-07 19:07:55 -05:00
dmytro vovk
e85777603f Refactored FBitTree::GetMemoryRequirements to be a constexpr to allow computing memory requirement in compile time
#rb Derek.Ehrman

[CL 32093517 by dmytro vovk in ue5-main branch]
2024-03-07 13:35:39 -05:00
matt peters
0dd9cc3b00 LLM: Set PLATFORM_HAS_MULTITHREADED_PREMAIN for IOS platforms; the load of executables on IOS does include OS threads that can call new and delete and that run before Main.
#jira UE-209176, UE-208554
#rnx
#rb Jeff.Fisher

[CL 32090382 by matt peters in ue5-main branch]
2024-03-07 12:13:28 -05:00
matt peters
1d5fe6d2ab LLM - Changed bIsDisabled into a multi-state variable that includes the state NotYetKnown. During the NotYetKnown state, the multithreaded synchronization strategy is different, because some values that are normally immutable have not yet been initialized.
#jira UE-208554
#rb Jeff.Fisher
#rnx

[CL 32089115 by matt peters in ue5-main branch]
2024-03-07 11:42:48 -05:00
paul chipchase
5cf5e9aa40 Fix FBuildVersion to be able to load newer versions containing the "BuildUrl" key/pair.
#rb Per.Larsson
#rnx

- The C# code that writes out version info added a new field "BuildUrl" last year but the cpp code was not updated.
- Unfortunatly the cpp loading code is set to fail reading the info if it encounters an unknown field so "BuildUrl" not being supported prevented it from reading the newer info.
- Added logging when unknown fields are encountered so this might be noticed quicker next time.
- Added ::TryReadFromString that allows the version info to be read from a string rather than a .version file. This would allow higher level code to open a .target file, then find the version info json object and pass it to FBuildVersion in a way that it can be read.

[CL 32086960 by paul chipchase in ue5-main branch]
2024-03-07 10:52:37 -05:00
dmytro vovk
23201f9f89 Revert correct TLS Index check in MB2\3 & CSV Profiler to old behavior in an attemt to mitigate rate Linux server crash
[REVIEW] [at]ben.woodhouse

#localization none
#tests locally tested that both MB2 and MB3 allocators work on Win Client builds

[CL 32077072 by dmytro vovk in ue5-main branch]
2024-03-06 21:09:31 -05:00
nicolas mercier
302fe9acfb Temporarily release the lock before calling the OutOfMemory handler, which will allow the crash reporter thread to run.
Mark out-of-memory fatal asserts as OOM for better handling of the reports.

#rb daniele.vettorel, zach.harris
#rnx
#tests frontend using debug commands to generate OOM

[CL 32057591 by nicolas mercier in ue5-main branch]
2024-03-06 12:17:34 -05:00
steve robb
611847fa3b Moved UE_REQUIRES into its own header.
[CL 32053226 by steve robb in ue5-main branch]
2024-03-06 10:18:07 -05:00
josh adams
7c99ad4d71 - Added StagedBuild.ini file to staged builds so runtime code can determine if the build is staged or not
- Using it now in SubmitTool and in ProjectDir() logic
#rb paul.chipchase

[CL 32017558 by josh adams in ue5-main branch]
2024-03-05 08:45:23 -05:00
wouter dek
00a81ee850 Use non-fast conversion for LocalToWorld and InstanceToWorld to fix precision issues seen in plant WPO.
Allow more direct transformation to and from translated worldspace, without absolute worldspace as an intermediate.
#rb Kevin.Ortegren

[CL 32017092 by wouter dek in ue5-main branch]
2024-03-05 08:17:13 -05:00
steve robb
6c35198546 Fixed inconsistency between EmptyString.ParseIntoArray(Array, DelimiterArray, 1, true) and EmptyString.ParseIntoArray(Array, DelimiterArray[0], true).
Added some tests for this, which also covers the case which was fixed in CL# 31993660.

#rb devin.doucette

[CL 32016140 by steve robb in ue5-main branch]
2024-03-05 06:49:13 -05:00
devin doucette
2807197a97 New engine version to serialize FPropertyTag more compactly and with complete property type names
#jira UE-197352
#rb Andrew.Davidson, Phillip.Kavan
#lockdown Marc.Audy

[CL 31999405 by devin doucette in ue5-main branch]
2024-03-04 15:42:11 -05:00
rob krajcarski
dbbabee5c3 Fix for FString::ParseIntoArray when string to parse has a length of 0, but still has backing memory
#rb Tim.Smith

[CL 31994772 by rob krajcarski in ue5-main branch]
2024-03-04 13:39:16 -05:00
daniele pieroni
62c104a093 - Fix a race condition that can happen inside the FPersistentStorageManager ctor where the logging system is asking for a FPersistentStorageManager::Get after testing FPersistentStorageManager::IsReady true
#jira UE-208677
#rb David.Harvey

[CL 31990712 by daniele pieroni in ue5-main branch]
2024-03-04 12:01:43 -05:00
pj kack
4161e66f68 Move all IoStoreWriter code (writing of .utoc/.ucas containers) out from Core into IoStoreUtilities.
Break cyclic dependency on DerivedDataCache module to utilize DDC2 API to cache compressed chunks.
The declarations moved from the public header are considered private and are not really usable outside of the IoStoreUtilities/UnrealPak context.

#rb per.larsson
#rnx
#tests BuildCookRun Lyra with pak/container files

[CL 31986007 by pj kack in ue5-main branch]
2024-03-04 07:47:44 -05:00
jamie dale
58b404b9c3 Move the ENABLE_LOC_TESTING display string backup to a separate map
This is only used when using the leet or keys culture, and makes the size of FDisplayStringEntry consistent between builds with and without ENABLE_LOC_TESTING enabled

[FYI] Leon.Huang
#rnx

[CL 31977382 by jamie dale in ue5-main branch]
2024-03-02 13:21:53 -05:00
jamie dale
f10c63322a FTextKey/FTextId memory crunching
* UE_TEXTKEY_USE_SLAB_ALLOCATOR (default enabled) controls whether the internal strings are allocated in slabs, or as separate allocations
 * UE_TEXTKEY_STORE_EMBEDDED_HASH (default enabled) controls whether FTextKey/FTextId store an embedded hash value, or whether they calculate it on-demand

#rb anton.dunchev
#rnx

[CL 31977211 by jamie dale in ue5-main branch]
2024-03-02 12:12:33 -05:00
anousack kitisa
a826fa885d ISPC: GeometrySceneProxy optimizations
Submitting on behalf of Refik Karic (Intel)

#rb Anousack.Kitisa

[CL 31952100 by anousack kitisa in ue5-main branch]
2024-03-01 14:44:06 -05:00
tim smith
fa0b37588c Improve the support for notification that UObjects have been registered. This includes the callback always being registered regardless of the target options.
#rb ben.zeigler, tim.smith

[CL 31944532 by tim smith in ue5-main branch]
2024-03-01 11:00:06 -05:00
nicolas mercier
f08d4a7041 Publish AnticheatProvider in the abnormal termination context.
Change PlatformName to be stored as TCHAR array like all other properties.

#rb daniele.vettorel, elizabeth.bunner, zach.harris
#tests locally in FrontEnd

[CL 31938694 by nicolas mercier in ue5-main branch]
2024-03-01 04:10:42 -05:00
paul chipchase
f0805a8dda Remove the additional metadata added in CL 28039514 from the IoStoreToc.
#rb Per.Larsson
#jira UE-189912
#rnx

- The metadata was originally added so that we could generate a toc for OnDemand streaming data if needed at runtime, but we no longer have any plans to support this functionality so we can remove it.
- The change still allows .utoc files that contain the additional metadata to be read. Since the data was at the end of the structure we can just ignore it and the code does not need to consider it's existence.
- Strictly speaking there was no need to add a new entry to EIoStoreTocVersion but we have chosen to do so on the off chance that we need to identify .utoc files that were created while this code was active, for what ever reason.

[CL 31938508 by paul chipchase in ue5-main branch]
2024-03-01 03:41:44 -05:00
jamie dale
464d89c8ff Silence errant PVS warning
#rnx

[CL 31930801 by jamie dale in ue5-main branch]
2024-02-29 19:26:25 -05:00