Commit Graph

128 Commits

Author SHA1 Message Date
andrew rodham
71686cb06a Sequencer: Added custom accessors for heavily used cinematic camera properties
#rb Max.Chen

[CL 28185804 by andrew rodham in ue5-main branch]
2023-09-25 09:21:10 -04:00
evgenii babinets
2f5d095581 Fixed CineCameraComponent registering for tick in builds where it won't do anything useful.
[CL 27315978 by evgenii babinets in ue5-main branch]
2023-08-23 15:15:44 -04:00
UnrealBot
08c294ea96 Branch snapshot for CL 27138787
[CL 27138787 in ue5-main branch]
2023-08-16 14:03:58 +00:00
henrik karlsson
5db685f97d [Engine]
* Moved dllexport from type to methods/staticvar in all Engine runtime code. This improves compile times, memory and performance in dll builds

[CL 26082269 by henrik karlsson in ue5-main branch]
2023-06-17 18:13:06 -04:00
JeanMichel Dignard
89eb55cc5f CineCameraComponent: DebugFocusPlaneComponent will now be ignored when computing the component bounds for editor focus purposes. The focus plane can be very far away which makes moving the viewport to the camera itself impossible.
#jira UE-186612
#rb none

[CL 25961557 by JeanMichel Dignard in ue5-main branch]
2023-06-13 16:01:19 -04:00
bryan sefcik
999455981c Removed header that isn't used and has bad #includes.
#preflight 646419d3f033744ae62f5e51

[CL 25501415 by bryan sefcik in ue5-main branch]
2023-05-16 20:33:15 -04:00
Ruslan Idrisov
571c0ee553 Cine Camera Actor: Made Custom Near Clipping plane keyable in sequencer.
#rb Max.Chen
#jira UE-174499
#rnx
#preflight 63cfe611574ab9cae40ea525

[CL 23831003 by Ruslan Idrisov in ue5-main branch]
2023-01-24 10:30:11 -05:00
marc audy
ea78b28a70 Fixed so all headers can be compiled stand alone
#preflight 63b529e5592c1a9d7c665974
#rb none

[CL 23580295 by marc audy in ue5-main branch]
2023-01-04 15:49:53 -05:00
Takashi Kuribayashi
1be1188c3f CameraRig_Rail: Made private methods and properties protected so that the child class has access. Removed orientation on the mount mesh as it is unnecessary
#jira UE-171787
#rb Max.Chen
#preflight 639a3a5b2960b7322096ebc9

[CL 23519057 by Takashi Kuribayashi in ue5-main branch]
2022-12-14 16:30:36 -05:00
bryan sefcik
4b8a83790a Updated to use UE_INLINE_GENERATED_CPP_BY_NAME.
#jira
#preflight 637c388f170bc34a93587526

[CL 23244381 by bryan sefcik in ue5-main branch]
2022-11-22 20:17:33 -05:00
jeanfrancois dube
b3fb9fc123 World Partition: make CineCameraActor non-spatially loaded by default.
#jira UE-169427
#rb richard.malo
#preflight none
#p4v-cherrypick 23017713
#rnx

[CL 23020990 by jeanfrancois dube in ue5-main branch]
2022-11-07 18:18:04 -05:00
benn gallagher
6a275becd3 Fixed performance issues in camera rig rail actor and made spline mesh component skip mesh and physics updates when incoming data hasn't changed from the current state (on behalf of Jaco.VanDyk)
#rb Max.Chen
#jira UE-168361
#preflight 635bf383a27fb703be4bdf90
#lockdown Mitchell.Wilson

[CL 22831530 by benn gallagher in ue5-main branch]
2022-10-28 13:17:02 -04:00
henrik karlsson
b5b86c796c This change is a strategical submit for a coming change that removes lots of includes in headers that are included by many files. This change contains adding of includes in files that previously got those includes transitively from other inclkudes
#preflight 6355d4940313c24974b2107b
#rb none

[CL 22783162 by henrik karlsson in ue5-main branch]
2022-10-26 12:57:32 -04:00
jason walter
9c0feb024a Make the override value blueprint accessible
#jira UE-166093
#rb Ruslan.Idrisov
#preflight 634ec674e746026e48df9eff

[CL 22601729 by jason walter in ue5-main branch]
2022-10-18 11:51:09 -04:00
ruslan idrisov
649944acc8 Cine Camera Actor: Fixed the issue of when viewport dissapears when Custom Near Clipping plane is set to 0.
#rb Eric.Renaudhoude
#jira UE-161741
#rnx
#preflight None

[CL 22323323 by ruslan idrisov in ue5-main branch]
2022-10-03 21:12:26 -04:00
david hibbitts
f89987f3f6 Fix for derived CineCamera data not updating when modifying properties via Blueprints
#preflight 63347879c76bdd0b4387cdcf

[CL 22239288 by david hibbitts in ue5-main branch]
2022-09-28 21:45:51 -04:00
marc audy
311f7464bf Updated ../Engine/Source/Runtime/... to inline gen.cpp files
Before:
3648 unity files
Total CPU Time: 47886.140625 s
Total time in Parallel executor: 498.81 seconds

After:
3548 unity files
Total CPU Time: 46643.828125 s
Total time in Parallel executor: 486.06 seconds

#jira
#preflight

[CL 22173263 by marc audy in ue5-main branch]
2022-09-24 13:57:58 -04:00
david hibbitts
36156cb938 Added functions to get CineCameraSettings presets by name
#jira UE-164254
#preflight 632bb41a10030508062642c7

[CL 22143201 by david hibbitts in ue5-main branch]
2022-09-22 15:38:24 -04:00
bryan sefcik
cb0456c6d4 Cleaned up build.cs files by removing any include paths that were already being added by UBT. This was done to help identify how include paths are being added and to help with future refactoring.
#jira
#preflight 631a5c04967ffc68fbf0dd8f

[CL 21911226 by bryan sefcik in ue5-main branch]
2022-09-08 21:44:02 -04:00
david hibbitts
616f10f9f6 Fixed bug where Sensor Aspect Ratio does not update when setting Filmback Presets in the Cine Camera Settings
[FYI] colin.benoit
#preflight 6317aca7304480f8f8e3d3ab

[CL 21855937 by david hibbitts in ue5-main branch]
2022-09-07 13:35:35 -04:00
david hibbitts
96a07290eb CineCameraComponent now correctly respects the default Crop Settings
[FYI] colin.benoit

[CL 21855889 by david hibbitts in ue5-main branch]
2022-09-07 13:34:34 -04:00
David Hibbitts
5a5296cedd Ensured CineCameraSettings notification is only displayed in Editor
#jira UE-162756
#preflight 6310f130c354a6319ed0a1c5
#rb Vincent.Gauthier

[CL 21744463 by David Hibbitts in ue5-main branch]
2022-09-01 14:11:57 -04:00
David Hibbitts
23b7051f68 Moved cine camera lens and filmback presets from the CineCameraComponent to a new CineCameraSettings class that appears in the project settings. This allows users to view and edit their own presets easily without needing to edit an INI file
#rb matt.hoffman, ludovic.chabant
#preflight 63079ac80968fbaf691e0b23

[CL 21566885 by David Hibbitts in ue5-main branch]
2022-08-25 12:30:57 -04:00
Guillaume Abadie
dd0382b57c Implements anamorphic lens' squeeze factor and post desqueeze aspect ratio crop on the cinecamera
Notes:
* Model used for the squeeze factor is HorizontalFocalLength = LensFocalLength / SqueezeFactor; VerticalFocalLength = LensFocalLength;
* The renderer renders the desqueezed image directly because of not wanting to add support to maintain non squared pixel.
* Squeeze factor is only hooked in to DOF's CoC.
* Squeeze factor currently also affects depth blur which it shouldn't in theory, requires dual CoC shader permutations in DOF algorithm to do that correctly.
* Crop's model fits an aspect ratio directly into the desqueezed full sensor image.
* Crop settings are directly applied to the camera's FOV calculation of the camera to avoid rendering extra pixels.
* Custom crop aspect ratios can be added into the project's DefaultEngine.ini

#rb colin.benoit, rod.bogart, pat.tubach
#fyi colin.benoit, rod.bogart, pat.tubach
#jira none
#preflight 62fcefe51e39eb26a08cede2

[CL 21424608 by Guillaume Abadie in ue5-main branch]
2022-08-17 10:08:42 -04:00
Bryan sefcik
b4a6e947d8 Ran IWYU on Public headers under Engine/Source/Runtime/...
Headers are updated to contain any missing #includes needed to compile and #includes are sorted.  Nothing is removed.

#ushell-cherrypick of 21065896 by bryan.sefcik
#preflight 62d4b1a5a6141b6adfb0c892
#jira

#ROBOMERGE-OWNER: Bryan.sefcik
#ROBOMERGE-AUTHOR: bryan.sefcik
#ROBOMERGE-SOURCE: CL 21150156 via CL 21151754 via CL 21154719
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)
#ROBOMERGE-CONFLICT from-shelf

[CL 21181076 by Bryan sefcik in ue5-main branch]
2022-07-20 11:31:36 -04:00