[FYI] Bryan.Johnson
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL31782478
[FYI] karen.jirak
Original CL Desc
-----------------------------------------------------------------
Place Actors Panel - Usability Improvements
~ Extracted a large chunk out of FToolkitBuilder and put it in abstract class CategoryDrivenContentBuilderBase, which provides a base class for any class which needs a lefthand vertical category picker which loads content in the box next to the picker
~ Implemented CategoryDrivenContentBuilder, which provides a delegate which takes an FName as an argument which provides the name of the category just clicked, and returns the TSharedRef<SWidget> the user wants loaded for the selected category
~ created FPlacementModeCommands which creates a command to load content for any placement commands found
~ Introduced CVar PlaceActors.EnableCategoryChooserView which, when true, loads the new (in progress) place actors tab
~ altered SPlacementModeTools to create and use the CategoryDrivenContentBuilder when PlaceActors.EnableCategoryChooserView is true, else it loads the usual place actors panel
~ updated ToolElementRegistry with a convenience method that generates the widget and immediately converts it to a shared Ref
Note that after a change in the CVar, you will need to close and reopen the place actors panel for it to appear properly.
#jira UE-205201
#rb brooke.hubert, JeanMichel.Dignard
[CL 31846160 by karen jirak in ue5-main branch]
[FYI] karen.jirak
Original CL Desc
-----------------------------------------------------------------
Place Actors Panel - Usability Improvements
~ Extracted a large chunk out of FToolkitBuilder and put it in abstract class CategoryDrivenContentBuilderBase, which provides a base class for any class which needs a lefthand vertical category picker which loads content in the box next to the picker
~ Implemented CategoryDrivenContentBuilder, which provides a delegate which takes an FName as an argument which provides the name of the category just clicked, and returns the TSharedRef<SWidget> the user wants loaded for the selected category
~ created FPlacementModeCommands which creates a command to load content for any placement commands found
~ Introduced CVar PlaceActors.EnableCategoryChooserView which, when true, loads the new (in progress) place actors tab
~ altered SPlacementModeTools to create and use the CategoryDrivenContentBuilder when PlaceActors.EnableCategoryChooserView is true, else it loads the usual place actors panel
~ updated ToolElementRegistry with a convenience method that generates the widget and immediately converts it to a shared Ref
Note that after a change in the CVar, you will need to close and reopen the place actors panel for it to appear properly.
#jira UE-205201
#rb brooke.hubert, JeanMichel.Dignard
[CL 31789618 by bryan johnson in ue5-main branch]
- fix import in CategoryDrivenContentBuilder.h
- move copyright up in the placement commands
#jira UE-205201
#rb justin.peterson
[CL 31784985 by karen jirak in ue5-main branch]
~ Extracted a large chunk out of FToolkitBuilder and put it in abstract class CategoryDrivenContentBuilderBase, which provides a base class for any class which needs a lefthand vertical category picker which loads content in the box next to the picker
~ Implemented CategoryDrivenContentBuilder, which provides a delegate which takes an FName as an argument which provides the name of the category just clicked, and returns the TSharedRef<SWidget> the user wants loaded for the selected category
~ created FPlacementModeCommands which creates a command to load content for any placement commands found
~ Introduced CVar PlaceActors.EnableCategoryChooserView which, when true, loads the new (in progress) place actors tab
~ altered SPlacementModeTools to create and use the CategoryDrivenContentBuilder when PlaceActors.EnableCategoryChooserView is true, else it loads the usual place actors panel
~ updated ToolElementRegistry with a convenience method that generates the widget and immediately converts it to a shared Ref
Note that after a change in the CVar, you will need to close and reopen the place actors panel for it to appear properly.
#jira UE-205201
#rb brooke.hubert, JeanMichel.Dignard
[CL 31782540 by karen jirak in ue5-main branch]
This was due to the actor being spawned at the default transform (within a transaction), and then moved post-spawn (outside of a transaction). This change has the entire spawn and move captured by a single transaction.
#jira
#rb Dave.Belanger, JeanMichel.Dignard
#rnx
[CL 27646336 by jamie dale in ue5-main branch]
#jira UE-151202 - Box Reflection Capture is placed with a different default scale value when placed from the Quick Add Menu
#rb editor-ux
#preflight 62cec775ec5992eb2fecaeaa
[CL 21070597 by lina lam in ue5-main branch]
This change consists of multiple changes:
Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values
AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes
Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names
#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32
#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786
#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)
[CL 20448496 by robert manuszewski in ue5-main branch]
This represents UE4/Main @17774255, Release-5.0 @17791557 and Dev-PerfTest @17789485
[CL 17794212 by aurel cordonnier in ue5-release-engine-test branch]
Move Editor Modes to a Combo Button,
Combine Content and Create into one dropdown,
Reorder items in the Content Browser add and context menu to be more meaningful
#jira UETOOL-3814
#preflight 61434322599fd8000190b8bf
#rb Louise.Rasmussen, brooke.hubert
#ROBOMERGE-AUTHOR: aditya.ravichandran
#ROBOMERGE-SOURCE: CL 17538574 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v870-17433530)
[CL 17538604 by aditya ravichandran in ue5-release-engine-test branch]
#ROBOMERGE-SOURCE: CL 17101213 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v853-17066230)
[CL 17101294 by matt kuhlenschmidt in ue5-release-engine-test branch]