Commit Graph

138 Commits

Author SHA1 Message Date
karen jirak
b31df3472a [Backout] - CL31789615
[FYI] Bryan.Johnson
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL31782478
[FYI] karen.jirak
Original CL Desc
-----------------------------------------------------------------
Place Actors Panel - Usability Improvements

~ Extracted a large chunk out of FToolkitBuilder and put it in abstract class CategoryDrivenContentBuilderBase, which provides a base class for any class which needs a lefthand vertical category picker which loads content in the box next to the picker
~ Implemented CategoryDrivenContentBuilder, which provides a delegate which takes an FName as an argument which provides the name of the category just clicked, and returns the TSharedRef<SWidget> the user wants loaded for the selected category
~ created FPlacementModeCommands which creates a command to load content for any placement commands found
~ Introduced CVar PlaceActors.EnableCategoryChooserView which, when true, loads the new (in progress) place actors tab
~ altered SPlacementModeTools to create and use the CategoryDrivenContentBuilder when PlaceActors.EnableCategoryChooserView is true, else it loads the usual place actors panel
~ updated ToolElementRegistry with a convenience method that generates the widget and immediately converts it to a shared Ref

Note that after a change in the CVar, you will need to close and reopen the place actors panel for it to appear properly.

#jira UE-205201
#rb brooke.hubert, JeanMichel.Dignard

[CL 31846160 by karen jirak in ue5-main branch]
2024-02-27 13:36:17 -05:00
bryan johnson
0a9447536e [Backout] - CL31782478
[FYI] karen.jirak
Original CL Desc
-----------------------------------------------------------------
Place Actors Panel - Usability Improvements

~ Extracted a large chunk out of FToolkitBuilder and put it in abstract class CategoryDrivenContentBuilderBase, which provides a base class for any class which needs a lefthand vertical category picker which loads content in the box next to the picker
~ Implemented CategoryDrivenContentBuilder, which provides a delegate which takes an FName as an argument which provides the name of the category just clicked, and returns the TSharedRef<SWidget> the user wants loaded for the selected category
~ created FPlacementModeCommands which creates a command to load content for any placement commands found
~ Introduced CVar PlaceActors.EnableCategoryChooserView which, when true, loads the new (in progress) place actors tab
~ altered SPlacementModeTools to create and use the CategoryDrivenContentBuilder when PlaceActors.EnableCategoryChooserView is true, else it loads the usual place actors panel
~ updated ToolElementRegistry with a convenience method that generates the widget and immediately converts it to a shared Ref

Note that after a change in the CVar, you will need to close and reopen the place actors panel for it to appear properly.

#jira UE-205201
#rb brooke.hubert, JeanMichel.Dignard

[CL 31789618 by bryan johnson in ue5-main branch]
2024-02-24 01:15:09 -05:00
karen jirak
aa979f8b0c Place Actors Panel - Usability Improvements
- fix import in CategoryDrivenContentBuilder.h
- move copyright up in the placement commands

#jira UE-205201
#rb justin.peterson

[CL 31784985 by karen jirak in ue5-main branch]
2024-02-23 19:16:57 -05:00
karen jirak
cbd7f320e1 Place Actors Panel - Usability Improvements
~ Extracted a large chunk out of FToolkitBuilder and put it in abstract class CategoryDrivenContentBuilderBase, which provides a base class for any class which needs a lefthand vertical category picker which loads content in the box next to the picker
~ Implemented CategoryDrivenContentBuilder, which provides a delegate which takes an FName as an argument which provides the name of the category just clicked, and returns the TSharedRef<SWidget> the user wants loaded for the selected category
~ created FPlacementModeCommands which creates a command to load content for any placement commands found
~ Introduced CVar PlaceActors.EnableCategoryChooserView which, when true, loads the new (in progress) place actors tab
~ altered SPlacementModeTools to create and use the CategoryDrivenContentBuilder when PlaceActors.EnableCategoryChooserView is true, else it loads the usual place actors panel
~ updated ToolElementRegistry with a convenience method that generates the widget and immediately converts it to a shared Ref

Note that after a change in the CVar, you will need to close and reopen the place actors panel for it to appear properly.

#jira UE-205201
#rb brooke.hubert, JeanMichel.Dignard

[CL 31782540 by karen jirak in ue5-main branch]
2024-02-23 18:18:23 -05:00
semion piskarev
f3f45f2115 Editor: Support using non-actor factories for dragging things into the level, support non-actor drag preview objects, and fix some "recently placed" category handling to handle custom placed items.
#rb brooke.hubert, logan.buchy
#jira UE-201096

[CL 30305072 by semion piskarev in ue5-main branch]
2023-12-13 16:33:42 -05:00
jamie dale
987c5fb85b Fixed placing an actor via the create menu failing to capture the initial transform correctly within a transaction diff
This was due to the actor being spawned at the default transform (within a transaction), and then moved post-spawn (outside of a transaction). This change has the entire spawn and move captured by a single transaction.

#jira
#rb Dave.Belanger, JeanMichel.Dignard
#rnx

[CL 27646336 by jamie dale in ue5-main branch]
2023-09-06 15:00:15 -04:00
semion piskarev
29b0d1715d Editor: Make placement mode panel update itself if external code requests a category refresh.
#rb Brooke.Hubert

[CL 26705382 by semion piskarev in ue5-main branch]
2023-07-31 10:11:48 -04:00
sebastien hillaire
b6879a2b60 Rename from LocalHeightFog to LocalFogVolume in code
#rb none
#jira UE-187077

[CL 26545239 by sebastien hillaire in ue5-main branch]
2023-07-24 12:00:44 -04:00
sebastien hillaire
90e9834931 Rename/move file(s) from LocalHeightFog to LocalFogVolume
#rb none
#jira UE-187077

[CL 26543667 by sebastien hillaire in ue5-main branch]
2023-07-24 11:29:58 -04:00
vincent gauthier
f7710150bd Fix to PlacementMode localization. Instead of recreating Placement Items with partial information we keep the manually created Basic shapes in a map so we can fetch them when building the recently used list.
#jira UE-182009
#rb aditya.ravichandran

[CL 25875794 by vincent gauthier in ue5-main branch]
2023-06-08 13:18:50 -04:00
sebastien hillaire
256b3e8ba4 First simple LocalHeightFog volume component support.
Lots of missing bits but that is a good first step for iterations.

#rb none
#preflight https://horde.devtools.epicgames.com/job/645e51146b4bdec267ea31cf

[CL 25472344 by sebastien hillaire in ue5-main branch]
2023-05-15 09:23:13 -04:00
vincent gauthier
dd2e32231b Fix to Placement Mode localization of Display Name to use the asset class name.
#jira UE-177120

[CL 24372023 by vincent gauthier in ue5-main branch]
2023-02-22 18:02:19 -05:00
rex hill
ca6a312971 Fix crash with PlacementModeModule when editor closes
#preflight skip
[FYI] Tyler.Quilen

[CL 23124822 by rex hill in ue5-main branch]
2022-11-14 15:56:07 -05:00
henrik karlsson
b5b86c796c This change is a strategical submit for a coming change that removes lots of includes in headers that are included by many files. This change contains adding of includes in files that previously got those includes transitively from other inclkudes
#preflight 6355d4940313c24974b2107b
#rb none

[CL 22783162 by henrik karlsson in ue5-main branch]
2022-10-26 12:57:32 -04:00
Robert Millar
ed78ac634c FNames containing asset paths are deprecated. FSoftObjectPath or FTopLevelAssetPath should be used instead.
Fixups for editor support classes for actors.

#jira none
#preflight 631a69a9d31788ea3a6d2741

[CL 21905995 by Robert Millar in ue5-main branch]
2022-09-08 18:31:00 -04:00
lina lam
cc7b64e06b When adding a new Box Reflection Capture from the Quick Add Menu, the object is transformed once again to (1, 1, 1) after setting the right scale. The new code restores object to the original scale.
#jira UE-151202 - Box Reflection Capture is placed with a different default scale value when placed from the Quick Add Menu
#rb editor-ux
#preflight 62cec775ec5992eb2fecaeaa

[CL 21070597 by lina lam in ue5-main branch]
2022-07-13 10:06:44 -04:00
Matt Peters
803e794b36 AssetRegistryModule: Add TryGet function that can return null instead of asserting during Engine shutdown.
#jira UE-157056
#rb PJ.Kack
#rnx
#preflight 62b1d7fd827ccccb2cdec5a3

[CL 20758071 by Matt Peters in ue5-main branch]
2022-06-21 11:07:36 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
Matt Peters
7ad238a806 AssetRegistry includes (Engine/Source): change #include "AssetData.h" -> #include "AssetRegistry/AssetData.h", and similar for the other moved AssetRegistry headers.
#rb Zousar.Shaker
#rnx
#preflight 6270509a220f89f0ad573030

[CL 20016982 by Matt Peters in ue5-main branch]
2022-05-02 18:06:48 -04:00
Matt Peters
c1b46b1fed FAssetData: Callsites need to handle AssetData.GetClass() returning null. Added IsInstanceOf(UClass*) for the common operation GetClass() && GetClass->IsChildOf(BaseClass).
#jira UE-146521
#rb Zousar.Shaker
#rnx
#preflight 623874b789625f06129e466b

[CL 19450936 by Matt Peters in ue5-main branch]
2022-03-21 09:00:36 -04:00
aditya ravichandran
d7a6de08dd Place Actors Panel: Fix checkbox styling
#rb Lauren.Barnes
#jira UE-138922
#preflight 62213592bf662715a8cdfa7c

[CL 19254055 by aditya ravichandran in ue5-main branch]
2022-03-03 16:53:20 -05:00
aurel cordonnier
a12d56ff31 Merge from Release-Engine-Staging @ 17791557 to Release-Engine-Test
This represents UE4/Main @17774255, Release-5.0 @17791557 and Dev-PerfTest @17789485

[CL 17794212 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-12 21:21:22 -04:00
aditya ravichandran
9c09a76984 Reskin the Level Editor Main Toolbar,
Move Editor Modes to a Combo Button,
Combine Content and Create into one dropdown,
Reorder items in the Content Browser add and context menu to be more meaningful
#jira UETOOL-3814
#preflight 61434322599fd8000190b8bf
#rb Louise.Rasmussen, brooke.hubert

#ROBOMERGE-AUTHOR: aditya.ravichandran
#ROBOMERGE-SOURCE: CL 17538574 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v870-17433530)

[CL 17538604 by aditya ravichandran in ue5-release-engine-test branch]
2021-09-16 10:15:01 -04:00
matt kuhlenschmidt
e3daec26fc Sort "All Actors" in create menu alphabetically
#ROBOMERGE-SOURCE: CL 17101213 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v853-17066230)

[CL 17101294 by matt kuhlenschmidt in ue5-release-engine-test branch]
2021-08-09 09:29:55 -04:00