Commit Graph

227 Commits

Author SHA1 Message Date
aditya ravichandran
e97a64fff9 SAssetView: Change Content Browser column resize mode to fill so there is no cap on resizing columns
#jira UE-206404
#rb brooke.hubert

[CL 31349473 by aditya ravichandran in ue5-main branch]
2024-02-09 13:59:52 -05:00
ionut matasaru
7f8829bd4c Fixed usage of TRACE_CPUPROFILER_EVENT_SCOPE macros in various engine files.
* TRACE_CPUPROFILER_EVENT_SCOPE(ScopeName) --> to be used with a plain text as scope name (not a string!). If the parameter is a string ("abc" or TEXT("abc")), the quotes (and the TEXT prefix) will be included in the actual timer name.
* TRACE_CPUPROFILER_EVENT_SCOPE_STR("scope name") --> to be used with a static string (const ANSICHAR* or const TCHAR*); ex: when the scope name needs to include a space char
* TRACE_CPUPROFILER_EVENT_SCOPE_TEXT(*MyScopeName) --> to be used with a dynamic string (const ANSICHAR* or const TCHAR*)
See also the comments for these macros in ProfilingDebugging\CpuProfilerTrace.h.

#rb Catalin.Dragoiu

[CL 28337510 by ionut matasaru in ue5-main branch]
2023-09-29 04:05:39 -04:00
logan buchy
5d75d51d13 Tag ContentBrowser's SAssetTileIItem with Asset's ItemName
* Enables automation driver to discover the widget using the path "<SContentBrowser>/<SAssetView>/MyAssetItemName"

#rb brooke.hubert
#jira UE-195070

[CL 27764834 by logan buchy in ue5-main branch]
2023-09-11 14:50:24 -04:00
zahra nikbakht
165dac13a7 Asset View: Ensure there is enough space for the name of the asset when source control icons are enabled.
A constant height is added to the total asset tile height to make space for both the name and the icon.
#jira UE-193377
#rb patrick.boutot, aditya.ravichandran

[CL 27346375 by zahra nikbakht in ue5-main branch]
2023-08-24 12:41:10 -04:00
jamie dale
e3cbbe5534 Updated the asset view filter to process every filter looking for an exclusion, rather than assuming the first inclusion means the rest of the filters can be skipped
#jira
#rb Scott.Nelson
#rnx

[CL 27245680 by jamie dale in ue5-main branch]
2023-08-21 13:38:33 -04:00
zahra nikbakht
aba178ff3d AssetView: fix a bug where the name area is too small in Medium-sized tile views when we choose not to show the type of the asset.
#rb patrick.boutot
#jira UE-189311

[CL 26576734 by zahra nikbakht in ue5-main branch]
2023-07-25 12:01:20 -04:00
robert millar
4301477ebd Provide telemetry to SAssetView. Telemetry is not sent to any endpoint for licensees.
#rb julien.st-jean,logan.buchy,wes.hunt

[CL 26301369 by robert millar in ue5-main branch]
2023-06-28 18:21:13 -04:00
rex hill
858bd384e3 Re-add ability to hide collections that was removed by 23662444
#preflight skip
#rnx

[CL 25461666 by rex hill in ue5-main branch]
2023-05-12 18:52:39 -04:00
julien stjean
8787c97df0 Additional improvement for the filter compilations of the asset views.
Added a system to cache some data that can be used when recompiling the filters for the incremental data updates.
For now this only used by for the asset data source internal path compilation of the asset views.

In my test on a bad scenario this yielded a reduction 98% of the time it take to call UContentBrowserAssetDataSource::CreateAssetFilter when the cache is used.

Before the optimization the reference call took  26.3 ms
After the optimization the reference call took 0.3725 ms

Also this change fix an issue with my last change interacting badly with the alias data source by not using its customization of the package paths hierarchy.

#preflight 645a92f42d27fa25b3069003
#jira UE-183276
#rb Rex.Hill

[CL 25396753 by julien stjean in ue5-main branch]
2023-05-09 18:06:59 -04:00
julien stjean
703a8ebc8f Adding some cpu traces for the content browser data source filter compilation.
#jira UE-183269
#rb none
#rnx
#preflight 64493e39b208f61af8999741

[CL 25202960 by julien stjean in ue5-main branch]
2023-04-26 13:56:32 -04:00
julien stjean
7acf14ca7a Fixed a crash where a ThumbnailPool could be deleted while it is ticking because the asset view that owned it was destroyed while generating a thumbnail.
The fix was simply to make the asset views use the shared pool. Greatly increased the size to of shared thumbnail pool from the thumbnail manager to acommodate the asset views.

#jira UE-149354, FORT-581705
#preflight 642c9d8f6a37fb35e950b909
#rb Aditya.Ravichandran, Brooke.Hubert

[CL 25032701 by julien stjean in ue5-main branch]
2023-04-13 17:06:54 -04:00
jamie dale
b95e92ef3d Content Browser UX improvements for cooked content
* Plugins that only contain cooked content (and have no C++ modules) no longer show their "Content" suffix.
* Folders that only contain private cooked content are no longer visible in the asset or path views.

#preflight 642f2e3cb306e98c632f0195
#rb Jason.Stasik, Aditya.RaviChandran

[CL 24994922 by jamie dale in ue5-main branch]
2023-04-11 14:22:33 -04:00
Steve Robb
c341d7fc22 Added [[nodiscard]] to relevant TUniquePtr functions.
Fixed up misuses.

#rb devin.doucette
#jira none
#preflight 6413707f345ab08524938eec

[CL 24686373 by Steve Robb in ue5-main branch]
2023-03-17 07:06:23 -04:00
lauren barnes
17a57fa4fa Fall back to EditorConfig version of content browser settings where it exists, removing some settings from per-instance settings
#jira UE-175898
#preflight 63fe5ff8ac6c61e2b553eea1

[CL 24454235 by lauren barnes in ue5-main branch]
2023-02-28 18:18:28 -05:00
lauren barnes
2aae7e7f18 Browsing to assets where the current settings would cause the asset to be hidden now updates the settings of the active Content Browser to show the asset(s). This is done by directly changing the setting as many systems are listening for Content Browser settings changes to refresh their display to the user.
#jira UE-175679
#rb julien.stjean
#lockdown jeanmichel.dignard
#preflight 63ea6739923476b686e0bc0b

[CL 24194579 by lauren barnes in ue5-main branch]
2023-02-13 18:26:10 -05:00
julien stjean
1d02db5d50 Remove the capacity to copy and paste the unsupported assets.
#rb Jason.Stasik
#preflight 63e17a0514326f9a40903541

[CL 24043044 by julien stjean in ue5-main branch]
2023-02-06 20:01:27 -05:00
JeanMichel Dignard
38ef5daae8 Fixed truncation warnings in the ContentBrowser modules
#jira UE-166269
#rb yohann.dossantos
#preflight 63e12ffa797b029c0a6507fe

[CL 24032337 by JeanMichel Dignard in ue5-main branch]
2023-02-06 12:05:08 -05:00
julien stjean
55a1b3af29 Introducing the unsupported asset item for the content browser.
These are currently used to display the asset that are hidden by a backend class permission system.
They can also be restricted to some path only if desired.
Note: We will do a UX pass for the unsupported items after this is submitted and later we will also add some support for the unsupported asset to the alias data source.

#preflight 63dc23a7175a9839ac4cf474
#rb Jason.Stasik

[CL 24007061 by julien stjean in ue5-main branch]
2023-02-03 22:39:50 -05:00
sebastian nordgren
9ebab4256d Collections are now visible in the Content Browser again.
Removed CollectionsDocked setting, since it wasn't bound to any toggle anywhere.

Removed sources widget switcher which was untoggleable.

#jira UE-173851
#review-23661236 @editor-ux
#preflight 63c00acc4b018bfa800fbebc

[CL 23662444 by sebastian nordgren in ue5-main branch]
2023-01-12 09:40:29 -05:00
sebastian nordgren
de150ad082 Content browser settings moved to editor config system.
There are a few settings here that we use in places where it's ambiguous which content browser instance is triggering the change, and those have not been transferred over. A few settings also appear to now be unused, and those have also not been transferred.

Additionally, set the SetDisplayDeveloperFolder(bool, bool) functions which took an override variable have been deprecated, and the overrides moved to SAssetView variables directly - these were used after syncing content to temporarily override filters and weren't persisted.

Tested across 2 Content Browsers, toggling all settings enabled on one, and all setting disabled on the other, and checking that the settings persist across restarts of the editor.

#jira UE-150674
#review-23434533 @editor-ux
#preflight 63bd773868068a8bd64ea317

[CL 23626453 by sebastian nordgren in ue5-main branch]
2023-01-10 09:46:42 -05:00
daren cheng
d9543c938a Add an option to collapse assetview scrollbars, preventing jitter when using multiple assetviews within an already-scrollable container.
#jira UE-170836
#preflight 63893c3b303395f6c9560e6d
#rb Patrick.Boutot

[CL 23578055 by daren cheng in ue5-main branch]
2023-01-04 13:18:36 -05:00
aditya ravichandran
e4cf636ae8 Content Browser: Fix a bug where the revision control icons would get skewed
#jira UE-172658
#rb lauren.barnes
#preflight 6398b9d32540a78d272e8306

[CL 23500079 by aditya ravichandran in ue5-main branch]
2022-12-13 18:25:14 -05:00
aditya ravichandran
4e9cd752c2 Content Browser: Update Revision Control icon placement, add multiple columns to the list view and add a column to show the revision control status to the list and column view
#rb Lauren.Barnes
#preflight 639745e3776b61ba3bc2b298
#jira UE-172571

[CL 23480146 by aditya ravichandran in ue5-main branch]
2022-12-12 13:41:19 -05:00
nick darnell
954d29b9f5 Editor - Beginning the process to no longer make loading all assets you right click in the content browser. The first step, is setting up the code to have a deprecation flag DEPRECATE_ASSET_TYPE_ACTIONS_NEEDING_LOADED_OBJECTS, this will make it illegal to implement GetActions on all AssetTypeAction implementations. Checked in disabled, enable it locally to begin trying to implement the recommended method detailed in the IAssetTypeActions header. WIP. One of the things this change does is outlaw (regardless of deprecation) the HasActions() function, this function is no longer used at all, and so we may as well remove its implementation, it also works well as a canary in finding other samples and things that need to be upgraded.
#jira UE-165574
[REVIEW] [at]Rex.Hill, [at]Lauren.Barnes
#preflight 63483c43ad0f7e2f20e44910

[CL 22534452 by nick darnell in ue5-main branch]
2022-10-14 16:59:41 -04:00
robert millar
e6857190f2 Updating collection manager interface to use FSoftObjectPath for the paths of assets and objects rather than FName.
#jira UE-161932
#rb julien.stjean
#preflight https://horde.devtools.epicgames.com/job/6324e773f258fccf98de78cf

[CL 22064625 by robert millar in ue5-main branch]
2022-09-16 20:57:34 -04:00