Commit Graph

477 Commits

Author SHA1 Message Date
dmytro ivanov
d7e3046599 Unreal Insights support for tracing swap events
#jira UE-198367
#rb ionut.matasaru

[CL 31839388 by dmytro ivanov in ue5-main branch]
2024-02-27 09:39:44 -05:00
ionut matasaru
11e371d176 [Insights] Fixed FMemory::Malloc/delete mismatch in FDefinitionProvider.
#rb paul.chipchase

[CL 31838349 by ionut matasaru in ue5-main branch]
2024-02-27 09:07:27 -05:00
ionut matasaru
ed3e2bda78 [Insights] GpuProfiler: Fixed crash when analysis encounters GPU profiler frames with invalid timestamps (ex. emitted with invalid "CalibrationBias"). Also added error / log messages when analysis is completed.
#jira UE-207405
#rb Catalin.Dragoiu

[CL 31643875 by ionut matasaru in ue5-main branch]
2024-02-20 09:29:28 -05:00
steve robb
f8d47335a4 Replaced RemoveAt(N, 1, EAllowShrinking::*) with RemoveAt(N, EAllowShrinking::*).
[CL 31626444 by steve robb in ue5-main branch]
2024-02-19 16:51:58 -05:00
ionut matasaru
8693ff8d8b [Insights] Fixed Unreal Insights crash when analysing LoadTime trace events. It happened in two situations: a) when EndRequest event encounters a package (associated with the request) already destroyed; b) when AsyncPackageRequestAssociation tries to associate an async package with imported packages already destroyed.
#jira UE-206110
#rb Catalin.Dragoiu
[FYI] Danny.Couture, Francis.Hurteau

[CL 31562381 by ionut matasaru in ue5-main branch]
2024-02-16 08:50:04 -05:00
ionut matasaru
53933c01e1 [Insights] Fixed incorrect timestamps for cpu timing events with metadata that are adjacent to other regular cpu timing events.
#jira UE-205404
#rb Catalin.Dragoiu

[CL 31208333 by ionut matasaru in ue5-main branch]
2024-02-06 04:59:13 -05:00
ionut matasaru
e550b3ffde [Insights] Fixed crash when "TimingInsights.ExportTimerStatistics" execute command is specified with an invalid filename. An error message is logged instead.
#jira UE-177417
#rb Catalin.Dragoiu

[CL 31127407 by ionut matasaru in ue5-main branch]
2024-02-02 11:26:08 -05:00
mattias hornlund
4104e1f338 NetworkInsights
- Detected lost packets are now marked on incoming data
- Changed how we display lost data to make it easier to spot.

#rb Peter.Engstrom

[CL 31039322 by mattias hornlund in ue5-main branch]
2024-01-31 02:05:01 -05:00
jerome delattre
0d04f4b841 Move Insights tests into System.Insights.
#jira UE-179877

[CL 30935355 by jerome delattre in ue5-main branch]
2024-01-26 14:33:32 -05:00
ionut matasaru
9bf87dd93c [Insights] Improved error detection for timing region events. A zero duration region will be created automatically if begin and end events do not match. Excluded warnings for "<SlowTask>" regions as begin-end events are known to mismatch.
#rb Catalin.Dragoiu

[CL 30767803 by ionut matasaru in ue5-main branch]
2024-01-22 07:58:35 -05:00
steve robb
f029468598 Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.
[CL 30729174 by steve robb in ue5-main branch]
2024-01-19 16:41:35 -05:00
ionut matasaru
5ae96cb993 [Insights] LoadTime: Added error message (instead of a check that would result in a crash) for cases when an End* event is encountered without the corresponding Begin* event. This can happen in late connect sessions with "loatime" channel enabled.
#rb Catalin.Dragoiu

[CL 30480962 by ionut matasaru in ue5-main branch]
2024-01-08 10:25:19 -05:00
catalin dragoiu
b23770a38e Fix static analysis error.
[CL 30266237 by catalin dragoiu in ue5-main branch]
2023-12-12 12:03:49 -05:00
catalin dragoiu
35f3568730 [Insights] Add metadata filter to the Filter Configurator. Add support for filters with custom UI.
#rb ionut.matasaru
#jira UE-140771

[CL 30259460 by catalin dragoiu in ue5-main branch]
2023-12-12 05:34:37 -05:00
ionut matasaru
ba659ff174 [Insights] CpuProfilerAnalysis:
- Refactored code re "pending events" and detection of "still-open" timing events.
  - Added support for "CpuProfiler.EndThread" with a timestamp. "Still-open" timing events will be closed with this timestamp.
  - Removed analysis for unused "CpuProfiler.EndCaptureV2" event.
  - Separated the analysis code for the backward compatibility events.

#rb Johan.Berg, Catalin.Dragoiu

[CL 30076061 by ionut matasaru in ue5-main branch]
2023-12-04 06:52:33 -05:00
ionut matasaru
deffabcf41 [Insights] Added missing TRACESERVICES_API to FProviderLock and IEditableRegionProvider.
#rb Sebastian.Thomeczek

[CL 29987777 by ionut matasaru in ue5-main branch]
2023-11-29 10:06:09 -05:00
marc audy
763a611985 Fix C4072 warnings
#rnx

[CL 29852844 by marc audy in ue5-main branch]
2023-11-20 17:26:53 -05:00
ionut matasaru
0e22ba621b [Insights] Implemented workaround for trace files with broken stats counters events (-trace=stats; i.e. incorrect timestamps).
#jira UE-198975
#rb Catalin.Dragoiu
[FYI] Sebastian.Thomeczek

[CL 29139541 by ionut matasaru in ue5-main branch]
2023-10-26 12:27:41 -04:00
bhavan vaishnav
05b85f3266 This change adds the requested priority to the package summary so we can assess the order in which packages are loaded and if AsyncLoading is respecting package priorities as expected.
Discussions suggest we don't have enough data points to debug/ensure priorities are being respected, and this would be good to have in the engine in any case.

#rb simon.orr ionut.matasaru

[CL 28885835 by bhavan vaishnav in ue5-main branch]
2023-10-18 15:04:49 -04:00
ionut matasaru
40d03d4e71 [Insights] MemoryInsights/Mem Allocs table:
- Added "Alloc/Free Callstack Id" columns, separated by "Alloc/Free Callstack Size" columns. Both shows entire callstack in tooltip (and can be copied to clipboard). Also removed the full callstacks from the main tooltip of an allocation (where values of all columns are displayed).
  - Fixed "Free Callstack" columns (some showing the wrong "alloc callstack" and other still using "alloc callstack" for sorting and grouping).
  - Added "Alloc/Free Thread Id" columns (shows the trace assigned thread id for "alloc" and "free" events).

#rb Catalin.Dragoiu
[FYI] Anton.Dunchev

[CL 28875205 by ionut matasaru in ue5-main branch]
2023-10-18 09:27:51 -04:00
ionut matasaru
818a6622b8 [Insights]
- Metadata / MemoryInsights: Fixed mem tags and metadata association with mem allocations for threads where SystemThreadId is not available (ex. missing $Trace.ThreadInfo event). Now, both taggging and metadata uses the "trace asigned" thread ids.

#rb Catalin.Dragoiu

[CL 28836716 by ionut matasaru in ue5-main branch]
2023-10-17 08:37:21 -04:00
anton dunchev
6caa157b62 [MemoryInsights] Add free memory event callstack groupings/columns.
#rnx
#tests win64
#rb ionut.matasaru

[CL 28636038 by anton dunchev in ue5-main branch]
2023-10-10 16:22:30 -04:00
ionut matasaru
119dbc1a08 Enabled UnsafeTypeCast warnings as errors in Trace/Insights related modules (UnrealInsights, TraceAnalysis, TraceServices, TraceDataFiltering, TraceUtilities, EditorTraceUtilities).
Fixed conversion warnings in TraceAnalysis and in TraceServices modules.

#rb Catalin.Dragoiu

[CL 28339045 by ionut matasaru in ue5-main branch]
2023-09-29 07:22:52 -04:00
catalin dragoiu
30565203c0 [Insights] Add infinity and NaN support to table import and table diff.
#jira UE-177128
#rb Ionut.Matasaru

[CL 28267148 by catalin dragoiu in ue5-main branch]
2023-09-27 05:11:10 -04:00
mikita hauruk
cac2ca067e [Insights] Reorganized the structure of functional tests for Unreal Insights.
Added a couple of .h files for compilation with the -NoPCH -DisableUnity flags
Wrapped OpenTraceFile in quotes in tests for custom paths with spaces
Changed type of Timeouts from float to double.

#rb Ionut.Matasaru Catalin.Dragoiu-Pruna Johan.Berg
#prefligh 65096a64cf5b71e8360cec09

[CL 28082139 by mikita hauruk in ue5-main branch]
2023-09-21 07:39:41 -04:00