Commit Graph

14602 Commits

Author SHA1 Message Date
florin pascu
4212ff13dc Deprecated FTargetPlatformBase, TTargetPlatformBase and TNonDesktopTargetPlatformBase
Replaced with FTargetPlatformControlsBase/FTargetPlatformSettingsBase,  TTargetPlatformControlsBase/TTargetPlatformSettingsBase and TNonDesktopTargetPlatformControlsBase
#jira UE-206488
#rb Josh.Adams

[CL 32151592 by florin pascu in ue5-main branch]
2024-03-11 07:24:38 -04:00
geordiemhall
60fbb602d9 PR #10485: Make the Content Browser 'Filter' toggle buttons hit-test the entire button rather than just the text
[REVIEW] [at]Julien.StJean
#jira UE-187946
#rb Julien.StJean

[CL 32127685 by geordiemhall in ue5-main branch]
2024-03-08 14:24:46 -05:00
jerome delattre
43322bb6a0 Validate active screenshot id before accepting screenshot comparison completion
#jira UE-202925
#rnx
#rb christopher.fiala, sean.sweeney, sebastian.lewicki

[CL 32122480 by jerome delattre in ue5-main branch]
2024-03-08 11:48:08 -05:00
anousack kitisa
6a8947ee4f Fixed typo in message log.
#jira UE-209142

[CL 32120514 by anousack kitisa in ue5-main branch]
2024-03-08 10:42:12 -05:00
charles bloom
ab5bc4c973 TextureCompressorModule : fix bug with MaxTextureSize on images with more than 1 slice (cubes, arrays)
bump DDC key for affected textures
bug introduced in CL 31470247
#rb Dan.Thompson

[CL 32105201 by charles bloom in ue5-main branch]
2024-03-07 18:16:29 -05:00
sebastian arleryd
6223cfc88f Make UToolMenu::bSearchable control whether the menu's search field is available
Setting UToolMenu::bSearchable to false in a menu delegate will now disable the search field completely for that menu (hidden and non-functional even if the user types into the menu). However, menu entries from this unsearchable menu will still show if a parent menu is searched.

#jira UE-208812
#rb brooke.hubert

[CL 32081852 by sebastian arleryd in ue5-main branch]
2024-03-07 06:19:34 -05:00
zousar shaker
404a8affe6 Attempt shut down of running zenserver process if we find a locked lock file but the pid registered in the lock file can't be found.
If a pid can not be found when finding a matching desired/effective port, keep looking if any other state has a matching port.
Hardened and added logging to NativeIsProcessRunning.

Run of Low Level Tests in Main  here: https://horde.devtools.epicgames.com/job/65e81c5d156d6df40d304906

#jira UE-207039
#rb Zousar.Shaker

#ushell-cherrypick of 31938454 by swarm

[CL 32068216 by zousar shaker in ue5-main branch]
2024-03-06 16:52:12 -05:00
zach harris
c8c7fd62ec Various fixes and enhancements to the primitive debugger tool.
- Renamed the command to access the tool from DrawPrimitiveDebugger.Open to PrimitiveDebugger.Open
- Fixed access violations and crashes that occurred when opening and using the tool.
- Fixed issue where the debugger table would not populate until filter text was entered when using it in-game.
- Fixed an issue causing the server to crash if the console command cheat DrawPrimitiveDebugger.Open is used
- Added support for skeletal meshes and other primitives.
- Added a details panel for the currently selected row to declutter the table view and provide more in depth information such as the materials and textures used and the number of available LODs. The data displayed will refresh automatically and display the active location, LOD, and triangle count of the primitive.
- The details panel can force LOD levels, force disable nanite, display bounds, and show skeletal bones. Bounds and bone displays only work in development or debug builds.
- Note that any changes to primitives made by the debugger, as well as pinned and hidden entries, will be reset when the debugger is closed.
- Fixed communication between the game and render threads when handling frame captures.
- Enhanced search functionality. You can now search by primitive name, primitive class, actor name, actor class, material name, and texture used.

#rb daniele.vettorel
[FYI] elizabeth.bunner, nicolas.mercier, bryce.lumpkin
#tests FNTEST-128602

[CL 32064534 by zach harris in ue5-main branch]
2024-03-06 15:16:33 -05:00
dan elksnitis
be2a80c92b [shaders/stb_preprocess] stb preprocessor bug fixes:
- fix line number mismatches caused due to multiline macro arguments by keeping leading/trailing whitespaces in cases of multiple lines encountered in a single macro argument (single line macro args still have whitespace trimmed as this is needed for token pasting)
- avoid early out preventing parsing of "defined" builtin macro outside of #if conditions; this allows using defined in #define directives (among other places)

#rb Yuriy.ODonnell

[CL 32051438 by dan elksnitis in ue5-main branch]
2024-03-06 09:07:22 -05:00
jamie dale
9bd4d604e4 Tear down localization prior to static destruction
This avoids crashes from a logging attempt during static destruction in the test runner, which can happen as the test runner only manually tears down a subset of things that the standard LaunchEngineLoop handles

#jira UE-208856
[FYI] chris.constantinescu
#rnx

[CL 32031506 by jamie dale in ue5-main branch]
2024-03-05 14:46:10 -05:00
josh adams
f4a4b1ec3d - Changed dir watcher on Mac to use an FRWLock protecting an array instead of GameThreadCall that was causing trouble when cooking
#rb roman.dzieciol
#jira UE-208803, UE-208811

[CL 32023184 by josh adams in ue5-main branch]
2024-03-05 12:02:59 -05:00
zousar shaker
8b0a81dc6c Add NoZenLocalFallback and InstalledNoZenLocalFallback DDC graphs for use in scenarios where users are unable to run a local zenserver for any reason. Also fix a mis-labeling of a local cache store as being remote if it is deactivated.
#rb devin.doucette
#jira UE-208878

[CL 32022101 by zousar shaker in ue5-main branch]
2024-03-05 11:24:22 -05:00
zousar shaker
0c40eb4aef Identify zenserver as Unreal Zen Storage Server in messagebox dialogs and accompanying logs for high priority messages. Ensure google drive warning follows the same messagebox/log logic as other prompts. Eliminate the use of RequestExit from within ZenServerInterface, failure should not force process shutdown.
#rb dan.engelbrecht
#jira UE-208878

[CL 32022078 by zousar shaker in ue5-main branch]
2024-03-05 11:23:40 -05:00
wouter burgers
586f305a83 SourceControl: Fixed crash in FSourceControlAssetDataCache::LaunchFetchAssetDataTasks().
The fix is theorycrafted by reasoning about the code - I was not able to actually reproduce this.

The callstack suggests a nullptr exception, indicating that the Find() in AssetDataCache failed. The AssetDataToFetch container is populated in two places:
- AddAssetInformationEntry()
- OnUpdateHistoryComplete()

The AddAssetInformationEntry() method populates the AssetDataCache and optionally the AssetDataToFetch container.
The OnUpdateHistoryComplete() assumes the entry in AssetDataCache exists and populates the AssetDataToFetch container.

The ClearPendingTasks() removes pending entries from the AssetDataCache container.
However, it doesn't wait for any pending FUpdateStatus task to be finished.

Thus, if the ClearPendingTasks() method is called after GetFileHistory() queues an FUpdateStatus operation but before that operation returns, the OnUpdateHistoryComplete() would queue an entry in AssetDataToFetch while there is no accompanying entry in AssetDataCache. This will result in the crash. The ClearPendingTasks() is called on shutdown, when the source control provider changes or when the source control dialog is shown - the latter being the most likely thing to have happened.

#rb luc.eygasier, manuel.lang

[CL 32014349 by wouter burgers in ue5-main branch]
2024-03-05 04:15:49 -05:00
graham wihlidal
831fff0c59 Added CFLAG_ShaderBundle and decorated Nanite CS materials with it (some platforms can use this to build relevant data structures for internal bundle implementations).
#rb yuriy.odonnell
[REVIEW] https://p4-swarm.epicgames.net/reviews/32011926

[CL 32012726 by graham wihlidal in ue5-main branch]
2024-03-05 00:40:11 -05:00
marco anastasi
94cb4ec971 Snapshot History Design/UI Fixes
* Updated dropdown text color for dates
* Added missing icon(s) for project size
* When a Snapshot is expanded, the background color now remains dark
* When two adjacent Snapshots are expanded, there is now a separation between the expanded areas

#rb wouter.burgers

[CL 32007002 by marco anastasi in ue5-main branch]
2024-03-04 19:56:50 -05:00
dan thompson
2ed61a6050 Updating FCompressedImage2D to NumSlices from SizeZ, for clarity.
Tested cooked build diff for sanity as this should only ever affect in-memory editor values.

#jira UE-149124
#rb fabian.giesen

[CL 31997496 by dan thompson in ue5-main branch]
2024-03-04 14:39:15 -05:00
pj kack
4161e66f68 Move all IoStoreWriter code (writing of .utoc/.ucas containers) out from Core into IoStoreUtilities.
Break cyclic dependency on DerivedDataCache module to utilize DDC2 API to cache compressed chunks.
The declarations moved from the public header are considered private and are not really usable outside of the IoStoreUtilities/UnrealPak context.

#rb per.larsson
#rnx
#tests BuildCookRun Lyra with pak/container files

[CL 31986007 by pj kack in ue5-main branch]
2024-03-04 07:47:44 -05:00
jamie dale
f3631d6d16 Tear down GLog prior to static destruction
This avoids crashes from anything that logs during static destruction in the test runner, which can happen as the test runner only manually tears down a subset of things that the standard LaunchEngineLoop handles

[FYI] chris.constantinescu
#rnx

[CL 31977137 by jamie dale in ue5-main branch]
2024-03-02 11:52:53 -05:00
aditya ravichandran
2bb9133247 AssetTools: Fix a bug where FAssetDefinitionProxy::GetIconBrush was calling AssetDefinition->GetThumbnailBrush instead of AssetDefinition->GetIconBrush
#rb JeanMichel.Dignard

[CL 31945684 by aditya ravichandran in ue5-main branch]
2024-03-01 11:36:04 -05:00
dan engelbrecht
4f7386867d Use process-unique name for zen data directory validity test
Fixes warning "Warning: [CookWorker 2]: Skipping subprocess environment variable UE-ZenSubprocessDataPath=d:/build/++Fortnite/Sync/ZenData due to an invalid path" caused by a race condition between multiple cook workers.
See https://horde.devtools.epicgames.com/log/65dc47bbdd128eaa49c6cc13?lineindex=90207
#jira UE-208562

#rb Zousar.Shaker

[CL 31941714 by dan engelbrecht in ue5-main branch]
2024-03-01 08:58:49 -05:00
yafes sahin
8c78548e84 - IAssetTools.h expose bPrompt and create bIgnoreDependencies
- AssetTools.cpp add a case to only copy the selected assets and ignore the dependencies (usecase for automation)
- Added BP example that implements the scripted asset action with the new migrationOption

#rb Julien.StJean, Takashi.Kuribayashi
[FYI] Michael.Lentine
#tests

[CL 31930249 by yafes sahin in ue5-main branch]
2024-02-29 19:11:14 -05:00
charles bloom
8d76e1c458 ImageCore: more resize filter options (Lanczos)
make DownscaleOptions Default pass through without changing to SimpleAverage for new filters
map DownscaleOptions to better resize filters
#rb Dan.Thompson, fabian.giesen

[CL 31916433 by charles bloom in ue5-main branch]
2024-02-29 13:40:21 -05:00
josh adams
7f0dda88b8 - Hopeful fix for some threading issues
- Will need to go to 5.4
#rb calvin.zheng
#jira UE-208120

[CL 31915769 by josh adams in ue5-main branch]
2024-02-29 13:25:37 -05:00
julien stjean
727cc8e07e Added a filter to only show the assets that are not used by another asset.
Also removed some uneeded code and removed some unessary copy of a SharedPtr in the construction of the frontend filters.

#jira UE-208480
#rb JeanLuc.Corenthin

[CL 31911508 by julien stjean in ue5-main branch]
2024-02-29 11:46:24 -05:00