Commit Graph

968 Commits

Author SHA1 Message Date
carlmagnus nordin
d0a7f9a0ad ZenLoader: Fixed incorrect calling of CreateAsyncPackagesFromQueue when running without the ALT
#preflight 633b01932a5690003a171881
#rb pj.kack

[CL 22322234 by carlmagnus nordin in ue5-main branch]
2022-10-03 20:38:22 -04:00
carlmagnus nordin
fa887104cb ZenLoader: Ensure that packages for sync load requests are created as soon as possible so that we don't waste time looking for them in the event queue
#rb pj.kack
#preflight 633aa141b34118b9b4403c8b

[CL 22307506 by carlmagnus nordin in ue5-main branch]
2022-10-03 12:52:58 -04:00
pj kack
5da047bb3e AsyncLoading2: Only process/create pending CDOs when absolutely required to unblock the current FlushAsyncLoading stack during initial load.
Fix for FAsyncLoadingThread2::FlushLoading getting stuck in an infinite loop (constructur reentrancy) on projects where native class CDOs are loading blueprints.

#jira UE-165541
#rb carlmagnus.nordin
#rnx
#preflight 6335ef34f76de2d4d567888c

[CL 22271555 by pj kack in ue5-main branch]
2022-09-30 11:27:56 -04:00
per larsson
c25048d9df Bulk Data - deprecate GetPackagePath/PackageSegment
#rb Paul.Chipchase
#jira UE-165473
#preflight 63359b2e3041fbb5665410c3

[CL 22271509 by per larsson in ue5-main branch]
2022-09-30 11:25:58 -04:00
danny couture
e52aab5513 Move BP reinstanciation to happen on async loading thread before postloads are called
#rb CarlMagnus.Nordin, Dan.OConnor
#preflight 6335d7b5d165c45137abf76f

[CL 22267626 by danny couture in ue5-main branch]
2022-09-30 05:32:59 -04:00
arciel rekman
1facaa88b2 Add more logging to investigate shader decompression errors (UE-159777).
- Hexdump of the whole compressed shader will be dumped if small enough (which is what we're seeing mostly).

#rb Jason.Nadro
[REVIEW] [at]Jason.Nadro
#jira UE-159777
#preflight 6335b508f76de2d4d55a858c

[CL 22262833 by arciel rekman in ue5-main branch]
2022-09-29 23:45:42 -04:00
Matt Peters
e116834785 Suppress the BulkData duplicate guid warning until we have eliminated all sources of duplication.
#rb Paul.Chipchase
#rnx
#preflight 633480a0e41069160680aac8

[CL 22248339 by Matt Peters in ue5-main branch]
2022-09-29 11:32:13 -04:00
paul chipchase
aafc08afb4 EditorBulkData will now generate a new identifier when loaded into a transient package
#rb Matt.Peters
#jira UE-163504
#rnx
#preflight 63344a9ec7791417aafe4d8e

- This fix an issue where Niagara emitters being loaded from templates could end up with duplicate unique identifier as they were first being duplicated to a transient package before being moved (via UObject::Rename) to the final package. This meant we had no way to produce a unique guid for the editor bulkdata.
- This solution does mean that we are not producing stable guids between multiple runs of the editor (the above scenario occurs every time the Niagara package is loaded) but that requirement is for future features that are not yet online. We will revisit this code in 5.2 to implement a solution that does produce stable guids.

[CL 22239135 by paul chipchase in ue5-main branch]
2022-09-28 21:41:54 -04:00
Devin Doucette
e80df527fd DerivedData: Extracted private FCookedData from FDerivedData
The new FCookedData has been used to clean up the FLinkerSave API and the implementation of FDerivedData.

#preflight 63344bde0530d7c4b9c115d0
#rb Zousar.Shaker
#rnx

[CL 22221553 by Devin Doucette in ue5-main branch]
2022-09-28 10:07:08 -04:00
carlmagnus nordin
d85453b37c ZenLoader: Optimized management of sync load context packages
#preflight 63315888e23e50651b1ac9ea
#jira UE-164912
#rb pj.kack

[CL 22218253 by carlmagnus nordin in ue5-main branch]
2022-09-28 01:08:15 -04:00
CarlMagnus Nordin
049635aa3b ZenLoader: Removed editor ifdef that was supposed to have been removed in 22152724
#preflight 63319c4b0d6a7155ba2b4bb8
#rb none

[CL 22180539 by CarlMagnus Nordin in ue5-main branch]
2022-09-26 09:04:06 -04:00
CarlMagnus Nordin
be3f1e00b6 ZenLoader in editor: Only call CreateImports/Exports when in the correct state, fixes issues with trying to use the linker after it has been detached.
#rb pj.kack
#preflight 632c72c8a4769ad714abeb89

[CL 22152851 by CarlMagnus Nordin in ue5-main branch]
2022-09-23 04:43:31 -04:00
CarlMagnus Nordin
b3f84ab33e ZenLoader in editor: PostLoad all constructed objects for a package instead of only the exports
#rb pj.kack
#preflight 632d6aced51603c5487a3747

[CL 22152850 by CarlMagnus Nordin in ue5-main branch]
2022-09-23 04:42:29 -04:00
CarlMagnus Nordin
6b8aec6bb8 LinkerLoad: Ensure that objects are associated with the correct async package for NotifyConstructedDuringAsyncLoading
#rb per.larsson
#preflight 632d6010a4769ad714ec2077

[CL 22152724 by CarlMagnus Nordin in ue5-main branch]
2022-09-23 04:03:50 -04:00
CarlMagnus Nordin
4dd555b4a4 ZenLoader in editor: Fixed handling of failed packages
#rb pj.kack
#preflight 632c4ae77b582f58ab338468

[CL 22135779 by CarlMagnus Nordin in ue5-main branch]
2022-09-22 10:11:28 -04:00
CarlMagnus Nordin
df930de60e ZenLoader in editor: Remove garbage objects from linker export tables when notifying unreachable objects so that we don't end up with garbage objects in the import store
#rb pj.kack
#preflight 632ae9b19840225da2c50cc1

[CL 22109845 by CarlMagnus Nordin in ue5-main branch]
2022-09-21 06:47:50 -04:00
per larsson
4549f92468 Bulk Data - crash fix for bulk data with wrong flags getting uploaded to DDC
#rb Paul.Chipchase
#preflight none
#rnx

[CL 22088631 by per larsson in ue5-main branch]
2022-09-20 00:48:35 -04:00
carlmagnus nordin
9355c00328 EditorPackageLoader: Fixed issue with exports from already loaded uncooked packages not being registered in the import store
#rb pj.kack
#preflight 63284780ae4e65ae63c4da96

[CL 22084676 by carlmagnus nordin in ue5-main branch]
2022-09-19 19:49:50 -04:00
Matt Peters
97d33caf50 MeshDescription: In addition to applying the package's CustomVersions when deserializing MeshDescription out of BulkData, also apply the UEVersion and LicenseeUEVersion.
#jira UE-160855
#rb Richard.TalbotWatkin
#rnx
#preflight 63289253ea1c94f4c5e2fd67

[CL 22076022 by Matt Peters in ue5-main branch]
2022-09-19 13:01:00 -04:00
carlmagnus nordin
98fd341d01 ZenLoader: Let the async loading thread progress on other packages if there's no more work to do for the current sync load
#preflight 63245c4bae4e65ae63e96d20
#rb pj.kack

[CL 22059800 by carlmagnus nordin in ue5-main branch]
2022-09-16 16:34:29 -04:00
carlmagnus nordin
25d64f3d04 ZenLoader in editor:
* Fixed issue with LOAD_PackageForPIE getting lost when calling LoadPackageAsync from LoadPackageInternal
* Fixed issue with externally created packages not being tracked in the import store and unintentionally being loaded multiple times
* Fixed issue with instancing contexts not being propagated to imported packages

#preflight 63232218e872d7da0397f29e
#rb pj.kack
#jira UE-162812

[CL 22050271 by carlmagnus nordin in ue5-main branch]
2022-09-16 11:32:12 -04:00
joe pribele
73e907afca [CoreUObject] changed DuplicateDataReader/Writer to handle TObjectPtr
#rb zousar.shaker
#preflight 6320f8078c478acecf7abfaa

[CL 21998836 by joe pribele in ue5-main branch]
2022-09-13 22:44:01 -04:00
joe pribele
8dcd88cb17 [CoreUObject] changed the default behaviour of FArchiveUObjectFromStructuredArchiveImpl to forward FObjectPtr to the inner archive to avoid loading objects
Inner archive can choose how to handle FObjectPtr

#rb zousar.shaker
#preflight 6320ec888838676d1007de3e

[CL 21998399 by joe pribele in ue5-main branch]
2022-09-13 22:13:58 -04:00
Devin Doucette
0ce0756966 DerivedData: Added a way to request compressed data from derived data references
- FDerivedDataIoBatch::Compress requests the entire compressed value.
- FDerivedDataIoResponse::GetCompressedData gets the compressed buffer from the response when available.
- FDerivedDataIoResponse::GetCacheValueId has been added to get the FValueId when available.
- FDerivedDataIoResponse::GetCacheKey has been fixed to return a non-null cache key when appropriate.
- Asserts about FDerivedData now log the derived data reference too.

#preflight 631a5f6fa60c539c98ab5fa9
#rb Zousar.Shaker

[CL 21920523 by Devin Doucette in ue5-main branch]
2022-09-09 10:36:44 -04:00
carlmagnus nordin
da495608f8 ZenLoader: Fixed recently introdced atomic ordering problem
#rb pj.kack
#preflight 631b0aaeec45fbf3d7688182

[CL 21918456 by carlmagnus nordin in ue5-main branch]
2022-09-09 07:36:02 -04:00