#lockdown Nick.Penwarden
#rb none
============================
MAJOR FEATURES & CHANGES
============================
Change 3853627 by Shaun.Kime
Merging using OrionDevNiagaraToUE4DevNiagara_DoNotUse VectorVM
#tests non-gpu auto tests pass
Change 3853628 by Shaun.Kime
Merging using OrionDevNiagaraToUE4DevNiagara_DoNotUse Runtime
#tests all non-gpu auto tests pass
Change 3853629 by Shaun.Kime
Merging using OrionDevNiagaraToUE4DevNiagara_DoNotUse Engine\Shaders
#tests all non-gpu auto tests pass
Change 3853630 by Shaun.Kime
Merging using OrionDevNiagaraToUE4DevNiagara_DoNotUse Engine\Plugins\FX
#tests all non-gpu auto tests pass
Change 3853631 by Shaun.Kime
Jonathan's material function from Orion\DevNiagara
#tests all non-gpu auto tests pass
Change 3853633 by Shaun.Kime
Merging using OrionDevNiagaraToUE4DevNiagara_DoNotUse EngineTest
#tests all non-gpu auto tests pass
Change 3853911 by Shaun.Kime
GPU rendering now works
#tests GPU tests now pass
Change 3854179 by Shaun.Kime
Removing dead system
#tests now just with a warning
Change 3854731 by Shaun.Kime
Checkpointing current work
#tests n/a
Change 3855080 by Shaun.Kime
Fixing not all control paths return a value error
#tests n/a
Change 3856185 by Bradut.Palas
MultiStack with pinning support.
#jira UE-53459
#tests none
Change 3856615 by Shaun.Kime
Preventing a null pointer dereference when copying unallocated data
#tests auto tests pass
Change 3856622 by Shaun.Kime
Getting rid of the bogus get alias method
#tests auto tests pass
Change 3856644 by Shaun.Kime
Adding the ability to query the number of filtered triangles, index those triangles directly, and compute the position, velocity, UV, and NBT of a triangle.
#tests all auto tests now pass
Change 3856645 by Shaun.Kime
Added several new auto tests and tweaked existing ones.
+ PerParticleRandom still had some randomness in it
+ UserColorCurve has a user color curve defined in 3 different components referencing the same system
+ BasicSkinnedEmitter has 4 skinning sub-tests, attached as a subcomponent, referencing a world skeletal mesh, using a material filter, and using a bone filter
+ added a skinning module that spawns based off exec index and a data interface that queries the number of triangles on a skeletal mesh.
#tests auto tests pass
Change 3856675 by Shaun.Kime
Fixing crash on delete of an emitter
#tests removed one and multiple emitters from active multi-emitter. No crash
#jira UE-54378
Change 3860613 by jonathan.lindquist
New dynamic input
Change 3862549 by Shaun.Kime
Missing last known good images
Change 3864525 by Simon.Tovey
Fix for vm compiler crash when using structs as constants.
#tests No longer crashes.
Change 3864729 by Frank.Fella
Sequencer - Fixed a few places which were modifying sequencer data, but not calling the NotifySequencerDataChanged.
Change 3864737 by Frank.Fella
Niagara - Fix the timeline in the niagara editor plus other fixes.
+ Turned on looping in the timeline by default.
+ Added simulation options to control playback in the editor, including turning off auto-play, disabling reset on change, and disabling resimulation when changing while paused.
+ Added a buttons to the timeline for each renderer an emitter has which shows a renderer specific icon and will allow navigation directly to the renderer with future stack changes.
+ Fixed issues in the emitter life cycle and spawn rate modules which were preventing delay and looping from working consistently. (includes auto-test)
+ Added top level metadata for modules.
+ Added the ability to add metadata to a module and it's inputs to allow it to be edited directly using timed sections in the timeline. Currently configured for the emitter life cycle module.
+ Changed the way the "MaxSimTime" on niagara component works so that it now represents the maximum frame time which should be used when seeking the component to the desired age. This previously was the maximum amount of simulation time to run which would prevent simple effects from simulating quickly, and would also allow more complicated effects to hang the UI while seeking.
+ Changed the behavior of niagara component when seeking to desired age so that it always uses the exact specified seek delta instead of trying to seek to the exact desired age.
+ Fixed the component so that systems which are seeking to the desired age in the editor no longer draw in fast forward mode.
+ Changed the default playback range for effects in the timeline from 1000 seconds to 10 seconds, and fixed the timeline so that the playback range is serialized into the asset which will persist the setting across loads.
+ Fixed scrubbing in the timeline so that it doesn't immediately reset when scrubbing backwards.
+ Added a button to the timeline track for enabling and disabling isolation mode for emitters.
+ Added a checkbox to the timeline to enabled and disable emitters from the timeline.
+ Fixed PinToNiagaraVariable so that it asserts if bNeedsValue is specified and it can't actually provide a value.
+ Create a class called FNiagaraStackFunctionInputBinder which allows binding to an input of a function on a stack so that you can easily set and get the value of the input without having to worry about modifying the graph or rapid iteration parameter sets directly.
#tests Existing auto-tests and 1 new test for life cycle changes.
Change 3867179 by Frank.Fella
Niagara - Turn off GPU simulation for test assets for Shaun.
Change 3869201 by Simon.Tovey
Bypassing JonLs issue
#tests no longer crashes.
Change 3869897 by Frank.Fella
Niagara - Fix crashes when using the skeletal mesh data interface. NOTE: The change to the actual skeletal mesh data interface code doesn't seem needed, but without it, it crashes with the stomp allocator on. We'll have to investigate further.
Change 3870487 by Frank.Fella
Niagara - Always generate cached skin data immediately, and make sure we're not indexing triangles that don't exist. This is a temporary fix to avoid a crash when changing the skeletal mesh source on an effect in the level from the details panel.
Change 3877378 by Frank.Fella
Niagara - Update the burst and lifecycle modules with new metadata for incoming timeline changes.
Change 3877564 by Frank.Fella
Sequencer - Fix a few more places which were modifying sequencer data without calling NotifyMovieSceneDataChanged.
Change 3877565 by Frank.Fella
Niagara - Remove old unused burst code from some runtime classes.
Change 3877567 by Frank.Fella
Niagara - Add support for keying bursts on the timeline which is configured using script metadata.
Change 3877699 by Frank.Fella
Niagara - Fix a crash in the new timeline code for when you have bursts, but you have inputs on the emitter lifecycle bound, also set lower bound of view range of the timeline to be -.1 so that you can more easily interact with keys at 0.
Change 3877715 by Frank.Fella
Sequencer - Update the change type when pasting keys from the clipboard from Unknown to TrackValueChanged to avoid unnecessary work. From code review on last change.
Change 3879285 by Simon.Tovey
A couple of fixes for using struct constants
#tests Jon's case now compiles and works correctly.
Change 3879378 by Frank.Fella
Niagara - Fix a few spots where recursive graph traversal was visiting nodes multiple times because of diamonds in the pin connections. This reduces a terrible hang in UNiagaraScriptSource::InitializeNewRapidIterationParameters from 5 minutes to 5 seconds but there are futher issues to investigate becasue even 5 seconds it too long.
Change 3879858 by Shaun.Kime
Moved the VM script compilation to the DDC in order to facilitate better team compilation behavior. Significant changes to the translator and overall compile workflow to make the data behave better for a future multi-threaded compilation path.
In order to know when to compile, a key is generated that uses the compile id's of the graphs that influence the compilation of our node. In this way, if an end user goes and edits a function or module and checks in, the overall compile id will not match b/c that function is in the dependency list of a system downstream. The system will then know to recompile. However, everyone else on the team will generate the same key because the asset in question was checked in with its local compile id already changed.
Additionally, we now employ change tracking on traversals from a node graph. These traversals walk through all the nodes leading to a given output node and see if they've been altered. If they have, a new compile id is generated. If not, the old compile id is used. This also means that if you edit a particle update section in the stack, the emitter section won't force the system to recompile.
GPU scripts now have their own script slot rather than riding alongside particle spawn scripts. This allows us to address them independently in the translator and put them in the DDC as well. Once the text is generated, we then go back out to the DDC to generate the shader associated.
Known issues:
+ Emitters are sometimes marked dirty on open
+ Nodes connected to event writes aren't part of the hashing
+ DataInterface signature changes don't dirty the compiles
+ Struct changes don't dirty the compiles
+ On system loading, we go out to the DDC instead of using existing scripts, which is slower..
#tests all auto-tests pass, additional tests run to validate proper behavior
Change 3879859 by Shaun.Kime
Content update post DDC change
Change 3879862 by Shaun.Kime
Niagara plugin content to ddc
Change 3879958 by Frank.Fella
Niagara - Actually fix the bad recursion in this function by using the existing traversal method.
Change 3881727 by Damien.Pernuit
Niagara - Houdini - Created a separate plug-in for the Houdini CSV Data Interface.
Change 3881877 by Simon.Tovey
Fix for mac compile issue
Change 3882773 by Simon.Tovey
Actual fix for Mike
Change 3882822 by Shaun.Kime
Rather than throw a check, I instead emit an error when we can't match up a data interface and instantiate a CDO version. Not perfect, but this will let you recompile.
#tests allows me to open jonathan's file
Change 3883538 by Shaun.Kime
Moving particle-level scripts to compile with the emitter named Emitter in their internal scripts. This simplifies the dependencies quite a bit, but causes some complexity on the wiring side (most of which we were already doing anyway).
Getting rid of some allocations in translation (still more to go).
Fixed some of the logic for emitters that had modules of the same name to now properly concatenate.
Compile version bumped, so all scripts will be forced to recompile. Not saving this into the test files for now, as I expect this to happen a bit for the near term.
#tests all auto-tests pass, creating a new emitter and system on PC works
Change 3883552 by Shaun.Kime
Fixing renaming to work properly now. It just invalidates the system script compile id's, forcing it to auto-compile.
#tests auto-tests pass
Change 3884722 by Bradut.Palas
Added searchbar with basic name search for Niagara stack
#tests none
#jira UE-53469
Change 3884793 by Shaun.Kime
Adding pragma once
#tests no longer complains about duplicate definition
Change 3885629 by Wyeth.Johnson
Setting up a transient meshrotation framework pre-integration
Change 3887440 by Wyeth.Johnson
Custom HLSL failure for Shaun
Change 3888911 by Bradut.Palas
stack search box now has a minimum width of 300 pixels
#tests none
Change 3890843 by Shaun.Kime
Creating a Niagara quaternion type.
#tests created in editor, saw default was correct, carried through to VM runtime through attribute viewer
Change 3890849 by Shaun.Kime
Porting over 4.19 fix to Dev-Niagara
#tests allows creation of valid scripts even when ini is cleared.
Change 3891088 by Frank.Fella
Sequencer - When getting selected tracks for the external selection api, include tracks if any of their child nodes are selected. This matches the behavior object guid external selection.
Change 3891114 by Bradut.Palas
Fixing crash that sometimes happens if a stack tree changes while a stack search is active
#tests none
Change 3891131 by Frank.Fella
Sequencer - Move section headers for bool, int, vector, and color to the public directory so they can be used by the niagara level sequence integration.
Change 3891165 by Wyeth.Johnson
error for shaun
Change 3891354 by Shaun.Kime
Adding Quat struct to more locations. Now treated like hlsl float4.
#tests EulerToQuaternion now compiles
Change 3891463 by Bradut.Palas
Fix crash that sometimes happens when deleting module and hitting Ctrl-Z to undo (the condition for removing the listeners from the rootentry should not be tied to the validity of weak pointers for system and emitter, because sometimes they are out of sync when changing the graph)
#tests none
Change 3891641 by Wyeth.Johnson
resave node
Change 3893143 by Shaun.Kime
Fixing issue where you try to bind a vertex color sampler to a mesh without it. We failthe binding rather than crash due to a check later. Also fixed up error logging to only mention the one that failed.
#tests can open NiagaraSystem'/Game/FX/SkeletalMeshDissolve/EmittersAndSystems/FightSceneDissolve.FightSceneDissolve' with an error..
Change 3893528 by Bradut.Palas
fix another crash when search results are invalidated during search
#tests none
Change 3893830 by Shaun.Kime
Fix for copy & paste of comment boxes
#tests can now copy and paste comment boxes
Change 3894012 by Bradut.Palas
no longer executing search tick if the rootentry is null
#tests none
Change 3894828 by Frank.Fella
Niagara - Runtime changes to support sequencer animation
+ Reset the simulation when force solo is changed on the component.
+ Invalidate the render data and clear the buffers when resetting to avoid previously rendered particles from drawing.
+ Automatically sync the override parameters in the component when the source assets exposed parameters change and removed forced syncing from various places.
+ Remove lots of refresh code from the niagara component details which should not be neccessary anymore.
#TESTS Ran autotests, tested through the UI while building the sequencer tests asests.
Change 3894832 by Frank.Fella
Niagara - Level sequence support for spawning and animating system life cycle and select user parameter types.
#Tests Ran existing tests and added a new test to verify added functionality.
Change 3896944 by Bradut.Palas
safeguard entries with no search items (it actually can be null)
#tests none
Change 3896948 by Bradut.Palas
Fix assert when dereferencing source array (no need for a raw pointer to the array since it's initialized with the content anyway)
#tests none
Change 3896950 by Bradut.Palas
fix compile error with previous commit
#tests none
Change 3897698 by Frank.Fella
Niagara - Fix some safety issues with parameter initialization on the niagara component.
+ Kill the current system if we synchronize parameters to avoid issues with data interface lifetime.
+ Always sync parameters when the asset is set to prevent missing data interfaces in the override list.
+ Add an enum to control how data interface parameters are handled when calling CopyParametersTo.
+ When the system instance is copying the asset parameters, have it copy data interfaces by reference so that it's not creating data interfaces copies which will be deleted at the next garbage collection.
#Tests Auto-tests, also doesn't crash anymore when opeining Jonathan's disolve effect and then opening a level.
Change 3897953 by Frank.Fella
Niagara - Remove some namespace restrictions from the code that generates the available parameters to read from in the stack UI since it was preventing the use of custom namespaces in modules and it was not clear what issue it was solving since we already prevent scripts from addressing parameters from lower level scripts. Also move user parameters to their own menu section.
#Tests Custom namespaces are usable again in the stack.
Change 3898926 by Bradut.Palas
Fix for crash caused by garbage collection and async search
#jira UE-55284 (Stack search doesn't work on collapsed entries) now searching through unfiltered children, will need extra fixes on the stack to eliminate "ghost" results"
Both are still under code review, submitting because they are simple to rollback and harmless to other features.
#tests none
Change 3899069 by Shaun.Kime
Parallel compilation
Major changes:
Rather than a custom streaming version that we know influences a rebuild, I'm moving away to a guid that you need to regenerate if you change the compiler in any meaningful way
needed for multiple reasons,
1) if two people are making changes to the compiler, having something other than a guid as the value makes the content of the ddc ambiguous
2) when iterating I often need to make multiple changes to get to a working final result, bumping the version number each time that happens gets old fast
We fully clone the input graph to do the compile in the background. While the translation step is not a huge amount of time, it keeps the main thread responsive.
We currently have a big critsec around the crosscompiler to bytecode as it isn't threadsafe. Future changes will push this to the ShaderCompilerWorker.
#tests all tests pass as well as stress tests around saving while compilng, long compile times, etc.
Change 3899071 by Shaun.Kime
Fixing the availability flags for system and emitter scripts.
#tests all auto tests pass
Change 3899077 by Shaun.Kime
Fixing assets to have their wait on compile finished checkbox checked in the editor for testing
#tests n/a
Change 3899114 by Wyeth.Johnson
Random bool custom hlsl node
Change 3899184 by Bradut.Palas
implemented categories for module inputs (now inputs can be assigned a category in the module editor and they will be grouped by those categories in the Niagara stack)
#tests none
Change 3899329 by Bradut.Palas
fix broken commit by adding missing new files NiagaraStackInputCategory.cpp and .h
#tests none
Change 3899439 by Yannick.Lange
Niagara reroute node.
Change 3899516 by Shaun.Kime
Official angle conversion modules.
#tests made a local test emitter that converted back and forth between angles. Results were correct.
Change 3900193 by Shaun.Kime
Fixing build
#tests now compiles
Change 3900474 by Shaun.Kime
Fixes to help Mac compile
#tests n/a
Change 3901131 by Simon.Tovey
Warmup feature.
CPU Sim only.
Also has ability to advance simulation by tick count or seconds via BP/C++.
Includes some engine tests.
#tests editor + autotests
Change 3901455 by Frank.Fella
Niagara - Add WITH_EDITORONLY_DATA to prevent non-editor compile failures.
Change 3902477 by Frank.Fella
Niagara - Fix FNiagaraEditorTypeUtilities to be a thread safe TSharedFromThis since it's always created with a thread safe shared pointer, also fix up issues related to this change. Fixes a crash which occurrs when it's the target object of a delegate binding.
#Tests adding a curve data interface to a parameter collection no longer crashes.
#jira UE-55403
Change 3903478 by Shaun.Kime
No longer doing the check if compiling on load is enabled as this always forces different change ids'
#tests n/a
Change 3903783 by Shaun.Kime
Trimming down excess log spew
#tests auto-tests pass
Change 3905753 by Shaun.Kime
Made Sine(Degrees), Sine(Radians), and Sine, and the variants thereof for trig functions.
#tests n/a
Change 3905759 by Shaun.Kime
Auto tests for mesh orientation
#tests these now pass
Change 3905762 by Shaun.Kime
These files needed to be resaved for some reason to keep passing.
Change 3906727 by Bradut.Palas
Curve UX improvements
#jira UE-55134
#tests none
Change 3908177 by Shaun.Kime
Fixing build due to typo
#tests now compiles
Change 3908199 by Shaun.Kime
Trying to fix compilation when destroying objects. We cannot safely attach anything beneath us at this point ,we just need to clear out the queues.
#tests normal work day-to-day
Change 3908201 by Shaun.Kime
Working to fix crashes where the component was destroyed out from underneath us due to PIE shutting down and we have a Niagara item editable in Blueprint or world editor.
#tests n/a
Change 3908985 by Bradut.Palas
Renaming ColorCurveAsset to CurveAsset to better reflect the actual usage of the variable (fixing copy-paste issue)
#tests none
Change 3909222 by Yannick.Lange
Niagara graph connection colors
Change 3909436 by Bradut.Palas
fix crash in curve ux when importing a linear curve (curve of floats)
#tests none
Change 3909561 by Bradut.Palas
Updating LUT before sending NotifyPostChange when editing curves inline (so that LUT will not go out of sync)
#tests none
Change 3910010 by Yannick.Lange
Use new Niagara Actor icon
Change 3910191 by Yannick.Lange
Fix viewport widget showing up in the viewport when pressing W, E or R.
#jira UE-55142
Change 3910213 by Frank.Fella
PropertyEditor - PropertyRowGenerator - Added features and fixes to support integration into niagara's stack view.
+ Added a method to get filter/search strings for an IDetailTreeNode to support external searching and filtering.
+ Added a delegate to the layout builder for when one of it's owned nodes has it's visibility forcibly changed by a customization.
+ Changed the filtering so nodes are generated for properties marked as advanced.
+ Pass the notify hook down to the detail utilities so that change notifications work as expected.
+ Add layout data for the widgets returned from the IDetailTreeNode to prevent alignment and sizing issues in custom implementations.
Change 3910307 by Frank.Fella
PropertyEditor - Missed in last checkin.
Change 3910509 by Frank.Fella
Niagara - Removed nested details panels from the stack and integrate them properly plus other fixes.
+ Generate rows for nested objects using the details panel property row generator.
+ Fix the horizontal sizing for niagara parameter editors.
+ Add an IsValid() method to the base niagara stack entry so that derived classes can know if the associated view models are still valid when processing events. This is a temporary measure to fix a crash in the user parameter UI.
+ Set stack entries to be expandable by default and delete usages which were setting it to true.
+ Highlight the active search result with a border since property rows can't highlight text.
Change 3911653 by Frank.Fella
Niagara - Fix stack spacer sizing.
Change 3911667 by Frank.Fella
PropertyEditor - Actually fix the notify hook handling in the property row generator.
Change 3911896 by Yannick.Lange
Niagara function input context menu.
Change 3911900 by Yannick.Lange
Project setting for not showing comment bubbles.
Change 3911996 by Yannick.Lange
Niagara fix if node persistent guids for older nodes. The OutputVarGuids are always synced on PostLoad.
Change 3912221 by Wyeth.Johnson
Renderer Icons for timeline
Change 3912608 by Bradut.Palas
stack style refactor
#jira UE-55399
#tests none
Change 3913063 by Wyeth.Johnson
Icons for stack added, including new system param png
Change 3913618 by Shaun.Kime
Fixing two of the most common Illegal call to StaticFindObject() errors while compiling.
#tests ran through compilation after changes.
Change 3914369 by Bradut.Palas
Using new SystemParams.png icon provided by Wyett (instead of the old "Parameters.png")
#tests none
Change 3914782 by Wyeth.Johnson
Adjusting icon for update to not indicate "flow"
Change 3915738 by Shaun.Kime
Moving away from the generic and super-slow EdGraphSchema ShouldAlwaysPurgeOnModification being true to using the same mechanism we use to invalidate the compile to synchronize nodes. This should be substantially faster.
#jira UE-55463
#tests ran through a variety of tests creating and wiring nodes
Change 3915739 by Shaun.Kime
Assignment nodes need to invalidate the graph for compile.
Change 3915741 by Shaun.Kime
Making default values more accessible and making it possible to route renderers to use different values than the defaults.
#tests n/a
Change 3915798 by Frank.Fella
SearchBox - Add options to show the number of search results and an option to show a throbber when a search is active.
Change 3915966 by Shaun.Kime
Changing the default for velocity to 0,0,0 as requested by Wyeth
#tests n/a
Change 3915982 by Shaun.Kime
Making the default text more readable
#tests n/a
Change 3916237 by Frank.Fella
PropertyEditor - Change the DetailCategoryBuilderImpl so that it sets the horizontal alignment to fill for value widgets when generating stand alone widgets so that the behavior in the property row generator matches the behavior of the property grid.
Change 3916240 by Frank.Fella
Niagara - Should prevent some recent crashes due to stack entry delegates and lifetime.
Change 3916261 by Frank.Fella
Niagara - Lots of minor stack ui fixes and adjustments
+ Tweaked padding in a bunch of different places.
+ Added a dark background behind the stack and stack header to prevent the colors from bleeding together.
+ Fixed the group text not being white anymore.
+ Hooked up new features of the search box for showing the search result data and an is searching throbber.
+ Fixed an issue where the current search result couldn't be interacted with.
+ Fix some other inconsistencies with searching where you might jump more than one result.
+ Replace the checkbox for showing curve in the curves tab with an icon based button. (icon is placeholder)
Change 3916833 by Shaun.Kime
Fixing issue where the system wasn't set to wait for compilation on load, sometimes leading to failures for auto-tests
#tests this test now passes when forced to recompile
Change 3916846 by Shaun.Kime
Missed one system in the scene.
#tests n/a
Change 3917458 by Shaun.Kime
Fixing another potential race condition on the DDC.
#tests n/a
Change 3918349 by Frank.Fella
Niagara - Invalidate the node visuals when reallocating pins.
#Jira UE-55698
Change 3918783 by Olaf.Piesche
Correct 'temp' to 'Temp' in map set
Change 3919262 by Shaun.Kime
We weren't properly updating the default values for user data interface components when tweaked in the editor.
#tests open skinned mesh auto test system change the preview for the user skinned mesh to be SK_Mannequin_Niagara. It now updates, it didn't before.
Change 3919602 by Shaun.Kime
Fixing the skeletal mesh to now clamp to the end of the index buffer for safety as well as adding IsValidTriCood. This lets us keep going even when swapping out the skeletal mesh underneath.
Tested out isvalidtricoord in the test skinning module.
#tests auto tests pass
#codereivew simon.tovey
Change 3921701 by Yannick.Lange
Make Vector2 and Vector4 default blue color to be consistent with blueprints.
Change 3922331 by Damien.Pernuit
Niagara - Houdini - Added support of CSV File as UAsset (HoudiniCSV)
Modified the Data Interface to use the CSV asset instead of the imported buffers from the CSV File Path.
Added some new functions to the DI:
GetLastParticleIndexAtTime()
GetCSVPositionAndTime()
GetCSVVectorValue()
GetCSVFloatValueByString()
Change 3923118 by Simon.Tovey
PS4 compile fix.
Change 3924934 by Bradut.Palas
fix Mac compile issues
#jira UE-55426
#tests none
Change 3925168 by Bradut.Palas
Curve logspamming
#jira UE-55593
#tests none
The UpdateCompiledDataInterfaces would end up comparing LUTs when copying curves and the source LUT was out of date.
Change 3925366 by Frank.Fella
Slate - SMenuAnchor - Fix the implementation of "BelowRightAnchor" to align the right edge of the menu with the right edge of the anchor. There aren't any other usages of this in the engine as far as I can tell, hopefully people weren't relying on the broken behavior in a game somwhere.
Change 3925423 by Frank.Fella
Niagara - Remove the large add buttons from the stack and add smaller add buttons in the group headers.
Change 3925877 by Olaf.Piesche
New collision modules, separating query, linear and angular impulse; Solve forces and velocity takes care of integrating f->v->p and fA->vA->O; linear impulse module would probably be cleaner by zeroing velocity on collision and calculating a force instead of setting new velocity directly
Change 3926582 by Simon.Tovey
PS4 compile fix
Change 3927401 by Shaun.Kime
Fixing events due to added member
#tests all tests pass as of 3925423 with this change
Change 3927496 by Shaun.Kime
Getting auto-tests to run
Questions: Why did I have to recompile the GPU tests... something is missing in their key generation?
Resaved several files.
#tests almost all pass now
Change 3927582 by Shaun.Kime
Fixing last failing auto test
#tests all tests now pass
Change 3927924 by Simon.Tovey
Chunk level vm parallelism.
Any execution processing > batch_size chunks will go wide.
The batch size is 4 currently but adjsutable via vm.ParallelChunksPerBatch.
VM parallelism can be disabled by vm.Parallel 0
Change 3927990 by Shaun.Kime
Submitting redirector
Change 3928426 by Frank.Fella
Niagara - Always propagate rapid iterations parameters when merging an emitter.
Change 3929823 by Frank.Fella
Niagara - Fix hlsl generation for system/emitter spawn script so that we read the engine and user parameters from the data set instead of initializing them to 0.
#Tests Full recompile + auto-tests
Change 3929983 by Simon.Tovey
Curve LUT Interpolation
+ updated test altered by it.
Change 3930551 by Frank.Fella
Niagara - Fix what looks like a copy/paste error in the SNiagaraSelectedEmitterGraph destructor which was preventing clean removal of delegates and causing a crash.
#Tests closing the "Selected Emitter Graph" tab and then changing the selected emitter no longer crashes.
Change 3932695 by Damien.Pernuit
Niagara - Houdini:
Houdini CSV Asset:
- Packed vector values in the CSV file are now properly supported (not just for Position/Normal) and can be of any size.
- Added support for reimporting Houdini CSV files.
- Added an "open in text editor" entry in the context menu.
- Improved error/warning logging during the parsing of the file
Houdini Niagara Data Interface:
- Added GetParticleIndexesToSpawnAtTime():
New helper functions returning the min index, max index and number of particles to be spawned for a given time value.
Uses an internal LastSpawnIndex to avoid spawning the same particles twice.
- Modified GetLastParticleIndexAtTime():
If the CSV file doesn't have time informations, returns false and set the LastIndex to the last particle
If desiredTime is smaller than the first particle, LastIndex will be set to -1
If desiredTime is higher than the last particle in the csv file, LastIndex will be set to the last particle's index
Change 3933425 by Shaun.Kime
Made the spreadsheet debugger capable of capturing in-world systems as long as they are solo'ed.
#tests have been running with it for several days, debugging real-world assets stably
Change 3933986 by Frank.Fella
Niagara - Fixed a bug with merging where added dynamic inputs which changed names could end up with the wrong rapid iteration parameters. Also fixed an issue where added dynamnic inputs would be renamed when they didn't need to be.
#Tests Engine tests and fixes custom repro.
Change 3934052 by Frank.Fella
Niagara - Added a console command to dump rapid iteration parameters for a system or emitter asset.
Change 3934436 by Simon.Tovey
Fixes for sprite VF depth test failure issue
Change 3934658 by Frank.Fella
Niagara - Make disabled modules visually distinct.
#Tests General stack use.
Change 3935383 by Shaun.Kime
Fixing mac compile errors
#tests n/a
#jira UE-55911
Change 3935420 by Yannick.Lange
Niagara parameter UI first version.
Change 3935482 by Yannick.Lange
Add missing files for parameters
Change 3935591 by Shaun.Kime
more macos compile
#tests na
Change 3935637 by Shaun.Kime
Reverting to prior behavior
#tests na
Change 3936541 by Yannick.Lange
Remove the merge up menu entry for set variables module items.
Change 3936841 by Wyeth.Johnson
Bool comparison dynamic input
Change 3936895 by Simon.Tovey
A few perf improvements and fixes to the SetSolo transfering between solo and batched so all lightning sims can run batched after they're warmded up.
Change 3936899 by Simon.Tovey
Missed a file
Change 3937178 by Krzysztof.Narkowicz
Fixed bHasSkipOutputVelocityParameter for shaders without PreviousLocalToWorldMatrix (e.g. particles)
#jira UE-50914
Change 3937222 by Yannick.Lange
Random event spawn
Change 3937292 by Yannick.Lange
Fix Adding a new parameter then renaming it the default name deletes the new parameter
#jira UE-55994
Change 3938472 by Yannick.Lange
Fix new parameters in emitters saving by using the editable emitter.
Change 3938474 by Yannick.Lange
- Store graphs as weak object pointers in the parameter UI.
- Allow right mouse menu on parameters in the system toolkit.
- Refresh only the parameter actions when deleting an entry instead of refreshing the graphs aswell.
Change 3938525 by Yannick.Lange
Fix creating an unique FName every tick for parameterstores by using a FString instead.
Change 3938596 by Shaun.Kime
Macos compile
#tests n/a
Change 3939362 by jonathan.lindquist
Adding a new Component Spacing input to the debug value functions. This will allow users to make better use of space when debugging values.
Change 3939365 by Shaun.Kime
Back out changelist 3936895 and 3936899
Leaving in some changes around stats as they should be harmless.
These changes were removed b/c they added poor perf to Jonathan's dissolve effect and also caused multiple tests to fail in engine tests.
#tests all tests pass besides Yannick's FName/FString warning, with the exception of BPTimeControl, Hypnotizer, and MeshOrientation, which seem to be off by one frame, but have been consistently off for several days (CL 3929823 had same issues for me)
Change 3939367 by jonathan.lindquist
Adding greyscale output
Change 3939368 by jonathan.lindquist
Changing the pin order
Change 3939377 by Shaun.Kime
Allows the unnormalized lut table flag to be copied over
#tests all tests pass besides Yannick's FName/FString warning, with the exception of BPTimeControl, Hypnotizer, and MeshOrientation, which seem to be off by one frame, but have been consistently off for several days (CL 3929823 had same issues for me)
Change 3939379 by Yannick.Lange
Rename FParameterStore Name to DebugName to prevent loading a FName into a FString with existing assets.
Change 3939382 by Shaun.Kime
Adding the ability to have a default curve index with a custom switch node.
#tests all tests pass besides Yannick's FName/FString warning, with the exception of BPTimeControl, Hypnotizer, and MeshOrientation, which seem to be off by one frame, but have been consistently off for several days (CL 3929823 had same issues for me)
Change 3939383 by Shaun.Kime
Converting existing curves over to using the new default pin
#tests all tests pass besides Yannick's FName/FString warning, with the exception of BPTimeControl, Hypnotizer, and MeshOrientation, which seem to be off by one frame, but have been consistently off for several days (CL 3929823 had same issues for me)
Change 3939501 by Shaun.Kime
Submitting missing files
#tests n/a
Change 3939580 by Wyeth.Johnson
Default curve indexing to three more DIs
Change 3940122 by Yannick.Lange
Parameters view: - Jump to new parameter added and request rename for new parameter.
- Remove adding parameters to the parameterstore when a pin is requested.
- Only show make new parameters in the dropdown to add a new parameter.
- Use Sections of UI as types instead of int32.
Change 3940214 by Bradut.Palas
fix crash when rename skeletal mesh user variable
#jira UE-55236
#tests none
Change 3940215 by Bradut.Palas
undo not working in graph editor
#jira UE-55466
#tests none
Overriding the BreakPinLinks methods to include a transaction
Change 3940250 by Bradut.Palas
Creating stats tab in module toolkit to show LastOpCount
#tests none
Change 3940251 by Bradut.Palas
#jira UE-55684 create inline menus for stack
#tests none
Change 3940262 by Simon.Tovey
Back out changelist 3939365 with fixes
Tests all now pass
Change 3940333 by Shaun.Kime
Nullptr check
#tests n/a
Change 3940338 by Krzysztof.Narkowicz
Niagara sprite particles - implemented get previous position in order to fix sprite particle motion vectors
#jira UE-52865
Change 3940407 by Yannick.Lange
Create pin on map get and set node when dragging without recompiling the graph.
Change 3940534 by Shaun.Kime
Making sure that collision returns defaults of 0 if nothing was found.
#tests auto-tests that have been passing still pass
Change 3940709 by Simon.Tovey
Temp hacks for the skeletal mesh painting issues.
Change 3940960 by Yannick.Lange
Only build parameter menu once when graphchanged is called multiple times in a frame.
Also use the existing metadata from graph to build the parameter menu, because the metadata already looped through all nodes and pins.
Change 3941019 by Yannick.Lange
Meta data UI refresh next tick to avoid refreshing multiple times a tick.
Change 3941853 by Simon.Tovey
Adding more dynamic parameters
Change 3941957 by Frank.Fella
Property Editor - Fix issues with property row generator to support the niagara stack.
+ Make the detail tree node name accessible through the interface, and fix the implementations for category group and property item.
+ Add a temporary fix for passing instance customizations from the property row generator to the detail property row through the detail layout builder. This should be unified in a nicer way, but this will work for the time being.
Change 3942174 by Frank.Fella
Niagara - Stack UI Pass
+ Advanced rows are not handled properly per item.
+ Expanded and scroll state is now saved in editor data per asset.
+ Added a "View Options" drop down for showing all advanced rows, and for showing/hiding outputs.
+ Added an option to collapse all stack items from the emitter header context menu.
+ Added support for "Edit Conditions" on module and dymaic inputs which will enable and disabled an input based on the value of another input. This includes showing a checlbox inline for the edit condition toggle input.
+ Added support for "Visible Conditions" on module and dynamic inputs which will hide and show inputs based on the value of another input.
+ Removed the pencil icon for locally editable values in the stack.
+ Fixed issues with invisible search results. It's still possible for a search result to not highlight the text correctly, but the outline never disappears.
+ Removed pinning for module inputs.
+ Fixed the event handler properties so that they use the property row generator instead of an embedded details panel.
+ Unified indent handling across all stack classes.
+ Unified stack editor data across all stack classes.
Change 3942427 by Simon.Tovey
Another hack for vertex painting tool
Change 3942453 by Simon.Tovey
Some more hacks for skel mesh vertex painting until Jurre's rework is ready.
Change 3942799 by Yannick.Lange
Rebuild metadata, input and output parameters UI next frame instead of on every graph changed call.
Change 3942833 by Frank.Fella
Niagara - Fix the visibility of the advanced expander item.
Change 3942923 by Yannick.Lange
Revert using metadata for parameters to looping through pins to find parameters in maps not connected to anything.
Temporary fix to remove used parameters if they are found in the graph.
Change 3943094 by Wyeth.Johnson
Rollback //UE4/Dev-Niagara/Engine/Plugins/FX/Niagara/Content/Modules/Spawn/Location/SphereLocation.uasset to revision 5
Change 3943154 by Wyeth.Johnson
Metadata to sphere location module
Change 3943256 by Wyeth.Johnson
Testing out sweet new metadata control
Change 3943374 by Olaf.Piesche
Fixing mesh motion blur
Change 3943382 by Olaf.Piesche
Turning on base pass velocities until I can fix separate vel pass for particles
Change 3943471 by Yannick.Lange
Emitter view stats only show particles count. Use Niagara.EmitterStatsFormat 0 and 1 to switch between all data and only particle count. Default is 1 to only show particle count.
Change 3943497 by Yannick.Lange
Paramater map remove FTickableEditorObject and use SWidget::Tick
Change 3943589 by Olaf.Piesche
-Fix for linear impulse (offset by 1/2*velocity*dt instead to avoid distracting bounciness)
-Collision Rest; add after impulse modules to make particles rest if in collision under threshold velocity magnitude
Change 3943644 by Olaf.Piesche
Turn shader development mode back off
Change 3943718 by Olaf.Piesche
Fix vertex factories
Change 3943776 by Olaf.Piesche
Properly calculate old particle position using dt for velocity rendering
Change 3943780 by Frank.Fella
Niagara - Fix ensure when removing dynamic inputs due to incorrect logic which would have left unused nodes in the graph.
Change 3943870 by Yannick.Lange
Parameter drag drop window
Change 3943994 by Frank.Fella
Niagara - Fix some editor settings not saving across sessions.
Change 3944056 by Shaun.Kime
Updating to replace values reset when Wyeth resaved files.
#tests DrawOrderGPU, DrawOrder, and TestDifferentInactiveEmitters now pass
Change 3944068 by Simon.Tovey
Back out of my changes to vertex painting and replaced with Jurre's fixes.
Change 3944174 by Frank.Fella
Niagara - Fix stack categories so that they don't freak out when the stack is refreshed, and also remove the uncategorized heading and move uncategorized inputs to the top.
Change 3944313 by Shaun.Kime
Updated screenshots after motion blur
Change 3944321 by Shaun.Kime
Fixing error message to be clearer about a disconnected Get node.
#tests n/a
Change 3944351 by Shaun.Kime
Making safe against weak pointers going away.
Track error encountered by Jonathan.
#tests n/a
Change 3944368 by Yannick.Lange
Remove automatic adding prefix "particles." when renaming functioninput.
Change 3944383 by Shaun.Kime
Just adding some more nullptr check
#tests n/a
Change 3944384 by Shaun.Kime
Providing more context for a check that existed previosuly and was encountered by Wyeth today
#tests n/a
Change 3944872 by Yannick.Lange
Remove old material parameter node.
Change 3945209 by Shaun.Kime
Fixing possible infinite recurson on child array size of zero
#tests n/a
Change 3945865 by Yannick.Lange
Spreadsheet filter for output attributes
Change 3946091 by Simon.Tovey
Per particle sorting for translucent sprites and meshes
Change 3946095 by Simon.Tovey
Updated screens for dynamic param tests
Change 3946378 by Olaf.Piesche
Another sprite motion blur fix
Change 3946864 by Shaun.Kime
SkinnedMesh per-instance data requires 16 byte alignment due to usage of FMatrix. We were not guaranteeing that in our per-instance data system. We are now enforcing that to be true by aligning all memory size requests.
#tests autotests pass
Change 3946928 by Wyeth.Johnson
Skeletal mesh location metadata. THIS VERSION ALSO CRASHES ON SAVE FYI
Change 3946934 by Frank.Fella
Niagara - Clean up rapid iteration parameters on compile.
#Tests - Fixes the jira below, all auto tests which were currently passing still pass, and GDC effects load and look correct.
#jira UE-55932
Change 3946936 by Frank.Fella
Niagara - Fix crash when undoing adding a dynami input.
Change 3947213 by Simon.Tovey
Fix for thread safety in collision data interface.
Previously I'd made them thread safe between VM chunks but they already weren't safe between system instances.
Change 3947279 by Simon.Tovey
Fixed thread safety issue with niagara global dynamic buffer
Change 3947788 by Simon.Tovey
Fix enum property warnings
Change 3947849 by Olaf.Piesche
Normalize orientation quats. Safety first.
Change 3947877 by Frank.Fella
Niagara - Fix a crash when editing meta-data for a module currently open in a system or emitter editor stack. This updates the FNiagaraStackFunctionInputBinder to track the lifetime of the default pin correctly.
Change 3948445 by jonathan.lindquist
Inverting alpha output
Change 3948615 by Olaf.Piesche
Don't access data layouts that are invalid because their bindings don't exist
Change 3949361 by Yannick.Lange
Command to expand all groups and collapse all items of those groups in the stack.
Change 3949365 by Yannick.Lange
Missing file for change 3949361
Change 3951123 by Simon.Tovey
Fix bug with dynamic parameters in Niagara mesh particle VFs
Change 3951199 by Simon.Tovey
Fix for issues caused by unsafe reads of GT data from RT
Change 3951293 by Olaf.Piesche
Workaround for jittering particles with collision at rest state; will need to revisit after GDC
Change 3951533 by Yannick.Lange
Collapse parameter menu by default
Change 3952106 by Frank.Fella
Niagara - Fix data interface input initialization when inserting modules and dynamic inputs. We now put all inputs into categories in the stack and this code didn't handle that.
Change 3954809 by Frank.Fella
HoudiniNiagara - Add include to fix CIS incremental build.
Change 3954857 by Frank.Fella
Niagara - Accept newer versions of 3 automated tests images as they are stable and still look correct for what they are testing.
Change 3954935 by Frank.Fella
Niagara - Fix a crash in the skeletal mesh sampling info details customization when a mesh has no skeleton.
Change 3954969 by Simon.Tovey
Compile fix for gpu emitters
Change 3955012 by Frank.Fella
Niagara - Fix clang and deprecation warnings.
Change 3955988 by Olaf.Piesche
Fixing collision queries (separating line query trace direction and velocity, so we can look a frame ahead properly); various fixes to the impulse modules; rest module now allows for color change when particles are set to rest. This checkin should stabilize collision dynamics substantially.
Change 3956730 by Yannick.Lange
Cleanup parameter
Change 3957065 by Bradut.Palas
enable/disable mechanism for renderers
#tests none
Change 3957802 by Olaf.Piesche
-Removing Velocity parameter from collision query DI, since velocity at query time is known and can just be passed along in temporary parameter; this stops the compiler from falling over in unity builds and also makes the Perform Query function more sane as an actual line check
-Put some safeguarding against non-collisions (v.n>0) reported as intersections into the collision query module to avoid instances of particles being pushed through geometry
-Updated modules to use the new function signature
#tests modular explosion test map, EngineTests
Change 3957804 by Olaf.Piesche
Updated tests for 3957802
Change 3957859 by Frank.Fella
Niagara - Add missing #if to fix some of the nightly build errors.
Change 3958065 by Olaf.Piesche
Fix GPU sim hlsl for the collision data interface; should make GPU collision bounce test run again
Change 3958302 by Olaf.Piesche
modified test for sane depth bounds; accepting new results; some changes to hlsl for collision data interface
Change 3959007 by Simon.Tovey
Further defining the barrier between GT and RT data.
Not finished yet, especially for GPU sims but we're heading in the right direction.
Change 3960004 by Bradut.Palas
QOL change, now committing search text in the stack (pressing enter) will jump to the next occurrence.
#tests none
Change 3960019 by Frank.Fella
Niagara - Preemptively fix up stack related header includes to avoid manual merges.
Change 3964217 by Bradut.Palas
Fixing compile issue after renderer enable feature(the Isolate features require the WITH_EDITORONLY_DATA preprocessor directive to be enabled)
#tests none
Change 3964581 by Frank.Fella
Niagara - Get things compiling again after merge. Mostly include fixes and commeting out lots of sequencer related stuff that needs to be fixed.
Change 3965057 by Frank.Fella
Niagara - Fix compile issues in the houdini plugin. Also add the houdini pluging to EngineTest so that it compiles by default when running tests.
Change 3965075 by Frank.Fella
Niagara - Fix another include issue that was caught on the build machine.
Change 3965308 by Frank.Fella
Niagara - One more header fix. Should fix the win64 build in CIS.
Change 3965313 by Frank.Fella
Niagara - Fix in editor playback. The timeline data is still broken.
Change 3965482 by Yannick.Lange
Stack source taken apart into different files.
Change 3965863 by Shaun.Kime
Fixes scope level variable definition causing my local build to fail
#tests n/a
Change 3965866 by Shaun.Kime
Crash fix when the module is missing. Now show an error message as well as checking for script validity before calling method on it
#tests n/a
Change 3968174 by Frank.Fella
Niagara - Fix more merge fallout. The emitter/system editor timeline now matches the stack data again.
Change 3968183 by Frank.Fella
Niagara - Delete commented out include from merge.
Change 3972162 by Frank.Fella
Niagara - Updated level sequence testing assets.
Change 3972880 by Shaun.Kime
Merging using DevNiagaraToGDC2018
Allowing disabled modules to still influence parameter maps.
#tests n/a
Change 3973269 by Shaun.Kime
Disabling warning about divide by zero as it is often incorrect
#tests n/a
Change 3973273 by Shaun.Kime
Forcing all three planes to be GPU
#tests n/a
Change 3973307 by Shaun.Kime
Fixing CIS win32 errors
#tests n/a
Change 3973374 by Shaun.Kime
Fixing minor static analysis warnings
#tests n/a
Change 3976107 by Shaun.Kime
Updating multiple files as they have the unversioned file warning
#tests auto tests now show green
Change 3976114 by Shaun.Kime
Taking snapshots after the integration for time control to clear automated tests. Frank was uncertain about the current behavior being correct, but didn't want to hold up integration for that.
#jira UE-57117
Change 3976119 by Shaun.Kime
Makiing GPU shaders contain the dependencies and the compile id's and other items so that they update properly.
#tests auto-tests now pass
Change 3976449 by Shaun.Kime
Adding additional debugging to logs
#tests n/a
Change 3977172 by Frank.Fella
Niagara - Fix issues with the level sequence integration for niagara caused by the integration from main, and accept the new test image. This code should be updated at some point to use the new channel blending in sequencer.
NOTE: There is still a timing issue that is evident in the automated test screen shot due to float timing and rounding issues in niagara, but the sequencer code is functioning correctly.
Change 3977362 by Bradut.Palas
UE-55601 curve snapping not working in Niagara curve editor
#tests none
Change 3977363 by Bradut.Palas
exposed added external asset for function input so it would appear in context menu in the Niagara stack.
#tests none
Change 3977368 by Bradut.Palas
#jira UE-51052 If you undo an emitter rename we get invalid values
The CachedUsageInfo got emptied but it didn't get restored by the undo, sending the system in an endless Compile() loop
Added a Modify() call in the UNiagaraScriptSource::InvalidateCachedCompileIds()
#tests none
Change 3978716 by Shaun.Kime
Fixing half of CIS static analysis warnings and localization symbol dupe warnings from Jamie Dale
#tests auto tests pass other than known level sequence test
Change 3978857 by Shaun.Kime
The map SpawnTest niagara actor didn't have its wait for compilation flag set, potentially leading to artifacts. Disabling for now as that didn't resolve the issue.
Change 3979594 by Shaun.Kime
Potential fix for cook on Orion
#tests n/a
Change 3979713 by Shaun.Kime
Fixing several more CIS static analysis warnings as well as duplicate localization string warnings from Jamie Dale
#tests n/a
Change 3980017 by Shaun.Kime
Fixing CIS static analysis warnings as well as duplicate localization string warnings from Jamie Dale
#tests n/a
Change 3981859 by Shaun.Kime
Fixing crash in Paragon when the normals buffer was not present during startup with just UI screens.
#jira UE-57188
#tests got through to paragon main screen, related auto-tests pass
Change 3982685 by Shaun.Kime
For some reason, when Lightmass is spinning off workers, the render thread is null, causing us to trigger checks that we shouldn't trigger when killing of system instances.
#jira UE-57214
#tests all auto-tests pass
Change 3983902 by Simon.Tovey
Speculative fixes for mac errors regarding niagara vertex decls.
Change 3984023 by Andrew.Rodham
Sequencer: No longer upgrade bIsInfinite for section types that do not support open ranges
Change 3986727 by Wyeth.Johnson
Fixed add velocity from point to work in more situations, not cause errors regardless of stack location, made it more programmable with inputs, and added metadata
Change 3988114 by Wyeth.Johnson
fixed color and inherit parent vel
Change 3989175 by Simon.Tovey
Improved VM error reporting.
#tests engine tests
Change 3995007 by Yannick.Lange
Parameter menu in system layout
Change 3995192 by Yannick.Lange
Fix niagara script details panel search
Change 3995291 by Yannick.Lange
Parameter menu tooltip fix
Change 3997804 by shaun.kime
Lookup table is off for this. Keys are 0,0 and 1,1, so you'd expect normalized age as a sampler to just return the same value from lookup. If LUT is disabled, this is true. If LUT is enabled, it isn't, especially the farther one gets from 0.
Change 3998124 by Simon.Tovey
Fixed Curve LUT generation
#tests editor
#jira UE-57604
Change 3998286 by Wyeth.Johnson
Fixed normalized execution index to, you know, work.
Change 4000324 by Shaun.Kime
Replacing a thread-safety issue where we get an enum on an as-needed basis. This was causing crashes in cooking as you cannot find from the global table while serializing.
#tests have not gotten the crash since
Change 4000428 by Bradut.Palas
UE-55750 focus curve editor when "show" button is pressed
UE-55791 user variable curves cannot be shown in the Curve tab
These issues were related and touched the same area of code, so I fixed them together. UE-55791 is basically just getting curve data from the system exposed variables too.
#tests none
Change 4001094 by Frank.Fella
Niagara - Fix slowdown in the metadata editor due to delegate rebinding.
Change 4001098 by Frank.Fella
Niagara - Remove the tool tip from the additional options drop-down for modules since it covers the drop down menu.
Change 4001133 by Bradut.Palas
Fix curve editor getting focused each time a curve was changed.
#jira UE-57708
#tests none
Change 4001253 by Frank.Fella
PropertyEditor - Fix issues with external root handling.
+ Fix external nodes not being cleaned up correctly when custom node builders rebuild children.
+ Fix expanded state being trampled when processing external nodes due to the expanded nodes list being emptied every time RestoreExpandedItems was called.
+ Fix performance issues with refreshing during tick by moving all calls to RestoreExpandedItems to UpdateFilteredDetails, and then only calling UpdateFilteredDetails once per tick as needed instead of per root property node and per root external node.
Change 4003365 by Shaun.Kime
If the physical material has gone away, make sure to set value values. Note that if this data interface is going to go on in parallel to the game thread, we'll need something more sophisticated.
#tests Win64 tests pass
Change 4003367 by Shaun.Kime
Making sure that the system has finished compiling before we begin cooking.
#tests n/a
Change 4003374 by Frank.Fella
Niagara - Fix a crash when adding and removing modules and dynamic inputs with data interfaces.
#jira UE-57749
Change 4003696 by Shaun.Kime
Getting rid of whitelist, now open on all platforms.
#tests n/a
Change 4005368 by Shaun.Kime
Fixing compile error on Linux
#tests n/a
Change 4013779 by Shaun.Kime
Interpolated spawn on GPU does not yet work but checkpointing work.
+ Added AdditionalDefines to the VMCompileId, switched interpoalted spawn to use that
+ Added rough interpolated spawn support to translator by refactoring away from specific calls and hard-coded update/spawn somewhat... could improve for events
+ Revised shader variables away from Phase0/Phase1 terminology to the true Update/Spawn meaning. Leaving the phase numbers as an implementation detail within the usf.
+ Added ToString to ParameterStores for debugging
+ Changed GPU ExecIndex() logic to actually work similar to the VM
#tests collision gpu fails
Change 4015355 by Simon.Tovey
Persistent IDs final.
Still need to change the compile ID parts over to use the new additional defines but the core functionality is in.
#tests editor + engine tests
Change 4018445 by Simon.Tovey
Some missing assets
Change 4021647 by shaun.kime
Moving jonathan's DebugParticleData to Niagara Extras
Change 4024809 by Yannick.Lange
Parameter map hover text using metadata description.
Change 4025042 by Wyeth.Johnson
Dogfooding the skeletal Mesh location module w/ comments, reroute pins, map gets and sets, metadata, tooltips, etc.
Change 4025236 by Shaun.Kime
Working on getting interpolated spawning working. Submitting to get assistance from Simon.
... PLEASE DON'T SYNC UNLESS YOU'VE SPOKEN TO ME...
#tests collision test on GPU is better, but not yet right.. ribbon id emitter is ensuring on LUT table generation
Change 4025372 by Shaun.Kime
Making the debug particle data stay the same size as the base particle for easier debugging.
#tests n/a
Change 4025701 by Shaun.Kime
Debug asset for Simon
#tests n/a
Change 4027865 by Shaun.Kime
Fixing parameter map stores to properly handle reset. Previously was leaving around padding info from previous version of the script which could be totally wrong.
#tests now don't crash
Change 4029638 by Wyeth.Johnson
Refactor Skeletal mesh location module to test some ideas on coding standards and shake out workflow issues
Change 4030135 by Shaun.Kime
Interpolated spawning now works on the GPU.
#tests collision gpu has stray collisions and the GenerateLocationEvent was recently updated that broke . will fix in a later update
Change 4030197 by Wyeth.Johnson
Refactor static mesh location module
Change 4033437 by Simon.Tovey
Adding a few simple new functions for direct access to vertex positions for cannabis.cod3r.
Change 4033937 by Shaun.Kime
Setting the wait for compilation flag
#tests now pass consistently
Change 4034391 by Shaun.Kime
Created a parameter map default node to start default call chains.Updated standard modules and dynamic inputs.
#tests all previoulsy passing tests pass
Change 4035002 by Shaun.Kime
Updated to work with latest main integration
#tests n/a
Change 4035523 by Wyeth.Johnson
Refactor Cone stuff to coding standards, replace some things with functions
Change 4035672 by Shaun.Kime
Fixing build warnings
#tests n/a
Change 4036887 by Wyeth.Johnson
Some metadata, some optimization, some additional refactoring and swapping in functions. Straight Dogfoodin'
Change 4037132 by Shaun.Kime
Adding GPU test versions of several assets
Change 4037241 by Wyeth.Johnson
Optimizing, metadata, and making some coding standards changes
Change 4037436 by Wyeth.Johnson
Fixing a pointless module to make it... pointful?
Change 4037629 by Frank.Fella
Niagara - Fix issues with data interfaces as parameters
+ Collect data interface reads and writes from parameter maps during compilation so they can be hooked up a runtime.
+ Add new runtime parameter stores for systems and emitters at runtime which bind the exposed data interfaces into the execution contexts.
+ Fix the editor code which updates the compiled data interfaces so that it updates the correct ones regardless of where they are defined.
+ Fix an issue where failed compiles weren't being propgated to the UI correctly.
Change 4037832 by Shaun.Kime
Properly handling nullptr references
#tests deleting a module from the stack after it was recently refreshed now doesn't crash
Change 4037917 by Wyeth.Johnson
Fix add velocity from point (needed begin defaults), reorg, comment and metadata
Change 4038250 by Wyeth.Johnson
Big refactor of spawn per unit
Change 4038665 by Shaun.Kime
Events now take parameter map in/out pins
#tests now the events auto-tests should pass
Change 4038723 by Shaun.Kime
Now renderers can say if they are compatible with the SimTarget mode.
#tests now changing to GPU doesn't crash a light renderer
Change 4038731 by Shaun.Kime
Missing file from prior checkin
#tests n/a
Change 4038742 by Shaun.Kime
Attempting to fix editor build, which is unfortunately fine on my machine
#tests n/a
Change 4040069 by Wyeth.Johnson
Refactor of Event Generator and Event Receiver, new coding standards for events
Change 4040377 by Wyeth.Johnson
Refactor the solver to adhere to coding standards (and remove some reroute pins, sorry Shaun)
Change 4040639 by Wyeth.Johnson
Vector Noise Force refactor and optimization
Change 4041031 by Shaun.Kime
Making the modulo functions on the gpu return a value.
#tests passes cook on PS4 and gets past this in compile on Mac
Change 4041254 by Wyeth.Johnson
Refactor Point Attraction, change some behavior also
Change 4041999 by Yannick.Lange
Parameters refactor:
- Find parameters and references in graph
- Renaming parameters, includes renaming all pins in the graph
- Removing parameters
- Find metadata when finding parameters, so we are not looping through all nodes/pins twice
- Parameters list supports multiple emitters in systems
Change 4042058 by Simon.Tovey
Refactored GPU parameters.
- Shader now uses the DI default object to create the correct parameters struct.
All parameter and buffer management now being handled inside this parameter struct.
This allows far more encapsulated code for each DI.
Allows us to reamove the GPU buffers from and the Scene texture refs that were in the base DataInterface class.
Simplifies the API and process of implementing DI's on the GPU considerably.
- Removed all existing GPU buffer support code and usage. All DIs now use a parameters struct.
- Have moved tons of curve code into the base class, simplifying the child implementation classes.
- Implemented GPU curve interpolation.
- Removed bAllowUnnormalizedLUT. Confusing and now unnessessary. All curves do this by default.
- Modified FNiagaraShaderMapId to use the latest FNiagaraCustomVersion::LatestScriptCompileVersion and bumped it.
- Created NiagaraCore module and moved a few classes into it. Anything needed by both the shaders and runtime should be here.
- Refactored DI hierarchy to base from a new UNiagaraDataInterfaceBase which is inside NiagaraCore.
- Removed constness from many UStruct/UEnum/UClass pointers. Technically we don't ever need these to be non const so initialy coded as const. Some existing engine code however requires these be non const so had to propagate that back through our code.
Change 4043427 by jonathan.lindquist
Submitting a material function that will allow users to reproduce mesh surfaces.
Change 4043448 by Olaf.Piesche
Async GPU buffer readbacks and updates
Change 4043679 by Shaun.Kime
Fixing Mac compile issue. Not sure if correct, but unused code so good for now.
#tests n/a
Change 4044000 by Simon.Tovey
static analysis fix
Change 4044001 by Simon.Tovey
Fix for gpu scripts with multiple curves.
Change 4044124 by Yannick.Lange
Fix persistent guid for parameter map set pins.
Change 4044230 by Simon.Tovey
I didn't forget to check these in. Nothing to see here.... *whistling*....
Change 4044584 by Bradut.Palas
Module dependency properties are now available (to be used by technical artists before the functionality is done and submitted)
#jira UE-58200
#tests none
Change 4044663 by Wyeth.Johnson
Jitter position needed begin defaults, got a refactor which I was in there
Change 4044894 by Yannick.Lange
Rename parameter and all referenced pin when renaming a pin on a map set or get.
Also fixes renaming a pin not deleting the old metadata.
Change 4045383 by Wyeth.Johnson
Fix up and comment/tooltip on mesh rotation, look at, and rot rate
Change 4045488 by Wyeth.Johnson
Update Age reorg just for readability
Change 4045799 by Shaun.Kime
Reworking test art to get rid of known issues and put known issues into their own assets.
Change 4046328 by Wyeth.Johnson
Some optimizations, options to polar/cartesian, starting in on Dynamic Inputs
Change 4046728 by Shaun.Kime
Fixed error where we were writing to Loca.Module.EventVelocity instead of Local.Module.EventVelocity.
Change 4047423 by Frank.Fella
Niagara - Fix post load code for the assignment node which was not conditionally post loading another object it was using which now has a custom post load. This resulted in strange pin renaming which was breaking merging and automated tests.
Change 4047425 by Frank.Fella
Niagara - Make the merge manager a little more resistant to malformed stacks.
Change 4047788 by Bradut.Palas
#jira UE-57902 Module input sort priority
#tests none
Change 4048063 by Yannick.Lange
Fix don't show context menu on parameter view categories.
#jira UE-57196
Change 4048068 by Yannick.Lange
Fix create system from emitter
#jira UE-57186
Change 4048132 by Yannick.Lange
Add missing includes.
Change 4048269 by Shaun.Kime
Removing ensure that we log later
#tests n/a
Change 4048273 by Shaun.Kime
Really doing it this time
#tests n/a
Change 4048595 by Yannick.Lange
Fix niagara if node input disconnect on output pin rename.
#jira UE-58095
Change 4049640 by Simon.Tovey
Daft mistake in curve hlsl gen.
Change 4050270 by jonathan.lindquist
Submitting a module that lerps each of a particle system's intrinsic particle values. Each variable set utilizes an opt-in bool.
Change 4050282 by jonathan.lindquist
Submitting newly formated Mesh Reproduction modules. They now contain documentation, be fully generalized and meet our updated coding standards.
Change 4050566 by Olaf.Piesche
-More fixes and changes for async gpu buffer readback
-removed more CPU intervention; spawning and death now happen largely without CPU direction, other than determining the number of particles to spawn
-Added piping number of vert indices per instance from the renderer down to the GPU context and CS; as a result, GPU simulated mesh emitters are working again; this will need a bit of additional work to handle multiple renderers (will need multiple DrawIndirect parameter buffers reflecting the different renderers)
-General cleanup and prettification
Change 4050907 by Frank.Fella
Niagara - Add support for default dynamic inputs on modules and dynamic inputs.
Change 4051436 by Simon.Tovey
Forcing a refresh of curve LUTs on assets with old versions.
Change 4051463 by Simon.Tovey
Compile fix
Change 4051900 by Frank.Fella
Niagara - Fix linux warning.
Change 4052253 by Olaf.Piesche
GPU sim interpolated spawn fixes - Look Ma, no gaps!
Change 4052321 by Frank.Fella
Niagara - Enable the level sequence test.
Change 4052353 by Shaun.Kime
Renamed variable after Wyeth's change
#tests MeshOrientationTests now pass
Change 4052627 by jonathan.lindquist
Submitting a new spline function.
Change 4052648 by Shaun.Kime
PS4 development builds don't seem to be able to remove generated data for structs like this even though it is in a non-editor build.
#tests n/a
Change 4052661 by Olaf.Piesche
-Avoid branching on every OutputData operation by allocating a scratch instance at the buffer end and setting the default index from AcquireIndex to that.
-bit of shader code cleanup
Change 4052706 by jonathan.lindquist
Adding a module that supports a single segment spline
Change 4052712 by jonathan.lindquist
Adding a below threshold output to the direction and length safe function
Change 4052786 by jonathan.lindquist
Submitting a new height lerp function
Change 4053126 by jonathan.lindquist
Submiting a function that calculates a triangle's surface area.
Change 4053132 by jonathan.lindquist
Changing the category to geometry
Change 4053141 by jonathan.lindquist
Moving the asset back to a generic math category
Change 4053166 by jonathan.lindquist
Submitting a new threshold function that removes threshold downtime.
Change 4053564 by Shaun.Kime
Added staging to ini as requested by cook
#tests n/a
Change 4053619 by Shaun.Kime
Fixing defaults
#tests used by Orion art
Change 4054171 by Yannick.Lange
Remove bold font for parameters.
Change 4054183 by Yannick.Lange
Syncing system exposed parameters and parameters list. Includes adding, removing and renaming parameters.
Change 4054313 by Wyeth.Johnson
Refactor spawnrate to (mostly, other than a bug) conform to coding standards, and set begin defaults on a few things.
Change 4054840 by Shaun.Kime
Fixing redundant branch for CI
#tests n/a
Change 4055492 by Shaun.Kime
Updating compile version since I changed the usf
#tests n/a
Change 4055550 by Shaun.Kime
Disabling rendering of middle module as it differs between machines.
#tests LevelSequenceTestsNiagara now passes
Change 4056256 by Shaun.Kime
Disabling the ensure and turning into log statements for curve copying
#tests n/a
Change 4056287 by Shaun.Kime
Now using GLobalCompileShader. There are still issues with cooking as there is sometimes a runtime streaming error that we didn't read in the correct amount of data. I think the logic for when/if we stream out the compiled shader might still need TLC.
#tests n/a
Change 4056381 by jonathan.lindquist
A new quat to angle axis and angle axis to quat conversion mat function
Change 4056513 by Frank.Fella
Niagara - Fix crashes for default data interfaces where the pin default was empty or the data interface wasn't initialized.
#jira UE-58789
Change 4056734 by Frank.Fella
Niagara - Drag and drop for modules.
Change 4056880 by Simon.Tovey
Replacing engine tests shots for RibbonID test.
Some slight changes introduced, likely curve or recent module changes.
Change 4056894 by Bradut.Palas
UNiagaraStackEntry Error refactoring + Module dependency warning feature.
#jira UE-58199, UE-58200
#tests none
Change 4056916 by Bradut.Palas
Add missing files from shelved changelist.
#tests none
Change 4056937 by Bradut.Palas
#jira UE-54678 The skeletal mesh customisation did not update when the mesh was changed through the data interface or mesh editor
#tests none
Change 4057014 by Frank.Fella
Niagara - Fix cis initializer order warning.
Change 4057542 by Bradut.Palas
#jira UE-58554 Remove Refresh UI button from Niagara script editor
#jira UE-58555 Remove Numeric Output Type Selection Mode from Niagara script UI
#tests none
Change 4057702 by Bradut.Palas
The stack editor priority in the variable metadata now properly has zero as default value.
#jira UE-58740
Change 4057758 by Frank.Fella
Niagara - Fix text wrapping for error items.
Change 4057990 by Bradut.Palas
Stack error tweaks (added error count to the stack errors button and also updating icon according to highest severity issue in the subtree)
#tests none
Change 4057996 by Shaun.Kime
Trying to fix the static analysis header tool error in CIS
#tests n/a
Change 4058027 by Shaun.Kime
Fixing compilation on other platforms
#tests compiles on playstation
Change 4058356 by Frank.Fella
Niagara - Fix an assert that happens when adding a module or dynamic input with a boolean or enum input.
Change 4058428 by Frank.Fella
Niagara - Fix a crash when removing an input from a set variables node in the stack which was caused by the function losing an input without the stack being refreshed. This also fixes an issue where add and remove actions on a set variables module wouldn't take affect until the graph was compiled.
Change 4059924 by Wyeth.Johnson
Rollback //UE4/Dev-Niagara/Engine/Plugins/FX/Niagara/Content/Modules/Spawn/Velocity/AddVelocity.uasset to revision 5
Change 4060256 by Wyeth.Johnson
Forces are now dependent on a solver
Change 4060430 by Wyeth.Johnson
Velocity modules depend on a solver
Change 4060949 by Shaun.Kime
Fixing pragma once definition as well as a possible null deref
#tests n/a
Change 4060955 by Shaun.Kime
Fixing due to changes in defaults
#tests all now pass PC
Change 4061000 by jonathan.lindquist
Debug particle material improvements which includes comments in the shader, rearranged layout with a vector 2 input for particle id, new texture, a new instance that includes "focus masking"
Change 4061804 by Wyeth.Johnson
Optimized out a couple unnecessary bits of math from some axis alignment stuff, solver dependencies
Change 4061974 by Simon.Tovey
Fixed GPU cooking.
- Removing check for emitter SimTarget in CanBeRunOnGpu() and relying only on the script usage having been loaded already.
We can't rely on properties in the emitter being loaded before the call to UNiagaraScript::PostLoad() so this is unsafe.
- Adding some dummy gpu buffers to bypass validation ensures in rhi when we need to set params for SRVs that have not been allocated yet.
- Fixed bug in RHI that was returning FGPUFenceRHIParamRef and so the created fence was immediately freed and boom.
Change 4062269 by Shaun.Kime
Re-enabling most of the tests.
#test n/a
Change 4062414 by tim.gautier
QAGame: Updated QA-Effects for mobile compatibility
- Removed Atmospheric Fog (not supported on Mobile)
- Added SkySphere (resolved lighting issues)
Change 4062651 by Shaun.Kime
Saving with versions
Change 4062673 by Shaun.Kime
Making emitter names without spaces so that they can be blacklisted if need be
Change 4062686 by Shaun.Kime
Getting ready for CI for 4.20
Change 4062687 by Shaun.Kime
Updating mac images
Change 4063298 by Shaun.Kime
Disabling collision test gpu for now. Need to investigate what broke it tomorrow.
#tests CollisionBounceGPU
Change 4063373 by Shaun.Kime
Blacklisting mac tests that still need work
Change 4063434 by Shaun.Kime
Cleaning out previous debug code
#tests n/a
Change 4063618 by Yannick.Lange
Fix dragging an input pin to the add pin of an if node
#jira UE-58600
Change 4063847 by Frank.Fella
Niagara - Rename RibbonSortKey to RibbonLinkOrder, change it from an int32 to a float, and disable uv age offset when using link order instead of normalized age to order particles in the ribbon. This should fix the issues preventing beams from being implemented nicely.
#tests Auto-tests
Change 4064150 by tim.gautier
QAGame: Removing floating NewWidgetBP from /Content
Change 4064237 by Shaun.Kime
Disabling the level sequence test for now
Change 4064902 by Shaun.Kime
Fixing compile errors on linux editor build
#jira UE-58620
#tests n/a
Change 4065167 by tim.gautier
QAGame: Submitting temporary update to TM-ShaderModels, adding Niagara station
Change 4065400 by tim.gautier
QAGame: Submitting updated (temp) TM-ShaderModels. Set NewNiagaraEmitter to Local Space by default
Change 4065540 by Frank.Fella
Niagara - Temporarily disable the module dependencies until they can be fixed.
Change 4065570 by Shaun.Kime
Fixing linux build
#tests n/a
#jira UE-58979
Change 4066753 by Shaun.Kime
Updating custom version after previous change to shader includes
#tests autotests pass
Change 4067981 by Frank.Fella
Niagara - Fix potential null dereference found by CIS
#jira UE-59013
Change 4067998 by Shaun.Kime
Nullpointer checks on shutdown
#jira UE-59000
Change 4068104 by Frank.Fella
Niagara - Change the prefix for the previous parameter values from PREV__ to PREV_ since the cross compiler reserves all symbols with double underscores for opengl.
Change 4068118 by Frank.Fella
Niagara - Fix an open GL crash where we weren't passing the correct buffer index when setting parameters for compute shaders.
Change 4069299 by Olaf.Piesche
Async GPU readback/update mobile platform fixes
CPU particles should work on Android
#jira UE-58986
Change 4069603 by Shaun.Kime
Making it possible to see the debug output if the console variables are set for shaders.
#tests auto-tests pass
Change 4069628 by Shaun.Kime
OpenGL is very picky about shutting down its texture buffers. We were improperly holding onto static resources and leaking OpenGLShaderResourceViews until module shutdown. Unfortunately, this is *after* the renderer has been shut down and the corresponding OpenGL managers have been deleted, causing us to call into deleted memory. By making several classes FRendererResources, we now register at the appropriate times. In several cases, since the buffers are special purpose fallbacks I moved them into helper locations that are build on demand.
Removed FNiagaraVertexFactoryBase::DummyBuffer
Created FNiagaraDummyRWBufferInt and FNiagaraDummyRWBufferFloat so that I could wrap several dummy RW buffers in RendererResources and TGlobalResource.
Removed NiagaraEmitterInstanceBatcher::DummyWriteIndexBuffer
#tests all auto-tests pass on PC and OpenGL and we can open and close OpenGL after using Niagara assets
#jira UE-59000
Change 4069646 by Shaun.Kime
Disabling Niagara component activation on Switch. This is an attempt to bypass a crash after the assets have been loaded on Switch.
#tests auto-tests on PC still pass
#jira UE-59048
Change 4069660 by Shaun.Kime
Updated Niagara version
#tests Auto tests pass
Change 4069714 by Shaun.Kime
Fixing Olaf's checkin prior adding offset to the base readback call
#tests autotests pc pass
Change 4070785 by Olaf.Piesche
Make RWBuffer available on Metal, Vulkan, and ES3.1 with SRVs
Change 4070888 by Olaf.Piesche
#jira UE-57657
Reenable ribbon custom facing mode
Change 4071570 by Shaun.Kime
Removing thread pool size log item as it comes up thousands of times in a cook and is purely for debugging.
#tests n/a
Change 4071926 by Shaun.Kime
Disabling Olaf's change from earlier in the day as it doesn't work on PS4.
#tests Ribbon test now works again
Change 4073700 by Shaun.Kime
Fixing compiler warning about float4 being used as a float.
#tests pc auto tests pass
#jira UE-59157
[CL 4075457 by Shaun Kime in Main branch]
#lockdown Nick.Penwarden
============================
MAJOR FEATURES & CHANGES
============================
Change 3870267 by Arne.Schober
DR - SafeRelease SRVs that might be hold by the Vertexfactories (maybe due to indirect use in GlobalResources)
Note that the VFs are not owners of the data, e.g the underlying Buffers might be released before this and this reference counting should be uneccessary
Change 3872507 by Arne.Schober
Back out changelist 3870267
Change 3988916 by Marcin.Undak
Quail/Linux compilation fix #rb none #codereview arciel.rekman
Change 4042277 by Rolando.Caloca
DR - Clear UBs between PSOs on D3D to help track down not setting resources
Change 4042297 by Arne.Schober
DR - Fix case where LPV requires SSAO to run but no GBuffer is available in formward mode. In this case we force the behaviour to use the simple AO (as ASyncAO pass)
#jira UE-42135
Change 4042404 by Jian.Ru
Fix a race condition when RT is disabled and then re-enabled
#jira
Change 4042437 by Richard.Wallis
Mac Localization - Mac now uses FUICommand and NSLOCTEXT to build main menu items. Don't fetch menu items using name since that could change. Lookup using ID's.
Note:
New CB function binding system in *FStartupApplicationToMacMenuBinder*. Added to simplify the existing and new CB function binding.
Update:
Application menu now also gets an update on runtime langauge changed event. Other menu's get updated anyway as per runloop updates.
#jira UE-49526
Change 4042602 by Guillaume.Abadie
Adds support for alpha channel in DOF.
Change 4042603 by Guillaume.Abadie
Gates global sampler behind SUPPORTS_INDEPENDENT_SAMPLERS for nicer error messsage on platform that do not support them.
Change 4042671 by Guillaume.Abadie
Massages DOF's shader code for HLSLCC.
Change 4042772 by Mark.Satterthwaite
Expose the MTLComputePipelineState's label string.
Change 4043013 by Juan.Canada
Fixed bounds of skeletal meshes could be inverted (min > max) with negative scaling. That was breaking occlusion tests in some scenes, creating flicking issues.
#jira UE-49290
Change 4043171 by Rolando.Caloca
DR - Workaround crash on hlslcc
Change 4043182 by Uriel.Doyon
Fixed skylight issues when using pre-exposure.
Improved IndirectIrradiance gbuffer encoding when using pre-exposure.
Change 4043452 by Mark.Satterthwaite
Extensively refactor the MetalRHI GPU profiling code. There is now a "MetalProfiler Start/Stop/Frames=X" in-game command that will spit out JSON files similar to the platform-agnostic TracingProfiler, but this displays the command-buffer encoding and execution which actually makes sense with Metal where we can't arbitrarily insert requests for time-stamps and breaking command-buffers/encoders is expensive.
Change 4044732 by Richard.Wallis
Fix for macOs restoring to fullscreen results in render with large black border. Also tested that is fix doesn't seem to re-introduce UE-51270 (CL 3696161). There appears to be an edge case that can cause the toogleFullScreen: method to not correctly expand window frame to the full screen size - we end up with a frame size of the previous setting. Forcing the correct values doesn't fix the issue - the only consistant fix seems to be to re-introduce the - (NSSize)window:(NSWindow *)window willUseFullScreenContentSize:(NSSize)proposedSize delegate method.
#jira UE-57549
Change 4044741 by Guillaume.Abadie
Fixes a couple of regressions in DOF when using temporal upsampling.
Change 4044753 by Guillaume.Abadie
Fixes a bug in WaveBroadcastIntrinsics.ush
Change 4045010 by Guillaume.Abadie
Creates TM-DepthOfField in QAGame to test DOF.
Change 4045417 by Jian.Ru
Prevent recursive flush
#jira
Change 4045923 by Mark.Satterthwaite
Further insulate private plugin usage within MetalRHI.
Change 4046006 by Mark.Satterthwaite
Simplify dependency on the private module and hope it now builds properly.
Change 4046612 by Mark.Satterthwaite
Apple A9 introduced support for baseVertex & baseInstance, earlier GPUs don't support it at all. The code was incorrectly compiling shaders assuming they did at given Metal shader standard versions. Instead we always compile mobile shaders assuming they don't support base index & vertex and for dektop shaders we now need an A9 or better GPU for it to work.
#jira UE-55234
Change 4047504 by Mark.Satterthwaite
Supress warnings about the missing module when not available or enabled. Also make it work on all Metal platforms.
Change 4048765 by Uriel.Doyon
Fixed compilation issue from CL 4048308
Change 4048776 by Guillaume.Abadie
Fixes a static pixel projection regressions in TAA caused by alpha channel support in DOF.
Change 4049059 by Mark.Satterthwaite
Thread names in the MetalProfiler output and don't load the private module when selecting a device as it isn't useful anymore.
Change 4050290 by Mark.Satterthwaite
Sort out the timebase for all the different Metal clocks when profiling - everything is now in microseconds and seems to line up! Need to rework all the other timing code similarly - but not in this commit.
Change 4050822 by Mark.Satterthwaite
Partial custom counter support - still has bugs.
Change 4051210 by Guillaume.Abadie
Dumps PermutationID of shader when shader compile worker crashes.
Change 4051652 by Guillaume.Abadie
Optimises DOF's reduce with wave broadcast instrinsics.
Change 4051839 by Mark.Satterthwaite
Tiny fix to changing custom counters.
Change 4052553 by Guillaume.Abadie
Implements GATHER_INPUT_LAYOUT_RGB_SEPARATE_COC to save texture bandwidth in gather pass.
Change 4052611 by Guillaume.Abadie
Fixes a crashes in light shaft.
Change 4052916 by Mark.Satterthwaite
Extend the Mac & iOS Frame-Pacer API to proivde the target output time and the intended duration so that the MetalProfiler can record the display V-Blank window.
Change 4053111 by Rolando.Caloca
DR - hlslcc - RequiresNegateDDY()
Change 4053402 by Mark.Satterthwaite
Add instrumentation for buffer & texture allocation and shader & pipeline compilation to MetalProfiler. Everything that I personally care to track should now be in place but the implementation details are grim so there's still plenty of room for improvement.
Change 4053454 by Mark.Satterthwaite
More attempts to allow the builders to compile for Mac in such a fashion that the private module's perfectly innocuous headers don't cause an error.
Change 4053765 by Guillaume.Abadie
Fixes a failure in DOFGather's ShouldCompilePermutation() caused by R11G11B10 change.
Change 4053911 by Marcus.Wassmer
Copying //Tasks/UE4/Dev-Rendering-RectLight@4053906 to Dev-Rendering (//UE4/Dev-Rendering)
Change 4053915 by Marcus.Wassmer
Attempt to fix what looks like some unity build rearrangement issue.
Change 4053916 by Marcus.Wassmer
Fix PS4 shader compile issues. Point seems to be a reserved keyword in PSSL
Change 4054642 by Rolando.Caloca
DR - Fix SCW not showing correct callstack/exception info on crashes
Change 4054661 by Mark.Satterthwaite
Make thre MetalBackend convert depth texture sampls to float4 from float to match the expected return type and fix compiler errors.
#jira UE-58670
Change 4054780 by Guillaume.Abadie
Cuts number of shader permutation for DOF's gather pass from 138 to 41.
Change 4054950 by Rolando.Caloca
DR - vk - Fix negated ddy
Change 4055019 by Guillaume.Abadie
Cuts number of shader permutation for tonemapper from ~2k to 64.
Change 4055144 by Guillaume.Abadie
Adds an ensure to catch when there is too many permutations on a global shader.
Change 4055240 by Krzysztof.Narkowicz
Checkboard subsurface fix for resolutions non divisible by 2. Align up subsurface prepare buffer, so downsampling always pickups correct pixel from the full-res buffer.
#jira FORT-79981
Change 4055323 by Rolando.Caloca
DR - Fix GLSL-based platforms
Change 4055387 by Guillaume.Abadie
Adds a point mirror between foreground and background bokeh to be phisically accurate.
Change 4055403 by Rolando.Caloca
DR - Fix uninitialized var causing crash
Change 4055709 by Guillaume.Abadie
Fixes a crash in SunTemple.
Change 4055771 by Guillaume.Abadie
Fixes DOF's reduce pass being compiled for SM4.
#jira UE-58714
Change 4055876 by Rolando.Caloca
DR - hlslcc - Fix crash during loop analysis on empty if() blocks
Change 4056026 by Rolando.Caloca
DR - Enable volumetric fog on Vulkan
Change 4056272 by Guillaume.Abadie
Exposes new DOF settings in post process settings.
Change 4056460 by Brian.Karis
Fix uniform buffer assert.
Change 4057151 by Guillaume.Abadie
Fixes a bug in DOF's temporal stability gathering pass.
Change 4057220 by Guillaume.Abadie
Cherry-picks and reworks experimental AO decal from GDC 2017's The Human Race demo.
AO decal are on purpose not supported with ASync AO, because the proper way location to do that would be right before whenever a pass use it, but is currently challenging to track down considering the screen space AO buffer is used a by a lot of different passes through the scene texture uniform buffer.
#jira UE-53997
Change 4057587 by Rolando.Caloca
DR - Enable Diaphgram DOF on Vulkan
Change 4058022 by Guillaume.Abadie
Exposes new DOF settings to UCineCameraComponent
Change 4058136 by Guillaume.Abadie
Replaces Circle DOF with Diaphragm DOF on supported platforms by default, with renderer settings to fallback.
Change 4058338 by Jostin.Bilyeu
Checking in new map for verifying Mobile rendering features in conjunction with TAAU
Change 4058352 by Matt.Collins
Wrapped NSString for lambda capture.
Change 4058500 by Rolando.Caloca
DR - Fix bad normals & tangents on GL mobile
#jira UE-57769
Change 4058723 by Rolando.Caloca
DR - vk - Split device pipeline cache off generic cache file
Change 4058782 by Mark.Satterthwaite
Rebuild Mac hlslcc for 4055876
Change 4058791 by Mark.Satterthwaite
Force MetalBackend to pick up new hlslcc.
Change 4058840 by Guillaume.Abadie
Fixes a bug in DOF's scalability setting groups
Change 4058928 by Daniel.Wright
Fixed dangling FSceneViewStateReference references getting created when scene capture reallocates its ViewStates array
Change 4059141 by Marcus.Wassmer
PR #3799: Fix for leak in BatchedLines (Contributed by DSDambuster)
Change 4059227 by Brian.Karis
Fix for simple forward
Change 4059269 by Marcus.Wassmer
Update test screenshots to account for minroughness changes from devrectlight
Change 4059478 by Mark.Satterthwaite
It looks like FMetalCompiledShaderCache was misusing FRWScopeLock in ways that I can't believe even compiled - it looks like it ended up creating and destroying the scope-lock as a temporary rather than treating it as a block-local variable.
#jira UE-58773
Change 4059870 by Guillaume.Abadie
Works arround an HLSLCC bug in DOF's recombine pass that was using a AtomicMax(asfloat(MyFloat)).
#jira UE-58850
Change 4060324 by Rolando.Caloca
DR - Very minor render pass
Change 4060328 by Rolando.Caloca
DR - vk - Fix crash when running with r.Vulkan.DelayAcquireBackBuffer=0
Change 4060461 by Jostin.Bilyeu
Updated test map for use during Mobile Rendering based testing. Map name TM-Mobile_TAAU
Change 4060698 by Marcus.Wassmer
Merging xbox compile fix
Change 4060930 by Marcus.Wassmer
Fix android compile
Change 4060971 by Mark.Satterthwaite
Some missing #defines to guard functions that require an external plugin.
#jira UE-58910
Change 4061104 by Guillaume.Abadie
Whitelists mobile tonemapper's high number of permutation in mean time it gets fixed by UE-58014.
#jira UE-58900
Change 4061364 by Jostin.Bilyeu
updated Test map TM-TAAU_Mobile to added lighting importance volume, reflection spheres etc.
Change 4061743 by Mark.Satterthwaite
Fix another build error for iOS.
#jira UE-58827
Change 4061753 by Arne.Schober
DR - Higher precision (16bit per channel) for RecomputeTangent and Skincache
#jira UE-58525
Change 4062236 by Mark.Satterthwaite
AppleTV doesn't appear to support the set*Bytes APIs in Metal.
#jira UE-58580
Change 4062320 by Guillaume.Abadie
Enables bokeh simulation on scattered bokeh on Epic post process settings.
Change 4062402 by Guillaume.Abadie
Phiscally animates the rotation of the bokeh as aperture changes.
Change 4062587 by Mark.Satterthwaite
Fix another Ocean compile error.
#jira N/A
Change 4062811 by Marcus.Wassmer
Only do newton iterations for area lights
Fixes a host of AMD-only bugs
Change 4063174 by Marcus.Wassmer
Workaround shipping build compile error for all clang platforms.
Change 4063760 by Guillaume.Abadie
Changes the default number of diaphragm blades to 7.
Change 4063992 by Marcus.Wassmer
Fix DX12 crash when depthboundstest not available.
Change 4064233 by Rolando.Caloca
DR - Proper fix for GL changes related to tangents
#jira UE-58948
Change 4064323 by Uriel.Doyon
Increase the max number of uavs to 16
#jira 58898
Change 4064428 by Guillaume.Abadie
Fixes a crashes on XB1 when doing async SSAO.
Change 4064525 by Uriel.Doyon
Better logic for depth bound support in d3d12.
#jira 58956
Change 4064694 by Jian.Ru
Fix a bug in FMaterialBakingModule::ReadTextureOutput caused by uninitialized variables
Change 4064873 by Guillaume.Abadie
Fixes wrong resource transitions in DOF's reduce passes.
Change 4064956 by Guillaume.Abadie
Disables R11G11B10 optimisations on platforms that can't supports more than 8 UAVs.
Change 4065215 by Arne.Schober
DR - Make Clang Happy the standart says: "A variable or non-overloaded function whose name appears as a potentially-evaluated expression is odr-used unless it is an object that satisfies the requirements for appearing in a constant expression (5.19) and the lvalue-to-rvalue conversion (4.1) is immediately applied."
In English this means that when the reference is taken (or it is passed by reference) the pointers could be compared and therefore needed to be allocated.
Change 4065312 by Guillaume.Abadie
Fixes D3D12RHI doing a draw indexed indirect behind a DrawPrimitiveIndirect()
Change 4070361 by Guillaume.Abadie
Fixes resource transitions for PS4. PS4 RHI's logic to check for resource transition is still buggy.
Change 4070778 by Marcus.Wassmer
Fix bad merge
Change 4071337 by Rolando.Caloca
DR - vk - Do not spam log
Change 4048308 by Uriel.Doyon
Merging //UE4/Partner-MGPU to Dev-Rendering (//UE4/Dev-Rendering) at CL 4047519 :
- Fixed d3derror when resizing the window in multi-gpu.
- Fixed d3d12 checks when exiting in multi-gpu.
- Command context containter can now only be used with a single gpu mask. This cleans up passing the mask everywhere.
- RenderPass now reuse the current GPUMask instead of assuming the view mask. Decoupling furter more the binding.
- Removed of IRHIComputeContext::GetContextForGPUMask().
- Removed GPUMask from QueueRenderThreadCommandListSubmit and QueueCommandListSubmit since it is now a member of FRHICommandListBase.
- FRHICommandListBase::CopyContext() can not change anymore the GPUMask and the target list must have the same GPUMask as the reference one.
- Command lists now have a GPU mask set at creation time.
- Support for immediate command list GPU mask.
- Using the new SCOPED_GPU_MASK where we previously used a new command list on the stack.
- Refactored most NodeMask naming to GPUMask, and also "const FRHIGPUMask&" to "FRHIGPUMask".
- Commandline option "-mgpu" is now replaced by "-MaxGPUCount=" and "-PresentGPU="
- Multi-gpu modes are now controlled through -mgpumode={ gpu0, gpu1, broadcast, avr, afr }
- Defines WITH_SLI and WITH_MGPU now control the path to multi-gpu support in the engine.
- Variable GNumActiveGPUsForRendering is now split in GNumAlternateFrameRenderingGroups and GNumExplicitGPUsForRendering.
[CL 4072858 by Marcus Wassmer in Main branch]
#lockdown Nick.Penwarden
#rb none
============================
MAJOR FEATURES & CHANGES
============================
Change 3751378 by Ben.Woodhouse
Integrate from //UE4/Main/...@3748735 to //UE4/Dev-Console/...
Change 3807818 by Ben.Woodhouse
Integrate from //UE4/Main/...@3803271 to //UE4/Dev-Console/...
Change 3818577 by Ben.Woodhouse
Integrate from //UE4/Main/...@3812936 to //UE4/Dev-Console/...
Change 3726554 by Luke.Thatcher
[CONSOLE] [+] Improved Scoped Named Events
- Added SCOPED_NAMED_EVENT(_FSTRING/_TEXT/_F) macros to allow use of string literals, FString and printf in scoped named event strings.
- Replaced explicit use of FPlatformMisc::Begin/EndNamedEvent throughout the engine with macros, so the events can be compiled out.
- Fixed performance issues on various platforms with named events. SCOPED_NAMED_EVENT macros were not considering whether the platform uses wide or ansi char strings.
Change 3813513 by Ben.Woodhouse
CSV profiler refactor+ bug fix
- Move the CSV profiler to core, so we can use it in modules other than engine
- Profiler no longer enqueues RT commands - this is handled by a new core delegate type
- Make begin/end requests more robust, enqueued via a command queue and processed in order
- Defer end capture requests by a frame. This ensures stats on threads other than the gamethread (e.g. renderthread etc) are complete, so the last frame is not truncated
- Fix long-standing bug with multiple captures where old/stale frames would appear in the first <128 frames of captures
- Move unit stats and dynamic resolution out of the profiler itself and into the engine. Only frametime is recorded in the profiler now
- Fix longstanding bug in first frame renderthread time in the engine
Change 3814039 by Ben.Woodhouse
More Csvprofiler improvements
- Event support (via CSV_EVENT macros). These appear in the "EVENTS" column of the CSV and can be used to add context to the stat data
- Reduced memory overhead for timestamps through bit-packing (now 16 bytes per marker instead of 24), and splitting stats into different types
Change 3814229 by Ben.Woodhouse
Integrate + refactor of CL 3792591 to reduce complexity and fix bugs
Original changelist description:
CSV profiler improvements:
- The CSV profiler is now always compiled in on the server
- The CSV profiler can now handle both int32 and float stats
- In BeginCapture, the function can take additional arguments for some customization of filenames
Fixes to the above:
- Remove FCustomValue class
- Fixes bug where all timestamp values from CSV_SCOPED_STATs were garbage (due to issues resulting from FCustomValue type ambiguity when adding values together)
- FCsvCustomStat now just uses simple union + bitfield flag to reduce size and complexity (4 bytes instead of 8 per value)
- FCsvColumn class modified to use doubles, which can represent both ints and floats without loss of precision - this class is not memory or time critical
- Replace multiple overrides used by the server for filenameprefix/folder/postfix etc with a single FilenameOverride
Change 3817339 by Ben.Woodhouse
Duplicate from 3816641: CSV profiler improvements
- Added a low-pri processing thread to compress raw timing data into a much more efficient format
- Reduces memory usage for 15 minute 30k frame capture with GPU stats enabled from 110MB to 3.4MB
- Processing time : 0.1ms per frame
- Improved name handling for char literal stats. We now use the string as the ID rather than the pointer so multiple stat uses of the same name string apply only to a single stat
- Reworked thread data access to eliminate locking for anything time-critical. Frame boundaries now handled via a lock-free helper class
- Fixed bug with queue implementation where 1 in 128 reads would duplicate the last block of stat data
- Reduced #include dependencies for CSVProfiler.h
- Removed AccumulateMax because it doesn't work, and implementing properly would add a lot of complexity
- Added a simple test harness
Change 3827787 by Ben.Woodhouse
Integrate-as-edit CL 3820678 from Fortnite/Main
Allow the CSV Profiler to be compiled in to shipping dedicated server builds
Change 3827842 by Ben.Woodhouse
Integrate-as-edit CL 3827079 from Fortnite/Main
CSV profiler category support
Change 3840185 by Ben.Woodhouse
Integrate from //UE4/Release-4.19/...@3840005 to //UE4/Dev-Console/...
Change 3861618 by Ben.Woodhouse
Integrate from //UE4/Release-4.19/...@3860990 to //UE4/Dev-Console/...
Change 3901590 by Anthony.Bills
Fix incorrect srv and sampler count when an array of textures or an array of samplers is used.
- The code originally set the local variable BindCount but did not pass this to the total sampler or srv count and instead used the original BindDesc.BindCount (which will be 1) and still skipped over those resource indicies.
- The code also checked for the array's bracket location but then only compared the resource names before the bracket, meaning non arrays could be included.
Change 3904065 by Anthony.Bills
Allow easily increasing the maximum number of SRVs to 64 in the D3D12RHI.
- Increasing to 64 will fix shader compilation issues when using more than 32 textures.
- Casting has been added to correct the type on bitshifting the masks when the type changes.
- A new type has been added for the bound VB mask to make sure bitshifting is explicitly typed.
Change 3905752 by Ben.Woodhouse
Integrate from //UE4/Release-4.19/...@3904082 to //UE4/Dev-Console/...
Change 3920080 by Luke.Thatcher
[CONSOLE] [+] Added .natvis visualizer for FRHICommandList, which expands the list links to a flat list of commands. To use this, add an FRHICommandList* to your watch window.
Change 3951698 by Keith.Judge
Fix CIS (leftover debugging code)
#jira UE-55443
Change 3953261 by Luke.Thatcher
[CONSOLE] [^] Merging //UE4/Release-4.19 (CL 3944462) to Dev-Console (//UE4/Dev-Console)
Change 3971144 by Luke.Thatcher
[CONSOLE] [^] Merging //UE4/Dev-Main (CL 3964322) to Dev-Console (//UE4/Dev-Console)
- First merge since Dev-Console was reparented back to Dev-Main.
Change 3992843 by Anthony.Bills
Fix deploying to the default device in UAT.
Change 4010029 by Marcin.Undak
ShooterGame: use console UI on Quail platform
Change 4010030 by Marcin.Undak
RecordPerformance: don't fail if game crashes
Change 4012181 by Marcin.Undak
Implemented Low Level Memory tracker for Unix platforms
Change 4039094 by Ben.Woodhouse
[INTEGRATE] Integrate from //UE4/Main/...@4039044 to //UE4/Dev-Console/...
Change 4039598 by David.Harvey
adding LLM hooks for bespoke platform-specific memory tracking tools.
Change 4042637 by Arciel.Rekman
Merging //UE4/Dev-Main@4042226 to Dev-Console (//UE4/Dev-Console)
Change 4044679 by Marcin.Undak
RecordPerformance: store logs from runs
Change 4045895 by Marcin.Undak
Vulkan: added log when compiling new PSO
Change 4047096 by Ian.Fox
#ShooterGame - Potential fix for ShooterGame friendslist empty issue
#review-4046664
Change 4048332 by Marcin.Undak
Compilation fix for Oculus. Ported Rolando's change from Dev-Rendering
Change 4051609 by Marcin.Undak
Compilation fix
Change 4053542 by Joe.Barnes
Integrate as edit:
Faster Guid creation. Don't check time for every Guid (it's slow on some platforms). Check it once, then use that + CPU timer.
Change 4057462 by Luke.Thatcher
[CONSOLE] [-] Remove "frame rate smoothing" override on console.
- This was arbitrarily forced on when vsync is enabled.
- It can still be enabled via the bSmoothFrameRate in UEngine if needed.
(merge as edit CL 3891390 from //Fortnite/Release-3.0.0 to //UE4/Dev-Console)
Change 4057551 by Luke.Thatcher
[CONSOLE] [~] Improvements to game thread hitch detection.
- Allows the system to be configured by ini files.
- Fixes callstack addresses being truncated to 32 bits.
- Removes memory allocation in hitch callstack logging code. We use a pre-allocated 64KB buffer for this now. This was a memory leak anyway, as the memory was never freed.
- Performs a throwaway gamethread stack dump on launch, to prime the stack walker so we don't make gameplay hitches worse than they otherwise would be.
#jira FORT-78417
(merge as edit CL 3967234 from //Fortnite/Main to //UE4/Dev-Console)
Change 4057562 by Luke.Thatcher
[CONSOLE] [~] Increase verbosity on FlushAsyncLoading logging. Higher verbosity limited to once per frame, to avoid log spam.
#jira FORT-77411
(merge as edit CL 3967336 from //Fortnite/Release-3.4 to //UE4/Dev-Console)
Change 4057568 by Luke.Thatcher
[CONSOLE] [+] Add async load flush analytics stats.
#jira FORT-80229
(merge as edit CL 3986900 from //Fortnite/Release-3.5 to //UE4/Dev-Console)
Change 4057590 by Luke.Thatcher
[CONSOLE] [+] Add hang detector duration multiplier to allow extending the hang timeout on loading screens etc.
#jira FORT-80325
(merge as edit CL 3990275 from //Fortnite/Release-3.5 to //UE4/Dev-Console)
Change 4057679 by Luke.Thatcher
[CONSOLE] [WIN64] [~] Modify hitch detector stack walking to avoid expensive symbol lookups. Stack walk now only prints the return addresses without symbol information.
- Old behaviour of performing full symbol resolution can be achieved by defining LOOKUP_SYMBOLS_IN_HITCH_STACK_WALK to 1.
- Also fixed a minor bug in CaptureStackTraceHelper which duplicates the last line if stack walking fails.
#jira FORT-87620
(merge as edit CL 4049361 from //Fortnite/Release-4.1 to //UE4/Dev-Console)
Change 4057779 by Luke.Thatcher
[CONSOLE] [~] Refactored how the default LLM categories are defined.
- Prevents initialization order problems which stops early boot code from getting group name strings.
#jira FORT-80324
(partial merge as edit CL 4057155 from //Fortnite/Main to //UE4/Dev-Console)
Change 4059809 by Luke.Thatcher
[CONSOLE] [!] Fix compiler warning (incorrect order of member initializers in FGameThreadHitchHeartBeat)
Change 4060781 by Luke.Thatcher
[CONSOLE] [!] Fix for XGE control worker hanging around after killing the editor from Visual Studio.
- Reused the "XGE monitor" mode of shader compile worker, that the old XGE compiler used.
- The monitor watches the editor process and automatically terminates the build if the editor exits.
#jira UE-55864
Change 4063641 by David.Harvey
remove legacy "r.AmbientOcclusionSampleSetQuality" cvar from ini files (deleted in CL 2622264)... gets rid of warning in log.
#jira UE-51256
Change 4067367 by Ben.Woodhouse
Edigrate dev rendering CL 4062236:
AppleTV doesn't appear to support the set*Bytes APIs in Metal.
#jira UE-58580
Change 4067748 by Arciel.Rekman
Fix editor build (a plugin also needs private VulkanRHI headers, heh).
Change 4068121 by Arciel.Rekman
Correct paths to referenced directories for Linux.
- Should help CIS.
Change 4069919 by Arciel.Rekman
Fix Lumin build (another plugin needs private Vulkan headers, grrr).
[CL 4070552 by Luke Thatcher in Main branch]
#lockdown Nick.Penwarden
============================
MAJOR FEATURES & CHANGES
============================
Change 3873313 by Nick.Atamas
Merging CL 3834212 using //UE4/Dev-VR=>//Tasks/UE4/Dev-VR-4.19a
Merging CL 3805354, CL 3822769, CL 3827454, CL 3831789
//UE4/Partner-Google-VR/Engine/...
to //Tasks/UE4/Dev-VR-4.19a/Engine/...
Change 3873330 by Nick.Atamas
Merging CL 3835373 using //UE4/Dev-VR=>//Tasks/UE4/Dev-VR-4.19a
Merging CL 3777058
//UE4/Partner-Google-VR/Engine/...
to //Tasks/UE4/Dev-VR-4.19a/Engine/...
and fixing up QAARApp to work with latest ARCore changes.
Change 3873791 by Nick.Atamas
Merging //UE4/Dev-Main@3866324 to Dev-VR (//UE4/Dev-VR) to get missing files and fixing CIS.
Change 3933769 by Keli.Hlodversson
Remove unused IStereoRendering::GetCustomPresent
#jira UEVR-1083
Change 3935219 by Nick.Atamas
QAARApp re-write.
Change 3935664 by Mike.Beach
Oculus SI 1.23 changes
Change 3941505 by Joe.Graf
Made the send & recv buffer sizes for the BackChannel plugin configurable
Added send & recv counters for tracking the amount of transmission data
Change 3944003 by Joe.Graf
Added -buildscw to the CMake build command lines for editors to match what XCode is doing on Mac
Change 3945189 by Douglas.Copeland
Saving Material with Use w/ Static Lighting Flag set to resolve Engine warnings
Change 3945245 by Douglas.Copeland
Resaving QA_MeshTypes asset to resolve warnings produced by missing info
Change 3945266 by Douglas.Copeland
Updating TM-HMDNodes LevelBP WallofGets to use PxielDensity instead of ScreenPercentage. Resolving Engine warnings
Change 3947785 by Mike.Beach
Oculus changes to Android core count - only count usable cores not deadicated to the OS, etc.
Change 3951763 by Joe.Graf
Fixed thread ordering bug with remote session frame compression
Change 3952242 by Joe.Graf
Saved about 20-25% of the cpu time for compressing jpeg when performing the cpu swizzle
Change 3954571 by Keli.Hlodversson
* Add FXRRenderBridge base class containing common code from different CustomPresent implementations.
* Create a default implementation of UpdateViewportRHIBridge in FXRRenderTargetManager by adding GetActiveRenderBridge_GameThread.
** The default implementation now handles calling View->SetCustomPresent instead of making it up to the custom present (now XRRenderBridge) implementation (it already had to handle when the custom present was null.)
* Remove unused member variable ViewportRHI from RHICustomPresent.
#jira UEVR-1081
Change 3954572 by Keli.Hlodversson
* Apply XRRenderBridge and XRRenderTargetManager changes to the SteamVR plugin
* Move duplicated methods into an already existing BridgeBaseImpl class
#jira UEVR-592
Change 3954573 by Keli.Hlodversson
* Apply XRRenderBridge refactor to Oculus plugin
#jira UEVR-590
Change 3954575 by Keli.Hlodversson
* Apply XRRenderBridge refactor to OSVR
#jira UEVR-595
Change 3954578 by Keli.Hlodversson
* Apply XRRenderBridge refactor to GoogleVR
#jira UEVR-594
Change 3954596 by Keli.Hlodversson
Add file missing from cl#3954572
Change 3957882 by Jeff.Fisher
UEVR-1100 bLockToHmd false doesn't work correctly
-CameraComponent can now tell the LateUpdateManager to store, correctly buffered, the fact that we don't want to do late update this frame. DefaultXRCamera checks that flag before applying the late upate to the camera.
#jira UEVR-1100
#review-3956168
Change 3957945 by Jeff.Fisher
Fix for Oculus begin/end frame problem after XRRenderBridge refactor.
-The 'Frame' lifetime in the frame was not long enough, so it was null by the time GetActiveRenderBridge_GameThread was called. NextFrameToRender is the same value, but has a long enough lifetime.
#review-3957897
Change 3958760 by Dongsik.Seo
Adding UseCameraRotation feature to StereoPanorama plug-in.
To enable this feature, use console command
SP.UseCameraRotation 7
Simply add numbers to mark axis to use. 1 = Pitch, 2 = Yaw, 4 = Roll
7 means all axis (1+2+4)
#review-3958756 @Joe.Conley
Change 3959347 by Douglas.Copeland
Fixing spelling errors in test displays
Change 3964331 by Jason.Bestimt
Merging CL 3959979 from 4.19 to Dev-VR + uplugin change from CL 3954046
GoogleARCore Plugin fixes for Unreal 4.19.1 hotfix:
Fixed the crash in Acquire/Release UGoogleARCorePointCloud.
Fixed the issue that multiple line trace channel doesn't work correctly.
Fixed the issue the passthrough camera texture has blue and red channel swapped when building against gles 3.1
Fixed the issue that UGoogleARCorePointCloud::GetPoint doesn't return position in world space.
Change 3967485 by Ryan.Vance
Removed the exlude rect, we want to clear stencil on the entire surface.
Change 3968028 by Zak.Parrish
Nuking contents of existing FaceARSample, to be replaced by the one from Release-4.19.
Change 3968114 by Zak.Parrish
Adding in the new version of FaceARSample from Release-4.19 #rb none
Change 3978381 by Mike.Beach
Mirroring CL 3969503 from 4.19
Only triggering new Blueprint event, OnMotionControllerUpdated, from the game thread (causing a assert/crash when triggered from the render thread and the component has been destroyed on the main thread).
#jira UE-55445
Change 3981160 by Joe.Graf
Merged the BackChannel unit test fix over from Owl
Change 3981705 by Mike.Beach
[WIP] MR Calibration - Expose a config setting that will alter the tracking origin type used to calibrate (eye vs. floor).
#jira UE-55220
Change 3981898 by Joe.Graf
Added support for Apple hardware accelerated image conversion to JPEG, TIFF, PNG, and HEIF
Added a Blueprint latent action to perform the conversion in the background
Change 3981910 by Joe.Graf
WIP AR texture support so that other systems can interact with the camera data
Change 3982102 by Joe.Graf
Pull request: Update CMakefileGenerator.cs for CLion
Fixed an issue in the PR and added cleanup for the macro errors that result in FOO()= definitions
#jira: UE-57103
GitHub #4619
Change 3982883 by Joe.Graf
Added a CLionGenerator for consistency
Fixed editor preferred source code accessor parsing in the project file generator
Added code to detect the bad assumption of the project name always being UE4 and stripped that off in the CLionSourceCodeAccessor
#jira UE-54801
Change 3983687 by Joe.Graf
Fixed the lack of platform checks for adding a framework in the Apple image utils plugin causing a Switch compile error
Change 3984325 by Jeff.Fisher
UEVR-1141 PSVR - fix morpheus on pc render target scaling
-Hard coding the target size. Perhaps the old method broke with the pixel density change.
#review-3983261
Change 3984563 by Joe.Graf
Temporarily disabled ConvertToHEIF on Mac until the build machines are updated to XCode 9.3
Change 3985213 by Zak.Parrish
Removing a ton of excess art assets that were taking up lots of space and possibly throwing warnings. We weren't going to use them anyway. #rb none
Change 3985577 by Joe.Graf
WIP support for the Apple Vision API to perform computer vision tasks on images
Change 3985654 by Joe.Graf
Fixed missing forward declaration hidden by unity files
Change 3990596 by Mike.Beach
Adding a delegate for handling when the active XR system modifies the tracking space origin, and a API function for getting a transform between floor and eye space.
#jira UE-55220
Change 3990788 by Mike.Beach
Attempted CIS fix (fallout from CL 3990596)
Change 3990824 by Ryan.Vance
Re-submitting 4.19.1 hotfox 3968537
Change 3995804 by Jeff.Fisher
Merging cl 3995785
//UE4/Dev-VR-Seal/Engine/Source/...
to //UE4/Dev-VR/Engine/Source/...
UEVR-1148 bLockToHmd change breaking qagame entry level xr camera behavior
-Fixing late update when no camera component is in use.
-The camera component's bLockToHMD==false behavior is supposed to be that hmd motion is ignored, meaning we should not do a late update. This behavior is being applied TO the XRCamera system FROM the camera component, but the camera component can go away or be switched at any time. We want the default to be do apply hmd motion and late update, so disabling late update needs to be a positive setting applied each frame.
#review-3995764
Change 3999842 by Nick.Whiting
Exposing Apple ARKit function library as public for our buddies down under.
Change 4005541 by Joe.Graf
UE-57541 Blacklisted TVOS since it also defines PLATFORM_IOS as 1
#jira UE-57541
Change 4006308 by Jason.Bestimt
#DEV_VR - Hopeful fix for possible unity issue
Change 4006543 by Joe.Graf
Added code to be more correct on setting face blendshapes
Change 4007508 by Jason.Bestimt
#LUMIN - Adjusting automation tests.
- Moved QA specific content test into QA Game
- Wrapped controller not found to only happen on device
Change 4007515 by Jason.Bestimt
#LUMIN - Disabling privilege warning except on device
Change 4007552 by Jason.Bestimt
#LUMIN - Wrapping LuminTargetPlatform internals that require WITH_ENGINE
Change 4008585 by Joe.Graf
Added virtual curves for the head rotation information from the FaceAR's face tracking for streaming via LiveLink
#jira: UE-57830
Change 4008604 by Mike.Beach
MR - Making the chroma key material easier to customize & switch out. Updating the calibration to let you set whatever params you've exposed in the video processing material (removing hardcoded params for old chroma keying material).
#jira UEVR-1153
Change 4009396 by Jason.Bestimt
#DEV-VR - Removing warning about stat on different threads (CL 4009124)
Change 4009514 by Joe.Graf
Added a weighted moving average method to the modify curve anim node
Change 4010125 by Jason.Bestimt
#DEV-VR - Integrating 0.12 changes from Dev-VR-Seal to Dev-VR
Change 4010434 by Jason.Bestimt
#DEV-VR - Fix for Lumin Haptic Test include
Change 4010945 by Jeff.Fisher
QAHapticTests build fix
-removed unused bad include
Change 4011002 by Nick.Atamas
Fixed Android compilation.
Change 4011220 by Nick.Atamas
- Adding visualization for boundary polygons.
- Adding support for vertical planes.
Change 4011298 by Mike.Beach
MR - Revamping the VideoProcessing/ChromaKeying material so that it:
1) Better extracts luminance from the image
2) Utilizes despill to remove chroma bleed from the scene
3) Leverages the generated despill mask to add back in a faux bounce
#jira UEVR-1153
Change 4011858 by Keli.Hlodversson
Move ExecuteOn(RHI|Render)Thread from Oculus plugin into XRThreadUtils.{h|cpp} inside the HMD module
Use TFunction and TFunctionRef instead of std::function as arguments. (Depends on the changes in CL#3987166: Allow overloading of functions which take TFunctions or TFunctionRefs with mutually exclusive signatures.)
-- Ref for methods that guarantee the function has been invoked before returning, TFunction for *_NoWait, as the function may not get execured until later when RHI is in a separate thtread and not bypassed.
#jira UE-57380
Change 4011956 by Keli.Hlodversson
Fix missing includes after CL#4011858
Change 4012096 by Joe.Graf
Disabled building AppleVision on Mac until there's a good solution for older Mac OSes
Change 4012294 by Jason.Bestimt
#DEV-VR - Adding dependency on LuminRuntimeSettings to MagicLeap module. Hopefully, this will fix the generated files not being found
Change 4012390 by Jason.Bestimt
#DEV-VR - Misc fixes for static code analysis issues
- Guards around GEngine usage
- Fix from Rolando for uint32 -> uint64 + shifting warning
- Redundant if checks
Change 4013426 by Jason.Bestimt
#DEV-VR - Guarding RestoreBaseProfile so we don't crash on exit
#JIRA: UE-57960
Change 4014661 by Ryan.Vance
Initial support for omni-directional stereo captures.
https://developers.google.com/vr/jump/rendering-ods-content.pdf
Change 4015561 by Jason.Bestimt
#DEV-VR - Moving MLSDK out of thirdparty directory to fix static code analysis issue
Change 4016202 by Jason.Bestimt
#DEV-VR - Integrated CL 2685 from Seal depot
#JIRA: UEVR-1157
Change 4016448 by Jason.Bestimt
#DEV-VR - Adding LuminRuntimeSettings as dependent modules for anything that references the MLSDK
Change 4016457 by Ryan.Vance
#jira UE-58018
Cleaning up compiler errors/warnings.
Change 4017246 by Jason.Bestimt
#DEV-VR - Potential fix for UE-58043 where metal asserts that it should be in the render thread rather than either the render thread OR RHI Thread
#JIRA: UE-58043
Change 4018571 by Joe.Graf
Added a remapping of curve values in a range to the modify curve anim node
Change 4018991 by Joe.Graf
Wrapped vertical plane detection in a if iOS 11.3 check since ARKit 1.5 is only availabe from 11.3 on
#jira: UE-57999
Change 4019068 by Joe.Graf
Changed how Apple Vision support is enabled in code
#jira: UE-57552
Change 4019194 by Joe.Graf
Added a console command to change where Face AR is publishing LiveLink curve data "LiveLinkFaceAR SendTo=192.168.1.1"
Change 4019648 by Keli.Hlodversson
Work around build failures caused by missing virtual destructor warnings.
Reverting back to Oculus' original method of implementing own RHICommand wrapper around TFunctions and TFunctionRefs (using overloaded inline functions and templates to reduce code duplication.)
Change 4019871 by Joe.Graf
Changed the __IPHONE_11_3 to the raw numeric value
Change 4020121 by Keli.Hlodversson
Fix parameter types to match header declarations.
Change 4020127 by Keli.Hlodversson
Remove dllimport/export macros from cpp file.
Change 4020621 by Joe.Graf
Wrapped the Apple ARKit plane geometry building in a #if IOS_11_3 check
Change 4020910 by Joe.Graf
Refactored how ARKit support #define to make it easy to wrap individual features by ARKit version
Change 4020952 by Joe.Graf
Added checks to make sure PLATFORM_IOS and PLATFORM_TVOS are defined to 0 on non-Apple platforms when checking for ARKit
Change 4021116 by Jason.Bestimt
#DEV-VR - Integrating CL 4005915 from Dev-Core to remove plugin modules that aren't supported on target platform
Change 4021320 by Joe.Graf
Fixed warnings resulting from unity builds hiding them
Change 4021738 by Chad.Garyet
- adding lumin filters
- changing defaults for platforms back to true, this was brought over erroneously.
#jira none
#ROBOMERGE: Dogma, Nightlies
Change 4021898 by Chad.Garyet
added missing bits from the ue4main script
#jira none
#ROBOMERGE: Dogma, Nightlies
Change 4022583 by Joe.Graf
Added functions for checking ARKit version availability at runtime
Change 4022610 by Joe.Graf
Added checks for ARKit 1.0 availability when creating the AR session to prevent calling invalid selectors on older iOSes
Change 4022616 by Joe.Graf
Added support for enabling the ARKit 1.5 autofocus setting
Change 4022650 by Joe.Graf
Defaulted autofocus for AR to on
Change 4023026 by Joe.Graf
Changed the ARKit video overlay to use the new availability api
Change 4023124 by Joe.Graf
Switched another version check in the ARKit overlay code to use the faster version
Change 4023489 by Ethan.Geller
[Dev-VR] #jira none fix AudioMixerModuleName for Lumin. #fyi nick.whiting, jason.bestimt
Change 4023995 by Nick.Atamas
Properly deprecated the bitfield for plane detection mode.
#jira UE-57842
Change 4024992 by Jason.Bestimt
#DEV-VR - Adding SupportPlatforms to MagicLeapAnalytics plugin
Change 4025702 by Jason.Bestimt
#DEV-VR - Fix for loading ML libraries even when the MLSDK is not present
#JIRA: UE-58033
Change 4026639 by Mike.Beach
Removing innocuous Oculus error that did not match up with the rest of the code - it is handled/acceptable when Frame_RenderThread has been reset.
#jira UE-58001
Change 4026949 by Mike.Beach
MR - Making a few fixes to the lens undistortion and how it interacts with the MRC component...
- Switching to a 16bit displacement map instead of a 32bit UV map (updating the materials accordingly)
- Using the OpenCV focal ratio to scale the aspect ratio to avoid stretching from the undistortion
- Adding CVar commands to enable/disable pieces of the undistortion
- Changing the default undistortion cropping to be uncropped
- Removing the need for the 'EnableMapping' material parameter
#jira UE-55195
Change 4027147 by Jason.Bestimt
#DEV-VR - Fix for UE-58043 (more call sites where it should be Render OR RHI thread)
#JIRA: UE-58043
Change 4027301 by Mike.Beach
Updating the MRCalibration project's ini so it doesn't error on packaging.
Change 4027469 by Mike.Beach
MR Calibration - Setting StartInVR to true, so when we package the app, we don't have to manually enable it.
Change 4027957 by Mike.Beach
As part of renaming the MR plugin, first renaming the root folder to be MixedRealityCaptureFramework.
#jira UE-57782
Change 4029182 by Keli.Hlodversson
Revert back to not enqueuing RHI tasks when RHI is not on a separate thread. Oculus code depends on being able to call ExecuteOnRHIThread from code potentially called from within other calls to ExecuteOnRHIThread.
#jira UE-58079
Change 4029687 by Dragan.Jerosimovic
Boy rig and pose asset mb files, maps and masks
Change 4030059 by Mike.Beach
As part of renaming the MR plugin, renaming the inner module to be MixedRealityCaptureFramework.
#jira UE-57782
Change 4030296 by Charles.Egenbacher
#LUMIN Copying from Dev-Incoming-Staging to Dev-VR
Change 4030593 by Jason.Bestimt
#DEV-VR - Merging olaf test maps to Dev-VR
Change 4031042 by Keli.Hlodversson
Allow executing ExecuteOnRHIThread* on the RHI thread. Enables simplifying destructors that can either be invoked on the RHI or Render thread.
#jira UE-58239
Change 4031046 by Keli.Hlodversson
Use the new XRThreadUtils functions in the HMD module for executing tasks on the RHI thread
#jira UE-58238
Change 4032593 by Mike.Beach
As part of renaming the MR plugin, renaming the inner module to be MixedRealityCaptureCalibration.
#jira UE-57782
Change 4033911 by Jason.Bestimt
#DEV-VR - Fix to LuminToolChain to allow it use a custom strip executable (android instead of gcc)
Change 4034087 by Mike.Beach
Renaming the MR plugin to be the 'MixedRealityCaptureFramework' plugin.
#jira UE-57782
Change 4034253 by Joe.Graf
Made the Apple Vision plugin use version checking consistent with ARKit
Change 4034543 by Joe.Graf
Added availability checks for the Apple Image Utils plugin similar to ARKit
#jira: UE-57541
Change 4034548 by Joe.Graf
Fixed the implicit conversion in the head rotation curves from the face ar feed causing the values to be 0
Change 4034577 by Jason.Bestimt
#DEV-VR - Removing MAC Custom Metal present (fixes Mac with -game rendering all black)
Change 4034605 by zak.parrish
Checking in test case for head rotation tracking - minor temporary change to AnimBP #rb none
Change 4034686 by Jason.Bestimt
#DEV-VR - Integrating (most of) CL 3980919 to disable instances of deprecation warnings caused by building for ios11
#JIRA: UE-58046
Change 4034799 by Joe.Graf
Added base types for detecting images in a AR session
Change 4034820 by Joe.Graf
Added a friendly name to UARCandidateImage objects
Change 4035010 by Joe.Graf
Added support for handling ARImageAnchor notifications from ARKit
Change 4035355 by Mike.Beach
[WIP] MR - Renaming some classes to reflect the plugin's new name.
#jira UE-57782
Change 4035464 by Joe.Graf
Added orientation to the ARCandidateImage object to pass to the detection system
Change 4035524 by Mike.Beach
[WIP] MR - More renaming of some classes to better match the plugin's new name.
#jira UE-57782
Change 4035606 by Mike.Beach
[WIP] MR - More renaming of some classes to better match the plugin's new name.
#jira UE-57782
Change 4035918 by Mike.Beach
[WIP] MR - Renaming the MrcFramework module's source files to better match the plugin's new name.
#jira UE-57782
Change 4035976 by Mike.Beach
[WIP] MR - Renaming some more files and classes to better match the MRC framework's new name.
#jira UE-57782
Change 4036044 by Ryan.Vance
#jira UEVR-377
Adding support for ISR Translucency.
Change 4036069 by Ryan.Vance
We can remove the last word PrimitiveVisibilityMap masking for ISR since the maps are always the same size between views.
Change 4036073 by Chance.Ivey
Fixed select blocks on LuminSamplePawn and GesturesAndTotem map to reflect recent changes. Fixes #JIRA UE-58328 #rb none
Change 4036307 by Mike.Beach
[WIP] MR - Renaming the MRC calibration files to better match the MRC framework's new name.
#jira UE-57782
Change 4036314 by Mike.Beach
[WIP] MR - Renaming some more calibration classes to better match the MRC framework's new name.
#jira UE-57782
Change 4036319 by Charles.Egenbacher
#LUMIN this is an out-of-date version of the lumin sample. Nuking.
Change 4036396 by Charles.Egenbacher
#LUMIN Adding the up to date version of the LuminSample.
Change 4036485 by Sorin.Gradinaru
UE-57773 Disable Thermals Message
#4.20
#iOS
Add in the Remote Session App BP an Execute Console Command node immediately after Event Begin Play, disabling all on-screen messages, for all builds.
Change 4036695 by Jason.Bestimt
#DEV-VR - Adding Lumin case to PrecompileTargetType check
Change 4037110 by Jason.Bestimt
#DEV-VR - Extra deprecated macro guards around HarfBuzz includes
#JIRA: UE-58046
Change 4037443 by Jason.Bestimt
#DEV-VR - Merging CL 4028003 from Partners-Google
Change 4037490 by Jason.Bestimt
#DEV-VR - Integrating CL 4028922 from Partners-Google (+ assignment guarding)
Change 4037691 by Jason.Bestimt
#DEV-VR - Swapping order of comparrison operator to deal with const error
Change 4037892 by Joe.Graf
Added UTexture2D to CGImage conversion in Apple Image Utils plugin
Change 4037894 by Joe.Graf
Changed the name of a property to make it clearer as to what it is and to have fewer things named similar in the same system
Change 4037901 by Joe.Graf
Added support for configuring which images you'd like detected during a AR session
Change 4037906 by Jason.Bestimt
#DEV-VR - Fixing buckled logic for =operator (derp)
Change 4038293 by Mike.Beach
[WIP] MR - Moving the calibration setup/level/content into its own project, and out of the MR plugin.
#jira UE-57782
Change 4038403 by Joe.Graf
Added the name from the candidate image when creating the Apple side representation
Change 4038488 by Mike.Beach
[WIP] MR Calibration - Moving calibration specific files to the MRCalibration project, out of the plugin (followup to CL 4038293). This makes the MRCalibration project a code project now.
#jira UE-57782
Change 4038776 by Chance.Ivey
Updates to Fix for Gestures change. Affects #JIRA UE-58328, though other non-content issues may cause packaging to fail #rb none #fyi Nick.Whiting
Change 4038877 by Mike.Beach
[WIP] MR - Renaming assets to better match the new plugin name.
#jira UE-57782
Change 4039097 by Joe.Graf
Fixed the public include path warnings in the Apple* plugins I added
Change 4039106 by Joe.Graf
Worked around a bad compile time assert that blocked valid FString::Printf debug code
Change 4039209 by Jeff.Fisher
Fixing one build script paths
Change 4039275 by Jeff.Fisher
More include path fixes.
Change 4039415 by Joe.Graf
Added support for remote session sending AR camera image data to be rendered on the host like we do for AR on device
Change 4039471 by Joe.Graf
Added a file I missed when adding to the remote session plugin
Change 4039473 by Joe.Graf
#ifdef-ed some code out until the linkage can be fixed
Change 4040249 by Mike.Beach
[WIP] MR - Moving some more asset files that aren't needed for the MRC plugin
#jira UE-57782
Change 4040365 by Mike.Beach
Fixing a compiler issue in the MRCalibration project, since moving MRC files there (WITH_OPENCV is not defined for the project).
#jira UE-57782
Change 4040455 by Mike.Beach
Moving the few remaining methods that were calibration specific, sprinkled through the MRC plugin.
#jira UE-57782
Change 4041404 by Mike.Beach
Fixing an issue with BP async nodes - making it so their wrapped function can be renamed and redirected.
Change 4041406 by Mike.Beach
MR - Splitting the Mrc video util library so that the BP functions needed for calibration aren't exposed to users.
#jira UE-57782
Change 4042110 by Jason.Bestimt
#DEV-VR - Stopping spew for ML eye tracking when not on platform
#JIRA: UE-58365
Change 4042407 by Joe.Graf
Disabled HEIF compression on Mac
#jira: UE-58479
Change 4042727 by Jason.Bestimt
#DEV-VR - Fix for Android compiling without version 24
Change 4042861 by Olaf.Piesche
#jira UE-57784
Change 4043105 by Mike.Beach
Exposing a way for programmers to strip save game headers from save data, and get to the tagged object serialization portion.
#jira UE-58389
Change 4043120 by Mike.Beach
MR - Loading the base save data, even if we're unable to fully construct the original save object class.
#jira UE-58389
Change 4043401 by Mike.Beach
New Oculus poke-a-hole material, in support on SI 1.25. Checking in to alleviate QA contention for testing the rest of SI 1.25.
#jira UEVR-1143
Change 4043424 by Mike.Beach
Oculus SI 1.24/1.25 - Engine rendering changes
#jira UEVR-1143
Change 4043495 by Mike.Beach
CIS fix - Missing files needed for the Oculus SI 1.24/25 Vulkan changes.
#jira UEVR-1143
Change 4043642 by Zak.Parrish
Changes to FaceARSample: added in support for JoeG's smoothing algorithm, also refactored calibration to use the new Modify Curves node. Added some more comments to the AnimBp to make it easier to read. #rb none
Change 4045638 by Zak.Parrish
Some minor updates to FaceARSample content. Mostly refactoring for new ModifyCurve stuff.
Change 4046003 by Jason.Bestimt
#DEV-VR - Fix for bEnableAlphaChannelInPostProcessing reading in as false for LuminSample
bEnableAlphaChannelInPostProcessing translates to r.PostProcessing.PropagateAlpha in ini files
#JIRA: UE-58523
Change 4046548 by Jules.Blok
Fix SetInstancedEyeIndex() ignoring the left eye.
#jira UE-54044
Change 4046859 by zak.parrish
Checking in the new rig from 3Lateral - this prevents the eyelashes from separating
Change 4047060 by Nick.Whiting
Wrapping -norhithread in PLATFORM_LUMIN to prevent the ML plugin from always disabling RHI threading.
#jira UEVR-1192
Change 4047667 by Mike.Beach
CIS fix - removing uneeded line from bad merge.
Change 4047673 by Mike.Beach
More CIS fixes for fallout from recent rendering merge.
Change 4048227 by Rolando.Caloca
VR - vk - Some Vulkan merge conflicts resolved
Change 4048421 by Jason.Bestimt
#DEV-VR - Converting OwnerName to EventName in UpdateSceneCaptureContent_RenderThread call
Change 4048423 by Jason.Bestimt
#DEV-VR - Fixing mediandk version check
Change 4048452 by Rolando.Caloca
VR - Merge fix
Change 4048530 by Rolando.Caloca
VR - Merge fix
Change 4048607 by Jason.Bestimt
#DEV-VR - Probable repair of Mr Mesh post merge
Change 4048794 by Rolando.Caloca
VK - Fix mobile from merge
Change 4048972 by Jeff.Fisher
Fixing MeshReconstructor merge problems.
Change 4049969 by Ryan.Vance
Fixing missing shader assert.
Change 4050831 by Ryan.Vance
Merge clean up. This is still needed to build w/ vulkan on Lumin.
Change 4050854 by Ryan.Vance
Merge clean up.
We need GetAllocationHandle for the ML Vulkan custom present sRGB workaround.
Change 4051495 by Jason.Bestimt
#DEV-VR - Adding Android, Quail, Linux vulkan include clauses
Change 4052528 by Zak.Parrish
Changing defaultEngine.ini for the higher res version of Gremlin
Change 4052880 by Ryan.Vance
Merge clean up.
Now with more Lumin
#jira UE-58645
Change 4052991 by zak.parrish
Update to FaceTrackingMap2 for proper camera positioning
Change 4053139 by Nick.Whiting
Fixing Lumin Vulkan platform header
Change 4053352 by Mike.Beach
On PC (in editor), not enabling ML stereo by default. Waiting for it to be enable by the EnableStereo() call (like we do for Oculus/SteamVR).
#jira UE-57991
Change 4053644 by Nick.Whiting
Fix for build break by wrapping bStereoDesired in !PLATFORM_LUMIN
Change 4054329 by Jason.Bestimt
#DEV-VR - Resave of GoogleARCorePassthroughCameraMaterial.uasset
#JIRA: UE-58689
Change 4054785 by Mike.Beach
Fixing a MRCalibration BP compilation error from the latest merge - was using a deprecated variable which was no longer exposed to BPs.
Change 4055466 by Jules.Blok
Suppress SteamVR submission errors after they've been logged once.
Change 4055500 by Jason.Bestimt
#DEV-VR - MrMeshComponent fix for unsupported pixel format
#JIRA: UE-58759
Change 4055761 by Ryan.Vance
#jira UE-58729
There's a single frame where the TLV textures are not initialized when using FCanvasTileRendererItem on startup.
Change 4056008 by Mike.Beach
Fixing bad merge from Main.
Change 4056616 by Nick.Whiting
Changing UBT configs to use Lumin-specific config files
#jira UE-58760
Change 4056969 by Keli.Hlodversson
MRCalibration: Set r.SceneRenderTargetResizeMethod to "Grow" to avoid cycling the scene render target size on every frame causing a flicker
#jira UE-58191
Change 4057356 by Jason.Bestimt
#DEV-VR - Guard around JNI function for Lumin
Change 4059353 by Nick.Whiting
Fix for shadow variable warnings on Linux
#jira UE-58843
Change 4060158 by Rolando.Caloca
DVR - vk - Temporarily add backbuffer delay/extra copy blit on android
#jira UE-58859
Change 4060432 by Mike.Beach
Fix for shadow variable warnings on Linux
#jira UE-58843
Change 4060520 by Rolando.Caloca
VR - Proper fix for r.Vulkan.DelayAcquireBackBuffer=0
- Restore Android to not delay
#jira UE-58859
Change 4060587 by Nick.Whiting
Fix for minimum iOS version being set to iOS 8 on MRCalibration, which was causing CIS warnings
#jira UE-58762
Change 4061277 by Jeff.Fisher
UE-58861 //UE4/Dev-VR - Compile UE4Game Lumin - ERROR: MLSDK is not specified; cannot use Lumin toolchain.
-Overriding HasAnySDK to setup the MLSDK.
Change 4061308 by Jason.Bestimt
#DEV-VR - Work around of UE-58864 crashing when mousing over project launcher with only a Lumin device plugged in
#JIRA: UE-58864
Change 4062111 by Ryan.Vance
#jira UE-58875
Fixing audio compilation failure.
Change 4064091 by Jason.Bestimt
#DEV-VR - Disabling ML Plugin with the editor when bIsVDZIEnabled is off
#JIRA: UE-58954
Change 4064554 by Jason.Bestimt
#DEV-VR - Removing ML haptic tests when not on the platform
#JIRA: UE-58966
Change 4064755 by Jeff.Fisher
UE-58970 Dev-VR - Incremental UE4Editor Linux - Referenced directory 'D:\Build\AutoSDK\HostWin64\Lumin\0.12\lib\linux64' does not exist.
-Removed linux from magicleap plugin whitelists, we have no sdk for linux.
#review-4064614
#jira UE-58970
[CL 4064889 by Mike Beach in Main branch]
Robert Manuszewski
Marc Audy
Graeme Thornton
Ben Marsh
Alexis Matte
Shaun Kime
James Hopkin
Daniel Lamb
Marcus Wassmer
Luke Thatcher
projectgheist
Mike Beach