Commit Graph

43 Commits

Author SHA1 Message Date
Helge Mathee
d45bd63bb7 Control Rig: Replace cast link with cast nodes
#rb sara.schvartzman
#jira na
#preflight https://horde.devtools.epicgames.com/job/636503dfde2c4dbb5d92f669

[CL 23008884 by Helge Mathee in ue5-main branch]
2022-11-07 04:27:49 -05:00
Helge Mathee
0c6059e8fe Control Rig: Guard against nullptrs in subpins
#rb na
#jira UE-168034
#preflight https://horde.devtools.epicgames.com/job/6357cb9710505f5393882e41

[CL 22748965 by Helge Mathee in ue5-main branch]
2022-10-25 07:47:30 -04:00
sara schvartzman
a4f0067488 Control Rig: Fix default values not showing up correctly
#jira UE-168188
#rb none
#preflight none

[CL 22748444 by sara schvartzman in ue5-main branch]
2022-10-25 06:09:50 -04:00
Helge Mathee
06171f6e93 Control Rig: Fix sequence node aggregate UI
#rb sara.schvartzman
#jira UE-168030
#preflight https://horde.devtools.epicgames.com/job/6356b4c9f92c325024ebd814

[CL 22748405 by Helge Mathee in ue5-main branch]
2022-10-25 06:00:44 -04:00
sara schvartzman
7ef7471729 Control Rig: Fix Reroute, If, Select, Array nodes not available when pulling from a pin
#jira UE-168032, UE-168033
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/6356b2773a547c3da323b609

[CL 22748352 by sara schvartzman in ue5-main branch]
2022-10-25 05:45:35 -04:00
sara schvartzman
8facd1f53e Control Rig: Inline function bytecode
#jira FORT-519929
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/634edc6d3042441e0f39ca99

[CL 22723244 by sara schvartzman in ue5-main branch]
2022-10-24 08:59:51 -04:00
Helge Mathee
fa274720f6 Control Rig: Fixes for fallout from UI optimizations
#rb sara.schvartzman
#jira UE-167285 UE-167244
#preflight https://horde.devtools.epicgames.com/job/634fd6adac48fa11ed310f59

[CL 22622242 by Helge Mathee in ue5-main branch]
2022-10-19 07:53:01 -04:00
Helge Mathee
630b370f55 Control Rig: UI Graph Performance Improvements
#jira UE-152944
#rb sara.schvartzman
#preflight https://horde.devtools.epicgames.com/job/6346d47cf04e6f85050ea4a2

[CL 22500206 by Helge Mathee in ue5-main branch]
2022-10-13 05:50:41 -04:00
jack cai
9d6ee2889b ControlRig: user defined struct used as function argument can trigger an assertion when one of the member variables change its type
#jira UE-165790
#rb Sara.schvartzman, Helge.mathee
#preflight https://horde.devtools.epicgames.com/job/633b1c006b10157eac5fc7ba

[CL 22336420 by jack cai in ue5-main branch]
2022-10-04 15:24:37 -04:00
bryan sefcik
50d4fac9e0 Updated ../Engine/Plugins/... to inline gen.cpp files
Before:
3548 unity files
Total CPU Time: 47343.578125 s
Total time in Parallel executor: 494.60 seconds

After:
3445 unity files
Total CPU Time: 46044.671875 s
Total time in Parallel executor: 468.51 seconds

#jira
#preflight 63336159b20e73a098b7f24f

[CL 22218213 by bryan sefcik in ue5-main branch]
2022-09-28 01:06:15 -04:00
sara schvartzman
eec59437e9 Control Rig: Collapse nodes with templates
#jira UE-146929
#rb helge.mathee
#preflight 62ced5dbd00f3c208e47c183

[CL 21089290 by sara schvartzman in ue5-main branch]
2022-07-14 06:53:37 -04:00
helge mathee
b3573a03b0 Control Rig: Remove strong dependencies from User interface on data model - use TWeakObejctPtr
#rb rob.millar
#preflight https://horde.devtools.epicgames.com/job/62c6e9bb2823f28cf21e5f45

#ROBOMERGE-AUTHOR: helge.mathee
#ROBOMERGE-SOURCE: CL 20988142 via CL 20988169 via CL 20988205
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 20992713 by helge mathee in ue5-main branch]
2022-07-07 17:00:35 -04:00
Helge Mathee
3d20407084 RigVM: Refactor template type system to rely on integers rather than string comparisons
* Switching the FRigVMTemplateArgumentType to be backed up by FName instead of FString for faster comparison
* Adding a "Types" storage under the RigVMRegistry of all of the known supported types
* Have the FRigVMTemplateArgument refer to type indices rather than full type structures
* Have the resolval comparison code rely on comparing type indices rather than type structures
* Store relationship between the bool and the TArray<bool> type as an array / element lookup within the registry - to avoid string operations when doing lookups from element to array to 2 dimensional array for a type.
* The preferred types list on the template node is now stored as pairs of argument name and type index <FName, int32> rather than FString.
* Also we no longer support all types for the untyped nodes (such as reroute, select, if etc) - but instead we support all user defined types (non-native structs and enums) as well as all types ever used as a template argument. The reasoning here is that supporting a type that's not used by any node is pointless. This reduced the type set from 9876 to 237.

#rb halfdan.ingvarsson
#jira na
#preflight https://horde.devtools.epicgames.com/job/62b9c666ba62f4498a345be2

[CL 20861728 by Helge Mathee in ue5-main branch]
2022-06-28 13:41:23 -04:00
benoit gadreau
c64c1bf314 Fix use of IsChildOf with possible nullptr (cf. CL 20439034)
todo: check for all use of IsChildOf within ControlRig to avoid future issues

#jira UE-155523 UE-155505
#rb halfdan.ingvarsson
#fyi brandon.schaefer
#preflight 6297bd5be809e387be23e44c

[CL 20457493 by benoit gadreau in ue5-main branch]
2022-06-01 15:51:46 -04:00
Helge Mathee
9c189267d5 ControlRig: user defined events and event invocation
#rb sara.schvartzman
#jira UE-153498 UE-153499
#preflight https://horde.devtools.epicgames.com/job/62975ffb2c618ddc66bb49a4

[CL 20453170 by Helge Mathee in ue5-main branch]
2022-06-01 11:28:01 -04:00
sara schvartzman
71eb93c798 Control Rig: Fix crash when changing variable type to rotator
#jira UE-151605
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/627ba08ba85e625d6f6169b3

[CL 20136557 by sara schvartzman in ue5-main branch]
2022-05-11 07:51:44 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
Helge Mathee
043e850f31 Control Rig: Enabling aggregate nodes + implementing sequence as aggregate
#rb sara.schvartzman
#jira na
#preflight https://horde.devtools.epicgames.com/job/6273e2f65c29fb7661e9bd23

[CL 20058905 by Helge Mathee in ue5-main branch]
2022-05-05 11:55:01 -04:00
Helge Mathee
1475be6205 RigVM: Change inheritance order - make UnitNode inherit from TemplateNode
Also implement a way to register external / auxiliary templates to the registry + unit test

#rb sara.schvartzman
#jira na
#preflight https://horde.devtools.epicgames.com/job/625847a0946114248dbaa7d9

[CL 19806894 by Helge Mathee in ue5-main branch]
2022-04-19 08:39:16 -04:00
Thomas Sarkanen
98c834dfd7 Control rig and RigVM changes to allow for data interface prototype to be further developed
This removes some of the dependencies on UControlRigBlueprint and replaces them with 'host' interfaces for URigVMController and URigVMGraph.
Also adds support for TScriptInterfaces in RigVM. This includes a modification of the RigVM parts of UHT.
Some of these changes are due to be reworked later to allow RigVM-hosting systems to not have to be also implemented in terms of control rig.

#rb Helge.Mathee,Sara.Schvartzman
#fyi Helge.Mathee,Sara.Schvartzman
#preflight 624d857aa64871f1a11ef3f9

[CL 19645705 by Thomas Sarkanen in ue5-main branch]
2022-04-06 08:26:45 -04:00
sara schvartzman
c7b0e74c59 Controlr Rig: UI implementation of Aggregate nodes
#jira UE-146928
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/62433ef7dc6183e3f5e500dc

[CL 19554694 by sara schvartzman in ue5-main branch]
2022-03-30 05:21:45 -04:00
Helge Mathee
63e119a364 Control Rig: Further template node workflows
Implemented unresolve as well as re-resolve node on already typed pins
Added UI in contextual menu to re-type pins

#rb sara.schvartzman
#jira UE-125892
#preflight https://horde.devtools.epicgames.com/job/622f488f505788e09ffffbe4

[CL 19372564 by Helge Mathee in ue5-main branch]
2022-03-14 10:19:31 -04:00
sara schvartzman
d904b9cfe5 Control Rig: Remove parameters
#jira UE-143591
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/6225ed1d8e6b4641d86295c4

[CL 19284981 by sara schvartzman in ue5-main branch]
2022-03-07 10:20:24 -05:00
Helge Mathee
627cb75494 Control Rig: Template Node Support.
The UE_RIGVM_ENABLE_TEMPLATE_NODES is disabled in this submit for now - which disabled the creation of template nodes as well, disabled auto-update functionality during load and spawning resolved templates nodes instead of unit nodes.

We'll enable the define in a follow up submit

#rb jack.cai
#jira na
#preflight https://horde.devtools.epicgames.com/job/621de289ca28c55634199235

[CL 19196111 by Helge Mathee in ue5-main branch]
2022-03-01 04:23:55 -05:00
dave jones2
ed1b4ed6a5 UE-140327 - Remove ENABLE_BLUEPRINT_REAL_NUMBERS usage
The original ENABLE_BLUEPRINT_REAL_NUMBERS macro was strictly meant for AB testing in the Dev-LWC. Currently, disabling it won't work, and would likely lead to broken behavior. Its presence might incorrectly indicate to licensees that this is an option that can be toggled safely.

#rb marc.audy
#jira UE-140327
#preflight 61fc6449dc0b3ecbecb6f381
#lockdown julien.marchand

#ROBOMERGE-AUTHOR: dave.jones2
#ROBOMERGE-SOURCE: CL 18864654 in //UE5/Release-5.0/... via CL 18864683 via CL 18864993
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18865002 by dave jones2 in ue5-main branch]
2022-02-04 11:54:52 -05:00