Commit Graph

373 Commits

Author SHA1 Message Date
robert manuszewski
d3991fec9b Fixing potential compile errors ahead of enabling TObjectPtr GC barrier
#rb trivial

[CL 26868625 by robert manuszewski in ue5-main branch]
2023-08-05 06:09:54 -04:00
cedric caillaud
5ec613e4de Geometry collection : fix bounds computation when custom renderer is being used
- this reverts CL 26423456 that introduced a bug trying to fix the same issue
- now component space transform are updated even when the GC is not yet broken , making sure that  all the leaf transforms are up to date for the bounds to be computed from them

#rb michael.bao, aris.theophanidis

[CL 26797787 by cedric caillaud in ue5-main branch]
2023-08-02 23:26:19 -04:00
michael bao
1b8d608469 geometry collection needs to compute its component space transforms even on the server otherwise will cause desync issues between client/server for character basing
#rb cedric.caillaud

[CL 26776928 by michael bao in ue5-main branch]
2023-08-02 12:53:22 -04:00
cedric caillaud
9f6b22cf34 Geometry Collection : Add ability to disable root proxy rendering at runtime when using custom renderer
#rb michael.bao, jeremy.moore

[CL 26727982 by cedric caillaud in ue5-main branch]
2023-07-31 20:36:40 -04:00
michael bao
3e9af0530d GCs should not set themselves dormant to avoid client/server desync
[CL 26722493 by michael bao in ue5-main branch]
2023-07-31 17:35:24 -04:00
jimmy andrews
bcd4636c1e Stop creating the Geometry Collection's Dynamic Component for Editor Preview Worlds (the worlds used for tool preview viewports, and thumbnails) since the Dynamic Component has data that isn't tracked for undo, so can't be active in editors contexts where undo can happen.
This fixes an issue where stale data on the preview thumbnail caused an ensure on undo of any fracture operation that changed the number of bones in the collection.

#jira UE-191403
#rb cedric.caillaud

[CL 26681608 by jimmy andrews in ue5-main branch]
2023-07-28 14:32:50 -04:00
cedric caillaud
c7fa6954f0 Fix mass calculation for geometry collections when overriding materials on the component
#rb michael.bao, steven.barnett

[CL 26679228 by cedric caillaud in ue5-main branch]
2023-07-28 13:39:56 -04:00
jeremy moore
216a518df7 Server doesn't need need Geometry Collection custom renderer visual representation.
[CL 26663253 by jeremy moore in ue5-main branch]
2023-07-27 21:57:26 -04:00
michael bao
f968ee975f fix old style geometry collection events (break/crumbling/removal events) to still fire even if we set the notification boolean after the initial registration
#rb cedric.caillaud, vincent.robert

[CL 26557021 by michael bao in ue5-main branch]
2023-07-24 17:42:08 -04:00
michael forot
3d6d146d33 Allow multiple Field targets to be rendered at the same time
#rb devon.penney

[CL 26506441 by michael forot in ue5-main branch]
2023-07-21 04:48:39 -04:00
bob tellez
804537e1b7 [Backout] - CL26484702
[FYI] Michael.Forot
Original CL Desc
-----------------------------------------------------------------
Allow multiple Field targets to be rendered at the same time

#rb devon.penney

[CL 26491420 by bob tellez in ue5-main branch]
2023-07-20 14:32:58 -04:00
michael forot
48f495d417 Allow multiple Field targets to be rendered at the same time
#rb devon.penney

[CL 26484723 by michael forot in ue5-main branch]
2023-07-20 09:46:44 -04:00
cedric caillaud
1b2d4697ac Geometry collection : override Primitive component GetMass method for geometry collections
Added display of mass in geometry collection physics editor properties

[FYI] michael.bao, brice.criswell, jim.vanallen, jack.oakman
#rb trivial

[CL 26474980 by cedric caillaud in ue5-main branch]
2023-07-19 19:24:20 -04:00
aris theophanidis
8d16a5e917 GeometryCollectionComponent: using root proxy to take into account root particle position when computing bounds
#rb micheal.bao

[CL 26423459 by aris theophanidis in ue5-main branch]
2023-07-17 21:44:37 -04:00
cedric caillaud
0333a26f4b Geometry collection : fixed ApplyBreakingAngularVelocity not calling the right proxy method
#rb trivial
[FYI] michael.bao

[CL 26421309 by cedric caillaud in ue5-main branch]
2023-07-17 19:22:31 -04:00
michael bao
904fb039cc ensure that the DecayFacade and DynamicStateFacade are valid in UGeometryCollectionComponent::CheckFullyDecayed
#rb cedric.caillaud

[CL 26419790 by michael bao in ue5-main branch]
2023-07-17 18:20:07 -04:00
cedric caillaud
26c55cfa28 Geometry Collection : Move creation of attribute from InitializeComponent to ResetDynamicCollection to make sure they are created even if the rest collection changes during the component lifetime
#rb michael.bao, benn.gallagher

[CL 26417737 by cedric caillaud in ue5-main branch]
2023-07-17 17:10:23 -04:00
michael bao
3c5570261a re-add the check of bUpdateNavigationInTick in UGeometryCollectionComponent::UpdateNavigationDataIfNeeded
[FYI] cedric.caillaud, aris.theophanidis

[CL 26417329 by michael bao in ue5-main branch]
2023-07-17 16:55:47 -04:00
michael bao
45864963cd geometry collection navmesh export using root proxy should take into account root particle position
- also remove usage of bUpdateNavigationInTick since that's no longer relevant since it now only happens in the post physics sync callback

[FYI] cedric.caillaud, aris.theophanidis

[CL 26300681 by michael bao in ue5-main branch]
2023-06-28 17:53:33 -04:00
vincent robert
2c139efcf1 Fix crash when moving forward in replay
In the Geometry Collection Component replication data cannot be reset on the physics thread because the reset is only called when the component is being destroyed.

[CL 26217857 by vincent robert in ue5-main branch]
2023-06-23 16:23:28 -04:00
michael bao
282630f308 geometry collections emit an event when their particles are fully decayed
[FYI] cedric.caillaud

[CL 26134010 by michael bao in ue5-main branch]
2023-06-20 16:46:06 -04:00
vincent robert
dcef39b920 Disable connectivity hack
Sometimes the connectivity graph was not updated correctly due to some missing events. This bug couldn't be reproduced locally, so this is an attempt to remove the hack.
#rb michael.bao

[CL 26098615 by vincent robert in ue5-main branch]
2023-06-19 14:43:07 -04:00
vincent robert
9cc10edd0e In the Geometry Collection Component the async tick had to block Game Thread and Physics Thread to apply the replicate data. Now all the replication code is copied and executed on the Physics thread. This allow not to block both thread at the same time.
#rb cedric.caillaud

[CL 26060570 by vincent robert in ue5-main branch]
2023-06-16 13:42:03 -04:00
michael bao
ab6d01d848 setting per-particle collision filter data on the geometry collection needs to sync that data to the physics thread
#jira UE-188831
[FYI] yue.xiao

[CL 26056799 by michael bao in ue5-main branch]
2023-06-16 12:29:38 -04:00
markus boberg
31ded4404b Networked Physics: Enable refactored physics replication in Juno.
Disable local GC movement replication logic if connected in a Cluster Union.
Implement PhysicsObjectPreset to override physics replication mode on replicated and simulated Juno actors.

#rb todd.eckert, michael.bao

[CL 25973950 by markus boberg in ue5-main branch]
2023-06-14 06:17:30 -04:00