Commit Graph

701 Commits

Author SHA1 Message Date
Jamie Dale
d1936d9b11 Read meta-data off the correct property when querying IStructureDetailsView
#rb none
#rnx

[CL 10142335 by Jamie Dale in Dev-Editor branch]
2019-11-13 14:03:51 -05:00
Jamie Dale
65e85378d4 Key Category localized meta-data against the source string rather than the path
This applies the de-duplication at the gather level rather than the PO export level, which)
  1) Removes redundant string copies in memory.
  2) Removes the need to gather and import to resolve new duplicates.

Note: This will make categories appear non-localizable until the next gather runs (due to the key change), at which point they'll fix themselves.

#fyi Tim.Gautier
#rb none
#rnx

[CL 10076163 by Jamie Dale in Dev-Editor branch]
2019-11-07 16:57:11 -05:00
Jamie Dale
872aa869c3 Converted code to use FObjectEditorUtils::GetCategoryText rather than access the UObjectCategory meta-data directly
This keeps the implementation common and will allow it to be changed in the future

#rb none
#rnx

[CL 10075120 by Jamie Dale in Dev-Editor branch]
2019-11-07 15:39:36 -05:00
sebastian nordgren
fa3f7d6cef Added missing TEXT() macros in unit test code.
#rb none
#rnx

[CL 9967386 by sebastian nordgren in Dev-Editor branch]
2019-11-04 10:02:13 -05:00
Chris Gagnon
d1973355bc Merge Dev-Tools-Stagng tp Dev-Editor
#rb none

[CL 9961726 by Chris Gagnon in Dev-Editor branch]
2019-11-01 17:39:56 -04:00
sebastian nordgren
f345526db6 Inline edit conditions in the details panel can now be properties without any metadata whatsoever.
Added a warning about this, since my view is that this sort of implicit behaviour should not be encouraged.

#jira UE-82597
#rb paul.chipchase

[CL 9956949 by sebastian nordgren in Dev-Editor branch]
2019-11-01 10:45:58 -04:00
Lauren Barnes
f61ab5cda7 Changing default multi-object details panel appearance
#rb Matt.Kuhlenschmidt
#jira none

[CL 9956594 by Lauren Barnes in Dev-Editor branch]
2019-11-01 10:29:12 -04:00
sebastian nordgren
138a3c542e Adding an entry to an array in a component being edited in a locked details view no longer asserts.
This was occurring due to the construction script being rerun and the old instance of the component being garbage collected. When the view is not locked this was handled by the selection being set, but with a locked view we were relying on SDetailsView::ReplaceObjects, which was failing to match the existing component to the newly created component.

#jira UE-61711
#rb paul.chipchase

[CL 9954537 by sebastian nordgren in Dev-Editor branch]
2019-11-01 07:45:52 -04:00
jason stasik
706f74275c Merge from Dev-Editor: Add temporary UObject to root to ensure it isn't being GC
#jira UE-82106
#rb rex.hill

#ROBOMERGE-SOURCE: CL 9807596 in //UE4/Release-4.24/...
#ROBOMERGE-BOT: RELEASE (Release-4.24 -> Main) (v546-9757112)

[CL 9807679 by jason stasik in Main branch]
2019-10-24 13:43:12 -04:00
Jason Stasik
a567cb28c5 Add temporary UObject to root to ensure it isn't being GC
#jira UE-82106
#rb rex.hill

[CL 9806176 by Jason Stasik in Dev-Editor branch]
2019-10-24 13:32:42 -04:00
jamie dale
7d15247b60 Fixed categories in the details panel being unlocalized
#jira UELOC-2406
#rb Matt.Kuhlenschmidt

#ROBOMERGE-SOURCE: CL 9748824 in //UE4/Release-4.24/...
#ROBOMERGE-BOT: RELEASE (Release-4.24 -> Main) (v543-9746878)

[CL 9748836 by jamie dale in Main branch]
2019-10-22 14:37:29 -04:00
sebastian nordgren
020444d6be Combo boxes for enum bitflags will no longer display enum values that have been marked with UMETA(Hidden).
#rb paul.chipchase

[CL 9743645 by sebastian nordgren in Dev-Editor branch]
2019-10-22 06:56:30 -04:00
sebastian nordgren
04ca6be793 EditConditions no longer crash when their parent object gets deleted from under them, eg. when editing a blueprint CDO and then compiling.
#jira UE-81793

#rb paul.chipchase

Source: 9581009 (//UE4/Dev-Editor)

#ROBOMERGE-SOURCE: CL 9743423 in //UE4/Release-4.24/...
#ROBOMERGE-BOT: RELEASE (Release-4.24 -> Main) (v542-9736015)

[CL 9743429 by sebastian nordgren in Main branch]
2019-10-22 06:01:06 -04:00
Jamie Dale
5904862070 Added PropertyAccessUtil to contain the common logic of getting and setting properties in a way that emits change notifications
The existing Python code has been ported to use this, and this can also be used by Blueprints (or other C++ setting properties) to allow property changes that emit change notifications.

#jira UE-77388
#rb Chris.Gagnon

[CL 9706346 by Jamie Dale in Dev-Editor branch]
2019-10-18 18:51:40 -04:00
fred kimberley
2dca3ea2bc Merging using //UE4/Dev-Framework_to_//UE4/Release-4.24
Fixes bugs with data inside container classes that are inside of sparse class data. When we're inside of a container class the pointer offsets for the sparse data structure have already been taken into account and trying to account for it again will result in bad pointers.

#jira UE-81002
#rb Marc.Audy

#ROBOMERGE-SOURCE: CL 9698557 in //UE4/Release-4.24/...
#ROBOMERGE-BOT: RELEASE (Release-4.24 -> Main) (v538-9681622)

[CL 9698676 by fred kimberley in Main branch]
2019-10-18 16:15:52 -04:00
Chris Gagnon
5b7e66b1fb Merging //UE4/Dev-Main to Dev-Editor (//UE4/Dev-Editor) to CL 9544902 for stream reparenting.
#rb none

[CL 9671142 by Chris Gagnon in Dev-Editor branch]
2019-10-17 19:44:57 -04:00
projectgheist
2020a06cfc PR #6287: More editor tooltips show property values (Contributed by projectgheist)
#rb sebastian.nordgren

[CL 9614880 by sebastian nordgren in Dev-Editor branch]
2019-10-16 06:47:12 -04:00
sebastian nordgren
2b39033c94 EditConditions no longer crash when their parent object gets deleted from under them, eg. when editing a blueprint CDO and then compiling.
#jira UE-81793

#rb paul.chipchase

[CL 9581009 by sebastian nordgren in Dev-Editor branch]
2019-10-15 04:32:11 -04:00
sebastian nordgren
cf86a119f9 EditCondition now supports bitflags that use enums. Eg. MyIntProperty & MyEnum::Flag (and negation by tacking on == false).
Flags must be enums with integral values. Powers of two are not checked for to allow for the use of combinations of flags, eg. Foo = 1, Bar = 2, FooAndBar = Foo | Bar.

#rb chris.gagnon

[CL 9580343 by sebastian nordgren in Dev-Editor branch]
2019-10-15 03:46:06 -04:00
sebastian nordgren
5a26ba3922 Added handling of UObject pointers to edit conditions to enable equality, inequality and nullptr checks of UObject pointers in the form of: MyProperty != nullptr, or MyProperty == OtherProperty.
#rb chris.gagnon

[CL 9533510 by sebastian nordgren in Dev-Editor branch]
2019-10-10 10:08:16 -04:00
JeanMichel Dignard
d4f0f4d3f2 Copying //UE4/Dev-Enterprise @ cl 9420543 to Dev-Main (//UE4/Dev-Main)
#rb none

[CL 9420574 by JeanMichel Dignard in Main branch]
2019-10-04 13:11:45 -04:00
Chris Gagnon
8ab0638182 Copying //UE4/Dev-Editor to Dev-Main (//UE4/Dev-Main) for 4.24
#rb none

[CL 9325047 by Chris Gagnon in Main branch]
2019-10-01 20:41:42 -04:00
Chris Gagnon
79fcc1f394 Merging //UE4/Dev-Main to Dev-Editor (//UE4/Dev-Editor) Prep for main copy up.
#rb none

[CL 9324846 by Chris Gagnon in Dev-Editor branch]
2019-10-01 20:19:12 -04:00
Lina Halper
3fd7f76532 Copying //UE4/Dev-Anim to Dev-Main (//UE4/Dev-Main)
#fyi: Laurent.Delayn, Marc.Audy
#rb: none

[CL 9321182 by Lina Halper in Main branch]
2019-10-01 16:59:31 -04:00
Fred Kimberley
38d787f2db Fix an obvious copy paste error that resulted in container properties not being handled correctly when multiselecting objects.
#rb Marc.Audy
#jira UE-81106

[CL 9317967 by Fred Kimberley in Dev-Framework branch]
2019-10-01 13:10:18 -04:00