Commit Graph

79 Commits

Author SHA1 Message Date
rob gay
e637f1ecef Fix for multiple referenced nodes of the same asset class not all auto-updating their interface when placed on multiple pages of the same MetaSound asset.
#jira UE-226390
#rnx
[FYI] jon.huller, sondra.moyls
#rb helen.yang

[CL 36871971 by rob gay in 5.5 branch]
2024-10-04 14:27:34 -04:00
helen yang
91c4370a7c Fix issues with MetaSound member metadata (ex. float input range) (changes not being serialized + values not inherited on preset creation)
#jira UE-222950
#jira UE-164990
#rb Rob.Gay

[CL 36024546 by helen yang in ue5-main branch]
2024-09-04 17:35:04 -04:00
rob gay
97b2aa8d74 Editor support for MetaSound Paged Input Defaults
#jira UE-193186, UE-219821
#rb helen.yang
#rnx
[FYI] Seth.Weedin, sondra.moyls, jon.huller

[CL 35844323 by rob gay in ue5-main branch]
2024-08-27 19:05:41 -04:00
rob gay
4bcc279ddd Add initial page implementation of input class default literals
#jira UE-219821
#rb phil.popp
#rnx

[CL 35115150 by rob gay in ue5-main branch]
2024-07-26 14:23:35 -04:00
rob gay
496613928a Fixed cook issues ([Backout] - CL34114021)
- Fixed regression with referencing graphs not updating
#tests AudioQA -cook
[FYI] hilda.cruz

Original CL Desc
-----------------------------------------------------------------
[Backout] - CL34112568 due to autotest error.
#rnx
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
More protections around accessing the wrong builder via the MetaSound builder registry by supplying the TopLevelPath of the asset if available when the registry has multiple conflicting entries due to bad content.
#rb helen.yang
#jira UE-216533
#rnx
[FYI] sondra.moyls

[CL 34125321 by rob gay in ue5-main branch]
2024-06-05 11:00:21 -04:00
hilda cruz
66ba34fea1 [Backout] - CL34112568 due to autotest error.
#rnx
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
More protections around accessing the wrong builder via the MetaSound builder registry by supplying the TopLevelPath of the asset if available when the registry has multiple conflicting entries due to bad content.
#rb helen.yang
#jira UE-216533
#rnx
[FYI] sondra.moyls

[CL 34114022 by hilda cruz in ue5-main branch]
2024-06-04 22:37:34 -04:00
rob gay
5bbc4d55ac More protections around accessing the wrong builder via the MetaSound builder registry by supplying the TopLevelPath of the asset if available when the registry has multiple conflicting entries due to bad content.
#rb helen.yang
#jira UE-216533
#rnx
[FYI] sondra.moyls

[CL 34112574 by rob gay in ue5-main branch]
2024-06-04 20:25:06 -04:00
rob gay
711a973c73 - Move MetaSoundAssetSubsystem& BuilderSubsystem implementations to monolithics that are initialized at MetaSoundEngine module load for safety
- Avoids PreDefault vs Default module Init which can interact negatively and obscurely with EngineSubsystems not being loaded prior to certain builds/scenarios where serialized assets are loaded earlier
- Sunset existing Subsystem non-UFUNCTION calls not pertaining to direct Blueprint exposition
- Optimize AssetManager to use own key vs NodeRegistryKey and TopLevelPaths vs SoftObjectPaths
- Misc module clean-up
- Misc callsite refactors to use new monolithics
#rb phil.popp
[FYI] sondra.moyls, helen.yang

#tests EngineTest & AudioQA Automation PIE Packaged Build -game

[CL 33522338 by rob gay in ue5-main branch]
2024-05-08 14:53:53 -04:00
rob gay
b3ab5744bf - Fix for attempting to access EngineSubsystem during MetaSound versioning (serialization), which can assert when apparently certain commands in certain contexts can attempt to preload assets prior to the init phase.
- Minor Fix for LocText duplication
#tests BuildCookRun, -game, version MetaSounds assets in editor, PIE

[FYI] bob.tellez
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL33084850
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33102023 by rob gay in ue5-main branch]
2024-04-19 10:09:04 -04:00
bob tellez
416e6c17d8 [Backout] - CL33084850
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33096249 by bob tellez in ue5-main branch]
2024-04-18 23:43:05 -04:00
rob gay
184db3803e Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33085078 by rob gay in ue5-main branch]
2024-04-18 16:50:48 -04:00
marc audy
56a32fea9d Silence false V621, V654, and V1078 warnings mostly caused by TStaticArray, placement new, or population of the array inside a lambda
[CL 30587485 by marc audy in ue5-main branch]
2024-01-12 00:52:57 -05:00
AdricEpic
473f754908 - Registration Race Condition Fixes (Attempt #2 w/ cook fixes)
- Part 1/2 fixing inconsistent file naming that is causing code query tool slowdowns (2/2 will be deprecating old MetasoundFrontendRegistries.h header path)
- Replace SoftObjectPaths with TopLevelAssetPaths for perf (ObjPaths do string copies all over, TopLevelAssetPaths are just two FNames)
#rb helen.yang
#rnx
[FYI] sondra.moyls
#tests AudioQA/EngineTest MetaSound Automated Tests, AudioTests, cook WindowsClient, submit and backout and then fix those problems
#jira UE-198785

[CL 30354102 by AdricEpic in ue5-main branch]
2023-12-15 13:21:12 -05:00
rob gay
65111a0774 Fix for cook errors, undo changelist 30246187
#rb helen.yang
#rnx

[CL 30255375 by rob gay in ue5-main branch]
2023-12-11 20:36:24 -05:00
rob gay
a876bffd23 - Registration Race Condition Fixes
- Part 1/2 fixing inconsistent file naming that is causing code query tool slowdowns
- Replace SoftObjectPaths with TopLevelAssetPaths for perf (ObjPaths do string copies all over, TopLevelAssetPaths are just two FNames)
#rb helen.yang
#rnx
#tests AudioQA MetaSound Automated Tests, AudioTests
#jira UE-198785

[CL 30246215 by rob gay in ue5-main branch]
2023-12-11 14:43:42 -05:00
rob gay
500da9cd81 Fix async references not yet registered when auto-updating in editor
[FYI] phil.popp
#rb phil.popp

[CL 29283719 by rob gay in ue5-main branch]
2023-10-31 14:24:48 -04:00
rob gay
94048f43ca - Make FNodeRegistryKey an actual struct as opposed to a string alias
- Avoids string format/copies/conversions in most cases where its just used as a key
- Deprecate NodeRegistryKey namespace calls
#rb phil.popp
#rb helen.yang

[CL 28727626 by rob gay in ue5-main branch]
2023-10-12 16:37:45 -04:00
helen yang
1dd6972b5c Change MetaSound AutoUpdate warning verbosity level for cook
#rb rob.gay

[CL 28688359 by helen yang in ue5-main branch]
2023-10-11 18:37:59 -04:00
Rob Gay
86015d61b0 - Refactor node template transforms to support addition/removal of self (iterate & pass node ID instead of reference to avoid invalidating calling iterator)
- Misc clean-up to reroute transform to make clearer and more concise
- Add ability to override tooltip for template node warnings & place existing reroute specific warning in reroute transform
#jira UE-194159
#rnx

[CL 27640602 by Rob Gay in ue5-main branch]
2023-09-06 12:54:02 -04:00
Rob Gay
0ce9da005d Prepare code to preprocess MetaSound cooked layers/pages
- Move reroute preprocessing to Builder API
- Fix for potential memory scribble when deleting output edges in builder
- Move builder to use deterministic guid generation where necessary
#rb helen.yang
#rb phil.popp
#jira UE-194159
#rnx

[CL 27615214 by Rob Gay in ue5-main branch]
2023-09-05 17:54:02 -04:00
Rob Gay
b8c30dfd08 Remove creation of redundant document handle
#rb helen.yang
#rnx
#jira none

[CL 27145259 by Rob Gay in ue5-main branch]
2023-08-16 13:21:17 -04:00
Rob Gay
e78fce4c68 Add tags for InitParams & RebuildGraph MS transforms for more perf analysis datapoints
#rb trivial
#jira none
#rnx

[CL 27018471 by Rob Gay in ue5-main branch]
2023-08-10 20:04:23 -04:00
helen yang
fa585989cf Fix ensures when migrating MetaSound assets
- Create new class names for temporary packages created during migration to avoid duplicate node registration
- Change duplicate node registration ensure to if check with better logging of asset causing collision

#jira UE-161039
#jira UE-175059
#jira UE-188854
#rb rob.gay

[CL 26299244 by helen yang in ue5-main branch]
2023-06-28 17:08:29 -04:00
helen yang
07268d51d2 MetaSound deterministic id generation
- Deterministic generation of ids for various FGuids used in MetaSound documents so that Autoupdate can be moved from runtime to cook in the future while maintaining cook determinism
- cvar for enabling in editor au.MetaSound.EnableDeterministicIDGenerationInEditorCVar

#jira UE-176939
#jira UE-176940
#rb phil.popp

[CL 26126897 by helen yang in ue5-main branch]
2023-06-20 13:12:39 -04:00
helen yang
cc09fda972 Expand and consolidate MetaSound builder preset asset functionality
- Added document builder and BP functions for SetGraphInputDefault, ConvertFromPreset, ConvertToPreset, CreatePatch/SourcePresetBuilder, IsPreset
- Refactor MetaSound asset and preset initialization to use builder architecture more

#jira UE-185391
#rb rob.gay
#preflight 64710f423b73ebeef4c295bb

[CL 25683338 by helen yang in ue5-main branch]
2023-05-30 14:39:48 -04:00