Commit Graph

12506 Commits

Author SHA1 Message Date
wouter burgers
2ced1e32ad SourceControl: Fixed UnsavedAssetsAutoCheckout checking out assets that are no longer dirty.
During world recreation, which is triggered by REVERT ALL and SYNC ALL, some assets are temporarily dirty'd by the reload world code because it destroys the old world instance and recreates a new world instance (see: UEditorEngine::NewMap). By the time this code block finishes, the assets are no longer dirty but the events will have been broadcasted by the UnsavedAssetsTracker, resulting in UnsavedAssetsAutoCheckout checking out assets that aren't dirty (anymore).

[REVIEW]
#preflight none

[CL 23797456 by wouter burgers in ue5-main branch]
2023-01-20 16:40:40 -05:00
marco anastasi
b29f599449 * Refactored Sync Latest operation to improve performance
* Sync Latest no longer listing and reloading all packages when the source control provider provides a sync preview functionality. When a Sync Preview is available, Sync Latest unloads only the files that are going to be overwritten by the sync operation, and then reloads them and the world

* Refactored Revert All operation to improve performance
* Revert All no longer lists and reloads all packages when the source control provider provides a sync preview functionality. Instead it unloads only the files that may be overwritten by the revert operation (i.e. submittable files), and then reloads them and the world
* Replaced RevertAndReloadAllPackages with RevertAndReloadWorld, no longer listing and reloading all packages (see https://p4-swarm.epicgames.net/reviews/23244245/)

This review is a combination of the two archived reviews https://p4-swarm.epicgames.net/reviews/23736137 and https://p4-swarm.epicgames.net/reviews/23736282

#rb wouter.burgers, stuart.hill, brooke.hubert, francis.hurteau
#preflight 63c9c7786a00f3cc8ead6779

[CL 23796067 by marco anastasi in ue5-main branch]
2023-01-20 15:31:16 -05:00
sara schvartzman
d864a531ad Control Rig: Fix RigVM.Graph.NodeSelection and RigVM.UndoRedo.ClearSelection unit tests failing
#jira UE-174563
#rb trivial
#preflight https://horde.devtools.epicgames.com/job/63cadf8c91521d87fef008d9

[CL 23794037 by sara schvartzman in ue5-main branch]
2023-01-20 13:49:15 -05:00
Dan Thompson
9630f87172 Removing storing the hashes of chunk types other than bulk and external file, because Zen stores packed data before its hit by the PackageOptimizer under the same chunk id, so it doesn't match the data that ends up in the iostore containers.
#rb matt.peters
#preflight 63cad462243c2d811953ae52

[CL 23793142 by Dan Thompson in ue5-main branch]
2023-01-20 13:06:32 -05:00
Tim Smith
0fb5daa752 Removed HACK_HEADER_GENERATOR
#rb devin.doucette
#preflight 63cad02ca265157a6d5159af

[CL 23792667 by Tim Smith in ue5-main branch]
2023-01-20 12:47:21 -05:00
ionut matasaru
3e8534965a [Insights] Minor code style fixes.
#rb trivial
#preflight 63cad0911835336af8fa3f04

[CL 23792629 by ionut matasaru in ue5-main branch]
2023-01-20 12:45:59 -05:00
joe pribele
12cd475b42 changed REQUIRE_CHECK and REQUIRE_ENSURE test macros to disable themselves if DO_CHECK or DO_ENSURE it not enabled
this allows usage of REQUIRE_CHECK to not have to be guarded

https://p4-swarm.epicgames.net/reviews/23784409

#rb devin.doucette
#preflight 63cacd481835336af8f9bb2e

[CL 23792394 by joe pribele in ue5-main branch]
2023-01-20 12:35:12 -05:00
nick darnell
496d9a03a6 AssetDefinitions - Removing files I missed.
[CL 23791514 by nick darnell in ue5-main branch]
2023-01-20 11:50:17 -05:00
nick darnell
58645cbc15 Editor Performance - Fixing a long standing issue with asset thumbnails, they've been loading the assets for a pretty long time now, because of the thumbnail editing mode. Note that thumbnail editing mode was not needed to be enabled and yet the asset would still load. This was a cause for a lot of hitches in the Content Browser.
AssetDefinition - Working on the asset definitions for blueprints/class types, iterating on the Merge API.  Bringing over more of the blueprint features into its asset definition, unregistered the Blueprint AssetType Actions.

Asset Filters - We now support categories per filter, this enables a single asset definition to correctly specify multiple filters.  For example, blueprints actually supply 4 filters, one for blueprints, but also blueprint interfaces, macros and function libraries.

[CL 23791489 by nick darnell in ue5-main branch]
2023-01-20 11:49:23 -05:00
ionut matasaru
5887cc6065 [Insights] MemoryInsights: Added warning when detecting unsupported memory trace versions (supported versions are 1 and 2).
#rb Catalin.Dragoiu
#rb Johan.Berg
#preflight 63cac136243c2d81194a0600

[CL 23791467 by ionut matasaru in ue5-main branch]
2023-01-20 11:47:23 -05:00
Devin Doucette
d51817a175 Logging: Updated Mac feedback contexts to support structured logging
This relies on the base feedback context doing most of the work, as on other platforms.

Coloring was removed from the default Mac feedback context because it has no effect on the default output devices anyway. Output devices that do want to set color based on verbosity should incorporate that logic themselves in a thread-safe way instead of relying on the color being changed globally.

#jira UE-152840
#preflight 63cabcf76e7995c750c919da
#rb Zousar.Shaker
#rnx

[CL 23790894 by Devin Doucette in ue5-main branch]
2023-01-20 11:19:46 -05:00
halfdan ingvarsson
0179db1d12 Fix issues with alternate skin profiles and high-precision skin weights
#preflight 63c746a702024f93d88fb1e4
#rb alexis.matte
#jira none
#rnx

[CL 23790797 by halfdan ingvarsson in ue5-main branch]
2023-01-20 11:12:19 -05:00
dan elksnitis
be95382d48 [shaders] factor out single-input compilation and exception handling into shared utility functions
#preflight 63caa36ad45afa2a8f236855
#rb Jason.Nadro
#rb Laura.Hermanns
#rb Yuriy.ODonnell

[CL 23789494 by dan elksnitis in ue5-main branch]
2023-01-20 09:39:05 -05:00
Laura Hermanns
325df88cbd Include SPIR-V header from SPIRV-Headers folder instead of SPIRV-Reflect.
#rb Jason.Nadro
#jira none
#rnx
#preflight 63c968fd0274c9f5fb6ed1e4

[CL 23789338 by Laura Hermanns in ue5-main branch]
2023-01-20 09:25:39 -05:00
Martin Ridgers
1fb8d0b70e More robust analysis of trace streams where a large distance occurs between consecutive serialised events on different threads.
The main premise of this change is to order the heap of pending serialised events by distance from the next expected serial instead of in respect to each other. By using an unsigned comparison, wrapped serials that would otherwise appear on the negative side of the expected serial, in fact sort to the positive side. This allows the use of the full serial space as wraps no longer need to be calculated when sorting.
#rb jb
#rnx
#preflight 63caa0e6894b6403149bf5c0

[CL 23789248 by Martin Ridgers in ue5-main branch]
2023-01-20 09:17:33 -05:00
Johan Berg
e0c6d5e142 [Insights] Make MessageLog tab docked by default
This change makes space for the message log window in the tab manager. Whenever the window is opened it shows up as a tab.
#preflight 63ca58025471dab5d5647be7

[CL 23787323 by Johan Berg in ue5-main branch]
2023-01-20 04:06:21 -05:00
David Harvey
0158397359 Legacy Session Frontend profiler should be less likely to lose the connection during live data preview.
Root cause was the Editor/UFE framerate dropping too low when there was a lot of stat data arriving. This meant the keep-alive Ping request from the game could not be acknowledged fast enough to avoid the 5s disconnection timeout.

 - decompress incoming stat messages via a task pipe to avoid saturating all cores.
 - only process a few stat messages per frame.
 - reduce the timeslice for stat aggregation during live data preview.

However, if bandwidth is saturated (typically by a very large amount of log spam being sent to the Session Frontend too) then the connection can still be lost.

Note: It's recommended to use Unreal Insights instead of the Session Profiler for UE5.

#jira UE-174072
#rb Ionut.Matasaru, Francis.Hurteau
#rnx
#preflight 63ca5570894b640314806628

[CL 23787313 by David Harvey in ue5-main branch]
2023-01-20 04:03:59 -05:00
jamie dale
709e97ade9 Default to exporting localization files with the copyright notice set on the project
This can also be overridden using the "CopyrightNotice" option in the "CommonSettings" of a GatherText config

#preflight 63c9c142d368fed9e5d07f7a
#rb Leon.Huang

[CL 23784893 by jamie dale in ue5-main branch]
2023-01-19 20:48:37 -05:00
ionut matasaru
90adaa479d [Insights] Fixed FSbTree::SetTimeForEvent for cases where an Alloc or Free event is generated from within analysis (like in case of zero size allocs generated for unmatched free events or for free events generated to free allocs from heaps).
#rb none
#preflight 63c9cef80434dba5741e5e93

[CL 23783515 by ionut matasaru in ue5-main branch]
2023-01-19 18:36:35 -05:00
ionut matasaru
45b61cf31c [Insights]
- MemoryInsights: Moved FAllocationItem and FAllocMap (renamed from FAllocsMap) into their own header files.
  - MemoryInsights: Added debug logs to track edit API calls in FAllocationsProvider (can be enabled using API INSIGHTS_API_LOGF).
  - MemoryInsights: Fixed few includes.

#rb none
#preflight 63c9c7c80434dba57418608d

[CL 23782768 by ionut matasaru in ue5-main branch]
2023-01-19 18:01:16 -05:00
dj schilens
6548d72e8c Advanced Copy - Optional callback when copy is complete, and expose to blueprints
* Adds a new delegate for when AdvancedCopy is complete (since Advanced Copy is async and can't return the results directly)
* Adds a new blueprint callable overload for AdvancedCopy in the AssetTools interface that optionally takes this callback

[REVIEW] [at]matt.peters [at]brooke.hubert

[CL 23781823 by dj schilens in ue5-main branch]
2023-01-19 17:12:52 -05:00
nick darnell
7c56e6c4d1 AssetDefinition - Upgrading several skeletal and animation assets to be asset definitions. Had to upgrade a few utilities that were causing the assets to still load.
#jira UE-165574

[CL 23781708 by nick darnell in ue5-main branch]
2023-01-19 17:09:58 -05:00
dan elksnitis
e76b6207a1 [shaders] remove unneccessary global vars from D3D compile backend
#preflight 63c980120274c9f5fb7a3434
#rb Yuriy.ODonnell
#rb Jason.Nadro

[CL 23778371 by dan elksnitis in ue5-main branch]
2023-01-19 14:36:43 -05:00
aidin abedi
88e9765627 Improve ImageComparer by extending FComparableImage to be more straightforward when comparing images that are only in-memory.
#jira UE-173166
#preflight 63c502d70225f00e14f28aff
#review @yuriy.odonnell

[CL 23776626 by aidin abedi in ue5-main branch]
2023-01-19 12:51:53 -05:00
henrik karlsson
1dc10ba736 Fixed non unity compile errors in NNERuntimeORT, PartyPlatformSessionMonitor and Analysis.h
#preflight 63c97edeb0652247503efcbd
#rb none
#jira none

[CL 23776291 by henrik karlsson in ue5-main branch]
2023-01-19 12:42:13 -05:00