Commit Graph

100 Commits

Author SHA1 Message Date
Marc Audy
d46179b265 Don't rename selection set in to the PIE world as that has a number of knock on problems
Selection set will not be added to the transaction buffer if it contains any PIE objects
Transaction will not actually be created when clicking on a PIE object in the scene outliner
#codereview Matt.Kuhlenschmidt, Richard.TalbotWatkin

[CL 2606122 by Marc Audy in Main branch]
2015-06-30 14:05:38 -04:00
Nick Darnell
d287c6143f More Gamma Correction - Didn't catch this on the previous pass, apparently there was an implicit constructor allowing FLinearColor to FColor that was doing pow(2.2) gamma conversion inversion. Rather than leave the implicit constructor, I'm making it private and making people use ToFColor(true). Which is slightly more expensive, but performs the proper sRGB conversion. While fixing this, I found several terrible uses of the implicit constructor, when Hashing FLinearColors we were converting them to FColors first, when clearing FCanvas we were manually gamma correcting but leaving it as an FLinearColor, then implicitly converting to FColor, double gamma corrrecting. Neither of which should even be required as the RHI Clear command expects an FLinearColor. Additionally fixing a myriad of Slate widgets that were all doing FColor conversions needlessly only to convert back to FLinearColor when queuing slate draw commands.
#codereview nick.penwarden, martin.mittring, andrew.brown, gareth.martin

[CL 2593605 by Nick Darnell in Main branch]
2015-06-19 11:17:11 -04:00
Jamie Dale
fe2c01e3c0 Ensured that everything in the editor using a TTextFilter is reporting syntax error information back to the user
[CL 2582959 by Jamie Dale in Main branch]
2015-06-10 13:22:27 -04:00
Chris Wood
8a112d6140 PushMenu() now respects QueryPopupMethod(). All menus now support reusing windows.
UE-14641 - Fix PushMenu() to use QueryPopupMethod()

Pretty big refactor
Adds IMenu as way to identify menus. Replaces referring to menus as SWindows.
Lots of uses of PushMenu() fixed up to match new API

#codereview Nick.Atamas

[CL 2579277 by Chris Wood in Main branch]
2015-06-05 20:19:33 -04:00
Andrew Rodham
8ff0d8b98b Added config migration path for newer versions of the engine.
Newly installed versions of the engine will now attempt to copy the project-agnostic config settings from a previous engine installation. This happens by way of a versioned manifest that copies old versions when the manifest does not exist, or is a different version. This code path is benign for non-installed versions of the engine (or FPaths::ShouldSaveToUserDir() is false).

EditorGameAgnosticSettings and EditorUserSettings ini paths have been renamed to EditorSettings and EditorPerProjectUserSettings respectively to better convey their purpose. In general, most settings should be saved in EditorSettings (project-agnostic) so that they apply regardless of which project is open. We have some way to go migrating existing settings for this to be the case, however.

Some previously per-project configuration files are now project-agnostic (such as Editor.ini, EditorKeyBindings.ini, and EditorLayout.ini)

GEditor->Access...Settings and GEditor->Get...Settings have been removed in favor of direct access of the CDO through GetMutableDefault<> and GetDefault<> respectively. Global config ini filenames that are not set up are now neither loaded nor saved on build machines, to handle the problem of indeterminate state more generically.

This addresses UETOOL-270 (Most editor preferences should be project-agnostic)

[CL 2517558 by Andrew Rodham in Main branch]
2015-04-20 10:12:55 -04:00
Adric Worley
e578e2d7cd Separate automated system tests from project-specific tests
[CL 2514485 by Adric Worley in Main branch]
2015-04-16 12:40:47 -04:00
Richard TalbotWatkin
dcbedf3fa6 Deleting folders in the World Outliner now promotes all children to the level above instead of directly to the root.
#jira UE-12338 - Level Editor: Deleting a folder item within another folder item in the World Outliner results in the instances "contained" within the deleted folder item being moved to the root level rather than to underneath the parent folder item.

[CL 2506580 by Richard TalbotWatkin in Main branch]
2015-04-09 05:36:40 -04:00
Mike Fricker
114458bf0f Clang warning fixes: Fixed missing 'override' specifiers
- Also removed some unreferenced functions that adding 'override' revealed

PR #1002 -- Thank you, Omar007!

[CL 2498415 by Mike Fricker in Main branch]
2015-04-01 07:20:55 -04:00
Dan Oconnor
f4d3d65662 PR #968: Fixing PVS-Studio warnings (Contributed by PaulEremeeff)
These can be generally described as removing redundant condition checks, using logical operators instead of bitwise operators, removal of redundant parenthesis, and consistent use of pragma push and pragma pop. There is very little observable behavior change in this CL.

Changes that required further review are pending in 2489753

[CL 2489804 by Dan Oconnor in Main branch]
2015-03-24 15:51:28 -04:00
Andrew Rodham
44c693b416 Fixed clang compile error
[CL 2484655 by Andrew Rodham in Main branch]
2015-03-19 12:07:57 -04:00
Andrew Rodham
0594e62b39 Fixed "select immediate children" in the world outliner selecting recursively
This addresses UE-7385.

[CL 2484470 by Andrew Rodham in Main branch]
2015-03-19 10:23:29 -04:00
Jaroslaw Palczynski
f23f29257b Back out changelist 2481333
Rob asked me to back out GENERATED_*_BODY -> GENERATED_BODY change for now until the "_Validate and _Implementation auto-generation" discussion is over.

#codereview Robert.Manuszewski

[CL 2481343 by Jaroslaw Palczynski in Main branch]
2015-03-17 05:38:32 -04:00
Jaroslaw Palczynski
fa31560e2d Enabled UHT to digest GENERATED_BODY instead of GENERATED_UCLASS_BODY, GENERATED_USTRUCT_BODY, GENERATED_UINTERFACE_BODY or GENERATED_IINTERFACE_BODY, changed every occurence to the new syntax and fixed every warning that have fallen out of this change.
#codereview Robert.Manuszewski

[CL 2481333 by Jaroslaw Palczynski in Main branch]
2015-03-17 05:19:11 -04:00
Nick Atamas
f48d663699 TabManager : Hitting ESC will interrupt the current drag drop. NOTE: It will not restore the dragged widget to its original location.
Fixes: UE-1232.

Also, SceneOutliner no longer handles DockingDrag operations erroneously.

[CL 2478891 by Nick Atamas in Main branch]
2015-03-13 14:27:57 -04:00
Phillip Kavan
1d4f615687 [UE-8455] Remove level blueprint items from the World Outliner view.
change summary:
- removed FLevelBlueprintTreeItem.h/cpp and related code (per discussion threads)

#codereview Andrew.Rodham

[CL 2472915 by Phillip Kavan in Main branch]
2015-03-09 15:55:02 -04:00
Marc Audy
79f610442c Fix shadowed variables
[CL 2467803 by Marc Audy in Main branch]
2015-03-03 12:30:55 -05:00
Dan Hertzka
81af1217a2 [UE-10081] - Right-clicking an actor in the scene outliner always deselects components (even if the actor was already selected), so the proper context menu shows
- Removed the actor context menu options from the actor root in the components tree; can now only paste a component onto it
    -> Necessary because multiple details panels can be open and locked to different actors, so the context menu options would not necessarily pertain to the right-clicked actor root
- Fixed ProcesFCustomizableTextObjectFactory::ProcessBuffer attempting to load an archetype when none had been parsed from T3D

[CL 2453563 by Dan Hertzka in Main branch]
2015-02-20 13:46:19 -05:00
Andrew Rodham
d49e40d8b9 Non-unity compile fix
[CL 2451390 by Andrew Rodham in Main branch]
2015-02-19 03:53:06 -05:00
Andrew Rodham
c9ae6584e0 Added "Create Folder" to Level Root world outliner context menu
This addresses UE-8541

[CL 2450185 by Andrew Rodham in Main branch]
2015-02-18 10:45:40 -05:00
Andrew Rodham
85741ba8ef Child actors can no longer be dragged around in the scene outliner
They should be tied to their parent, and thus can no longer be re-parented using the scene outliner.
This addresses UE-7781 - Can attach a Child Actor to an Actor that isn't its parent.

[CL 2450128 by Andrew Rodham in Main branch]
2015-02-18 10:08:12 -05:00
Matthew Griffin
17b59eeea9 [INTEGRATE] Change 2440620 by Mike.Fricker@MFRICKER_G3686_Alpha on 2015/02/10 18:23:29
Changed color for dynamically spawned actors from blue to yellow
	- The color blue is usually used for Blueprint-related objects in UE4

[CL 2448571 by Matthew Griffin in Main branch]
2015-02-17 08:55:37 -05:00
Matthew Griffin
c787e8225e [INTEGRATE] Change 2436957 by Michael.Noland@mnoland-T2784-Reference on 2015/02/07 16:50:14
Editor: Show hyperlinks for native classes in the world outliner, as long as they are game-specific classes

[CL 2446952 by Matthew Griffin in Main branch]
2015-02-16 08:38:52 -05:00
Matthew Griffin
532700480b [INTEGRATE] Change 2436874 by Michael.Noland@mnoland-T2784-Reference on 2015/02/07 15:05:06
Editor: Add standard colors for Blueprint/Native text references to editor style
	- Update hyperlinks and components tree to use the standard color (native links are now greener)
	- Improve selection behavior for these colorized text fields so they are still readable
	- Remove some dead style entries
	[UE-8717]

[CL 2446936 by Matthew Griffin in Main branch]
2015-02-16 08:32:32 -05:00
Matthew Griffin
535c699092 [INTEGRATE] Change 2427067 by Matt.Kuhlenschmidt@matt_kuhlenschmidt_main on 2015/01/31 11:47:42
Renamed Scene Outliner to World Outliner in UI

[CL 2435285 by Matthew Griffin in Main branch]
2015-02-06 09:03:00 -05:00
Matthew Griffin
4cfa804256 [INTEGRATE] Change 2426247 by Michael.Noland@mnoland-T2784-Reference on 2015/01/30 15:17:31
Scene Outliner: Add a tooltip to world settings and level blueprint labels indicating that you can edit them by double-clicking, since they don't display in the details view when selected [UE-8455] [UE-8457]

[CL 2433501 by Matthew Griffin in Main branch]
2015-02-05 09:18:16 -05:00