Newly installed versions of the engine will now attempt to copy the project-agnostic config settings from a previous engine installation. This happens by way of a versioned manifest that copies old versions when the manifest does not exist, or is a different version. This code path is benign for non-installed versions of the engine (or FPaths::ShouldSaveToUserDir() is false).
EditorGameAgnosticSettings and EditorUserSettings ini paths have been renamed to EditorSettings and EditorPerProjectUserSettings respectively to better convey their purpose. In general, most settings should be saved in EditorSettings (project-agnostic) so that they apply regardless of which project is open. We have some way to go migrating existing settings for this to be the case, however.
Some previously per-project configuration files are now project-agnostic (such as Editor.ini, EditorKeyBindings.ini, and EditorLayout.ini)
GEditor->Access...Settings and GEditor->Get...Settings have been removed in favor of direct access of the CDO through GetMutableDefault<> and GetDefault<> respectively. Global config ini filenames that are not set up are now neither loaded nor saved on build machines, to handle the problem of indeterminate state more generically.
This addresses UETOOL-270 (Most editor preferences should be project-agnostic)
[CL 2517558 by Andrew Rodham in Main branch]
Not changing the existing behavior, although unsure whether it matches the intent in some cases.
Rule of thumb: when || and && are in the same scope, they are evaluated as if && was in parentheses
E.g.
Pointer && Pointer->Foo() || Pointer->Bar()
is evaluated as
(Pointer && Pointer->Foo()) || Pointer->Bar()
(I fixed such cases in changelists before this one as they were certainly unsafe).
#codereview Nicholas.Davies, Matt.Kuhlenschmidt, Gareth.Martin, Daniel.Wright, Mike.Beach, Maciej.Mroz, Simon.Tovey, Michael.Schoell
[CL 2362986 by Dmitry Rekman in Main branch]
Breaking changes include:
* Rename of GEditorModeTools -> GLevelEditorModeTools to signify that it applies only to the level editor modes
* Addition of FEditorModeRegistry, responsible for managing and creating new editor modes. Modes are no longer registered with an instance of the mode, instead with a mode factory that is able to create a new mode of that type.
* Editor modes now operate on FEditorViewportClients rather than FLevelEditorViewportClients
* Added ability to specify an FEditorModeTools when creating an FEditorViewport
Moved component vizualiser manager handling outside of individual editor modes, and into FLevelEditorViewportClient. This should make it easier to transplant in future.
This work addresses TTP#334640 - EDITOR: Investigate making editor modes a per-'editor' concept
Reviewed by Michael Noland, Matt Kuhlenschmidt
[CL 2109245 by Andrew Rodham in Main branch]
#ttp 337370 - EDITOR: CRASH: Placing an actor that has been renamed from the recently placed list results in an ensure
#branch UE4
#proj Editor.PlacementMode
#add Added new delegate to the OnAssetRenamed event (in FPlacementMode::Initialize / FPlacementMode::~FPlacementMode).
#add Created FPlacementMode::OnAssetRenamed which goes through the RecentlyPlaced array and amends the ObjectPath to the new path.
#reviewedby Chris.Wood
[CL 2108220 by Richard TalbotWatkin in Main branch]
#ttp 334592 - When an asset is deleted from the content browser, it should be removed from the 'recently placed' list as well to avoid confusion
#branch UE4
#proj Editor.PlacementMode
#add Added FPlacementMode::OnAssetRemoved, which forces a refresh of the recently placed list. Added a call to this method in the OnAssetRemoved event in AssetRegistryModule.
#add In SPlacementModeTools::RefreshRecentlyPlaced, the list of asset paths is iterated, and those which yield a valid FAssetData object are added to the widget container. In the case of a just deleted widget, the UObject is only marked as pending delete (it has had its RF_Standalone flag cleared), and a GC sweep cannot yet have happened, so it's necessary to explicitly check for this flag set when iterating.
[CL 2073929 by Richard TalbotWatkin in Main branch]
