UE-14641 - Fix PushMenu() to use QueryPopupMethod()
Pretty big refactor
Adds IMenu as way to identify menus. Replaces referring to menus as SWindows.
Lots of uses of PushMenu() fixed up to match new API
#codereview Nick.Atamas
[CL 2579277 by Chris Wood in Main branch]
With many particle emitters open, perf tanks. Cascade is ticking even if the editor tab is not visible/active, which can cause all sorts of performance issues. Cascade ticks through engine tick, so the only way to properly avoid this is to check for ticking of the viewport widget; added a flag to it to keep track of ticking in the last frame, then checking and clearing that in the Cascade tick function.
#codreview nick.atamas dave.ratti
[CL 2523454 by Olaf Piesche in Main branch]
On mac, window activation is not guaranteed syncronously when a window is created, thus any code that opened a window, then immediately opened some focus-sensitive operation, may fail.
I've fixed up three of the most common cases (SAssetView::ItemScrolledIntoView, STextEntryPopup and STextComboPopup) so they register an active tick to focus the widget when the window gains focus (optionally controllable from the .AutoFocus() argument)
This addresses UE-12929.
[CL 2521062 by Andrew Rodham in Main branch]
I have reviewed each change carefully, but it is a large change and I could have missed something! Here is a summary of the types of changes in this CL:
* Made nullptr checks consistent (the plurality of the changes are of this type)
* Completed switch statements (IE, switch did not explicitly handle default case, but had unhandled enum entries - this is the second most popular type of fix)
* Removed unused variables
* Removed redundant initializations
* WidgetNavigationCustomization.cpp was fixed by the owner
* integers converted to floats where result was stored in a float
* Removed redundent null checks (e.g. before delete statements)
* Renamed variables to prevent non-obvious shadowing
* Fixed use of bitwise & when checking for equality to an enum entry (which is often 0)
* Fixes for some copy paste errors (e.g. FoliageEdMode.cpp)
[CL 2498053 by Dan Oconnor in Main branch]
Rob asked me to back out GENERATED_*_BODY -> GENERATED_BODY change for now until the "_Validate and _Implementation auto-generation" discussion is over.
#codereview Robert.Manuszewski
[CL 2481343 by Jaroslaw Palczynski in Main branch]
Editor - Removing some old code that causes crashes in the editor when attempting to click on viewport menu anchors under low framerates, or when the frame rate is articially low, like coming back from the window not being focused. The viewport toolbar no longer attempts to collapse when the frame rate is low, or the window is not focused.
[CL 2436762 by Matthew Griffin in Main branch]
- SEditorViewportClient now has an additional optional parameter in its constructor for the SEditorViewport that the client is attached to
- SBasePoseViewport, SDestructibleMeshEditorViewport, and SPhATPreviewViewport were all updated to inherit from SEditorViewport (previously just inherited from SCompoundWidget)
[CL 2398765 by Dan Hertzka in Main branch]
#jira UE-1204 - CRASH: EDITOR: CASCADE: Undo convert to a seeded module does not correctly undo the action and can lead to a crash
[CL 2374538 by Richard TalbotWatkin in Main branch]
