Commit Graph

28 Commits

Author SHA1 Message Date
Michael Schoell
c246c1f538 Math Expression nodes will again correctly lookup by the display name of a function.
Changed metadata lookups that were still targetting FriendlyName to lookup the DisplayName.

#jira UE-17602 - Unable to use floor() in math expression node (display name), must use ffloor()

[CL 2602420 by Michael Schoell in Main branch]
2015-06-26 11:59:50 -04:00
Maciej Mroz
9c65f62697 UE-17607 Crash attempting to vect != vect in Math Expression Node
#codereview Mike.Beach

[CL 2600255 by Maciej Mroz in Main branch]
2015-06-25 04:54:12 -04:00
Michael Schoell
9347859ab2 Math expression functions without any parameters will still provide their end parenthesis in the Math Expression node.
#jira UE-17418 - Math Expression node unclosed parenthesis in name if expression starts with rand()

[CL 2597330 by Michael Schoell in Main branch]
2015-06-23 12:37:06 -04:00
Maciej Mroz
5ec4b83d35 For the simplest cases MathExpresion will be expanded the old way. The RPE optimization cannot handle the exoression without any function call.
Cases:
- literal - "3.14"
- variable access - "MyVar"
- new local variavle - "a"

UE-17139 Math Expressions fail to compile when output pin connected

[CL 2591759 by Maciej Mroz in Main branch]
2015-06-18 06:55:28 -04:00
Maciej Mroz
15e44a1b6e ME Optimization:
- FBPTerminal::InlineGeneratedParameter added - the result of the function is directly used as input parameter, it's not stroed in a lical variable
- FKismetFunctionContext::InlineGeneratedParameter
- MathExpressionHandler - compile (to out intermediate representation) a subgraph using "reverse polish notation" approach
- Math Expression node is not longer expanded
- VMBackend supports InlineGeneratedParameter and InlineGeneratedParameter

#codereview Nick.Whiting, Mike.Beach

[CL 2587365 by Maciej Mroz in Main branch]
2015-06-15 10:54:30 -04:00
sebastian kowalczyk
c46f070ab2 Fixed non unity build.
[CL 2584110 by sebastian kowalczyk in Main branch]
2015-06-11 09:50:36 -04:00
Michael Schoell
24e8feab5f Math Expression nodes will no longer always appear as changed when doing a diff on a Blueprint.
The Math Expression graph will be completely missing from the diff display, it is regenerated each time and the important detail is the math expression the user inputs. The node's math expression will show up if there are differences between two Blueprints.

#jira UE-9785 - Math expression nodes always appear in BP Diff

[CL 2582830 by Michael Schoell in Main branch]
2015-06-10 11:52:53 -04:00
Michael Schoell
48631ca1c9 Preventing MathExpression nodes from counting function inputs as valid variables to access via getter nodes.
#codereview Mike.Beach

[CL 2572543 by Michael Schoell in Main branch]
2015-06-01 11:24:10 -04:00
Michael Schoell
75062929e3 Added alias for ATAN to the MathExpression node so ARCTAN is also supported.
#jira UE-11570  - ATan is not available in a Math Expression

[CL 2528585 by Michael Schoell in Main branch]
2015-04-28 11:36:35 -04:00
Michael Schoell
63b7360ae0 Removed the Blueprint Editor's legacy node menu system.
#jira UE-13391 - Delete old BP menu system (is causing confusion)

#codereview Mike.Beach

[CL 2514361 by Michael Schoell in Main branch]
2015-04-16 11:47:54 -04:00
PaulEremeeff
c9a246101e PR #1013: Fixing PVS-Studio warnings. (Contributed by PaulEremeeff)
Some files have been omitted and will be submitted with modified corrections

[CL 2505544 by Dan Oconnor in Main branch]
2015-04-08 14:46:25 -04:00
Michael Schoell
b0ebc825d0 Math expression nodes now support variable renames without breaking and local variables can be used with them.
Behind the scenes, variables are converted to their Guid and are converted back to their name for display. The token parser was updated to handle these Guid's which are inside brackets { }.

Added some helper functions for looking up a Member Variable's Guid by name and a Member Variable's name by Guid.

#jira UE-9915 - Renaming Blueprint variables breaks MathExpression node on restart
#jira UE-12363 - Math expression node doesn't work with local variables.

[CL 2500113 by Michael Schoell in Main branch]
2015-04-02 14:24:15 -04:00
Michael Schoell
75200e5a0d Cached node titles can now be forced to refresh without iteration over every node.
This will occur with every structural modification to any BP, node titles refresh only when visible.

[CL 2499923 by Michael Schoell in Main branch]
2015-04-02 11:16:23 -04:00
Michael Schoell
5f3f433198 Can drag and drop pins onto a variety of K2Node_EditablePinBase nodes to add pins to them.
Shifted a lot of pin adding functionality from Blueprint Details customizion to the nodes themselves or BlueprintEditorUtils.

#jira UE-11334 - Dragging a pin to a node that can add pins (function entry/exit, custom events...) should add a pin of the type to the node.

[CL 2497224 by Michael Schoell in Main branch]
2015-03-31 10:32:10 -04:00
Michael Schoell
d96d07d065 Editing multiple Math Expression nodes will no longer cause a crash.
Changing the math expression will no longer mark the Blueprint structurally modified.

Kismet Inspector will now do a deferred refresh, waiting until the next tick to assign the new objects to the detail view.

#jira UE-7065 - Editing multiple Math Expressions will crash the editor

[CL 2428493 by Michael Schoell in Main branch]
2015-02-02 14:23:57 -05:00
Ben Marsh
149375b14b Update copyright notices to 2015.
[CL 2379638 by Ben Marsh in Main branch]
2014-12-07 19:09:38 -05:00
Jaroslaw Palczynski
7c41927cf4 Rename FPostConstructInitializeProperties to something simpler
Changed it with FObjectInitializer.

UECORE-7

[CL 2328384 by Jaroslaw Palczynski in Main branch]
2014-10-14 10:29:11 -04:00
Michael Schoell
b7ad5048b3 MathExpression node will no longer crash if placed in a Macro
Moved FinalNodeBackToMacroSourceMap into the CompilerResultsLog so compiling nodes can find their source nodes when they are contained within a Macro.

#ttp 346745 - LIVE: EDITOR: BP: CRASH: Editor crashes when using a math expression inside of a macro

[CL 2321338 by Michael Schoell in Main branch]
2014-10-07 12:27:44 -04:00
Michael Schoell
b9e9535fdc Added a new MenuTitle option for nodes to reduce issues with using ListView in a variety of circumstances. Fixes issues with some nodes being displayed by their palette action name in other menu lists.
[CL 2299888 by Michael Schoell in Main branch]
2014-09-16 15:01:38 -04:00
Mike Beach
27b65e9cab Keeping nodes from spawning unessecery menu actions (was causing a big memory spike for the new menu system).
[CL 2292953 by Mike Beach in Main branch]
2014-09-10 17:09:26 -04:00
Mike Beach
1dfbb2d829 Optimizing BP node titles (caching any that use FText::Format(), which is slow).
[CL 2282225 by Mike Beach in Main branch]
2014-09-02 19:08:09 -04:00
Mike Beach
1cfc231519 Handling enum/struct assets (so that the can be added into the blueprint menu database as they're created/updated).
Lots o' files!(changing UK2Node's GetMenuActions() function signature).

[CL 2269082 by Mike Beach in Main branch]
2014-08-23 20:16:29 -04:00
Michael Trepka
62e7793fa0 Another batch of fixes for Clang compile warnings
[CL 2237490 by Michael Trepka in Main branch]
2014-07-30 16:16:46 -04:00
Mike Beach
7923e88220 (WIP) Various standalone node types, adding themselves to the blueprint action database (for the new action menu system).
[CL 2214584 by Mike Beach in Main branch]
2014-07-14 16:05:25 -04:00
Michael Schoell
788de6f349 Removed GetNodeNativeTitle from the editor entirely, now uses BuildSourceString to obtain the source string in a more reliable way.
#codereview Justin.Sargent

[CL 2114371 by Michael Schoell in Main branch]
2014-06-23 15:36:50 -04:00