UK2Node_CallFunction::EnsureFunctionIsInBlueprint checks for the self pin being connected, if it is it will not change the function reference.
#jira UE-17073 - Duplicated blueprints cannot access casted class nodes
[CL 2606495 by Michael Schoell in Main branch]
change summary:
- added a new "InternalUseParam" UFUNCTION() meta to support tagging function parameters as internal use only (=> hidden | not connectable)
- added a UK2Node_CallFunction::IsConnectionDisallowed() override method; returns 'true' if the 'bNotConnectable' flag is set on the node's pin (and will emit a compile error in existing projects if something is connected to it)
- modified FBlueprintEditorUtils::GetHiddenPinsForFunction() to accept an optional 'InternalPins' TSet as an output; on return, this will contain the subset of hidden pins that are marked as "InternalUseParam"
- modified UK2Node_CallFunction::CreatePinsForFunctionCall() to set the 'bNotConnectable' pin attribute to 'true' if "InternalUseParam == '<PinName>'" is included within the UFunction metadata
- modified the AActor::AddComponent UFUNCTION() decl to switch the "HidePin" meta to "InternalUseParam" for the 'ComponentTemplateContext' parameter (because it should not be connectable)
- modified UK2Node_CallFunction::NotifyPinConnectionListChanged() to refresh the node to hide pins corresponding to internal-only params once the (invalid) connection in an existing project has been broken
#codereview Mike.Beach
[CL 2606203 by Phillip Kavan in Main branch]
change summary:
- restored modification to FDynamicOutputHelper::GetPinClass() to include object reference pin types
- restored modification to FDynamicOutputHelper::IsTypePickerPin() to include the PC_Object category
- restored modification to the UGameplayStatics::GetObjectClass() UFUNCTION declaration to include 'DeterminesOutputType' metadata
- modified FDynamicOutputHelper::GetPinClass() to consider connections to a literal 'self' reference; resolves a potential BP compilation error that was introduced with the initial fix
#codereview Mike.Beach, Dan.OConnor
[CL 2605968 by Phillip Kavan in Main branch]
UK2Node_CallFunction::EnsureFunctionIsInBlueprint will check the function's owner class to see if it is a child of UInterface and will not allow changes to the FunctionReference if it is.
#jira UE-17565 - Copy and pasting an interfaceCall node pasted a different node.
[CL 2604126 by Michael Schoell in Main branch]
change summary:
- modified FDynamicOutputHelper::GetPinClass() to include object reference pin types
- modified FDynamicOutputHelper::IsTypePickerPin() to include the PC_Object category
- modified the UGameplayStatics::GetObjectClass() UFUNCTION declaration to include 'DeterminesOutputType' metadata
#codereview Mike.Beach
[CL 2592119 by Phillip Kavan in Main branch]
#jira UE-13949 - Fix various uses of FindFunction that use string literals instead of GET_FUNCTION_NAME_CHECKED
[CL 2578531 by Michael Schoell in Main branch]
Localization fixes for Find-in-Blueprints so it will again search the current and native language.
CallFunction and CustomEvents now store their non-friendly "native" names. These will not actually appear in search results, but will be compared while searching to determine if the node matches the results.
Gathering Blueprint search data will now force friendly names to true while it gathers so gathered data does not differ based on the setting.
#jira UE-15901 - Right click a custom event to get a list of all blueprints that are calling the custom event
[CL 2572814 by Michael Schoell in Main branch]
Big conversion of FStrings and FNames to FText.
Version bump to move some MaterialFunction UProperty from a TArray<FString> to TArray<FText> (some Engine assets are older than being allowed to auto-convert the UProperty)
Auto conversion of FName to FText (and back) now supported (as well as TArrays of those types).
Searching categories by both the localized string and the source string is now supported in Blueprints.
#jira UE-14481 - We are missing ability to translate node categories
#codereview Justin.Sargent
[CL 2542875 by Michael Schoell in Main branch]
Blueprint node searching now leverages localized keyword metadata for searching, so searches can now be done in the current langauge and English to find the same nodes.
#jira UE-12049 - Using translated editor, Blueprint node search returns differ for English search terms compared to search terms in the current language
#codereview justin.sargent
[CL 2517785 by Michael Schoell in Main branch]
I have reviewed each change carefully, but it is a large change and I could have missed something! Here is a summary of the types of changes in this CL:
* Made nullptr checks consistent (the plurality of the changes are of this type)
* Completed switch statements (IE, switch did not explicitly handle default case, but had unhandled enum entries - this is the second most popular type of fix)
* Removed unused variables
* Removed redundant initializations
* WidgetNavigationCustomization.cpp was fixed by the owner
* integers converted to floats where result was stored in a float
* Removed redundent null checks (e.g. before delete statements)
* Renamed variables to prevent non-obvious shadowing
* Fixed use of bitwise & when checking for equality to an enum entry (which is often 0)
* Fixes for some copy paste errors (e.g. FoliageEdMode.cpp)
[CL 2498053 by Dan Oconnor in Main branch]