Commit Graph

98 Commits

Author SHA1 Message Date
Michael Schoell
49c96e1732 Fix shadow variable issue.
[CL 2607432 by Michael Schoell in Main branch]
2015-07-01 10:07:48 -04:00
Michael Noland
3c99dc668f Fixed up a few whitespace issues
[CL 2606940 by Michael Noland in Main branch]
2015-06-30 22:12:07 -04:00
Michael Schoell
dd3a91b825 Call Function nodes will no longer change the function reference when duplicating the node or duplicating the entire Blueprint.
UK2Node_CallFunction::EnsureFunctionIsInBlueprint checks for the self pin being connected, if it is it will not change the function reference.

#jira UE-17073 - Duplicated blueprints cannot access casted class nodes

[CL 2606495 by Michael Schoell in Main branch]
2015-06-30 17:18:11 -04:00
Phillip Kavan
f864e2455c [UE-14914] Prevent function parameters from being autowired when intended for internal use only.
change summary:
- added a new "InternalUseParam" UFUNCTION() meta to support tagging function parameters as internal use only (=> hidden | not connectable)
- added a UK2Node_CallFunction::IsConnectionDisallowed() override method; returns 'true' if the 'bNotConnectable' flag is set on the node's pin (and will emit a compile error in existing projects if something is connected to it)
- modified FBlueprintEditorUtils::GetHiddenPinsForFunction() to accept an optional 'InternalPins' TSet as an output; on return, this will contain the subset of hidden pins that are marked as "InternalUseParam"
- modified UK2Node_CallFunction::CreatePinsForFunctionCall() to set the 'bNotConnectable' pin attribute to 'true' if "InternalUseParam == '<PinName>'" is included within the UFunction metadata
- modified the AActor::AddComponent UFUNCTION() decl to switch the "HidePin" meta to "InternalUseParam" for the 'ComponentTemplateContext' parameter (because it should not be connectable)
- modified UK2Node_CallFunction::NotifyPinConnectionListChanged() to refresh the node to hide pins corresponding to internal-only params once the (invalid) connection in an existing project has been broken

#codereview Mike.Beach

[CL 2606203 by Phillip Kavan in Main branch]
2015-06-30 14:42:07 -04:00
Phillip Kavan
8ed4059fd6 [UE-15480] Restore ability to link GetClass() function call node output pin subtype to the input pin subtype (revised initial fix).
change summary:
- restored modification to FDynamicOutputHelper::GetPinClass() to include object reference pin types
- restored modification to FDynamicOutputHelper::IsTypePickerPin() to include the PC_Object category
- restored modification to the UGameplayStatics::GetObjectClass() UFUNCTION declaration to include 'DeterminesOutputType' metadata
- modified FDynamicOutputHelper::GetPinClass() to consider connections to a literal 'self' reference; resolves a potential BP compilation error that was introduced with the initial fix

#codereview Mike.Beach, Dan.OConnor

[CL 2605968 by Phillip Kavan in Main branch]
2015-06-30 12:42:39 -04:00
Michael Schoell
f928f7972b Copy and pasting a K2Node_CallFunction with an interface pin for the SelfPin will no longer change the SelfPin into a normal Object Reference pin.
UK2Node_CallFunction::EnsureFunctionIsInBlueprint will check the function's owner class to see if it is a child of UInterface and will not allow changes to the FunctionReference if it is.

#jira UE-17565  - Copy and pasting an interfaceCall node pasted a different node.

[CL 2604126 by Michael Schoell in Main branch]
2015-06-29 12:13:17 -04:00
Dan Oconnor
3e0ea670f1 [UEBP-60] Skipping tooltip generation for transient pins
[CL 2599950 by Dan Oconnor in Main branch]
2015-06-24 21:45:09 -04:00
Dan Oconnor
4a011eb4cc Back out changelist 2592119, causes errors in several blueprints in Mike's circular reference tests
[CL 2597502 by Dan Oconnor in Main branch]
2015-06-23 13:59:09 -04:00
Phillip Kavan
6e67897d5e [UE-15480] The output pin subtype for a GetClass function call node is now linked to the input pin's subtype.
change summary:
- modified FDynamicOutputHelper::GetPinClass() to include object reference pin types
- modified FDynamicOutputHelper::IsTypePickerPin() to include the PC_Object category
- modified the UGameplayStatics::GetObjectClass() UFUNCTION declaration to include 'DeterminesOutputType' metadata

#codereview Mike.Beach

[CL 2592119 by Phillip Kavan in Main branch]
2015-06-18 12:10:18 -04:00
Mike Beach
8164028b41 [UE-17011] If a function doesn't have any extra keywords, make sure we still include the compact title at the very least.
#codereview Michael.Schoell

[CL 2588760 by Mike Beach in Main branch]
2015-06-16 11:53:17 -04:00
Michael Schoell
a5e29efb5a Pin tooltips on Call Function nodes in Blueprints will no longer grow with each compile or change to the Blueprint.
#jira UE-16997 - Tooltip for boolean checkbox on blueprint node grows with every click

[CL 2588700 by Michael Schoell in Main branch]
2015-06-16 11:25:01 -04:00
Michael Schoell
91061b9d85 Fixed uses of FindFunctionByName that did not use GET_FUNCTION_NAME_CHECKED.
#jira UE-13949 - Fix various uses of FindFunction that use string literals instead of GET_FUNCTION_NAME_CHECKED

[CL 2578531 by Michael Schoell in Main branch]
2015-06-05 11:45:49 -04:00
Jeff Farris
d244d227bc Fixed several shadow variable warnings
#codereview: Lukasz.Furman, Michael.Schoell, Dan.Oconnor, Eric.Newman, Gil.Gribb

[CL 2575931 by Jeff Farris in Main branch]
2015-06-03 14:47:53 -04:00
Michael Schoell
d3c4f18bcd Can right click on any node to search for references of it. Does initial search only in current Blueprint.
Localization fixes for Find-in-Blueprints so it will again search the current and native language.

CallFunction and CustomEvents now store their non-friendly "native" names. These will not actually appear in search results, but will be compared while searching to determine if the node matches the results.

Gathering Blueprint search data will now force friendly names to true while it gathers so gathered data does not differ based on the setting.

#jira UE-15901 - Right click a custom event to get a list of all blueprints that are calling the custom event

[CL 2572814 by Michael Schoell in Main branch]
2015-06-01 14:36:32 -04:00
Dan Oconnor
2d871fe3fb [UEBP-56] Optimized K2Node_CallFunction construction, pin tool type generation was being performed for all pins, and is expensive. Made it lazy (pins created when you mouse over a pin)
[CL 2567511 by Dan Oconnor in Main branch]
2015-05-27 17:51:08 -04:00
Michael Schoell
3eeb3c3ed0 Function nodes are categorized correctly again.
#jira UE-15634 - Static Function Library Categories Ignored

[CL 2553608 by Michael Schoell in Main branch]
2015-05-15 17:26:19 -04:00
Michael Schoell
db9c8e2240 UProperty and UFunction metadata for Category can now be localized and have improved FText usage throughout the editor (Blueprints, Behavior Trees, Materials, etc).
Big conversion of FStrings and FNames to FText.

Version bump to move some MaterialFunction UProperty from a TArray<FString> to TArray<FText> (some Engine assets are older than being allowed to auto-convert the UProperty)

Auto conversion of FName to FText (and back) now supported (as well as TArrays of those types).

Searching categories by both the localized string and the source string is now supported in Blueprints.

#jira UE-14481 - We are missing ability to translate node categories

#codereview Justin.Sargent

[CL 2542875 by Michael Schoell in Main branch]
2015-05-08 10:46:42 -04:00
Michael Schoell
a2863038dc Fixed some dangerous localizable strings and improved Blueprint function/event node title localization support.
#jira UE-14414 - Japanese node labels are not displayed properly

[CL 2528578 by Michael Schoell in Main branch]
2015-04-28 11:31:15 -04:00
Maciej Mroz
4d804326e0 K2Nodes::HasExternalBlueprintDependencies and K2Nodes::HasExternalUserDefinedStructDependencies were changed into HasExternalDependencies and can return native structs
[CL 2525803 by Maciej Mroz in Main branch]
2015-04-25 17:47:39 -04:00
Maciej Mroz
ee6d70dfa1 UE-13981 Input pins of BP node are not updated after a hot reload
#codereview Robert.Manuszewski

[CL 2525773 by Maciej Mroz in Main branch]
2015-04-25 16:18:36 -04:00
Michael Schoell
abb8124662 Keywords metadata is now localized.
Blueprint node searching now leverages localized keyword metadata for searching, so searches can now be done in the current langauge and English to find the same nodes.

#jira UE-12049 - Using translated editor, Blueprint node search returns differ for English search terms compared to search terms in the current language

#codereview justin.sargent

[CL 2517785 by Michael Schoell in Main branch]
2015-04-20 12:25:37 -04:00
Michael Schoell
63b7360ae0 Removed the Blueprint Editor's legacy node menu system.
#jira UE-13391 - Delete old BP menu system (is causing confusion)

#codereview Mike.Beach

[CL 2514361 by Michael Schoell in Main branch]
2015-04-16 11:47:54 -04:00
Marc Audy
d55fffc485 Strip s when @returns is used instead of @return for a return pin tooltip
[CL 2507177 by Marc Audy in Main branch]
2015-04-09 15:30:49 -04:00
Michael Schoell
75200e5a0d Cached node titles can now be forced to refresh without iteration over every node.
This will occur with every structural modification to any BP, node titles refresh only when visible.

[CL 2499923 by Michael Schoell in Main branch]
2015-04-02 11:16:23 -04:00
PaulEremeeff
3d878d5a79 PR #996: Fixing PVS-Studio warnings (Contributed by PaulEremeeff)
I have reviewed each change carefully, but it is a large change and I could have missed something! Here is a summary of the types of changes in this CL:
 * Made nullptr checks consistent (the plurality of the changes are of this type)
 * Completed switch statements (IE, switch did not explicitly handle default case, but had unhandled enum entries - this is the second most popular type of fix)
 * Removed unused variables
 * Removed redundant initializations
 * WidgetNavigationCustomization.cpp was fixed by the owner
 * integers converted to floats where result was stored in a float
 * Removed redundent null checks (e.g. before delete statements)
 * Renamed variables to prevent non-obvious shadowing
 * Fixed use of bitwise & when checking for equality to an enum entry (which is often 0)
 * Fixes for some copy paste errors (e.g. FoliageEdMode.cpp)

[CL 2498053 by Dan Oconnor in Main branch]
2015-03-31 20:12:31 -04:00