Commit Graph

1305 Commits

Author SHA1 Message Date
vincent gauthier
80a9849b3c [Backout] - CL18952424
This is causing an ensure to hit in Slate applications.

[FYI] Patrick.Boutot, Matt.Kuhlenschmidt
Original CL Desc
-----------------------------------------------------------------
Slate: Clear the uncached draw elements once they are batches and clear the batches elements once they are rendered. We do this to remove hard references to the Glyph Sequence from the previous frame. Cached draw elements are still cached. An old Glyph Sequence may still be a reference in a cached element but it is the responsibility of the SWidget to do the proper invalidation.
#rb matt.kuhlenschmidt
#preflight 62066e4554003c49ad37c3e6

#ROBOMERGE-AUTHOR: vincent.gauthier
#ROBOMERGE-SOURCE: CL 18997554 via CL 18997606 via CL 18998070 via CL 18998217 via CL 18998286 via CL 19002213 via CL 19004425
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 19004631 by vincent gauthier in ue5-main branch]
2022-02-15 17:06:47 -05:00
patrick boutot
bd0c001889 Slate: Clear the uncached draw elements once they are batches and clear the batches elements once they are rendered. We do this to remove hard references to the Glyph Sequence from the previous frame. Cached draw elements are still cached. An old Glyph Sequence may still be a reference in a cached element but it is the responsibility of the SWidget to do the proper invalidation.
#rb matt.kuhlenschmidt
#preflight 62066e4554003c49ad37c3e6

#ROBOMERGE-AUTHOR: patrick.boutot
#ROBOMERGE-SOURCE: CL 18952424 via CL 18952442 via CL 18953137 via CL 18953283 via CL 18955233 via CL 18956023
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18958325 by patrick boutot in ue5-main branch]
2022-02-11 14:42:51 -05:00
Patrick Boutot
93e8a1f1b0 Slate: Add a CrashHandler for Slate code.
#rb johan.berg, patrick.laflamme
#preflight 62054589b84973a2bb5f8699

[CL 18938316 by Patrick Boutot in ue5-main branch]
2022-02-10 12:19:47 -05:00
daren cheng
4af0ec6765 Fix editor utility widget style changes not saving due to UMG style CDO comparisions reverting changes.
Also fixes issue where any 32x32 button texture would get shrunk to zero on editor utility widgets.

#preflight 620441552f56bd0ebf9fc84e
#rb vincent.gauthier lauren.barnes
#lockdown JeanMichel.Dignard


#ROBOMERGE-AUTHOR: daren.cheng
#ROBOMERGE-SOURCE: CL 18926528 via CL 18926776 via CL 18928248 via CL 18929495
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v916-18915374)

[CL 18929501 by daren cheng in ue5-main branch]
2022-02-09 19:39:40 -05:00
patrick boutot
80c2208955 Slate: Try to fix random crash that corrupt the memory in SlatePrepass.
#rb vincent.gauthier
#preflight 6202d4807e40979d33b88959

#ROBOMERGE-AUTHOR: patrick.boutot
#ROBOMERGE-SOURCE: CL 18913709 via CL 18913713 via CL 18913717 via CL 18918971 via CL 18920421
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v916-18915374)

[CL 18920677 by patrick boutot in ue5-main branch]
2022-02-09 12:49:16 -05:00
patrick boutot
ae7e5bc899 Slate: Revert changelist 18868541. GC FShapedGlyphSequence::FontMaterial. A FShapedGlyphSequence can be in the previous Slate Buffer (pending to be deleted). That will break the GC for PIE.
#rb none
#rnx
#preflight none

#ROBOMERGE-AUTHOR: patrick.boutot
#ROBOMERGE-SOURCE: CL 18884439 via CL 18884494 via CL 18884518 via CL 18884730 via CL 18885196
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18885238 by patrick boutot in ue5-main branch]
2022-02-07 09:33:04 -05:00
patrick boutot
b7de7530c8 Slate: GC FShapedGlyphSequence::FontMaterial. There were GCed by the Payload previously but nothing prevented a user to keep an instance of the FShapredGlyphSequence and not using it.
#rb matt.kuhlenschmidt, daren.cheng, sebastien.nordgren
#preflight 61fd49280a43b689e1791d6f

#ROBOMERGE-AUTHOR: patrick.boutot
#ROBOMERGE-SOURCE: CL 18868541 via CL 18868628 via CL 18868743 via CL 18870409 via CL 18870815
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18870833 by patrick boutot in ue5-main branch]
2022-02-04 15:01:03 -05:00
patrick boutot
0de0725d3d Slate: Try to fix random crash while iterating on SWidget.
#rb none
#preflight 61fce6e2e058822bdabf53a7

#ROBOMERGE-AUTHOR: patrick.boutot
#ROBOMERGE-SOURCE: CL 18861466 via CL 18861467 via CL 18861468 via CL 18861668 via CL 18861772
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18861779 by patrick boutot in ue5-main branch]
2022-02-04 06:55:54 -05:00
patrick boutot
9d38d6eea0 Slate: Update the LayerId in invalidation when the widget painted more elements than the previous paint. Disable by default. You can enable it with the cvar `Slate.InvalidationList.EnableReindexLayerId. This occurs when a child-widget was collapsed and is now visible. The sibling of the widget may have the same LayerId as the child-widget. That would affect how the elements are rendered.
#jira UE-136046, UE-106162
#rb vincent.gauthier
#preglight 61f94bb6a6632a34f372935a

#ROBOMERGE-AUTHOR: patrick.boutot
#ROBOMERGE-SOURCE: CL 18810476 via CL 18810478 via CL 18810490 via CL 18821442 via CL 18822953
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18825126 by patrick boutot in ue5-main branch]
2022-02-02 08:23:10 -05:00
andrew davidson
dc0932fb59 Fix PS4 minimal incremental
#rb trivial
#preflight 61f8a247f657e25a5909383e

#ROBOMERGE-AUTHOR: andrew.davidson
#ROBOMERGE-SOURCE: CL 18804984 in //UE5/Release-5.0/... via CL 18807943 via CL 18821736
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18822104 by andrew davidson in ue5-main branch]
2022-02-02 02:18:31 -05:00
patrick boutot
beb5f7670e Slate: Fix Num() that is not called every loop like previoulsy. Some widgets add/remove children while they are beeing iterating on.
#jira UE-139306, FORT-444155
#preflight 61f842e8a6632a34f3525401

#ROBOMERGE-AUTHOR: patrick.boutot
#ROBOMERGE-SOURCE: CL 18803173 via CL 18803177 via CL 18803181 via CL 18804419 via CL 18821687
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18822073 by patrick boutot in ue5-main branch]
2022-02-02 02:16:11 -05:00
andrew davidson
ec5b86d40e Fix ElementBatcher.cpp merge
#rb trivial
#preflight none

#ROBOMERGE-AUTHOR: andrew.davidson
#ROBOMERGE-SOURCE: CL 18803249 in //UE5/Release-Engine-Staging/... via CL 18821581
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18821665 by andrew davidson in ue5-main branch]
2022-02-02 01:49:29 -05:00
andrew davidson
8e95b10069 Fix FVector2D variant casts - Runtime
Submitted on behalf of fred.kimberley
#rb andy.davidson
#preflight 61f8729a5a026d2d19bb9ca6
#preflight 61f87a025a026d2d19be76ed

#ROBOMERGE-OWNER: andrew.davidson
#ROBOMERGE-AUTHOR: andrew.davidson
#ROBOMERGE-SOURCE: CL 18802361 in //UE5/Release-5.0/... via CL 18802891 via CL 18821557
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18821641 by andrew davidson in ue5-main branch]
2022-02-02 01:47:07 -05:00
patrick boutot
e340a0acab Slate: Fix reference to rvalue in FChildren
#jira UE-139306
[FYI] daren.cheng
#preflight none

#ROBOMERGE-AUTHOR: patrick.boutot
#ROBOMERGE-SOURCE: CL 18772549 in //UE5/Release-5.0/... via CL 18772571 via CL 18772833
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18772841 by patrick boutot in ue5-main branch]
2022-01-28 12:00:27 -05:00
patrick boutot
742d5b30a7 Slate: Remove had used to detect rare thread issue.
#jira UE-139306
#preflight 61f2ba66f50f352300ceacd2

#ROBOMERGE-OWNER: patrick.boutot
#ROBOMERGE-AUTHOR: patrick.boutot
#ROBOMERGE-SOURCE: CL 18755151 via CL 18755161 via CL 18755167 via CL 18756773 via CL 18758805
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18760836 by patrick boutot in ue5-main branch]
2022-01-27 15:47:39 -05:00
zak middleton
36c99f6887 #ue5 - LWC: FVector4f <-> FVector4d conversion is now explicit.
FLinearColor has also been modified to make any double->float conversions explicit. Previously all 3D TVector versions were allowed to be implicit and thus could convert TVector<double> => FLinearColor => TVector4<float>.

Fixed up all engine and game casts. Added "//LWC_TODO: precision loss" around any explicit casts that previously were silently explicit and we may need to revisit for precision loss analysis.

#jira UE-122085
#rb Ben.Ingram, Andrew.Davidson
#preflight 61f24af473238441cb7bb0f1

#ROBOMERGE-AUTHOR: zak.middleton
#ROBOMERGE-SOURCE: CL 18751249 in //UE5/Release-5.0/... via CL 18751253 via CL 18751319
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18751326 by zak middleton in ue5-main branch]
2022-01-27 03:30:41 -05:00
aurel cordonnier
bf8783604c Fix for no unity error
#rnx
#preflight none
[FYI] daren.cheng

#ROBOMERGE-OWNER: aurel.cordonnier
#ROBOMERGE-AUTHOR: aurel.cordonnier
#ROBOMERGE-SOURCE: CL 18719673 via CL 18720019 via CL 18720025 via CL 18720617 via CL 18720676
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18720678 by aurel cordonnier in ue5-main branch]
2022-01-25 03:36:30 -05:00
marc audy
6553e6cd0a Remove as much C++ deprecation as possible up to 4.17 (along with a few scattered removals from beyond)
#preflight 61eefc77ba69a4fdb220bf23

#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 18712765 in //UE5/Release-5.0/... via CL 18712784 via CL 18713147
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18713191 by marc audy in ue5-main branch]
2022-01-24 15:07:48 -05:00
Patrick Boutot
0124d27dd4 Slate: Add unit test for FChildren::ForEach
#rb vincent.gauthier
#preflight 61eb303345399e9f504456a7

[CL 18698251 by Patrick Boutot in ue5-main branch]
2022-01-21 17:41:48 -05:00
vincent gauthier
a558e2f441 CIS fix: Add Missing LOCTEXT_NAMESPACE undef
#rb trivial
#jira UE-136397
#preflight none

#ROBOMERGE-AUTHOR: vincent.gauthier
#ROBOMERGE-SOURCE: CL 18696797 in //UE5/Release-5.0/... via CL 18696825 via CL 18696864
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18696888 by vincent gauthier in ue5-main branch]
2022-01-21 16:38:37 -05:00
matt kuhlenschmidt
db5a52cfe0 Scale rounded blurs to fix UV calculating for corner rounding
#rb nick.darnell
#preflight none

#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
#ROBOMERGE-SOURCE: CL 18684976 in //UE5/Release-5.0/... via CL 18684984 via CL 18684999
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v902-18672795)

[CL 18685009 by matt kuhlenschmidt in ue5-main branch]
2022-01-20 20:07:27 -05:00
max chen
0930510276 Slate: Change ToggleButtonCheckboxAlt PressedForegroundColor to all white
#jira UE-113125
#rb lauren.barnes
#preflight none

#ROBOMERGE-AUTHOR: max.chen
#ROBOMERGE-SOURCE: CL 18682136 in //UE5/Release-5.0/... via CL 18682164 via CL 18682197
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v902-18672795)

[CL 18682219 by max chen in ue5-main branch]
2022-01-20 16:57:35 -05:00
ben hoffman
64e252935c Clean up type truncation warnings
#jira UE-116218
#rb trivial
#rnx
#preflight 61e6efb4837b79f7ccebe551

#ROBOMERGE-AUTHOR: ben.hoffman
#ROBOMERGE-SOURCE: CL 18641648 in //UE5/Release-5.0/... via CL 18641663 via CL 18641684
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v900-18638592)

[CL 18641708 by ben hoffman in ue5-main branch]
2022-01-18 12:13:22 -05:00
daren cheng
b4ca04f889 Fix editable text box default focused color black.
#jira UE-137124
#robomerge 5.0
#rb sebastian.nordgren
#preflight 61e6dda3837b79f7cce39c13

[CL 18640649 by daren cheng in ue5-main branch]
2022-01-18 11:08:35 -05:00
trystan binkley-jone
46c0a4b253 Added rotation and flip icons to the Editor's core starship style, and used then in the nDisplay plugin for rotation and flip operations
#jira UETOOL-4329
#rb Patrick.Hardy
#preflight 61e1aee0076be0fc4e162ad8

#ROBOMERGE-AUTHOR: trystan.binkley-jone
#ROBOMERGE-SOURCE: CL 18619334 in //UE5/Release-5.0/... via CL 18619614 via CL 18619961
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v899-18417669)

[CL 18620540 by trystan binkley-jone in ue5-main branch]
2022-01-14 13:37:35 -05:00