Commit Graph

1122 Commits

Author SHA1 Message Date
jason stasik
882beee667 Log "Add to Allowlist" events in PropertyEditor
#rb none
#preflight 620eb194731ab58d824fedfc

#ROBOMERGE-AUTHOR: jason.stasik
#ROBOMERGE-SOURCE: CL 19043699 via CL 19046089 via CL 19046103 via CL 19046126 via CL 19049397
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v918-19018356)

[CL 19065747 by jason stasik in ue5-main branch]
2022-02-21 00:31:46 -05:00
sebastian nordgren
7cd051a230 Removed unnecessary TWeakPtr::IsValid() check.
#rb paul.chipchase
#preflight 620fc793ff52bfecfcf87872

[CL 19051063 by sebastian nordgren in ue5-main branch]
2022-02-18 11:37:50 -05:00
vlad golovan
485406734e Engine change to allow only building the property nodes that user is going to see.
When property view widgets get reused, we are running (generate nodes) repeatedly while scrolling. Through some trial and error, I've identified that since I am only showing a fraction of the nodes I don't need to have all the nodes built; I can get away with generating the ones I will see, which improves performance from around 130 ms to 10-20ms per widget. I am adding a way to specify the properties you want to build and ignore the rest, which ultimately dramatically speeds up the PropertyView widget for the case where you are only showing a few properties from the object.


[REVIEW] [at]jay.Nakai, [at]sebastian.nordgren, [at]david.hamm

#rb sebastian.nordgren


#ROBOMERGE-OWNER: vlad.golovan
#ROBOMERGE-AUTHOR: vlad.golovan
#ROBOMERGE-SOURCE: CL 19036849 via CL 19036854 via CL 19038143 via CL 19038155 via CL 19039279
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v918-19018356)

[CL 19039995 by vlad golovan in ue5-main branch]
2022-02-17 14:54:44 -05:00
sebastian nordgren
2bb8c0f18a Scrolling a row outside of the Details view now commits any changes that were being made to that row.
#jira UE-134865
#rb matt.kuhlenschmidt
#preflight 620cb57701253d2e19fe9efa

[CL 19011614 by sebastian nordgren in ue5-main branch]
2022-02-16 03:42:24 -05:00
Robb Surridge
65a3c1236d Move IntroTutorials to a plugin. Part 1: move code module and clean up references.
#jira 141830
#preflight 6202f3e4bd4f846436f1dfc6
#rb lauren.barnes

[CL 18920903 by Robb Surridge in ue5-main branch]
2022-02-09 13:00:06 -05:00
George Rolfe
92509989f3 Property NoClear specifier propagates to item object pickers
#jira none
#preflight 62019c30384d6a94e8e656a7
#rb Sebastian.Nordgren

[CL 18895119 by George Rolfe in ue5-main branch]
2022-02-07 17:40:15 -05:00
George Rolfe
24061d010d InvalidEnumValues metadata support in PropertyHandle
(should have been part of 18805091)

#jira none
#preflight 61fae3a2e759a1a1a5ebe83b
#rb none

[CL 18832267 by George Rolfe in ue5-main branch]
2022-02-02 15:20:24 -05:00
jamie dale
d45257c2ba Allow AddChildStructure to be used by sparse data properties
The child struct properties can't inherit the sparse data flag, as FStructurePropertyNode is already directly editing a block of struct memory.

#jira UE-140961
#preflight 61fa9368ad2ae6c3b75c1d66
#rb Mikko.Mononen

#ROBOMERGE-AUTHOR: jamie.dale
#ROBOMERGE-SOURCE: CL 18826037 in //UE5/Release-5.0/... via CL 18826067 via CL 18826480
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18826515 by jamie dale in ue5-main branch]
2022-02-02 10:02:39 -05:00
sebastian nordgren
fe30f189fd The Reset to Default button is no longer hidden when a details row is disabled, but is rather shown greyed out.
#jira UE-139917
#review-18772191 @lauren.barnes
#preflight 61f415e06b5aea38e5bb1726

[CL 18824161 by sebastian nordgren in ue5-main branch]
2022-02-02 07:11:10 -05:00
George Rolfe
62e2ce4d8d InvalidEnumValues metadata support (inverse of ValidEnumValues)
#jira none

#preflight 61f89c86f657e25a5908ebe7

#rb matt.kuhlenschmidt

[CL 18805064 by George Rolfe in ue5-main branch]
2022-01-31 22:36:04 -05:00
sebastian nordgren
fbe733e5f5 Subcategory nodes now hide themselves if no children are visible. This was most evident with eg. EditInstanceOnly metadata set for a property while editing the CDO - the property would be hidden, but the subcategory would still be visible.
#jira UE-112640
[REVIEW] [at]lauren.barnes
#preflight 61f2b191304c93e2cba43cda

#ROBOMERGE-AUTHOR: sebastian.nordgren
#ROBOMERGE-SOURCE: CL 18753805 in //UE5/Release-5.0/... via CL 18753814 via CL 18756962
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18757283 by sebastian nordgren in ue5-main branch]
2022-01-27 14:10:26 -05:00
simon therriault
e3bac11d06 - Fixing crash at shutdown with remote control
#rb jeremie.roy
#jira UE-140261
#preflight 61f195d62f38223e17bc1910

#ROBOMERGE-AUTHOR: simon.therriault
#ROBOMERGE-SOURCE: CL 18740277 in //UE5/Release-5.0/... via CL 18740804 via CL 18741555
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18742261 by simon therriault in ue5-main branch]
2022-01-26 15:04:41 -05:00
sebastian nordgren
74959d7da3 FPropertyHandleObject::SetValue when called with an FAssetData no longer always marks an asset as dirty if the new value is identical to the previous value.
This makes an assumption the FObjectPropertyBase::GetExportPath() will continue to return the value in 'ClassName'ObjectPath format, but that seems very unlikely to change and is depended on elsewhere so this can be considered an acceptable risk.

Suggested by UDN: https://epicgames.lightning.force.com/lightning/r/Case/5004z00001ay3pbAAA/view

#rb paul.chipchase
#preflight 61efd42b8c16f8372245a8f2

[CL 18721203 by sebastian nordgren in ue5-main branch]
2022-01-25 06:05:21 -05:00
marc audy
6553e6cd0a Remove as much C++ deprecation as possible up to 4.17 (along with a few scattered removals from beyond)
#preflight 61eefc77ba69a4fdb220bf23

#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 18712765 in //UE5/Release-5.0/... via CL 18712784 via CL 18713147
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18713191 by marc audy in ue5-main branch]
2022-01-24 15:07:48 -05:00
simon therriault
106ad125a5 - Reverting show hidden properties bypassing customized struct
#rb none
#jira none
#preflight 61eed810ba69a4fdb216d923

#ROBOMERGE-AUTHOR: simon.therriault
#ROBOMERGE-SOURCE: CL 18710054 in //UE5/Release-5.0/... via CL 18710097 via CL 18710221
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18710247 by simon therriault in ue5-main branch]
2022-01-24 12:04:25 -05:00
michael noland
92354cbf98 Added a bit more information to what failed when an edit condition cannot be parsed, indicating whether it was an issue with the type or the value
#preflight none

#ROBOMERGE-AUTHOR: michael.noland
#ROBOMERGE-SOURCE: CL 18705386 in //UE5/Release-5.0/... via CL 18705389 via CL 18705411
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18705413 by michael noland in ue5-main branch]
2022-01-23 20:20:41 -05:00
patrick hardy
9939de5f19 Fixed removing an instanced element from a map or set not using the internal index for object lookup.
#jira UE-139981
#rb marc.audy
#preflight 61eb42cb731e3b4088a504ae

#ROBOMERGE-AUTHOR: patrick.hardy
#ROBOMERGE-SOURCE: CL 18699372 in //UE5/Release-5.0/... via CL 18699470 via CL 18699524
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18699561 by patrick hardy in ue5-main branch]
2022-01-21 18:49:57 -05:00
frank fella
2a62ba523e PropertyEditor - Expose an api on the property row generator to invalidate cached internal data so that visual state can be refreshed when the displayed object is modified from non property editor code.
#rb sebastian.nordgren
#preflight 61ead90d731e3b4088910db0

#ROBOMERGE-AUTHOR: frank.fella
#ROBOMERGE-SOURCE: CL 18691530 in //UE5/Release-5.0/... via CL 18691872 via CL 18692095
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18692290 by frank fella in ue5-main branch]
2022-01-21 13:31:29 -05:00
denys dubinin
907d9285ec BUG in RC and Material List. Slow details panel performance when lots of material slots are involved
#rb simon.therriault
#jira UE-138225
#preflight 61e841d0e543b825456e1952

#ROBOMERGE-AUTHOR: denys.dubinin
#ROBOMERGE-SOURCE: CL 18690369 in //UE5/Release-5.0/... via CL 18690385 via CL 18690405
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18690427 by denys dubinin in ue5-main branch]
2022-01-21 11:34:04 -05:00
jamie dale
d8a032c47c Avoid filtering sub-categories that may yet contain properties
#preflight 61e9a96a1739bb8724d865a9
#rb Jason.Stasik

#ROBOMERGE-AUTHOR: jamie.dale
#ROBOMERGE-SOURCE: CL 18679333 via CL 18679357 via CL 18679379 via CL 18679387 via CL 18681207 via CL 18681244 via CL 18681285
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v902-18672795)

[CL 18681568 by jamie dale in ue5-main branch]
2022-01-20 16:32:50 -05:00
simon therriault
54e2cac693 - Updating detail category node generation to consider ShouldShowHiddenProperties flag before discarding a customized node
#rb sebastian.nordgren
#jira UE-138909
#preflight 61e97d56f1602135349dedcc

#ROBOMERGE-AUTHOR: simon.therriault
#ROBOMERGE-SOURCE: CL 18675227 in //UE5/Release-5.0/... via CL 18675254 via CL 18675265
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v902-18672795)

[CL 18679734 by simon therriault in ue5-main branch]
2022-01-20 15:24:26 -05:00
sebastian nordgren
b9803aee28 Speculative fix for crash when an invalid FPropertyNode is passed into FDetailPropertyRow, causing it to store a null IPropertyHandle pointer that is never checked for validity.
This fix always initializes it to a valid pointer, but invalid handle, which is a state that is handled correctly in FPropertyHandleBase.

#jira UE-130580
[REVIEW] [at]lauren.barnes
#preflight 61e56664a2616066f67fbfa6

#ROBOMERGE-AUTHOR: sebastian.nordgren
#ROBOMERGE-SOURCE: CL 18639655 in //UE5/Release-5.0/... via CL 18639702 via CL 18639711
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v900-18638592)

[CL 18639724 by sebastian nordgren in ue5-main branch]
2022-01-18 09:53:00 -05:00
thomas sarkanen
fe89ad5266 Custom copy/paste actions now pulse the details row to indicate they were run
Previously the row only pulsed if it ran the built-in copy/paste routines

#jira none
#rb Sebastian.Nordgren
#preflight 61e59409a2616066f686b35b

#ROBOMERGE-AUTHOR: thomas.sarkanen
#ROBOMERGE-SOURCE: CL 18633622 in //UE5/Release-5.0/... via CL 18633637 via CL 18633649
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v899-18417669)

[CL 18637386 by thomas sarkanen in ue5-main branch]
2022-01-18 04:32:02 -05:00
thomas sarkanen
d884e2b6fc Fix ExtensionContent not working for FDetailWidgetRow created via IDetailPropertyRow::CustomWidget()
#jira none
#rb Sebastian.Nordgren
[FYI] Sebastian.Nordgren
#preflight 61e57650006b17a68656d278

#ROBOMERGE-AUTHOR: thomas.sarkanen
#ROBOMERGE-SOURCE: CL 18632672 in //UE5/Release-5.0/... via CL 18633038 via CL 18633049
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v899-18417669)

[CL 18637357 by thomas sarkanen in ue5-main branch]
2022-01-18 04:29:05 -05:00
stu mckenna
6fbad33170 - Fix crash when toggling a bool property
#rb frank.fella
#jira none
#rnx
#preflight 61df116dff67b6fe7abd8695

#ROBOMERGE-AUTHOR: stu.mckenna
#ROBOMERGE-SOURCE: CL 18586417 in //UE5/Release-5.0/... via CL 18586434 via CL 18586445
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Test -> Main) (v899-18417669)

[CL 18586456 by stu mckenna in ue5-main branch]
2022-01-12 12:48:03 -05:00