Commit Graph

330 Commits

Author SHA1 Message Date
sara schvartzman
73c142058b Control Rig: Fix pytlhon command for changing exposed pin type incorrect
#jira na
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/6214d973141b500e17e1542f

[CL 19071193 by sara schvartzman in ue5-main branch]
2022-02-22 07:50:53 -05:00
Helge Mathee
b37d7c3439 RigVM: split up RigVMTypeUtils into runtime and developer
#rb sara.schvartzman
#jira na
#preflight https://horde.devtools.epicgames.com/job/6214c3dc263b1fd1a27b9809

[CL 19070635 by Helge Mathee in ue5-main branch]
2022-02-22 06:21:42 -05:00
sara schvartzman
d9a6ca5d76 Control Rig: FIx unit test FRigVMCompilerVariableRemappingTest failing
#jira na
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/620fb54dbe45100d32bcc505

[CL 19051198 by sara schvartzman in ue5-main branch]
2022-02-18 11:46:10 -05:00
Helge Mathee
c87618e12d Control Rig: Sharing of operands only for matching types
#rb sara.schvartzman
#jira UE-141691
#preflight https://horde.devtools.epicgames.com/job/620fba85ec6f84cdfa3b82d1

[CL 19050261 by Helge Mathee in ue5-main branch]
2022-02-18 10:34:17 -05:00
sara schvartzman
afcf6854a6 Control Rig: Fix compiler issue RigVMCompiler.cpp Dereferencing NULL pointer 'InVarExpr'
#jira na
#rb trivial
#preflight https://horde.devtools.epicgames.com/job/620f915fbe45100d32b703a7?label=167

[CL 19049382 by sara schvartzman in ue5-main branch]
2022-02-18 09:07:50 -05:00
sara schvartzman
b266a1cf74 Control Rig: Fix function changes when folding is disabled
#jira UE-142718
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/620f6aa2be45100d32b14157

[CL 19048367 by sara schvartzman in ue5-main branch]
2022-02-18 04:54:34 -05:00
aurel cordonnier
c3ae875f67 Downgrading error to warning
#fyi sara.schvartzman
#preflight 620d9c37b51a2a072a462aba
#rnx

[CL 19028051 by aurel cordonnier in ue5-main branch]
2022-02-16 20:08:49 -05:00
sara schvartzman
bd953ff717 Control Rig: Fixed Cook Asserts in RigVMTypeUtils
#jira UE-142950
#rb jack.cai
#preflight https://horde.devtools.epicgames.com/job/620d7e7c7e2cef4bf1c151d2

[CL 19026082 by sara schvartzman in ue5-main branch]
2022-02-16 18:32:04 -05:00
Helge Mathee
80cb75fa33 Control Rig: refactor details panel to show any node, support vector, rotator and transform widgets
#rb sara.schvartzman
#jira UE-139767 UE-121980
#preflight https://horde.devtools.epicgames.com/job/620cde9301253d2e1906c4eb

[CL 19012796 by Helge Mathee in ue5-main branch]
2022-02-16 07:27:08 -05:00
helge mathee
4113dae73c Fix build break //Fortnite/Dev-PerfTest/Engine/Source/Developer/RigVMDeveloper/Private/RigVMModel/RigVMController.cpp revision 44
#rb na

#ROBOMERGE-AUTHOR: helge.mathee
#ROBOMERGE-SOURCE: CL 18995038 via CL 18995289 via CL 18995457
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18997988 by helge mathee in ue5-main branch]
2022-02-15 12:08:22 -05:00
helge mathee
409fa32a42 ControlRig: Fix for static analysis
#rb trivial
#preflight na

#ROBOMERGE-AUTHOR: helge.mathee
#ROBOMERGE-SOURCE: CL 18994829 via CL 18994851 via CL 18994852 via CL 18995284 via CL 18995433
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18997971 by helge mathee in ue5-main branch]
2022-02-15 12:07:32 -05:00
sara schvartzman
a76a3c8e1c Control Rig: Fix errors when undoing change exposed pin type of function
#jira UE-142089
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/620b847f483ff0ae5eaf6b0b

#ROBOMERGE-AUTHOR: sara.schvartzman
#ROBOMERGE-SOURCE: CL 18994662 in //UE5/Release-5.0/... via CL 18994724 via CL 18994765
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18997963 by sara schvartzman in ue5-main branch]
2022-02-15 12:07:03 -05:00
sara schvartzman
f0f2532a5a Control Rig: Fix ControlRig.Debug unit test failing
#jira UE-142345
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/620a94c24d320dbf4c1e5154

#ROBOMERGE-AUTHOR: sara.schvartzman
#ROBOMERGE-SOURCE: CL 18993594 in //UE5/Release-5.0/... via CL 18993651 via CL 18993699
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18997921 by sara schvartzman in ue5-main branch]
2022-02-15 12:05:01 -05:00
sara schvartzman
bbb64511e5 Control Rig: FIx crash when using old SpringInterpSpringInterp node
#jira UE-134574
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/6206710ead10bdb30a9e4ea8

[CL 18977339 by sara schvartzman in ue5-main branch]
2022-02-14 05:28:12 -05:00
sara schvartzman
c4c5dbacd8 Control Rig: Fixed variable node is ill-formed after change to real types
#jira UE-140997
#helge.mathee
#preflight https://horde.devtools.epicgames.com/job/6206897a54003c49ad3dfee1

[CL 18977332 by sara schvartzman in ue5-main branch]
2022-02-14 05:26:33 -05:00
marc audy
44f9f4a168 Fix non-unity
#jira UE-142290, UE-142291
[FYI] Robert.Manuszewski
#rnx
#preflight 620832eccb132bbe75990d38

#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 18973554 in //UE5/Release-5.0/... via CL 18973580 via CL 18973597
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18973598 by marc audy in ue5-main branch]
2022-02-12 17:52:50 -05:00
Helge Mathee
25659c95a1 RigVM: Remove use of UE_RIGVM_UCLASS_BASED_STORAGE_DISABLED define
#rb sara.schvartzman
#jira na
#preflight https://horde.devtools.epicgames.com/job/6206623a963efc0c28d83c37

[CL 18951321 by Helge Mathee in ue5-main branch]
2022-02-11 08:48:47 -05:00
helge mathee
6571672185 RigVMController Non Unity Build
#rb halfdan.ingvarsson
#jira na
#preflight https://horde.devtools.epicgames.com/job/62054adc0c64e1822f412002
#lockdown cristina.riveron

#ROBOMERGE-AUTHOR: helge.mathee
#ROBOMERGE-SOURCE: CL 18939036 in //UE5/Release-5.0/... via CL 18939165 via CL 18939379
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18939399 by helge mathee in ue5-main branch]
2022-02-10 13:08:01 -05:00
helge mathee
68a5d4b7df Control Rig: Move function reference table to the dependent blueprint asset registry searchable data
#rb sara.schvartzman
#jira UE-140239
#preflight https://horde.devtools.epicgames.com/job/6203d14b724404041858cd83
#lockdown juan.canada

#ROBOMERGE-AUTHOR: helge.mathee
#ROBOMERGE-SOURCE: CL 18934230 in //UE5/Release-5.0/... via CL 18934300 via CL 18934322
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v916-18915374)

[CL 18934323 by helge mathee in ue5-main branch]
2022-02-10 07:13:27 -05:00
helge mathee
aa0046a09a Control Rig: Traverse sub pins of select nodes correctly when compiling
Fixed the case of float vs double for arrays - this was never working before apparently.

Also improved the warning message from the VM's memory backend:
Failed to copy uValuesWings (TArray<double>) to Rig_ArrayReset_Array__IO (TArray<float>) in package ...

#rb sara.schvartzman
#jira UE-141662
#preflight https://horde.devtools.epicgames.com/job/620264aabd4f846436da20fb
#lockdown juan.canada

#ROBOMERGE-AUTHOR: helge.mathee
#ROBOMERGE-SOURCE: CL 18901271 in //UE5/Release-5.0/... via CL 18901305 via CL 18901351
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v912-18901109)

[CL 18901353 by helge mathee in ue5-main branch]
2022-02-08 08:49:46 -05:00
dave jones2
ed1b4ed6a5 UE-140327 - Remove ENABLE_BLUEPRINT_REAL_NUMBERS usage
The original ENABLE_BLUEPRINT_REAL_NUMBERS macro was strictly meant for AB testing in the Dev-LWC. Currently, disabling it won't work, and would likely lead to broken behavior. Its presence might incorrectly indicate to licensees that this is an option that can be toggled safely.

#rb marc.audy
#jira UE-140327
#preflight 61fc6449dc0b3ecbecb6f381
#lockdown julien.marchand

#ROBOMERGE-AUTHOR: dave.jones2
#ROBOMERGE-SOURCE: CL 18864654 in //UE5/Release-5.0/... via CL 18864683 via CL 18864993
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18865002 by dave jones2 in ue5-main branch]
2022-02-04 11:54:52 -05:00
dave jones2
c4b5ae240c FROST-8496 - ABP_Player_v2.uasset: [Compiler] Can't connect pins: float is not compatible with Double Real.
A couple of BP reals changes were missed for IKRig and a new-ish function in RigVMTypeUtils.

For RigVMTypeUtils, we simply need to ensure that we're using the correct PC_Real category when dealing with float/double CPPTypes.

For IKRig, the alpha pin needs to be a real/double type. Additionally, when copying the property data to the FIKRigGoal instance, we need to treat the property's value as a double type. Since FIKRigGoal::Position et al. use the alpha as a normalized value, it likely doesn't need the precision of a double, so it's been left as is. As a result, we need to perform a narrowing conversion when copying over the data.

#jira FROST-8496
#preflight 61faf7115e35b9215b000da8
#rb julien.marchand
#lockdown julien.marchand

#ROBOMERGE-AUTHOR: dave.jones2
#ROBOMERGE-SOURCE: CL 18835074 in //UE5/Release-5.0/... via CL 18835086 via CL 18835353
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18835421 by dave jones2 in ue5-main branch]
2022-02-02 17:45:48 -05:00
sara schvartzman
57fdf48ac3 Control Rig: Fix reroutes redo connection failing
#jira UE-140968 UE-140967
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/61fa99caad2ae6c3b75d1f0a

[CL 18826375 by sara schvartzman in ue5-main branch]
2022-02-02 09:55:36 -05:00
dave jones2
c8574d3b74 Merging //UE5/Dev-LargeWorldCoordinates [at] 18802167 to //UE5/Release-5.0
Blueprint real number support.

This change deprecates the use the of "float" and "double" types in Blueprints in favor of a new "real". By default, "real" is back by a double precision floating point number. However, it can be single precision if the number is a native float property or function parameter. This distinction won't be visible to the Blueprint user: in both instances, they'll be represented by "real" pin types. During deserialization, we'll automatically convert Blueprint pin types to use real/doubles, unless they're used to represent native code (including delegate signatures).

One consequence of this change is that we need to perform implicit casts between single and double precision real numbers. During Blueprint compilation, the compiler will detect points in the graph for when either a widening or narrowing conversion needs to occur. Subsequently, the script bytecode will contain a new cast instruction that performs the conversion. This also works on container types, but each entry in the container will have to be converted. This can introduce unwanted overhead for large containers that are frequently passed between Blueprint and native code.

The scope of this change affects Blueprints used by Gameplay, Animation, Control Rig, and UMG.

#rb marc.audy (serialization changes)
#jira UE-116484
#preflight 61f8bdd5a2514ba12ff7bdfc

#ROBOMERGE-AUTHOR: dave.jones2
#ROBOMERGE-SOURCE: CL 18809077 in //UE5/Release-5.0/... via CL 18809455 via CL 18822548
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18823569 by dave jones2 in ue5-main branch]
2022-02-02 05:50:50 -05:00
sara schvartzman
6f9a130ecd Control Rig: Refresh pasted nodes to update any old configuration of the node (color, pins, name, etc)
#jira UE-140601
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/61f909798b4112f7cc905136

#ROBOMERGE-AUTHOR: sara.schvartzman
#ROBOMERGE-SOURCE: CL 18807587 in //UE5/Release-5.0/... via CL 18809227 via CL 18822244
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18823265 by sara schvartzman in ue5-main branch]
2022-02-02 05:30:33 -05:00