Commit Graph

10460 Commits

Author SHA1 Message Date
sebastien lussier
ab2422f434 Fixed PolyGroup issue with FMeshMergeHelpers::MergeImpostersToMesh()
The function would remap polygroups of the source meshes, then use  FStaticMeshOperations::AppendMeshDescription() which would also mess with the groups.

Providing a polygroup delegate to AppendMeshDescription() solves the issue.

#rb luc.eygasier
#preflight 6214e6de30639b44d2e2976f

#ROBOMERGE-AUTHOR: sebastien.lussier
#ROBOMERGE-SOURCE: CL 19073080 via CL 19086547 via CL 19086625 via CL 19088170
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19131399 by sebastien lussier in ue5-main branch]
2022-02-24 19:01:43 -05:00
stephen ma
8af4582071 Add ability to LowLevelTestsRunner --global-base-moulde to Pre-load and unload modules outside of catch runs.
- This should avoid the startup.cpp and teardown.cpp pattern and more predictiablly tear-down and setup tests during GlobalSetup/Teardown.

#jira OI-3788
#review @chris.constantinescu
#rb @chris.constantinescu
#preflight 6217e996785f20248baf285d

[CL 19124450 by stephen ma in ue5-main branch]
2022-02-24 15:45:40 -05:00
michael noland
c8dc8362b7 Prevent a crash when there is more than one kind of UPlatformSettings usage in a project
- Removed the problematic static that caused the crash and introduced a new caching system via a UPlatformSettingsManager class that keeps explicit references to the settings instead of adding them to the root
- Switched the platform names to be more consistently FName instead of roundtripping through FString

- Slightly unrelated: Added DeterminesOutputType metadata to FindParentWidgetOfType to avoid needing an extra cast in typical usage

#jira UE-142875
#rb nick.darnell
#preflight 620c788a252ef638b5806fd7

#ROBOMERGE-AUTHOR: michael.noland
#ROBOMERGE-SOURCE: CL 19060400 in //UE5/Release-5.0/... via CL 19076932
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19120907 by michael noland in ue5-main branch]
2022-02-24 14:23:31 -05:00
charles bloom
be0e9e0d04 NOP comment about FinalizeVirtualTextureLayerFormat
#rb none
#preflight none

[CL 19117436 by charles bloom in ue5-main branch]
2022-02-24 12:48:42 -05:00
zousar shaker
25249765d9 Avoid wasted time when pulling data from Jupiter by:
1) Increasing connection pool size
2) Allowing DNS and SSL/TLS data to be shared by connections
3) Switching to ValueOnly mode for Jupiter backends by default
4) Using "inline get" feature when querying Value data

Tested:
- .run editor -- -execCmds="Automation RunTests System.DerivedDataCache.HttpDerivedDataBackend.CacheStore;Quit" -NullRHI -stdout -unattended -ddc=DerivedDataBackendGraph_Jupiter
-Launch CitySample editor with empty local cache and open Small_City_LVL
-Launch CitySample editor with hot local cache and open Small_City_LVL

Can be improved further with a batched existence API for refs (instead of blobs).  The current one does not work due to a Jupiter server bug, so this is an improvement that will have to come afterwards.

Note: There is a known issue involving Jupiter where the server will sometimes return uncompressed blobs.  This manifests as cache misses due to invalid/rejected results returned from Jupiter.  The client handles the miss and builds the data and stores it in its local cache but does not upload it to Jupiter (because Jupiter says it already has the blob).  Subsequent runs will not suffer from the issue as the data will be present in the local cache.  There are discussions in progress for how to address this issue on server or client side.  No immediate mitigation is needed for it.

#rb devin.doucette
#jira UE-143616
#lockdown aurel.cordonnier
#preflight


#ROBOMERGE-OWNER: zousar.shaker
#ROBOMERGE-AUTHOR: zousar.shaker
#ROBOMERGE-SOURCE: CL 19104205 via CL 19104462 via CL 19104579 via CL 19104585 via CL 19110006
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19113840 by zousar shaker in ue5-main branch]
2022-02-24 10:24:10 -05:00
Alexis Matte
9775bb4fbd Add Interchange support for Import geo/skinning only workflow
#UETOOL-4729
#rb richard.talbotwatkin
#rnx
#preflight 62178d841a114ad504392e3f

[CL 19112941 by Alexis Matte in ue5-main branch]
2022-02-24 09:10:50 -05:00
ionut matasaru
7e6a1a821c [Insights] Session Browser: Added sorting for all columns in the trace sessions list view.
#jira UE-143666
#rb Catalin.Dragoiu
#preflight 62173634647bb7debf78921f

[CL 19111480 by ionut matasaru in ue5-main branch]
2022-02-24 05:05:48 -05:00
Brian Karis
dba24ab6be FDynamicBVH now supports a forest with a spatial hash at the highest level to support LWC without the need for doubles for bounding boxes.
Switched FDynamicBVH to use greedy insertion because branch and bound perf significantly degrades with heavily overlapped leaves.

Added closest point queries using branch and bound.

FBounds is now templated as TBounds.

#rb graham.wihlidal
#robomerge FNNC
#preflight 6216dbf9104496cff8abfc36

[CL 19107993 by Brian Karis in ue5-main branch]
2022-02-23 21:17:53 -05:00
charles bloom
38b1d2e51f Mark up more ParallelFor scopes for Insights
#rb none
#preflight 6216cd82647bb7debf703367

[CL 19105606 by charles bloom in ue5-main branch]
2022-02-23 19:25:03 -05:00
geoff evans
bd2a5c3af2 Detect broken Blueprint assets and abort Migration if they are included.
The condition here mimics the condition we use when we advise caution about opening the Blueprint Editor on the same assets.

Use Force Delete to null out references and unload assets so we can delete the package files that Migrate generated.

#rnx
#rb steve.robb
#jira UE-142833
#preflight 62100735eb1ea1b2cce404d1

[CL 19103703 by geoff evans in ue5-main branch]
2022-02-23 17:53:45 -05:00
devin doucette
6dd39d0d04 DDC: Fixed -DDC-All-MissRate to work with callers that expect consistent hits on the same key
Fixes the accumulation of stats in the async wrapper as well.

#jira UE-143606
#preflight 6216a933a45a91013f3f4047
#lockdown Aurel.Cordonnier
#rb Zousar.Shaker
#rnx

#ROBOMERGE-OWNER: Devin.Doucette
#ROBOMERGE-AUTHOR: devin.doucette
#ROBOMERGE-COMMAND: _robomerge UE5-Main
#ROBOMERGE-SOURCE: CL 19102208 in //UE5/Release-5.0/... via CL 19102301
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19102315 by devin doucette in ue5-main branch]
2022-02-23 17:04:41 -05:00
charles bloom
2f44eb27d5 Fix alpha being turned on for textures when "Max Texture Size" is used
even when source image was opaque
this is caused by the mip filter being not quite normalized, which introduces a slightly less than 1 alpha
fix by increasing alpha tolerance to where a non-255 U8 alpha would actually be visible
prevents BC1 textures from becoming BC3 for no reason

#jira UE-133281
#preflight 6216749d104496cff89ca0e8
#rb dan.thompson,fabian.giesen

[CL 19097654 by charles bloom in ue5-main branch]
2022-02-23 14:33:29 -05:00
devin doucette
a2fba58903 DDC: Destroy the cache store graph when shutting down the cache
#jira UE-116166
#preflight 620ea11c7509be98435db253
#lockdown Aurel.Cordonnier
#rb Zousar.Shaker

#ROBOMERGE-OWNER: Devin.Doucette
#ROBOMERGE-AUTHOR: devin.doucette
#ROBOMERGE-COMMAND: _robomerge UE5-Main
#ROBOMERGE-SOURCE: CL 19092848 in //UE5/Release-5.0/... via CL 19096129
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19096234 by devin doucette in ue5-main branch]
2022-02-23 13:47:00 -05:00
devin doucette
0e929ad2f3 DDC: Re-added the in-flight cache for async puts
- Legacy puts are now executing asynchronously.
- Memory cache now merges partial cache records.
- Memory cache is used to store data temporarily while it is being written by an async put.
- Expanded the deprecation of persisted boot/memory caches, which no longer offer the performance benefit that they used to.
- Fixed the pak file cache to skip data with a compressed size of over 2 GiB.

#jira UE-141307
#preflight 620d85f93609e19371510fb1
#lockdown Aurel.Cordonnier
#rb Zousar.Shaker
#rnx

#ROBOMERGE-OWNER: Devin.Doucette
#ROBOMERGE-AUTHOR: devin.doucette
#ROBOMERGE-COMMAND: _robomerge UE5-Main
#ROBOMERGE-SOURCE: CL 19076205 in //UE5/Release-5.0/... via CL 19094550
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19095974 by devin doucette in ue5-main branch]
2022-02-23 13:40:18 -05:00
devin doucette
792dbb1d33 DDC: Fixed MissTypes configuration broken by the new legacy key format
#jira none
#preflight 620bd6fb475fb819ddc646c2
#lockdown Aurel.Cordonnier
#rb Zousar.Shaker
#rnx

#ROBOMERGE-OWNER: Devin.Doucette
#ROBOMERGE-AUTHOR: devin.doucette
#ROBOMERGE-COMMAND: _robomerge UE5-Main
#ROBOMERGE-SOURCE: CL 19075175 in //UE5/Release-5.0/... via CL 19094294
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19095954 by devin doucette in ue5-main branch]
2022-02-23 13:39:39 -05:00
Matt Peters
9741234c21 HttpCacheStoreTest: Add test to confirm that downloading from Jupiter -> Upstream Zen -> Zen -> Client works.
#rb Zousar.Shaker
#rnx
#preflight 621674780f71e491cc07ee7e

[CL 19095244 by Matt Peters in ue5-main branch]
2022-02-23 13:13:43 -05:00
Wojciech Krywult
7b5537cc26 CookOnTheFly (platform protocol): Editor: Added support of the platform-specific transport communication protocols to the editor and use it in the cooking server.
This change allows the cooking server to communicate with clients using platform-specific communication protocols instead of TCP (the default).

This new mode is activated by adding '-platformprotocol' command-line parameter when starting the cooking server (in addition to the usual '-cookonthefly').

The new functionality is included in FNetworkFileServerPlatformProtocol, which is a variant of the preexisting FNetworkFileServer but using ITargetDevice/ITargetDeviceSocket interfaces instead of traditional sockets.

Direct communication with targets is only supported on some platforms, which can be checked by calling ITargetPlatform::SupportsFeature(ETargetPlatformFeatures::DirectDataExchange).

#rb jeff.newquist
#preflight 62166a4237178b0175af6269

[CL 19094838 by Wojciech Krywult in ue5-main branch]
2022-02-23 12:54:09 -05:00
Dominik Peacock
37305aef15 Make dependencyy from UndoHistory to UnrealEd optional
#jira UE-143320
#rb Matt.Johnson
#rb Lauren.Barnes
#preflight 621642ffbd3bdd9086d72271

[CL 19090889 by Dominik Peacock in ue5-main branch]
2022-02-23 09:45:34 -05:00
ionut matasaru
5c95670948 [Insights]
- Modules: Split the "Stats" column into 4 separate columns: Discovered, Cached, Resolved and Failed.
  - Modules: Added sorting for all columns.
  - Modules: Improved coloring to highlight modules with failed status.
  - Modules: Implemented workadound for Discovered value to include the Cached value (so now displayed Discovered = Cached + Resolved + Failed).

#rb Johan.Berg
#prefligh 621623b3104496cff888e9bd

[CL 19090358 by ionut matasaru in ue5-main branch]
2022-02-23 09:20:19 -05:00
charles bloom
3033072e5a fix filter settings used by GenerateTopMip for ApplyCompositeTexture
use an odd centered filter so there's no half pixel shift

#preflight 621539e0840463c99a6d1037
#rb fabian.giesen

[CL 19081928 by charles bloom in ue5-main branch]
2022-02-22 16:55:59 -05:00
zousar shaker
5f7ace679b Improve error handling and messaging when Horde Storage server has errors during the multi-step PUT of structured data (records or values).
#rb devin.doucette
#jira UE-142763
#preflight 620c1c9901253d2e19ecebeb
#lockdown aurel.cordonnier

#ROBOMERGE-AUTHOR: zousar.shaker
#ROBOMERGE-SOURCE: CL 19059654 in //UE5/Release-5.0/... via CL 19074796
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19076670 by zousar shaker in ue5-main branch]
2022-02-22 13:55:39 -05:00
chris constantinescu
c8cb8f0b04 Module-level setup/teardown with the help of source file build order overrides.
- optional alter of source file build order: towards beginning or end
- test build: correctly handle inclusion of special dependencies such as Engine, Editor, CoreUObject and ApplicationCore
- existing tests: add setup and teardown tests that initialize test modules. This causes setup and teardown to be local to module instead of global, which was not the correct way to run tests across multiple modules.

#preflight 62151e43dc0170cfb3649ee8
#rb Jermoe.Delattre

[CL 19076600 by chris constantinescu in ue5-main branch]
2022-02-22 13:52:35 -05:00
nuno leiria
46fda1e778 Remove logging when no platform info is found because it can be spammy
#jira UE-141218
#rb david.harvey
#preflight 621505f09e113332ba13d4d5

[CL 19074665 by nuno leiria in ue5-main branch]
2022-02-22 12:16:00 -05:00
jason stasik
8322a4f3bc Add visibility controls to settings sections
#rb brooke.hubert
#preflight skip

#ROBOMERGE-AUTHOR: jason.stasik
#ROBOMERGE-SOURCE: CL 19053548 via CL 19059537 via CL 19071223 via CL 19071339 via CL 19072058
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v920-19070459)

[CL 19072234 by jason stasik in ue5-main branch]
2022-02-22 09:23:45 -05:00
sara schvartzman
73c142058b Control Rig: Fix pytlhon command for changing exposed pin type incorrect
#jira na
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/6214d973141b500e17e1542f

[CL 19071193 by sara schvartzman in ue5-main branch]
2022-02-22 07:50:53 -05:00