Commit Graph

115 Commits

Author SHA1 Message Date
luc eygasier
c45b45fb0c Enables "Locate file" only if assets are accessible from ContentBrowser.
#rb Sebastien.Lussier

[CL 15934324 by luc eygasier in ue5-main branch]
2021-04-06 16:11:32 -04:00
luc eygasier
49e2ce208b Adds notifications on success/failure when submitting with SourceControlChangelistsWidget
#lockdown Simon.Tourangeau
#rb Sebastien.Lussier
#jira UE-112896
#robomerge Release-5.0-EarlyAccess

[CL 15933038 by luc eygasier in ue5-main branch]
2021-04-06 14:20:24 -04:00
louise rasmussen
825c64a6f5 Level Editor Menu Re-org, Part 1
#JIRA UETOOL-3039
#rb Lauren.Barnes
#lockdown Simon.Tourangeau
#preflight 606b8e0315d4190001b1698b

#ROBOMERGE-SOURCE: CL 15924633 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v786-15839533)

[CL 15924652 by louise rasmussen in ue5-main branch]
2021-04-05 19:11:24 -04:00
Patrick Enfedaque
41d0fa18a5 OFPA: Add new static ULevel::GetExternalActorsFolderName() method to avoid proliferation of "__ExternalActors__" in code
#rb jeanfrancois.dube, jeff.farris
#preflight 605cb5a59f571900013ea12f
#robomerge Release-5.0-EarlyAccess

[CL 15826153 by Patrick Enfedaque in ue5-main branch]
2021-03-25 13:03:49 -04:00
julien lheureux
e1004780ae Added timer on changelist refresh operation
Added Move files operation on files in changelist dialog (incl. move to new)
Added new changelist button in toolbar
Added cancellable "path beautification" when we have deleted/shelved files with no matching file, until we make it lazy and/or batched

#rb sebastien.lussier

[CL 15797238 by julien lheureux in ue5-main branch]
2021-03-24 08:29:57 -04:00
Tim Smith
a2237e050d LiveCoding Re-instancing
LIMITATIONS:

1) Re-instancing will only update UClass instance data.
2) Adding and removing properties should only be done towards the end of a class or structure and can not be followed by complex data types.
3) Adding and removing properties from a base class should not be done if a derived class contains complex data types.

KNOWN ISSUES:

1) Changes to enumerations and structures will not be reflected in existing blueprints.  However, adding new nodes to the blueprint will show the updated enumeration or structure.
2) If a class contains an enumeration or structure as a member, the class will not be re-instanced if enumeration or structure is changed.

CHANGES:

1) LiveCodingServer
1a) Modified to always execute certain static instances during load.
1b) Modified to exclude the _Statics static structures to avoid patching to old copies.

2) Added support for LiveCoding reinstancing
2a) Refactored deferred registration system for UClass, UEnum, and UScriptStruct to use a common system that works for normal game, hot reload and live coding.
2b) Type specific version check data is possible (i.e. enum doesn't have a size)
2c) Single registration static for UClass
2d) Single registration class for all types that is just a blind forward to API.
2e) Static and dynamic registrations use different API entry points to avoid having overloaded argument lists that just apply to one or the other.
2f) Shims for older API

3) New common "Reload" system to avoid using HotReload code.
3a) Support common delegates regardless of who is reloading/reinstancing.
3b) Re-instancing code moved from HotReload to Kismet2 (where the bulk of the re-instance code already existed).
3c) Modified PyWrapper to use new helper class instead of depending on HotRelaod
3d) Added WITH_RELOAD which is defined if HotReload or LiveCoding is enabled.
3e) Modifed existing code to use new #define and delegates.

Robert did the review on the changes covered by Part 2.  Remaining changes are all straightforward.

#rb robert.manuszewski
#jira UE-74493

[CL 15736777 by Tim Smith in ue5-main branch]
2021-03-18 08:13:59 -04:00
patrick enfedaque
925afa781b SourceControl: Replace main menu "Submit" menu with "View Changelists..."
#rb sebastien.lussier

#ROBOMERGE-SOURCE: CL 15725157 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v781-15675533)

[CL 15727212 by patrick enfedaque in ue5-main branch]
2021-03-17 13:43:31 -04:00
Sebastien Lussier
fbd129105f Source control changelists - Disable submit button if the validation contains errors
#rb richard.malo
#robomerge Release-5.0-EarlyAccess

[CL 15668594 by Sebastien Lussier in ue5-main branch]
2021-03-10 15:03:45 -04:00
sebastien lussier
ef589f0b39 Minor UX improvements to the Source Control Changelists window
#rb none

#ROBOMERGE-SOURCE: CL 15554968 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v771-15082668)

[CL 15554971 by sebastien lussier in ue5-main branch]
2021-02-28 23:55:37 -04:00
julien lheureux
aa5b17da40 Fix "shelved files" from default changelist, now has the same behavior as in P4V.
Fix an issue where editing a changelist containing shelved files would fail silently.

#rb sebastien.lussier
#jira UE-107676

[CL 15359009 by julien lheureux in ue5-main branch]
2021-02-08 15:32:48 -04:00
julien lheureux
a460459eed Added possibility to get asset data from history, with a max fetch size (until we have a better solution)
Changed the way we associate shelved files with their local filename to facilitate mapping (perforce operations)
Implemented what was needed on the SCC side to support diff against shelve
Improved way we display object names for deleted & shelved files

#rb sebastien.lussier

[CL 15356101 by julien lheureux in ue5-main branch]
2021-02-08 09:36:20 -04:00
julien lheureux
57426a7c27 Refactored changelist tree items to be shareable with the submit dialog (allows symmetrical display)
Added an exception to changelist validation for deleted files
Improved display of deleted & shelved objects in changelists & submit dialog - improvements related to OFPA in a subsequent change.

#rb sebastien.lussier
#jira UE-107677, UE-107768

[CL 15322858 by julien lheureux in ue5-main branch]
2021-02-04 17:41:41 -04:00
julien lheureux
6b739a3205 Added data validation capabilities in the source control.
Exposed data validation in changelists

#rb sebastien.lussier, jeanfrancois.dube, jamie.dale

[CL 15316170 by julien lheureux in ue5-main branch]
2021-02-04 11:50:49 -04:00
Marc Audy
cac1fe0019 Merge UE5/Release-Engine-Staging @ CL# 15299266 to UE5/Main
This represents UE4/Main @ CL# 15277572

[CL 15299962 by Marc Audy in ue5-main branch]
2021-02-03 14:57:28 -04:00
julien lheureux
202e872b4c Improved behavior of changelist operations on default changelist - edit & submit now work as intended.
Fixed an issue when trying to delete the default changelist which triggered a disconnection from the source control provider.
Improved some UI in the changelist context menu to clarify what is available or not.

#rb sebastien.lussier

[CL 15222160 by julien lheureux in ue5-main branch]
2021-01-27 16:11:25 -04:00
julien lheureux
7d798e1d1c Added refresh button to the changelists dialog.
#rb sebastien.lussier

[CL 15220739 by julien lheureux in ue5-main branch]
2021-01-27 15:28:56 -04:00
julien lheureux
d859ef7cdb Added mechanism to retain tree expansion states around tree view rebuilds (changelists dialog)
#rb sebastien.lussier

[CL 15207712 by julien lheureux in ue5-main branch]
2021-01-26 10:56:16 -04:00
julien lheureux
108dfb8d7e Added support for shelved files in changelist, including shelve, unshelve and delete shelve operations.
Added update state for reopen operation as well.

#rb sebastien.lussier

[CL 15207112 by julien lheureux in ue5-main branch]
2021-01-26 09:19:24 -04:00
julien lheureux
7660280730 Added ActorLabel tag for actors using WP
Used the ActorLabel tag to obtain a better name in changelists dialog

#rb sebastien.lussier, jeanfrancois.dube

[CL 15166658 by julien lheureux in ue5-main branch]
2021-01-22 16:21:29 -04:00
julien lheureux
4c5895ebec Added asset name & type, simlar to the save dialog to the changelists view.
[CL 15145027 by julien lheureux in ue5-main branch]
2021-01-20 11:49:37 -04:00
julien lheureux
f3a1f5e632 Added confirmation on submit/revert changelists
Fixed an issue in the get pending changelists when there is only the default changelist present

[CL 15144321 by julien lheureux in ue5-main branch]
2021-01-20 09:51:23 -04:00
julien lheureux
8d3734f953 Added contextual menu options for file actions (diff agains depot, show history, locate file)
Better cleanup in perforce revert operation
Made revert work on changelists
Fixed issue where no changelists would be displayed if the default changelist was empty.

#rb sebastien.lussier

[CL 15138037 by julien lheureux in ue5-main branch]
2021-01-19 14:50:23 -04:00
Sebastien Lussier
58bdbc57ae Changelist window - Drag & drop support
#rb julien.lheureux

[CL 15132088 by Sebastien Lussier in ue5-main branch]
2021-01-18 15:31:14 -04:00
julien lheureux
2bb7495a45 - Added new, delete, edit changelist commands
- Added revert unchanged on changelists & files
- Added changelist parameter to the Execute method of ISourceControlProvider (& updated all derived classes)
- Fixed style problem in the Perforce settings dialog

#rb sebastien.lussier

[CL 15128504 by julien lheureux in ue5-main branch]
2021-01-18 09:42:33 -04:00
Sebastien Lussier
9f93f3e8cd Changelist window - Selection improvement
* Prevent selection of files & changelists at the same time
* Only allow selection of files from the same changelist
#rb julien.lheureux

[CL 15076981 by Sebastien Lussier in ue5-main branch]
2021-01-13 20:52:07 -04:00