Commit Graph

2133 Commits

Author SHA1 Message Date
alex kahn
eee2dd4151 [Backout] - CL30051221 - CIS Compile Error
[FYI] christopher.waters
Original CL Desc
-----------------------------------------------------------------
Dependency Cleanup
- Moving IAssetCompilingManager to its own header
- Changing FAsyncCompilationNotification members to TUniquePtr<FAsyncCompilationNotification> to remove dependencies on AsyncCompilationHelpers.h
- Removing includes of AsyncCompilationHelpers.h and AssetCompilingManager.h removes 3s of compile time per file on a 3990x

#rb henrik.karlsson

[CL 30054260 by alex kahn in ue5-main branch]
2023-12-01 16:35:33 -05:00
don boogert
ece3d424fc Landscape : fix crash on map load
#rb luc.eygasier

[CL 30054187 by don boogert in ue5-main branch]
2023-12-01 16:34:14 -05:00
christopher waters
63b714cc00 Fixing Debug NonUnity compile errors.
[CL 30051341 by christopher waters in ue5-main branch]
2023-12-01 15:34:00 -05:00
christopher waters
f665a777c7 Dependency Cleanup
- Moving IAssetCompilingManager to its own header
- Changing FAsyncCompilationNotification members to TUniquePtr<FAsyncCompilationNotification> to remove dependencies on AsyncCompilationHelpers.h
- Removing includes of AsyncCompilationHelpers.h and AssetCompilingManager.h removes 3s of compile time per file on a 3990x

#rb henrik.karlsson

[CL 30051281 by christopher waters in ue5-main branch]
2023-12-01 15:32:12 -05:00
jon cain
b11a5c3b85 Fix for Landscape Grass exporting the incorrect locations due to recent bUseFauxOrtho changes in orthographic rendering.
#rb Ola.Olsson

[CL 30041917 by jon cain in ue5-main branch]
2023-12-01 11:02:30 -05:00
don boogert
302241b760 Landscape: Emit warning during cook if Landscape needs resaving (to rebuild nanite)
#rb chris.tchou

[CL 30030169 by don boogert in ue5-main branch]
2023-11-30 19:50:50 -05:00
chris tchou
611f628789 Fix for assert when saving some landscapes with no grass.
Main issue was that RemoveGrassMap() would take a shortcut if there were no grass types, failing to set a proper generation hash. But I also noticed there was an issue with the amortization that could result in a partial update, which could also lead to the assert.

#rb jonathan.bard
#jira UE-200649

[CL 30007701 by chris tchou in ue5-main branch]
2023-11-29 20:49:36 -05:00
sebastien lussier
892a440b3f World Partition - HLOD: Allow line traces on HLOD actors in the editor
* Will enable many editor features to work with HLOD actors (placement tool, play from here, go here, etc)
* Build collision data for HLOD static meshes
* Enable queries collisions in editor
* Strip all collision data during cook
#rb JeanFrancois.Dube
#jira UE-193294

[CL 29994011 by sebastien lussier in ue5-main branch]
2023-11-29 13:42:37 -05:00
jonathan bard
831a58eb2c Deprecated prototype-y function to change LOD settings on landscape directly on the render proxy : it's already doable in a normal fashion by invalidating the render proxy
#rb chris.tchou
#tests editor

[CL 29991927 by jonathan bard in ue5-main branch]
2023-11-29 12:41:43 -05:00
jonathan bard
54268ac37a Fixed incorrect landscape CVar names
#rb chris.tchou
#tests editor

[CL 29990823 by jonathan bard in ue5-main branch]
2023-11-29 12:01:06 -05:00
josie yang
072ddd2180 Check landscape override key exists before using it
- Fix EngineTest Ocean_Colorless, River_Deep_EyeLevel, SkyOverview tests

#jira UE-201264
#rb roey.borsteinas

[CL 29988045 by josie yang in ue5-main branch]
2023-11-29 10:20:12 -05:00
jonathan bard
921d07e187 Fixed ensure when painting/sculpting outside a landscape
#rb chris.tchou
#jira UE-201067
#tests editor

[CL 29959327 by jonathan bard in ue5-main branch]
2023-11-28 09:50:47 -05:00
jonathan bard
de8005187b Fixed bad english
[CL 29958681 by jonathan bard in ue5-main branch]
2023-11-28 09:10:19 -05:00
jeanfrancois dube
71b3987465 Level Coloration:
- FPrimitiveSceneProxy derived classes no longer need to implement custom logic to set their level color, as it is now fetched directly from the FPrimitiveSceneProxyDesc owner's level and pushed into the corresponding FPrimitiveSceneProxy when creating the proxies.
  - World Partition level streaming objects will push a deterministic random color based on the obejct's name in the level streaming objects.
  - Added Nanite support for level coloration debug view mode.

This will then serves as a base for existing and future coloring debug view modes, instead of doing custom debug views.

#rb Sebastien.Lussier

[CL 29951102 by jeanfrancois dube in ue5-main branch]
2023-11-27 18:51:14 -05:00
don boogert
d01e192721 Landscape: Added a Nanite Position Precision property to Landscape Actors. Defaults to 1cm in worldspace.
#rb jonathan.bard

[CL 29938390 by don boogert in ue5-main branch]
2023-11-27 13:00:29 -05:00
jonathan bard
28427653f8 * Fixed translation/rotation/scale axis sub-property not being passed to PropertyChangedEvent anymore
* Fixed landscape XY scale which could become non-uniform when pasting a non-uniform scale in the details panel

#rb Robert.Manuszewski
#jira UE-201211
#tests editor

[CL 29934640 by jonathan bard in ue5-main branch]
2023-11-27 10:42:53 -05:00
dmytro vovk
664614acde Fixed grass not being updated by exclusion boxes during heavy building scenario in the local area
#rb Jonathan.Bard

[CL 29933356 by dmytro vovk in ue5-main branch]
2023-11-27 09:34:26 -05:00
don boogert
4ef23fca4d [Backout] - CL29911799
[FYI] don.boogert
Original CL Desc
-----------------------------------------------------------------
Landscape: Added a Nanite Position Precision property to Landscape Actors. Defaults to 1cm in worldspace.

#rb jonathan.bard

[CL 29925581 by don boogert in ue5-main branch]
2023-11-24 23:58:05 -05:00
don boogert
4c1ccc8aeb Landscape: Added a Nanite Position Precision property to Landscape Actors. Defaults to 1cm in worldspace.
#rb jonathan.bard

[CL 29911853 by don boogert in ue5-main branch]
2023-11-23 12:31:35 -05:00
christopher daniel
81d0844367 Crash Prevention: Added null checks to various crashes found when running the editor.
These crashes were surfaced by CL 29712224 which exposed that these values were not being null checked.

#rnx
#rb dan.kaufman, Mic.Rooney
[REVIEW] [at]Dan.Kaufman, [at]Beth.Reid, [at]Anthony.Glueck
[FYI] Jon.Cain

[CL 29870018 by christopher daniel in ue5-main branch]
2023-11-21 13:04:42 -05:00
chris tchou
f1c6f6ea27 Move cook time grass data stripping to serialization, and move cook time collision stripping to the NeedsLoadForClient/Server() callbacks.
This fixes deadlock issues when BeginCacheForCookedPlatform() is called multiple times to cache multiple platforms simultaneously, and also fixes an issue with collision stripping not being reversible.

#rb jonathan.bard
#jira UE-199972, PLAY-14480
[FYI] brandon.dawson

[CL 29868130 by chris tchou in ue5-main branch]
2023-11-21 12:12:00 -05:00
dmytro vovk
df99b345bd Minor mem saving in grass component's exclude boxes
#rb Jonathan.Bard

[CL 29867063 by dmytro vovk in ue5-main branch]
2023-11-21 11:38:04 -05:00
josie yang
42f21dadb5 Implementation of Custom Render Pass
- Supports rendering depth prepass and base pass, output scene color and depth
- Replacing the underline implementation of rendering scene capture depth as additional scene view
- Added water plugin support

#jira UE-194793
#rb Dmitriy.Dyomin, Florin.Pascu, roey.borsteinas, Rune.Stubbe, tim.doerries

[CL 29864008 by josie yang in ue5-main branch]
2023-11-21 09:55:42 -05:00
chris tchou
2b057e19f1 Fix an infinite loop on save when Grass.Enabled false.
Also fixed an assert when doing a blocking grass update: if you don't run a full update every loop then sanity checks will fail.

Also move the allocator pool to be a member instead of global static, and speed up save by using blocking GPU submit calls.

#rb jonathan.bard

[CL 29844714 by chris tchou in ue5-main branch]
2023-11-20 12:43:54 -05:00
don boogert
2dc081daf7 [Backout] - CL29761013
[FYI] don.boogert
Original CL Desc
-----------------------------------------------------------------
Landscape: Added a Nanite Position Precision property to Landscape Actors. Defaults to 1cm in worldspace.

#rb jonathan.bard

[CL 29835586 by don boogert in ue5-main branch]
2023-11-19 15:53:54 -05:00