michael nicolella
cd1f028d02
autortfm: catch a few cases of invoking Verse outside of an autortfm transaction
...
[CL 27504689 by michael nicolella in ue5-main branch]
2023-08-30 18:18:11 -04:00
eric day
b5e679b680
Fix for lambda delegate tied to lifetime of a shared-pointer.
...
[CL 26472377 by eric day in ue5-main branch]
2023-07-19 17:38:39 -04:00
eric day
de97b76872
Add lambda delegate tied to lifetime of a shared-pointer, similar to WeakLambdas for UObjects.
...
[REVIEW] [at]michael.atchison
[CL 26472153 by eric day in ue5-main branch]
2023-07-19 17:34:39 -04:00
steve robb
98cb3053d4
Delegate perfect forwarding.
...
#rb andriy.tylychko
[CL 26048600 by steve robb in ue5-main branch]
2023-06-16 09:01:39 -04:00
michael nicolella
b17f026085
[autortfm] - use no-op impl of FReadAccessScope+FWriteAccessScope under autortfm since this only seems to be for dev debugging?
...
[CL 25966033 by michael nicolella in ue5-main branch]
2023-06-13 18:20:43 -04:00
neil henning
7b0ae18c8b
Fix the multithreaded delegate access handler for AutoRTFM.
...
[CL 25865894 by neil henning in ue5-main branch]
2023-06-08 03:32:27 -04:00
Andriy Tylychko
4638ecdc48
enabled delegates race detection again despite the previous attemp resulted in https://horde.devtools.epicgames.com/job/6478888f1e2ac848d84a703e?step=3c1d (again). the assumption is that it's intermitted horde issue, details: https://epicgames.slack.com/archives/C044JF12ML2/p1684844687045239?thread_ts=1684838464.948959&cid=C044JF12ML2
...
#preflight trivial
[CL 25761318 by Andriy Tylychko in ue5-main branch]
2023-06-02 10:47:48 -04:00
Andriy Tylychko
13fbe63855
disabled delegates race detection due to https://horde.devtools.epicgames.com/log/64788e54f8715b9b1bf4b107
...
#preflight trivial
[CL 25727211 by Andriy Tylychko in ue5-main branch]
2023-06-01 11:03:19 -04:00
Andriy Tylychko
978c60a1e4
enabled delegates race detection to repro https://horde.devtools.epicgames.com/log/64761bdf03438130a4ebfc35?issue=311732 on horde as I can't repro it locally. will disable it again as soon as it fails
...
#preflight trivial
[CL 25723597 by Andriy Tylychko in ue5-main branch]
2023-06-01 07:53:21 -04:00
Andriy Tylychko
4a375b1271
disabled delegates race detection again, as it asserts in cooking, e.g. https://horde.devtools.epicgames.com/log/64761bdf03438130a4ebfc35
...
#preflight trivial
[CL 25679233 by Andriy Tylychko in ue5-main branch]
2023-05-30 12:17:59 -04:00
Andriy Tylychko
a35de96054
enabled delegates race detection as I disabled it by mistake
...
#preflight trivial
[CL 25677958 by Andriy Tylychko in ue5-main branch]
2023-05-30 11:00:06 -04:00
Andriy Tylychko
ee63c88cbe
disabling delegates race detection
...
#UE-187058
#preflight trivial
[CL 25677703 by Andriy Tylychko in ue5-main branch]
2023-05-30 10:49:27 -04:00
Andriy Tylychko
76a3b11bf1
enabled delegates race detection. the preflight succeeded on what was the previous issue on cooking ShooterGame ( https://horde.devtools.epicgames.com/job/646fc7cf8b0e69cfb2ea98a7?label=173&issue=309830 )
...
#preflight 6475d64741108655e086cb05
[CL 25675163 by Andriy Tylychko in ue5-main branch]
2023-05-30 08:02:14 -04:00
Andriy Tylychko
828133233d
disabled delegates race detection while investigating reports
...
#preflight trivial
[CL 25628506 by Andriy Tylychko in ue5-main branch]
2023-05-25 16:50:12 -04:00
Andriy Tylychko
2de9cbf131
the issue was fixed in 25607223, so rolling back the rollback
...
#preflight 646f8f135b484acfee4932fb
[Backout] - CL25597666
#fyi zack.neyland
Original CL Desc
-----------------------------------------------------------------
Reverting CL 25577637, it's is blocking Mac editor from opening entirely.
The failure is coming dyld with the following: "could not create thread local variables pthread key". This occurs during plugin loading.
#preflight 646d775d1b241f0748e75e95
#jira UE-186763
[CL 25623686 by Andriy Tylychko in ue5-main branch]
2023-05-25 12:52:20 -04:00
zack neyland
c47a81a427
Reverting CL 25577637, it's is blocking Mac editor from opening entirely.
...
The failure is coming dyld with the following: "could not create thread local variables pthread key". This occurs during plugin loading.
#preflight 646d775d1b241f0748e75e95
#jira UE-186763
[CL 25597666 by zack neyland in ue5-main branch]
2023-05-23 23:12:39 -04:00
Andriy Tylychko
5c238a4d7e
delegates refactoring:
...
* added a thread-safe (locked) delegates variant
* refactored and enabled by default race detection for the original not thread-safe version
* added "not thread-safe not checked" variant for rare cases where race detection doesn't work or it's a known case of a race
#rb steve.robb, francis.hurteau, danny.couture
#preflight 646b9f4d576becd7b53f674c
[CL 25577637 by Andriy Tylychko in ue5-main branch]
2023-05-23 05:17:19 -04:00
Steve Robb
b4bc748981
Made TDelegateBase::CreateDelegateInstance protected.
...
#rb andriy.tylychko
#jira none
#preflight 6447d14ec632d1e89bc80b8b
[CL 25180251 by Steve Robb in ue5-main branch]
2023-04-25 10:30:47 -04:00
Steve Robb
1d66d2db25
Added TDelegate::IsCompatable() and made FFieldMulticastDelegate use it instead of using internal functions.
...
#rb andriy.tylychko, patrick.boutot
#jira none
#preflight 64466b7a4944ef7892d12e3a
[CL 25162384 by Steve Robb in ue5-main branch]
2023-04-24 08:09:16 -04:00
Steve Robb
90d0767a7f
Removed redundant Unbind call from TDelegate's destructor, since TDelegateBase also unbinds.
...
#rb andriy.tylychko
#jira none
#preflight none
[CL 25154551 by Steve Robb in ue5-main branch]
2023-04-21 17:43:02 -04:00
Steve Robb
6fc1da610f
Lots of scoping fixes for the delegate race detector.
...
#rb andriy.tylychko
#jira none
#preflight 6442a9a60171aae0b1b50065
[CL 25146857 by Steve Robb in ue5-main branch]
2023-04-21 11:59:32 -04:00
Steve Robb
db0c8620ed
Separated out a UnicastDelegateType typedef from the invocation list element type in TMulticastDelegateBase.
...
#rb andriy.tylychko
#jira none
#preflight 644152e6090323f9a3dd4438
[CL 25143582 by Steve Robb in ue5-main branch]
2023-04-21 06:42:21 -04:00
Steve Robb
cfcbad6f4c
Probable fix for IncludeTool complaining about multiple conflicting definitions of FDelegateAccessHandlerBaseChecked.
...
#rb andriy.tylychko
#jira none
#preflight 643fff8da9720904a6a73f36
[CL 25107099 by Steve Robb in ue5-main branch]
2023-04-19 11:07:06 -04:00
Steve Robb
11c96f9179
Used a scoped access handler instead of macros for delegate thread-safety detection.
...
#rb andriy.tylychko
#jira none
#preflight 643e77e9b91c13075834e838
[CL 25083571 by Steve Robb in ue5-main branch]
2023-04-18 07:07:28 -04:00
Steve Robb
7263caa7b1
Removed unused forward declarations of FWeakObjectPtr.
...
#rb trivial
#jira none
#preflight none
[CL 25066866 by Steve Robb in ue5-main branch]
2023-04-17 09:02:26 -04:00
