Commit Graph

263 Commits

Author SHA1 Message Date
henrik karlsson
1a528a125b [UBT]
* Changed so code generating unity file is modifying the right compile environment when adding lookup for source file -> .gen.cpp

Fixes a bug where sndbs fails to remotely build unity files properly

#preflight skipped
#rb joe.kirchoff

[CL 24092753 by henrik karlsson in ue5-main branch]
2023-02-08 23:59:58 -05:00
joe kirchoff
0e0c85e015 UnrealBuildTool: Use a force include define header for .ixx compiles
#rnx
#rb Henrik.Karlsson
#jira UE-175773
#preflight 63e2a028c2257e56f40f5b85

[CL 24058078 by joe kirchoff in ue5-main branch]
2023-02-07 15:41:28 -05:00
henrik karlsson
0de807f1a8 [UBT]
* Added support for additional response files (will be used by header units)
* Added support for shared response files and changed so normal cpp/h build path uses it if toolchain supports it.
* Enabled shared response files on all platforms but android (which doesnt seem to support reponse files including response files)
* Some cleanup in the iwyu toolchain related to shared rsp files

#preflight 63d9af169b3bb6a66cec9a8e
#rb joe.kirchoff

[CL 23943501 by henrik karlsson in ue5-main branch]
2023-01-31 21:24:28 -05:00
ben woodhouse
61d6a27216 Add support for overriding an individual module's optimization level via a new OptimizationLevel property. This requires either a private PCH, or PCHUsageMode=NoPCHs (not recommended) because Clang requires that a PCH's optimization flags match the compile unit.
#rb Joe.Kirchoff

[CL 23933583 by ben woodhouse in ue5-main branch]
2023-01-31 14:12:11 -05:00
henrik karlsson
15e7512ecf [UBT]
* Changed a bunch of code to use StringBuilder instead of TextWriter. Based on superluminal profiling data

#preflight 63d8bb903656ea96dc4ef1bf
#rb none

[CL 23924725 by henrik karlsson in ue5-main branch]
2023-01-31 03:23:17 -05:00
henrik karlsson
047beba924 [UBT]
* Changed so code related to inlined .gen.cpp is using FileItems etc to reduce number of sys calls

#preflight 63d8a8c5ba4fadeef05749cb
#rb none

[CL 23924497 by henrik karlsson in ue5-main branch]
2023-01-31 01:45:05 -05:00
henrik karlsson
bce2998aaa [UBT]
* Fixed so only colliding headers gets hash suffix for files in immediate folder

#preflight 63d86e11f626715201a3daa5
#rb joe.kirchoff

[CL 23924099 by henrik karlsson in ue5-main branch]
2023-01-31 01:29:20 -05:00
henrik karlsson
8c4b56c12b [UBT]
* ActionGraphBuilder - Added AllowAsync parameter to CreateIntermediateTextFile which defaults to true.
* UEBuildModuleCPP - Added AllowAsync false to one place where the code touches the file after CreateIntermediateTextFile has been called
* UEBuildModuleCPP - Changed so code writing LiveCodingInfo.json is using same path as others when it comes to writing files

#preflight 63d86264ec3d1af440d22e35
#rb joe.kirchoff

[CL 23924077 by henrik karlsson in ue5-main branch]
2023-01-31 01:28:52 -05:00
bryan sefcik
5798c36ed1 Added a missing circular dependency with AssetTools and UnrealEd.
Updated AssetTypeActivationOpenedMethod.h to include the generated.h.
#preflight 63d2beb85354589b5c70adb5

[CL 23871556 by bryan sefcik in ue5-main branch]
2023-01-26 13:19:09 -05:00
josh adams
1610c3bee3 UnrealArch/UnrealArchitectures changes
- Creates the UnrealArchitectures class, which wraps a list of UnrealArch objects
 - UnrealArch is a single architecture, expandable enum-like struct
 - There is no more concept of "no/default architecture", there is always a valid active architecture when building
 - Most uses of "string Architecture" are replaced with one of the two above, depending if multiple architectures are supported or not
 - UnrealArch has some platform-extensions for platform-specific naming (like Linux adds in LinuxName that turns, for instance, Arm64 -> aarch64-unknown-linux-gnueabi, which is used in folder names, etc)
 - UnrealArch has bIsX64 which can be used determine intel instruction set (as opposed to arm)
 - TargetRules class has an "Architecture" accessor that will return a single architecture if the active architectures is a single architecture, or throw an exception if multiple. This is useful in a majority of the cases where a paltform can only have a single architecture active in TargetRules (microsoft platforms, for instance, will create separate targets when compiling multiple architectures at once)
 - Added UnrealArchitectureConfig class, which contains all the architecture information for a platform (what architectures are supported, what ones are currently active for given project, etc)

#preflight 63c81fb5b065224750a1759e
#rb mike.fricker,roman.dzieciol,joe.kirchoff,dmytro.vovk,brandon.schaefer [various parts]
#p4v-preflight-copy 23562471

[CL 23829977 by josh adams in ue5-main branch]
2023-01-24 09:30:28 -05:00
Joe Kirchoff
24ebcdfb1d UnrealBuildTool: Support msvc analyzer extensions
Enable by setting ModuleRules.bStaticAnalyzerExtensions = true.

It is recommended to use ModuleRules.StaticAnalyzerRulesets to filter the warnings that are reported as this will enable a large number of additional warnings.

Please see the following links for more details:
https://learn.microsoft.com/en-us/cpp/code-quality/using-the-cpp-core-guidelines-checkers
https://learn.microsoft.com/en-us/cpp/code-quality/using-rule-sets-to-specify-the-cpp-rules-to-run

#jira UE-174521
#rb trivial
#preflight 63c9e333977c626356cdf40f

[CL 23784396 by Joe Kirchoff in ue5-main branch]
2023-01-19 19:46:12 -05:00
christopher waters
552f2a9ca0 RHI header reorganization
- Changing RHIUtilities, RHIContext, RHICommandList and DynamicRHI to get them to compile independently of the rest of the RHI headers.

#preflight 63c1e22c2e714f64ad46aae5

[CL 23697282 by christopher waters in ue5-main branch]
2023-01-14 00:23:40 -05:00
christopher waters
c8fb19a8de IWYU iteration changes
- Adding -IWYUHeadersOnly command line option to restrict IWYU to just header files
- Adding IWYU support for -Module=XXX

#rb henrik.karlsson
#preflight 63c05f7e1a06fc61057cf347

[CL 23670631 by christopher waters in ue5-main branch]
2023-01-12 17:29:36 -05:00
bob tellez
971983eb65 [Backout] - CL23624045
[FYI] christopher.waters
Original CL Desc
-----------------------------------------------------------------
RHI header dependency cleanup
- Reducing other header dependencies from RHIDefinitions.h
- Moved a few functions to the new RHIStrings.h
- Uniform buffer layout initializer moved to its own file to reduce RHI dependency on MemoryLayout.

#preflight 63bca752577437afe604b097

[CL 23631957 by bob tellez in ue5-main branch]
2023-01-10 15:28:15 -05:00
christopher waters
3df5dae685 RHI header dependency cleanup
- Reducing other header dependencies from RHIDefinitions.h
- Moved a few functions to the new RHIStrings.h
- Uniform buffer layout initializer moved to its own file to reduce RHI dependency on MemoryLayout.

#preflight 63bca752577437afe604b097

[CL 23631946 by christopher waters in ue5-main branch]
2023-01-10 15:27:33 -05:00
henrik karlsson
31c48b294e [UBT]
* Fixed new iwyu code to be compatible with changes coming from ue5 main (CompileCppFiles is now protected and UEBuildModuleCPP.cs calls CompileAllCPPFiles instead of CompileCppFiles directly)

#preflight skipped
#rb none
#jira none

[CL 23631280 by henrik karlsson in ue5-main branch]
2023-01-10 14:56:25 -05:00
henrik karlsson
23ea716c7a [UBT]
* Added IWYU toolchain which can be enabled with -IWYU
* Added IWYU mode that can be used with -Mode=IWYU. This can be used to modify code files
* Binary of include-what-you-use that contains a ton of fixes to make ue build

#preflight skipped
#rb joe.kirchoff

[CL 23631202 by henrik karlsson in ue5-main branch]
2023-01-10 14:52:00 -05:00
henrik karlsson
20ad69e0f1 [UnrealBuildTool]
* Fixed log warning to show correct data (and is now copy-pastable)

#rb joe.kirchoff
#preflight skipped

[CL 23605571 by henrik karlsson in ue5-main branch]
2023-01-06 18:57:13 -05:00
henrik karlsson
c6f15b80c3 [UnrealBuildTool]
* Added code to fixup definitions provided through .build.cs files. There are actually strict rules around the syntax of defines (reading msvc documentation). There should be no space before or after the '=' character. so "MY_DEFINE = 1" is actually invalid. When building with header units this actually produce invalid data but in normal builds it seems to swallow it (even though the documentation says it shouldn't)

I would have wanted to fix the code producing bad definition format but it is in a whole bunch of modules so I suspect external teams might have this too, so instead we fix it up by trimming the strings before and after '='

#preflight 63b894b9221aab21e0970eb0
#rb none

[CL 23605565 by henrik karlsson in ue5-main branch]
2023-01-06 18:56:54 -05:00
Josh Adams
b337b06556 - Allow for a platform to compile for multiple architectures, and have the high-level compile separately, and then link not separately (this means we can't use the one-target-per-architecture stuff that is already present)
- Mac changes to compile separately,  but link together (with lipo) after making two .dylibs/executables
- Removed FixDylibDependencies on Mac by making "stub dylibs" to mimic what Windows does with import libs, to solve circular dependencies
- Added DependenciesToSkipByArchitecture to ModuleRules that is used, when making a new single-arch LinkEnvironment from a multi-arch LinkEnvironment, to strip out libraries, etc, that should not be included with that single architecture
#preflight 6387891b4004f73f623c85a0
#rb zack.neyland

[CL 23336522 by Josh Adams in ue5-main branch]
2022-11-30 13:38:45 -05:00
bryan sefcik
ac642e3ace Updated to disable XGE and SNDBS when profiling.
Added a flag that turns off module unity size overrides.

#jira
[FYI] joe.kirchoff
#preflight 637673ccaf52be152449722a

[CL 23182588 by bryan sefcik in ue5-main branch]
2022-11-17 15:29:33 -05:00
Rafa Lecina
df001c1d21 Support enable ARC in modules
#jira UE-107891
#review @Sam.Zamani @Bertrand.Carre @Chris.Varnsverry @Roman.Dzieciol @Josh.Adams  @Jack.Porter
#preflight

[CL 23133821 by Rafa Lecina in ue5-main branch]
2022-11-15 06:02:36 -05:00
bryan sefcik
d464a46b31 Reorganized the unity logic to take into account the generated cpp files when determining whether to use unity files. Previously the logic wouldn't take into account the number of generated files which meant that modules that had just generated cpp files wouldn't use unity files.
Before:
Unity Files: 6759
Total CPU Time: 77035.734375 s
Total time in Parallel executor: 2062.95 seconds

After:
Unity Files: 6656
Total CPU Time: 76182.40625 s
Total time in Parallel executor: 2047.47 seconds

#jira
[FYI] joe.kirchoff
#preflight 637273a1ee4d25f90acc3712

[CL 23123139 by bryan sefcik in ue5-main branch]
2022-11-14 14:15:09 -05:00
chris constantinescu
7859a6cdb4 Catch2 feature introduced: test groups and group events at global, group and test group before/after levels
#preflight 636ab505450be1d9f83e90e4
#rb Jerome.Delattre

[CL 23039159 by chris constantinescu in ue5-main branch]
2022-11-08 16:02:46 -05:00
joe kirchoff
4bd342fb6c UnrealBuildTool: BuildSetting.V3 (currently disabled) which disallows adding module parent directory to include path list
#rnx
#rb bryan.sefcik
#preflight 634df3105f008d633fd571d2

[CL 22798627 by joe kirchoff in ue5-main branch]
2022-10-26 19:13:07 -04:00