Commit Graph

7365 Commits

Author SHA1 Message Date
peter sauerbrei
0686a3a974 fix for crash while attempting to convert the minidump to human readable form
#rb brandon.schaefer


#ROBOMERGE-SOURCE: CL 11620493 via CL 11622560 via CL 11622714 via CL 11622924
#ROBOMERGE-BOT: (v656-11643781)

[CL 11794548 by peter sauerbrei in Main branch]
2020-02-29 00:40:36 -05:00
chris babcock
6df461dc0d Provide more control over OBB selection
#jira UE-89810
#ue4
#android
#rb Brandon.Schaefer

#ROBOMERGE-SOURCE: CL 11792686 in //UE4/Release-4.25/... via CL 11792867
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v656-11643781)

[CL 11792949 by chris babcock in Main branch]
2020-02-28 20:20:36 -05:00
andrew grant
6c1a380c64 Fix issue where new/changed screenshots could not be approved in the editor on some platforms (Mac, Xbox, others?)
The issue was that the code that captures screenshots on a device and sends them was the editor was setting a 'path' variable that represented what a screenshot *would* be saved at on the local system. (The screenshot was not actually saved, it's returned as raw data in the message).

This meant that the editor would try to save for screenshots to a local path that did not exist (e.g. g:\settings\ on xbox) and fail.

The fixes here are -

1) Add some warnings to the code that tries to save screenshots if that fails

2) Change the names of the screenshot functions in AutomationCommon to clarify what they should be used for.

3) Change the 'path' variable in the message to screenshot name.

4) Calculate the path to use for screenshots on the editor.


#tests ran EngineTest on WIn64, PS4, and XboxOne (which now passes).
#jira UE-69399
#rb swarm

#ROBOMERGE-SOURCE: CL 11733277 in //UE4/Release-4.25/... via CL 11733309
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v656-11643781)

[CL 11733341 by andrew grant in Main branch]
2020-02-28 09:47:55 -05:00
johan berg
ebdb3f1258 Add support for passing "abscrashreportclientlog" and "nullrhi" command line arguments to crash reporter monitor.
This allows enabling crash reporter client to run in monitor mode for game runtimes again.

#jira UE-89418
#rb steve.robb

#ROBOMERGE-SOURCE: CL 11726679 in //UE4/Release-4.25/... via CL 11726693
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v656-11643781)

[CL 11726700 by johan berg in Main branch]
2020-02-28 07:07:23 -05:00
allan bentham
63d1c8eaa2 Android Crash Reporter
- Dump logcat on non fatal reports.
#rb chris.babcock
[FYI] chris.babcock


#ROBOMERGE-SOURCE: CL 11600670 via CL 11600686 via CL 11600693
#ROBOMERGE-BOT: (v656-11643781)

[CL 11722236 by allan bentham in Main branch]
2020-02-27 21:28:37 -05:00
ben marsh
ffd2f1ede7 Fix detection of engine modules being out of date.
#rb none
#jira UE-88824, UE-89676

#ROBOMERGE-SOURCE: CL 11658206 in //UE4/Release-4.25/... via CL 11658244
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v656-11643781)

[CL 11658322 by ben marsh in Main branch]
2020-02-27 11:10:22 -05:00
steve smith
6e1d9c3200 From Microsoft: Hololens/WMR Support Windows Server 2019
#rb steve.smith ben.marsh
#jira none

#ROBOMERGE-SOURCE: CL 11644070 in //UE4/Release-4.25/... via CL 11644079
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v656-11643781)

[CL 11644083 by steve smith in Main branch]
2020-02-26 17:27:54 -05:00
Arne Schober
36711e223d MN - Disable Staic Analysis false positive.
#jira UE-89487
#RB

[CL 11634315 by Arne Schober in Main branch]
2020-02-26 12:19:32 -05:00
dmitriy dyomin
896fa48a73 Enable RHIT on OpenGL mobile by default
#jira UE-86775
#rb none

#ROBOMERGE-SOURCE: CL 11626204 in //UE4/Release-4.25/... via CL 11626205
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v655-11596533)

[CL 11626206 by dmitriy dyomin in Main branch]
2020-02-26 01:20:48 -05:00
ben marsh
83e759a4e5 Fix signed/unsigned comparison errors building debug configuration on Win32 (size_t is 32-bit)
#rb none
[FYI] Michael.Noland
#rnx
#jira

#ROBOMERGE-SOURCE: CL 11609981 in //UE4/Release-4.25/... via CL 11609993
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v655-11596533)

[CL 11610004 by ben marsh in Main branch]
2020-02-25 13:03:51 -05:00
johan berg
fe809e8b58 Fix for fixed buffer overrun and static buffer reuse in crash context.
In some scenarios when copying the shared crash context the engine would overrun the fixed size string buffer. This issue appeared after two ensures fired, since the dynamic string buffers lifetime was equal to the crash reporting thread, and only reset on initialization.

#jira UE-89180
#rb pj.kack
#ushell-cherrypick of 11586607 by Johan.Berg

#ROBOMERGE-SOURCE: CL 11601293 in //UE4/Release-4.25/... via CL 11601300
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v655-11596533)

[CL 11601325 by johan berg in Main branch]
2020-02-25 09:17:40 -05:00
danny couture
16431eb339 Upgrade all platforms to IntelTBB-2019u8
- Apply IntelTBB-4.4u3 Priority Inversion patch from CL 3984773 (Jeff.Rous)
 - Apply IntelTBB-4.4u3 ARM64 patch from CL 5420065 (Jackson.Fields)
 - Verified IntelTBB-4.0 reallocAligned and internalMsize patch was present CL 2605187 (James.Moran)
 - Compile ARM binaries for Hololens
 - Compile Mac binaries
 - Add tbb/tbb_debug dynamic libraries (used by OpenVDB)
 - OpenVDB now references tbb/tbb_debug from the official Thirdparty folder
 - Recompile OpenVDB
 - Update .tps for new Apache 2.0 License
 - Remove all old versions

From dev-enterprise[at]11303005

#jira UEENT-3378
#rb Steve.Robb, David.Hill, Michael.Trepka

#ROBOMERGE-SOURCE: CL 11586698 in //UE4/Release-4.25/... via CL 11586737
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v654-11333218)

[CL 11586755 by danny couture in Main branch]
2020-02-24 06:16:20 -05:00
ben woodhouse
a097c209d3 Enable CONTAINER_INITIAL_ALLOC_ZERO_SLACK (cross platform memory saving, saves up to 96MB on consoles)
#ROBOMERGE-SOURCE: CL 11585841 via CL 11585842 via CL 11585843 via CL 11585844
#ROBOMERGE-BOT: (v654-11333218)

[CL 11585845 by ben woodhouse in Main branch]
2020-02-23 06:59:38 -05:00
johan torp
b211a6f6f4 TBitArray fixes and optimizations
Initialize unused TBitArray bits, switch to faster unsigned operator% and don't shrink past initial allocation size

operator<, == and GetTypedHash() would access unused bits in the last word

#rb steve.robb
#robomerge[core] -core
#jira UE-88991
#ushell-cherrypick of 11575339 by Johan.Torp

#ROBOMERGE-SOURCE: CL 11575479 in //UE4/Release-4.25/... via CL 11575678
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v654-11333218)

[CL 11585323 by johan torp in Main branch]
2020-02-22 18:11:22 -05:00
david harvey
3bd96d2df1 remove WINDOWS_USE_FEATURE_APPLICATION and WINDOWS_USE_FEATURE_WINDOW
#rb jon.cain
#jira none

#ROBOMERGE-SOURCE: CL 11564657 in //UE4/Release-4.25/... via CL 11564659
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v654-11333218)

[CL 11581491 by david harvey in Main branch]
2020-02-21 19:27:20 -05:00
nicholas goldstein
cbceab4478 Pushing licensee fix
Add OnEnginePreExit() delegate to core delegates. This delegate is fired off before closing out the AssetTools, WorldBrowser and AssetRegistry modules, for handling shutdown tasks that would require these.

#jira UE-88976
#rb stefan.boberg

Handle lingering Niagara shader compiles on engine exit inside OnEnginePreExit() callback to avoid asserting if shader compile would require querying the asset registry module after it has shutdown.

#jira UE-88976
#rb frank.fella

#robomerge deadend

[CL 11580606 by nicholas goldstein in Main branch]
2020-02-21 18:44:43 -05:00
rex hill
f03e3a0fd7 Fix Blacklist Names IsBlacklistAll()
#rb jamie.dale
#rnx
#jira


#ROBOMERGE-SOURCE: CL 11578744 via CL 11578747 via CL 11578751
#ROBOMERGE-BOT: (v654-11333218)

[CL 11578759 by rex hill in Main branch]
2020-02-21 16:06:34 -05:00
chris babcock
c0d1cde0b0 Update Android toolchain to NDK 21 (20 also supported for x86_64)
#jira UE-80046
#ue4
#android
#rb Bradon.Schaefer


#ROBOMERGE-SOURCE: CL 11554677 in //UE4/Release-4.25/... via CL 11554724
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v654-11333218)

[CL 11578268 by chris babcock in Main branch]
2020-02-21 15:06:37 -05:00
will damon
ba400e70b9 Add copy constructor to FHashTable.
#rb ben.ingram
#jira UE-88773
#rnx

#ROBOMERGE-SOURCE: CL 11548943 in //UE4/Release-4.25/... via CL 11548953
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v654-11333218)

[CL 11578162 by will damon in Main branch]
2020-02-21 15:04:34 -05:00
ben ingram
4a2a37285d #jira UE-88915
Add iOS/TVOS to list of platforms that use template work-around
#rb none

#ROBOMERGE-SOURCE: CL 11546842 in //UE4/Release-4.25/... via CL 11546875
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v654-11333218)

[CL 11578130 by ben ingram in Main branch]
2020-02-21 15:03:48 -05:00
steve robb
d4c3e352e7 Constructors to allow the passing of a deleter with state.
Fix to the assignment operator of an array-based TUniquePtr with a different deleter.
Unification of constructor syntax.

#jira UECORE-507
#rb james.hopkin
[FYI] ryan.gerleve

#ROBOMERGE-SOURCE: CL 11535694 in //UE4/Release-4.25/... via CL 11535695
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v654-11333218)

[CL 11577616 by steve robb in Main branch]
2020-02-21 14:05:26 -05:00
allan bentham
b53079ec7b Flush logs when triggering a non-fatal report
[FYI] chris.babcock
#rb none
#rnx


#ROBOMERGE-SOURCE: CL 11567461 via CL 11567464 via CL 11567467 via CL 11567470
#ROBOMERGE-BOT: (v654-11333218)

[CL 11567472 by allan bentham in Main branch]
2020-02-20 13:16:03 -05:00
allan bentham
2d03b3e19a Add SIGABRT to fatal signals list.
#rb none
[FYI] chris.babcock
#rnx


#ROBOMERGE-SOURCE: CL 11564732 via CL 11564733 via CL 11564734
#ROBOMERGE-BOT: (v654-11333218)

[CL 11564736 by allan bentham in Main branch]
2020-02-20 08:47:54 -05:00
jimmy smith
6f0ee91505 Attempted fix for strange COM failure on build machine.
#jira UE-88759
#rb aaron.mcleran ethan.geller


#ROBOMERGE-SOURCE: CL 11558619 via CL 11558620 via CL 11558625
#ROBOMERGE-BOT: (v654-11333218)

[CL 11559047 by jimmy smith in Main branch]
2020-02-19 21:02:42 -05:00
JeanFrancois Dube
6ff218806c Optimize TSet::Empty to avoid the pathological case where the hash size is quite large but there's not so many elements in the hash, by clearing only the elements buckets instead of clearing the whole set of buckets.
This is mainly used when marking/unmarking objects during packages saving and other archives tagging objects, but also in several cases all over the engine.
#rb steve.robb

[CL 11535961 by JeanFrancois Dube in Main branch]
2020-02-19 07:01:57 -05:00