Commit Graph

39 Commits

Author SHA1 Message Date
Thomas Sarkanen
e27e005773 Source control copies now integrate/copy instead of Delete + Add
TTP# 334923 - EDITOR: Perforce Integration (Move -> Delete + Add instead of Integrate)

New API: Added ISourceControlRevision::GetBranchSource.
Made sure the P4 and SVN providers perform integrates/copies so that history is maintained across file copies & moves.
Also fixed SCC icons not refreshing sometimes until source control operation has completed.
Added new branch icon.
Fixed date display in history.
This required some fairly nasty fixup to get it all working within the Editor copy code path, but the majority of the changes are in the source control providers.

reviewed by Andrew.Brown

[CL 2095604 by Thomas Sarkanen in Main branch]
2014-06-05 12:10:47 -04:00
Barnabas McManners
f2f1e61dd3 AssetRegistrySearchable properties now show up the propertyÆs DisplayName if one is available.
#TTP 336118 - AssetRegistrySearchable properties do not display DisplayName in tooltip

#branch UE4

#proj Editor.ContentBrowser

#add Added an extra bit of logic to the tooltip creation code that grabs the property field and uses the display name from that if one is available.

#reviewedby Chris.Wood

[CL 2093143 by Barnabas McManners in Main branch]
2014-06-03 10:42:01 -04:00
Dan Oconnor
ca6937bc8e #UE4 Fixed source control status disapearing when an asset item is filtered or occluded and then becomes visible again..
[CL 2090147 by Dan Oconnor in Main branch]
2014-05-30 16:47:35 -04:00
Richard TalbotWatkin
e743ca8712 Content browser refreshes when package dirty state is updated.
#ttp 334481 - Regression: EDITOR: Content Browser: If you have the modified filter enabled and then save a modified asset, the asset is still visible in the browser
#branch UE4
#proj Editor.ContentBrowser
#add SAssetView registers a delegate with UPackage::PackageDirtyStateUpdatedEvent so that it can be refreshed.
#reviewedby Chris.Wood, Max.Preussner

[CL 2088030 by Richard TalbotWatkin in Main branch]
2014-05-29 17:36:00 -04:00
Dmitry Rekman
b7826acacb Safe compiler warning fixes from PR 185.
This is a subset of changes (compiler warning fixes needed to compile Linux editor) from pull request 185 by sbc100, 3dluvr, wshearn, abarbu et al: https://github.com/EpicGames/UnrealEngine/pull/185
- Initialization order fixes
- Missing virtual destructors in classes with virtual funcs.
- Missing newlines at the end of file

#codereview Robert.Manuszewski

[CL 2085576 by Dmitry Rekman in Main branch]
2014-05-29 17:09:32 -04:00
Bob Tellez
2004035699 UE4: Another small fix caught by static code analysis
[CL 2082556 by Bob Tellez in Main branch]
2014-05-22 19:11:00 -04:00
Bob Tellez
2c9d9f9edd UE4: Fixed a bug I found while running static analysis tools. The correct collection type string will now be detected when determining the config key.
[CL 2082553 by Bob Tellez in Main branch]
2014-05-22 19:10:48 -04:00
Richard TalbotWatkin
b532a23b1f Prevented content browser search filter from being cleared when renaming an asset.
#ttp 335652 - EDITOR: Content browser text search filter should not be wiped when renaming an asset.
#branch UE4
#proj Editor.ContentBrowser
#remove Removed the call to clear the filter textbox in SContentBrowser::SyncToAssets.
#reviewedby Chris.Wood

[CL 2079295 by Richard TalbotWatkin in Main branch]
2014-05-20 15:15:25 -04:00
Thomas Sarkanen
5c1bab1711 Fixed up source control state delegate to use shared pointer semantics
TTP# 335201  - ContentBrowser: Improve idle performance

reviewed by Bob.Tellez

[CL 2077399 by Thomas Sarkanen in Main branch]
2014-05-19 04:36:40 -04:00
Bob Tellez
50685c5dff UE4: Fixed a bug where unloaded assets were not dragable in the content browser.
[CL 2075589 by Bob Tellez in Main branch]
2014-05-16 11:12:52 -04:00
Thomas Sarkanen
ecaf01661c Prevented source control state from being fetched for every content browser widget
Instead of using the (cached) state, we cache the brush to use to display the state and only hit the state cache when state changes.
Also updated Execute() calls to providers to only do relative-path conversions if the path is already relative.
Added SourceControlHelpers::AbsoluteFilenames to aid conversion.

TTP# 335201  - ContentBrowser: Improve idle performance

#codereview Andrew.Brown

[CL 2075346 by Thomas Sarkanen in Main branch]
2014-05-16 06:46:44 -04:00
Barnabas McManners
cf8e753374 Asset picker now supports rename functionality.
#TTP 326521 - EDITOR: Feature Request: PERSONA: Have ability to rename assets in Asset Browser with F2 and right click

#branch UE4

#proj Editor.ContentBrowser

#add Added support for the rename UICommand to the Asset picker using a UICommandList and processing it in its onkeydown method.

#reviewedby Chris.Wood

[CL 2074306 by Barnabas McManners in Main branch]
2014-05-15 12:07:40 -04:00
Michael Noland
3f2dfc7f0d Editor: Generate better default name for newly created unusual Blueprint assets (interfaces, function libraries, macro libraries)
- Add GetDefaultNewAssetName method to UFactory interface
- Add GetDefaultNewAssetName overrides for various blueprint factory subclasses

[CL 2073776 by Michael Noland in Main branch]
2014-05-14 22:47:22 -04:00
Bob Tellez
ee55183e2b UE4: Removed many unnecessary checks in the editor to special-case assets found in umap files.
[CL 2073723 by Bob Tellez in Main branch]
2014-05-14 22:02:10 -04:00
Richard TalbotWatkin
fe4cf82fcf Removed "New Folder" from the New Asset context menu if a collection is currently selected.
#ttp 334526 - EDITOR: Content Browser: CRASH: Creating a new folder in a collection results in an ensure
#branch UE4
#proj Editor.ContentBrowser
#change In SContentBrowser::MakeCreateAssetContextMenu, if a collection is selected, pass an unbound FOnNewFolderRequested delegate to FNewAssetContextMenu::MakeContextMenu, so that the "New Folder" item is not added.
#reviewedby Chris.Wood

[CL 2070121 by Richard TalbotWatkin in Main branch]
2014-05-12 08:38:33 -04:00
Max Preussner
4664956156 Delegates: Cleaned up abusive/legacy usages of the Delegate API
Please use AddRaw, AddSP, AddUObject, , BindRaw, BindSP, RemoveAll, Unbind etc.

[CL 2068405 by Max Preussner in Main branch]
2014-05-09 14:02:33 -04:00
Michael Noland
1f34ce9e19 Core: Change FCoreDelegates::OnObjectPropertyChanged to take the property change event as an additional parameter
[CL 2066450 by Michael Noland in Main branch]
2014-05-07 22:17:44 -04:00
Phillip Kavan
cc24ba4eeb Remove internal "SKEL_*" classes from the class picker.
- Modified FKismetEditorUtilities::CanCreateBlueprintFromClass() to return false if the input class is a BP skeleton class.
- Modified FKismetEditorUtilities::IsClassABlueprintSkeleton() to incorporate the alternative class flags check in case the SkeletonGeneratedClass has not yet been loaded during serialization.
- Replaced individual occurrences of the alternative class flags skeleton class check with FKismetEditorUtilities::IsClassABlueprintSkeleton() instead (for consistency and per discussion).

[CL 2063239 by Phillip Kavan in Main branch]
2014-05-05 01:38:12 -04:00
Andrew Brown
15c505e13b Content Browser: Enter and SpaceBar keys can now be remapped.
#ttp 333671 - EDITOR: Content Browser: Customizable shortcut for opening assets and folders

#branch UE4

#add Added two new commands so that the Enter and SpaceBar functionality can be remapped.

#change Renamed EAssetTypeActivationMethod types so they don't mention which key was used, but the action that key performed.

reviewed by Thomas.Sarkanen

[CL 2059964 by Andrew Brown in Main branch]
2014-04-30 10:58:31 -04:00
Max Preussner
b63129a60c Slate: Refactored core Slate implementation into SlateCore module in preparation for UMG.
Other Updates:
- The WidgetReflector is now in its own module as well. It will be converted to a plug-in later.
- The Public API of both Slate and SlateCore has largely been reorganized for better discoverabilty. More cleanup work is needed.
- Added a lot of missing API documentation and fixed existing ones. More and better documentation is needed.
- Removed dead code, fixed a couple things I stubled upon, and conformed to coding guidelines (NULL vs nullptr, line breaks, etc.)

Upgrade Notes:
- The Slate Remote Server is currently disabled - will be re-enabled shortly!
- If your module previously had a module dependency to 'Slate', it now also needs a PrivateModuleDependency to 'SlateCore' in its Build.cs file.
- If your module exposes in any of its Public header files types that are now declared in SlateCore, it needs a PublicModuleDependency to 'SlateCore'
- The ToolTip property type on SWidget has changed from SToolTip to IToolTip; change local variables to TSharedPtr<IToolTip> instead of TSharedPtr<SToolTip> where needed
- IToolTip is not a widget. If you need access to the actual widget that represents the tool tip, use IToolTip::AsWidget(); If you need access to the tool tip's content, use IToolTip::GetContentWidget()

Troubleshooting:
- After syncing to this changelist you may have to clean your /Engine/Intermediate/Build/ directory and rebuild your entire project
- If in your project you are getting linker errors for unresolved types that are now declared in SlateCore, you may be missing a dependency to 'SlateCore'
- If in the Engine code you are getting linker errors for unresolved types that are now declared in SlateCore, you may need to rebuild the entire Engine

[CL 2057118 by Max Preussner in Main branch]
2014-04-26 15:07:24 -04:00
Andrew Copland
26a350742e Further limit the game name length (20 characters), predict the cooking path length and limit the naming length accordingly.
#ttp 332328 Content Browser: Need new warnings about long relative path lengths for assets
#proj Editor
#branch UE4
reviewed by Thomas.Sarkanen

[CL 2055478 by Andrew Copland in Main branch]
2014-04-24 10:58:49 -04:00
Robert Manuszewski
aa11e3bbbf Merging UE4-Pretest @ 2042161 to UE4
Change 1996384 by Andrew Brown:
	322252 - EDITOR: Asset picker displays incorrect text when there are no filter results.
Change 1996385 by Andrew Brown:
	321858 - CRASH: Assertion failed: (Index >= 0) Function: STransformViewportToolBar::GetLocationGridLabel() STextBlock::CacheDesiredSize()
Change 1996977 by Andrew Brown:
	309685 - UE4: Adding an event/renaming an event on an event track in Matinee does not update the MatineeActor node in blueprint
Change 2034873 by Jaroslaw Palczynski:
	More robust VS installation detection.
Change 2039693 by Jaroslaw Palczynski:
	327268 - RocketGDC: POSTLAUNCH: DEV: Make engine more robust against bad Visual Studio environment variables
Change 1978978 by Jaroslaw Surowiec:
	- Removed obsolete AllowEliminatingReferences from the FArchive
Change 2020326 by Maciej Mroz:
	pretest BP K2Node: RemovePinsFromOldPins function moved from K2Node to RemovePinsFromOldPins
Change 2017608 by Maciej Mroz:
	pretest Some changes in SFortMissionEventSelector caused by FPinTypeTreeInfo
Change 2017463 by Maciej Mroz:
	PinTypeSelector can lins unloaded UDStructs
Change 2019979 by Maciej Mroz:
	pretest BP: Crash when performing Diff against Depot with blueprints containing Format Text nodes
Change 2024469 by Maciej Mroz:
	MemberReference variable added to PinType. It's necessary for delegate's signature.
Change 2024049 by Maciej Mroz:
	HasExternalBlueprintDependencies added to UK2Node_DynamicCast
Change 2024586 by Maciej Mroz:
	FillSimpleMemberReference fix
Change 2024472 by Maciej Mroz:
	workaround for delegates signature in pintype removed.
Change 2023997 by Maciej Mroz:
	BP, UDStruc: Class UserDefinedStructEditorData added. It fixes many problems with undo/redo.
Change 2021934 by Maciej Mroz:
	typo in a comment
Change 2020355 by Maciej Mroz:
	Back out changelist 2020342
Change 2022178 by Maciej Mroz:
	CRASH: PRETEST: EDITOR: UDS: Crash when undo then redo new variable in struct that is used by blueprint
Change 2021958 by Maciej Mroz:
	CRASH: PRETEST: EDITOR: UDS: Crash using variable of a type of copied struct in blueprint
Change 1986247 by Maciej Mroz:
	User Defined Structures: circle dependency fixed. Early version.
Change 1985107 by Maciej Mroz:
	UserDefinedStruct cannot have a field of a non-native type
Change 1986278 by Maciej Mroz:
	pretest ensureMsgf in Struct::link
Change 1986250 by Maciej Mroz:
	User Defined Struct: Non native classes are accepted types od values in structures.
Change 1980955 by Maciej Mroz:
	Using AssetPtr and LazyPtr as UFunction parameter (intput or return) is explicitly disallowed.
Change 2041215 by Maciej Mroz:
	ttp331249 BLOCKER: PRETEST: UI: Survive the Storm is missing the Mission HUD.
Change 1984316 by Maciej Mroz:
	New User Defined Structure. WIP - there are still problems with circular dependencies.
Change 2011616 by Maciej Mroz:
	UserDefinedStructures - various problems fixed.
Change 2011609 by Maciej Mroz:
	more robust HasExternalBlueprintDependencies implementation
Change 2016697 by Maciej Mroz:
	pretest BP: UDStruct - default value propagation in cooked build
Change 2016288 by Maciej Mroz:
	pretest BP: UDStruct: Renaming variables wont break links from make/break nodes
Change 1987637 by Maciej Mroz:
	CustomStruct icons placeholders
Change 1987422 by Maciej Mroz:
	Better tooltips for variables in MyBlueprint
Change 1991387 by Maciej Mroz:
	UDStructures fixes:
Change 2029165 by Maciej Mroz:
	BP: better comment for incomatible pins
Change 2030016 by Maciej Mroz:
	8PRETEST: EDITOR: UDS: Defaults values aren't updated in struct type variables in blueprints
Change 2030017 by Maciej Mroz:
	Unused UDStructure code removed (PPF_UseDefaultsForUDStructures)
Change 2028856 by Maciej Mroz:
	BP: Pins with PC_Struct type are compatible only with exactly the same structure. (No derived structures are not handled as compatible).
Change 2026701 by Maciej Mroz:
	k2: odd error on an add item node within a function (see attached image in details)
Change 2028160 by Maciej Mroz:
	PRETEST: EDITOR: UDS: When deleting structures just after creating there is always some references in the memory
Change 2028165 by Maciej Mroz:
	BP: BreakHitResult function has proper icon.
Change 2033340 by Maciej Mroz:
	ttp330786 PRETEST: EDITOR: UDS: Changes of default values aren't apllied to breeak nodes for text type of variables
Change 2034255 by Maciej Mroz:
	EDITOR: UDS: Changes of default values aren't apllied to make nodes for text type of variables ttp#330620
Change 2037682 by Maciej Mroz:
	ttp331309 BLOCKER: PRETEST: CRASH: EDITOR: Crash occurs when performing Diff Against Depot on any Blueprint
Change 2033142 by Maciej Mroz:
	CreateDelegate Node uses internally FMemberReference. Refactor.
Change 2032329 by Maciej Mroz:
	ttp330608 CRASH: PRETEST: EDITOR: UDS: Crash when trying to use struct named 'Color' in blueprint
Change 2032420 by Maciej Mroz:
	ttp330620 PRETEST: EDITOR: UDS: Changes of default values aren't apllied to make nodes for text type of variables
Change 2033139 by Maciej Mroz:
	Functions generated from CustomEvents can be also identified by GUID
Change 2026631 by Maciej Mroz:
	BP. UDStruct: Invalid structs are handled better.
Change 2025344 by Maciej Mroz:
	UDStruct enabled by default
Change 2026672 by Maciej Mroz:
	EDITOR: BP: Can't easily remove 'pass-by-reference' pins on ReturnNodes
Change 2026411 by Maciej Mroz:
	ExposeOnSpawn updated, it supports UDStructs, custom native Structs, and it throws compiler error.
Change 2025342 by Maciej Mroz:
	GenerateBlueprintSkeleton moved from BLueprint::Serialize to RegenerateBlueprintClass, because SkeletonClass compilation requires all external dependencies to be loaded and linked.
Change 2025570 by Steve Robb:
	Moved dependency processing to its own function.
Change 2033235 by Steve Robb:
	String improvements
Change 2035830 by Steve Robb:
	Workaround for FriendsAndChat crash in Fortnite.
Change 2035115 by Steve Robb:
	UBT build time regression fixes.
Change 2034162 by Steve Robb:
	312775: UObject improvement: Ensure that *.generated.inl is included somewhere
Change 2034181 by Steve Robb:
	Removal of any references to .generated.inl
Change 2020165 by Steve Robb:
	BuildPublicAndPrivateUObjectHeaders factored out into its own function.
Change 2020187 by Steve Robb:
	CreateModuleCompileEnvironment function factored out.
Change 2020055 by Steve Robb:
	Refactoring of Unity.cs to remove complex and duplicate iteration.
Change 2020083 by Steve Robb:
	Another use of dictionary utilities.
Change 2031049 by Steve Robb:
	312775: UObject improvement: Ensure that *.generated.inl is included somewhere
Change 2025728 by Steve Robb:
	Refactored the application of a shared PCH file to multiple file into a single ApplySharedPCH function.
Change 2020068 by Steve Robb:
	A couple of helpful utility functions for populating dictionaries.
Change 2032307 by Steve Robb:
	312775: UObject improvement: Ensure that *.generated.inl is included somewhere

[CL 2054495 by Robert Manuszewski in Main branch]
2014-04-23 20:18:55 -04:00
Marc Audy
72c1271b72 Minor GWorld cleanup
[CL 2052582 by Marc Audy in Main branch]
2014-04-23 19:58:21 -04:00
Nick Darnell
12b635d213 Fixing the text in the asset menu, was stomping other key'ed text.
[CL 2052354 by Nick Darnell in Main branch]
2014-04-23 19:56:23 -04:00
Nick Darnell
4d26248bd0 * New asset category in the new menu "User Interface", currently just the slate related assets are visible unless -umg is provided.
* Porting a large swath of the code from SlateComponentWrapper into UMG.
* Creating a derived UBlueprint for AUserWidget. (The base class for a UMG widget).

[CL 2050095 by Nick Darnell in Main branch]
2014-04-23 19:38:57 -04:00